⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 25, 2004:

5:46 PM Changeset in webkit [7894] by adele
  • 3 edits in trunk/WebCore
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::inDesignMode): made inDesignMode const
  • khtml/xml/dom_docimpl.h:
4:42 PM Changeset in webkit [7893] by cblu
  • 2 edits in trunk/WebKit

Darin made an internal notification have the Web prefix.

Reviewed by me.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (ConsoleConnectionChangeNotifyProc):
4:02 PM Changeset in webkit [7892] by adele
  • 2 edits in trunk/WebCore

Reviewed by me, code change by Darin.

  • khtml/xml/dom_docimpl.cpp: Moved design mode code outside the XSLT ifdef.
3:05 PM Changeset in webkit [7891] by kocienda
  • 3 edits in trunk

Reviewed by me

Oops. These two test results changed with my last checkin, for the better.

  • layout-tests/editing/deleting/delete-3800834-fix-expected.txt
  • layout-tests/editing/inserting/insert-3775316-fix-expected.txt
2:52 PM Changeset in webkit [7890] by kocienda
  • 3 edits
    6 adds in trunk

Reviewed by Chris

Fix for this bug:

<rdar://problem/3820349> REGRESSION (Mail): select all, delete does not always delete everything

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::startPositionForDelete): New helper that determines when to expand the selection outwards when the selection is on the visible boundary of a root editable element. This fixes the bug. Note that this function also contains a little code I factored out of doApply: it also takes care of adjusting the selection in the smart delete case. (khtml::DeleteSelectionCommand::endPositionForDelete): Ditto. (khtml::DeleteSelectionCommand::doApply): Call new helpers. Refactored out the code as described.
  • khtml/editing/htmlediting.h: Declare new helpers.
  • layout-tests/editing/deleting/delete-select-all-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-select-all-001.html: Added.
  • layout-tests/editing/deleting/delete-select-all-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-select-all-002.html: Added.
  • layout-tests/editing/deleting/delete-select-all-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-select-all-003.html: Added.
11:49 AM Changeset in webkit [7889] by kocienda
  • 1 edit
    10 adds in trunk

Reviewed by me

Added some more editing layout tests.

  • layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-001.html: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-002.html: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-003.html: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-004-expected.txt: Added.
  • layout-tests/editing/deleting/delete-ws-fixup-004.html: Added.
  • layout-tests/editing/inserting/typing-003-expected.txt: Added.
  • layout-tests/editing/inserting/typing-003.html: Added.
11:48 AM Changeset in webkit [7888] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): I did not get my fix for 3848343 and 3848224

yesterday quite right: words that should have been placed on the next line were instead

appearing on the line before, beyond the right margin. This was a one-word only error
based on moving the line break object when it should have stayed put. Here is the rule:
The line break object only moves to after the whitespace on the end of a line if that
whitespace caused line overflow when its width is added in.

11:26 AM Changeset in webkit [7887] by adele
  • 7 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/3619890> Feature request: designMode

This change implements the designMode property of a document. This is an IE property that is also supported by Mozilla.
This will enable more JS editing compatibility.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): added case for designMode (KJS::HTMLDocument::putValue): added case for designMode
  • khtml/ecma/kjs_html.lut.h: (KJS::): regenerated
  • khtml/khtml_part.cpp: (KHTMLPart::isContentEditable): Now returns designMode value
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_designMode member variable (DocumentImpl::setDesignMode): added function to assign m_designMode value (DocumentImpl::getDesignMode): return m_designMode value (DocumentImpl::inDesignMode): if designMode is inherited, this will find the appropriate parent document designMode and return that value.

Otherwise, it will just return the m_designMode value.

(DocumentImpl::parentDocument):

  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::): added InheritedBool enum, prototypes, and m_designMode member variable.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::isContentEditable): added check for isContentEditable function in KHTMLPart
10:52 AM Changeset in webkit [7886] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

Reviewed by Chris.

  • Cleanup from fix for <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object; eliminated notificationsSuppressed mechanism, which was used only by WebBookmark
  • History.subproj/WebHistoryItem.m: removed notificationsSuppressed ivar from private data object (-[WebHistoryItem setAlternateTitle:]): remove notificationsSuppressed guard (-[WebHistoryItem setURLString:]): ditto (-[WebHistoryItem setOriginalURLString:]): ditto (-[WebHistoryItem setTitle:]): ditto (-[WebHistoryItem _setLastVisitedTimeInterval:]): ditto (-[WebHistoryItem setNotificationsSuppressed:]): removed this method (-[WebHistoryItem notificationsSuppressed]): ditto
  • History.subproj/WebHistoryItemPrivate.h: removed notificationsSuppressed and setNotificationsSuppressed

WebBrowser:

Reviewed by Chris.

  • fixed these bugs: <rdar://problem/3851676> bookmarks should not hold onto a WebHistoryItem object <rdar://problem/3852373> Could eliminate -[WebBookmark lastVisitedTimeInterval] for performance

This reduced RPRVT after launch with the standard set of built-in bookmarks on my machine from
4.12M to 4.09M, and sped up reading bookmarks a little also.

  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Don't set lastVisitedTimeInterval here
  • URLCompletionController.m: (-[URLCompletionController _addStatsForURL:]): Added comment to this #defined-away method explaining that it wouldn't work as-is anymore since it calls the obsolete setLastVisitedTimeInterval
  • WebBookmark.h: remove lastVisitedTimeInterval and setLastVisitedTimeInterval
  • WebBookmark.m: removed _URL, setLastVisitedTimeInterval, and lastVisitedTimeInterval
  • WebBookmarkExporter.m: (-[WebBookmarkExporter stringForBookmarkLeaf:withIndentLevel:]): Don't export last visited time anymore
  • WebBookmarkGroup.m: (-[WebBookmarkGroup _addBookmarkToURLStringDictionary:]): use [bookmark URLString] instead of [bookmark _URL]. The latter was getting the URL from its WebHistoryItem, which no longer exists.
  • WebBookmarkLeaf.h: remove _entry ivar, add _title ivar
  • WebBookmarkLeaf.m: (-[WebBookmarkLeaf init]): removed this method, which set up _entry (-[WebBookmarkLeaf initWithURLString:title:group:]): weaned from _entry, also calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase is updated properly (-[WebBookmarkLeaf initFromDictionaryRepresentation:topLevelOnly:withGroup:]): ditto (-[WebBookmarkLeaf dictionaryRepresentation]): weaned from _entry (-[WebBookmarkLeaf dealloc]): calls setURLString instead of setting the ivar directly to ensure that the WebIconDatabase is updated properly (-[WebBookmarkLeaf copyWithZone:]): ditto (-[WebBookmarkLeaf title]): weaned from _entry (-[WebBookmarkLeaf setTitle:]): ditto (-[WebBookmarkLeaf icon]): ditto (-[WebBookmarkLeaf URLString]): ditto (-[WebBookmarkLeaf setURLString:]): ditto, also updates WebIconDatabase (-[WebBookmarkLeaf setLastVisitedTimeInterval:]): removed this method (-[WebBookmarkLeaf lastVisitedTimeInterval]): ditto (-[WebBookmarkLeaf _computeIsRSSBookmark]): use isSyndicationURLString on a string instead of isSyndicationURL on a URL
  • WebBookmarkPrivate.h: removed _URL method
Note: See TracTimeline for information about the timeline view.