Timeline

Oct 27, 2004:

3:41 PM Changeset in webkit [7907] by kocienda

• 8 edits in trunk

WebCore:

Reviewed by Chris

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteSelection): Added new mergeBlocksAfterDelete flag to control whether content not in the block containing the start of the selection is moved to that block after the selection is deleted. (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Ditto. (khtml::DeleteSelectionCommand::doApply): Ditto. (khtml::InputNewlineInQuotedContentCommand::InputNewlineInQuotedContentCommand): New command to handle the case of inserting a newline when in quoted content in Mail. (khtml::InputNewlineInQuotedContentCommand::~InputNewlineInQuotedContentCommand): Ditto. (khtml::InputNewlineInQuotedContentCommand::isMailBlockquote): Ditto. (khtml::InputNewlineInQuotedContentCommand::isLastVisiblePositionInBlockquote): Ditto. (khtml::InputNewlineInQuotedContentCommand::doApply): Ditto. (khtml::TypingCommand::insertNewlineInQuotedContent): Support for new newline command. (khtml::TypingCommand::doApply): Ditto. (khtml::TypingCommand::preservesTypingStyle): Ditto.
• khtml/editing/htmlediting.h: Add new delclarations. (khtml::TypingCommand::): Ditto.
• kwq/WebCoreBridge.h: Added new bridge method called from WebKit.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge insertNewlineInQuotedContent]): Ditto.

WebKit:

Reviewed by Chris

Added new SPI for Mail so it can get the behavior it needs when the user hits
the return key with the selection in quoted content.

• WebView.subproj/WebView.m
• WebView.subproj/WebViewPrivate.h

3:09 PM Changeset in webkit [7906]

• 11 copies
  3 deletes in tags/WebKit-146~2

This commit was manufactured by cvs2svn to create tag 'WebKit-146~2'.

3:09 PM Changeset in webkit [7905] by vicki

• 2 edits in branches/WWDC-2004-branch/WebKit

WebKit:

• bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

• WebKit.pbproj/project.pbxproj:

WebBrowser:

• bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

• WebBrowser.pbproj/project.pbxproj:

3:01 PM Changeset in webkit [7904]

• 11 copies
  2 deletes in tags/WebCore-146~3

This commit was manufactured by cvs2svn to create tag
'WebCore-146~3'.

3:01 PM Changeset in webkit [7903]

• 16 copies
  3 deletes in tags/JavaScriptCore-146~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-146~3'.

3:01 PM Changeset in webkit [7902] by vicki

• 4 edits in branches/WWDC-2004-branch

JavaScriptCore:

• bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

• JavaScriptCore.pbproj/project.pbxproj:

WebCore:

• bump version numbers to fix <rdar://problem/3805185> Safari Dev Beta 1.3 no longer functional with SUPanNavy7R7 b/c of updated CFBSVstrings in Navy

• WebCore.pbproj/project.pbxproj:

Oct 26, 2004:

3:13 PM Changeset in webkit [7901] by cblu

• 4 edits in trunk/WebCore

Fixed: <rdar://problem/3774243> page up/down, arrow up/down, etc in Safari RSS should scroll main content

Reviewed by dave.

• khtml/ecma/kjs_dom.cpp: (DOMElementProtoFunc::tryCall): added scrollByLines and scrollByPages to HTML element for Safari RSS
• khtml/ecma/kjs_dom.h: (KJS::DOMElement::):
• khtml/ecma/kjs_dom.lut.h: (KJS::):

2:08 PM Changeset in webkit [7900] by hyatt

• 2 edits in trunk/WebCore

Fix for 3848214, deleting a partial word left a repaint artifact if the partial word was pulled back onto
the previous line.

Reviewed by kocienda

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):

1:15 PM Changeset in webkit [7899] by hyatt

• 3 edits in trunk/WebCore

Convert selectionRect() from using a list to a dict and patch it to be like setSelection. It was still trying
to use the old dirty bit optimization (which had been removed), and so it was pathologically slow on large documents.

Reviewed by kocienda

• khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect):
• khtml/rendering/render_object.h: (khtml::RenderObject::hasSelectedChildren):

12:57 PM Changeset in webkit [7898] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug

<rdar://problem/3851164> mail crashed when I pasted a large amount of text into a reply

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): This now returns bool to let the caller know if a placeholder was removed. (khtml::ReplaceSelectionCommand::doApply): Use the bool return value from the call to removeBlockPlaceholderIfNeeded. If true, shift the selection to the now-empty block. In some cases, the selection was still set on the removed BR, and this was the cause of the crash.
• khtml/editing/htmlediting.h: Change removeBlockPlaceholderIfNeeded return type.

11:26 AM Changeset in webkit [7897] by darin

• 2 edits in trunk/WebCore

Reviewed by Chris.

• fixed <rdar://problem/3851301> leak of one NSCFDictionary for each XMLHttpRequest issued

• kwq/KWQLoader.mm: (KWQServeSynchronousRequest): Add a release.

10:40 AM Changeset in webkit [7896] by cblu

• 2 edits in trunk/WebKit

Fixed exception that Darin encountered in Mail.

Reviewed by darin.

• Plugins.subproj/WebPluginController.m: (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]): if the plug-in returns a nil view, return nil

10:08 AM Changeset in webkit [7895] by kocienda

• 2 edits in trunk/WebCore

Reviewed by John

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): Do not call replaceText with a zero-length string. That triggers an assert. Call deleteText instead, using the same indices that are passed to replaceText.

Cleaned up the asserts in these three functions below, making them
more consistent. This is not needed for the fix, but I tripped over
these in the course of debugging.

(khtml::InsertTextCommand::InsertTextCommand):
(khtml::InsertTextCommand::doApply):
(khtml::InsertTextCommand::doUnapply):