Timeline

Nov 4, 2004:

7:09 PM Changeset in webkit [7942] by hyatt

• 13 edits in trunk/LayoutTests

land updated layout tests for the relpositioned change, the ex unit change, and the text-top vertical-align change

6:59 PM Changeset in webkit [7941] by hyatt

• 9 edits in trunk/WebCore

Fix for relpositioned inlines. This was reviewed a long time ago, but I can't recall who reviewed it (either
darin or ken).

Reviewed by darin or ken

• khtml/rendering/bidi.cpp: (khtml::appendRunsForObject): (khtml::RenderBlock::skipWhitespace): (khtml::RenderBlock::findNextLineBreak):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::lowestPosition): (khtml::RenderBlock::rightmostPosition): (khtml::RenderBlock::leftmostPosition):
• khtml/rendering/render_box.cpp: (RenderBox::position):
• khtml/rendering/render_box.h: (khtml::RenderBox::staticX): (khtml::RenderBox::staticY):
• khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition): (RenderLayer::convertToLayerCoords):
• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::placeBoxesHorizontally):
• khtml/rendering/render_object.h: (khtml::RenderObject::staticX): (khtml::RenderObject::staticY):

Finish turning on XSLT. Make sure child stylesheets can load.

• khtml/xsl/xslt_processorimpl.cpp: (DOM::stylesheetLoadFunc): (DOM::XSLTProcessorImpl::transformDocument):

5:19 PM Changeset in webkit [7940] by hyatt

• 2 edits in trunk/WebKit

Make sure the dominant line direction is properly set for RTL runs so that spaces will reverse.

Change xHeight to measure the ascent of the x glyph, since the xHeight metrics appear to be
totally bogus in both CG and AppKit.

Reviewed by darin

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): (-[WebTextRenderer _createATSUTextLayoutForRun:style:]): (-[WebTextRenderer _trapezoidForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer _ATSU_drawRun:style:geometry:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]):

5:18 PM Changeset in webkit [7939] by hyatt

• 15 edits in trunk/WebCore

Implement CSS3 support for multiple backgrounds. Also fix a bug with background propagation so that it only
happens (from the <body> to the root) for HTML documents. Fixed background-position to handle a mixture of
keyword and length values.

Reviewed by darin

• khtml/css/cssparser.cpp: (CSSParser::parseValue): (CSSParser::addBackgroundValue): (CSSParser::parseBackgroundShorthand): (CSSParser::parseBackgroundColor): (CSSParser::parseBackgroundImage): (CSSParser::parseBackgroundPositionXY): (CSSParser::parseBackgroundPosition): (CSSParser::parseBackgroundProperty): (CSSParser::parseColorFromValue):
• khtml/css/cssparser.h:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::mapBackgroundAttachment): (khtml::CSSStyleSelector::mapBackgroundImage): (khtml::CSSStyleSelector::mapBackgroundRepeat): (khtml::CSSStyleSelector::mapBackgroundXPosition): (khtml::CSSStyleSelector::mapBackgroundYPosition):
• khtml/css/cssstyleselector.h:
• khtml/rendering/render_box.cpp: (RenderBox::paintRootBoxDecorations): (RenderBox::paintBoxDecorations): (RenderBox::paintBackgrounds): (RenderBox::paintBackground): (RenderBox::paintBackgroundExtended):
• khtml/rendering/render_box.h:
• khtml/rendering/render_form.cpp: (RenderFieldset::paintBoxDecorations):
• khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paintBackgrounds): (khtml::InlineFlowBox::paintBackground): (khtml::InlineFlowBox::paintBackgroundAndBorder):
• khtml/rendering/render_line.h:
• khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::updateBackgroundImages): (RenderObject::getVerticalPosition):
• khtml/rendering/render_object.h: (khtml::RenderObject::paintBackgroundExtended):
• khtml/rendering/render_style.cpp: (m_next): (BackgroundLayer::BackgroundLayer): (BackgroundLayer::~BackgroundLayer): (BackgroundLayer::operator=): (BackgroundLayer::operator==): (BackgroundLayer::fillUnsetProperties): (BackgroundLayer::cullEmptyLayers): (StyleBackgroundData::StyleBackgroundData): (StyleBackgroundData::operator==): (RenderStyle::diff): (RenderStyle::adjustBackgroundLayers):
• khtml/rendering/render_style.h: (khtml::OutlineValue::operator==): (khtml::OutlineValue::operator!=): (khtml::BackgroundLayer::backgroundImage): (khtml::BackgroundLayer::backgroundXPosition): (khtml::BackgroundLayer::backgroundYPosition): (khtml::BackgroundLayer::backgroundAttachment): (khtml::BackgroundLayer::backgroundRepeat): (khtml::BackgroundLayer::next): (khtml::BackgroundLayer::isBackgroundImageSet): (khtml::BackgroundLayer::isBackgroundXPositionSet): (khtml::BackgroundLayer::isBackgroundYPositionSet): (khtml::BackgroundLayer::isBackgroundAttachmentSet): (khtml::BackgroundLayer::isBackgroundRepeatSet): (khtml::BackgroundLayer::setBackgroundImage): (khtml::BackgroundLayer::setBackgroundXPosition): (khtml::BackgroundLayer::setBackgroundYPosition): (khtml::BackgroundLayer::setBackgroundAttachment): (khtml::BackgroundLayer::setBackgroundRepeat): (khtml::BackgroundLayer::clearBackgroundImage): (khtml::BackgroundLayer::clearBackgroundXPosition): (khtml::BackgroundLayer::clearBackgroundYPosition): (khtml::BackgroundLayer::clearBackgroundAttachment): (khtml::BackgroundLayer::clearBackgroundRepeat): (khtml::BackgroundLayer::setNext): (khtml::BackgroundLayer::operator!=): (khtml::BackgroundLayer::containsImage): (khtml::BackgroundLayer::hasImage): (khtml::BackgroundLayer::hasFixedImage): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::hasBackground): (khtml::RenderStyle::hasFixedBackgroundImage): (khtml::RenderStyle::outlineWidth): (khtml::RenderStyle::outlineStyle): (khtml::RenderStyle::outlineStyleIsAuto): (khtml::RenderStyle::outlineColor): (khtml::RenderStyle::backgroundColor): (khtml::RenderStyle::backgroundImage): (khtml::RenderStyle::backgroundRepeat): (khtml::RenderStyle::backgroundAttachment): (khtml::RenderStyle::backgroundXPosition): (khtml::RenderStyle::backgroundYPosition): (khtml::RenderStyle::accessBackgroundLayers): (khtml::RenderStyle::backgroundLayers): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::resetOutline): (khtml::RenderStyle::setBackgroundColor): (khtml::RenderStyle::setOutlineWidth): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::setOutlineColor): (khtml::RenderStyle::clearBackgroundLayers): (khtml::RenderStyle::inheritBackgroundLayers): (khtml::RenderStyle::setOutlineOffset):
• khtml/rendering/render_table.cpp: (RenderTable::paintBoxDecorations): (RenderTableCell::paintBoxDecorations):

4:32 PM Changeset in webkit [7938] by hyatt

• 2 edits in trunk/WebCore

Make sure the text decoder returns empty strings rather than null strings when the utf8 char ptr is non-null.
Ensures that <a href=""> works with libxml (which returns data in utf-8 buffers).

Reviewed by darin

• kwq/KWQTextCodec.mm: (KWQTextDecoder::convertLatin1): (KWQTextDecoder::convertUTF16): (KWQTextDecoder::convertUsingTEC): (KWQTextDecoder::toUnicode):

4:30 PM Changeset in webkit [7937] by hyatt

• 2 edits in trunk/WebCore

Make sure line-height returns the correct value for normal.

Reviewed by darin

• khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):

1:07 PM Changeset in webkit [7936] by darin

• 1 delete in trunk/LayoutTests/.cvsignore

Don't ignore results file since it's not here any more.

10:29 AM Changeset in webkit [7935] by harrison

• 4 edits
  2 adds in trunk

Reviewed by Ken Kocienda.

<rdar://problem/3857753> REGRESSION (Mail): Delete incorrectly causes text to take on new style

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Fixed to move entire source subtree (up to, but not including, the enclosingBlockFlowElement) rather than just the source element. Fixed to insert after the destination subtree, rather than the destination element. Handles edge case of deleting back to the top of the tree, where there is nothing left to insert after.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingNonBlockFlowElement): New method to support moveNodesAfterNode changes.
• khtml/xml/dom_nodeimpl.h: Declare NodeImpl::enclosingNonBlockFlowElement
• layout-tests/editing/deleting/delete-3857753-fix-expected.txt: Added.
• layout-tests/editing/deleting/delete-3857753-fix.html: Added.

9:16 AM Changeset in webkit [7934] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Ken.

• fixed <rdar://problem/3865365> since -[WebScriptObject dealloc] does not call [super dealloc], the build will fail due to a warning
• fixed behavior so that [[WebScriptObject alloc] initWithCoder:] doesn't leak WebUndefined instances and incidentally so that [[WebScriptObject alloc] init] returns the single shared instance rather than allocating a new one

• bindings/objc/WebScriptObject.mm: Removed some stray semicolons. (+[WebUndefined allocWithZone:]): Made this the common bottleneck that returns the single instance of WebUndefined, since it's the single method that normally allocates new instances. Calls super to actually allocate only the very first time it's called. (-[WebUndefined initWithCoder:]): Simplified to just return self (no reason to re-lookup the single shared instance since there can be only one). (-[WebUndefined copyWithZone:]): Ditto. (-[WebUndefined retain]): Ditto. (-[WebUndefined retainCount]): Use UINT_MAX constant here (matches usage in NSObject.m for retain count of class). (-[WebUndefined autorelease]): Simplified to just return self (see above). (-[WebUndefined copy]): No need to override this since it just turns around and calls copyWithZone:. (-[WebUndefined dealloc]): Added an assertion since this method should never be called. Also added a call to [super dealloc] after return; to make the new -Wdealloc-check compiler happy (fixing the bug mentioned above). (+[WebUndefined undefined]): Reimplemented; calls allocWithZone:NULL to get to the shared instance. No need to call init, since that's a no-op for this class.

Nov 3, 2004:

4:40 PM Changeset in webkit [7933] by harrison

• 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Eliminate the use of a marker file to determine how to build.

• .cvsignore:
• Makefile.am:

7:58 AM Changeset in webkit [7932] by kocienda

• 1 edit
  6 adds in trunk

Reviewed by me

More layout tests.

• layout-tests/editing/deleting/delete-br-008-expected.txt: Added.
• layout-tests/editing/deleting/delete-br-008.html: Added.
• layout-tests/editing/deleting/delete-br-009-expected.txt: Added.
• layout-tests/editing/deleting/delete-br-009.html: Added.
• layout-tests/editing/deleting/delete-br-010-expected.txt: Added.
• layout-tests/editing/deleting/delete-br-010.html: Added.

3:52 AM Changeset in webkit [7931] by mjs

• 2 edits in trunk/WebCore

Fix by Yasuo Kida, reviewed by me.

<rdar://problem/3819004> REGRESSION (Mail): Can't move cursor / delete character after deleting the active input area

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setMarkedTextRange): Treat a collapsed range the same as a nil range - setting an empty marked range should clear the marked range entirely.

3:19 AM Changeset in webkit [7930] by mjs

• 15 edits in trunk

WebCore:

Reviewed by Dave Hyatt (when I originally coded it).

WebCore part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge firstRectForDOMRange:]): New method to compute the rect for a DOMRange, or if the range is split into multiple lines, the rect for the part on the first line only.

• khtml/rendering/render_object.cpp: (RenderObject::caretRect): Added extraWidthToEndOfLine parameter and ditto for the overrides below.
• khtml/rendering/render_object.h:
• khtml/rendering/render_box.cpp: (RenderBox::caretRect):
• khtml/rendering/render_box.h:
• khtml/rendering/render_br.cpp: (RenderBR::caretRect):
• khtml/rendering/render_br.h:
• khtml/rendering/render_flow.cpp: (RenderFlow::caretRect):
• khtml/rendering/render_flow.h:
• khtml/rendering/render_text.cpp: (RenderText::caretRect):

WebKit:

Reviewed by Dave Hyatt (when I originally coded it).

Redid WebKit part of fix for:

<rdar://problem/3759187> REGRESSION (Mail): implement firstRectForCharacterRange:

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView firstRectForCharacterRange:]): Call the appropriate new bridge method, and translate to screen coordinates.