⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 8, 2004:

7:46 PM Changeset in webkit [7959] by harrison
  • 2 edits
    2 adds in trunk

Reviewed by Ken Kocienda.

<rdar://problem/3865854> Deleting first line deletes all lines

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::performGeneralDelete): Problem was that the code that deletes fully selected m_downstreamEnd.node() by deleting one of its ancestors, failed to end the loop that deletes all fully selected nodes. Also, fixed this code to clear m_trailingWhitespaceValid. Also removed dead m_endingPosition update because it is handled in calculateEndingPosition now.
  • layout-tests/editing/deleting/delete-3865854-fix-expected.txt: Added.
  • layout-tests/editing/deleting/delete-3865854-fix.html: Added.
4:32 PM Changeset in webkit [7958] by kocienda
  • 7 edits in trunk/WebCore

Reviewed by Hyatt

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::createContextualFragment): Now takes flag to control whether comments are added to the DOM.
  • khtml/html/html_elementimpl.h: Ditto.
  • khtml/html/htmlparser.cpp: (KHTMLParser::KHTMLParser): Ditto. (KHTMLParser::getElement): Remove ifdef for comment processing. Replace with flag check.
  • khtml/html/htmlparser.h: Add flag to constructor so callers can request comment nodes.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): Add flag to constructor so callers can request comment nodes. (khtml::HTMLTokenizer::parseComment): Fix code to handle parsing out comment text correctly. There were a couple of indexing errors that resulted in the comment text containing part of the comment markers. (khtml::HTMLTokenizer::processToken): Don't let token id be reset to ID_TEXT if token is a comment.
  • khtml/html/htmltokenizer.h: Add flag to constructor so callers can request comment nodes.
4:22 PM Changeset in webkit [7957] by cblu
  • 4 edits in trunk/WebCore

Fixed: <rdar://problem/3870907> WebCore unnecessary links against JavaVM and Security

Reviewed by darin.

  • WebCore.pbproj/project.pbxproj: stop unnecessary linking
  • khtml/html/html_objectimpl.h: don't unnecessarily include JavaVM header
  • kwq/KWQKHTMLPart.h: ditto
4:02 PM Changeset in webkit [7956] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3825966> 8A274 Safari crashes closing window: QTimer::fire() with MallocStackLogging and MallocScribble enabled
  • kwq/KWQTimer.mm: (QTimer::fire): Rearrange so we don't access the QTimer object after calling code that possibly deletes the QTimer.
11:11 AM Changeset in webkit [7955] by cblu
  • 7 edits in trunk

WebCore:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

  • kwq/KWQTextField.mm: (-[KWQTextFieldController textView:shouldHandleEvent:]): let the bridge have a crack at the event so that it can swallow the newline if it wants to
  • kwq/WebCoreBridge.h:

WebKit:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge control:textView:shouldHandleEvent:]): new
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate control:textView:shouldHandleEvent:inFrame:]): new

WebBrowser:

Fixed: <rdar://problem/3783904> Return key behavior is confusingly different between popup menus and autofill menus

Reviewed by john.

  • BrowserWebController.m: (-[FormDelegate control:textView:shouldHandleEvent:inFrame:]): new
  • CompletionController.h:
  • CompletionController.m: (-[CompletionController handleInsertNewline]): new, factored out from next method (-[CompletionController control:textView:doCommandBySelector:]): call handleInsertNewline
  • FormCompletionController.h:
  • FormCompletionController.m: (-[FormCompletionController control:textView:shouldHandleEvent:]): new, call handleInsertNewline so that WebCore does not submit the form when a newline is entered
10:31 AM Changeset in webkit [7954] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Renamed NodeImpl::enclosingNonBlockFlowElement to NodeImpl::enclosingInlineElement, per Hyatt.

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::enclosingInlineElement):
  • khtml/xml/dom_nodeimpl.h:
Note: See TracTimeline for information about the timeline view.