Timeline

Nov 10, 2004:

6:08 PM Changeset in webkit [7971] by kdecker

• 2 edits in trunk/WebCore

Reviewed by mjs.

Fixed <rdar://problem/3875011> DOMNodeList::tryGet() performs unnecessary (and expensive) dom tree traversals. Improved a loop from 2-n-squared to just n-squared.

• khtml/ecma/kjs_dom.cpp: (DOMNodeList::tryGet): Got rid of an unnecessary node traversal.

2:39 PM Changeset in webkit [7970] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/3396872> ICONS: icon DB inconsistencies can cause slowness during startup, idle and quit

Reviewed by john.

• Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase objectForKey:]): added logging code
• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): use alloc, init rather than autorelease, retain (-[WebIconDatabase _loadIconDictionaries]): use 1 object for mapping icon URLs to site URLs and vice versa rather than 3. This avoids inconsistencies and is faster. (-[WebIconDatabase _updateFileDatabase]): write 1 object out

2:03 PM Changeset in webkit [7969] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Chris

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Move position adjustments for smart delete from the two functions below to here. There was an unnecessary double calculation of the leading and trailing whitespace positions. Also refined the trailing case so it only acts when the leading position is null (which seems to match TextEdit in my tests). Also removed some unnecessary copying of Position objects. (khtml::DeleteSelectionCommand::startPositionForDelete): Move out smart delete adjustment from here. (khtml::DeleteSelectionCommand::endPositionForDelete): Ditto.

11:04 AM Changeset in webkit [7968] by kocienda

• 4 edits in trunk/WebCore

Reviewed by Harrison

(khtml::DeleteSelectionCommand::performGeneralDelete): Add some more comments to
make things more clear.

• khtml/editing/selection.cpp: (khtml::Selection::toRange): Fixed the upstream and downstream calls so that the resulting positions do not cross block boundaries. This was a bug and caused some delete problems when whole blocks were selected. I will be addressing that issue more fully in upcoming changes.

8:58 AM Changeset in webkit [7967] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Harrison

Some cleanups and fixes in upstream and downstream functions.

Removed redundant checks for isBlockFlow() when calling enclosingBlockFlowElement().
Blocks do not need to skip the call to enclosingBlockFlowElement() for fear that the
block's enclosing block will be returned.

Remove code from upstream that confined the serach to block boundaries outside of
the code which runs in the StayInBlock case. This code was redundant, and caused
incorrect results to be returned in the DoNotStayInBlock case.

In downstream, the check for crossing into a new block should use the equivalentDeepPosition()
node, not the the this pointer's node.

• khtml/xml/dom_position.cpp: (DOM::Position::upstream) (DOM::Position::downstream)

Nov 9, 2004:

7:47 PM Changeset in webkit [7966] by hyatt

• 14 edits in trunk/WebCore

Fix for 3873234, Safari UI is unresponsive when parsing multiple HTML docs and 3873233, Safari hangs when
loading large local files.

Reviewed by mjs

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::reset): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::stopped): (khtml::HTMLTokenizer::processingData): (khtml::HTMLTokenizer::continueProcessing): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::allDataProcessed): (khtml::HTMLTokenizer::end): (khtml::HTMLTokenizer::finish): (khtml::HTMLTokenizer::notifyFinished):
• khtml/html/htmltokenizer.h:
• khtml/khtml_part.cpp: (KHTMLPart::slotFinished): (KHTMLPart::end): (KHTMLPart::stop):
• khtml/khtml_part.h: (KHTMLPart::tokenizerProcessedData):
• khtml/khtmlview.cpp:
• khtml/xml/dom_docimpl.cpp:
• khtml/xml/xml_tokenizer.h: (khtml::Tokenizer::stopped): (khtml::Tokenizer::processingData):
• kwq/KWQDateTime.h:
• kwq/KWQDateTime.mm: (QDateTime::secsTo): (KWQUIEventTime::uiEventPending):
• kwq/KWQKHTMLPart.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::tokenizerProcessedData):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge stop]): (-[WebCoreBridge numPendingOrLoadingRequests]): (-[WebCoreBridge doneProcessingData]):

7:46 PM Changeset in webkit [7965] by hyatt

• 3 edits in trunk/WebKit

Fix for 3873234, Safari UI is unresponsive when parsing multiple HTML docs and 3873233, Safari hangs when
loading large local files.

Reviewed by mjs

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge tokenizerProcessedData]):
• WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource isLoading]):

5:04 PM Changeset in webkit [7964] by harrison

• 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3865837> Wrong text style after delete to start of document

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::saveTypingStyleState): Sample computedStyle of m_selectionToDelete.start instead of m_downstreamStart.

4:28 PM Changeset in webkit [7963] by cblu

• 2 edits
  1 add in trunk/JavaScriptCore

Fixed: <rdar://problem/3872724> soft link against JavaVM to save ~2MB RSHRD

Reviewed by rjw.

• ChangeLog:
• JavaScriptCore.pbproj/project.pbxproj: don't link against JavaVM
• bindings/softlinking.c: Added. (loadFramework): new (getFunctionPointer): new (JNI_GetCreatedJavaVMs): load JavaVM if not already loaded, get _JNI_GetCreatedJavaVMs symbol if we don't already have it, call JNI_GetCreatedJavaVMs

1:52 PM Changeset in webkit [7962] by rjw

• 2 edits in trunk/WebCore

Fixed <rdar://problem/3872440> NSTimer prematurely released.

Reviewed by Darin.

• kwq/KWQTimer.mm: (QTimer::fire):
• kwq/KWQWidget.mm: (QWidget::paint):

12:57 PM Changeset in webkit [7961] by rjw

• 3 edits in trunk/WebKit

Fixed <rdar://problem/3870964> 8A300: Safari not recognizing a PDF link (it displays raw data)

Add "text/pdf" as an acceptable PDF MIME type.

Reviewed by Chris.

• WebView.subproj/WebDataSource.m: (+[WebDataSource _repTypesAllowImageTypeOmission:]):
• WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):

12:52 PM Changeset in webkit [7960] by cblu

• 2 edits in trunk/WebCore

Reviewed by vicki.

• WebCore.pbproj/project.pbxproj: explicitly link against libxml2.2.6.14.dylib since the version number has been bumped