⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 4, 2004:

2:31 PM Changeset in webkit [8122] by darin
  • 15 edits in trunk

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3878329> REGRESSION (169-170): colors are wrong for my.yahoo.com due to CSS background parsing changes
  • khtml/css/cssparser.cpp: (CSSParser::parseBackgroundShorthand): Changed function so it doesn't rely on the position attribute being at the end of the array and then moved position attribute before color attribute so it takes precedence. Since "0" can be both the X coordinate of a position and a legal color (meaning black), we need to do position first.
  • fixed <rdar://problem/3760869> click events for input type=button or type=checkbox don't have flags like shiftKey set
  • khtml/rendering/render_form.h: Remove unused RenderFormElement fields.
  • khtml/rendering/render_form.cpp: (RenderFormElement::RenderFormElement): Take out code to set a bunch of unused fields. (RenderFormElement::slotClicked): Change to create the QMouseEvent from the actual mouse event rather than creating it with all the flags set to 0, using the new QMouseEvent constructor that does so.
  • kwq/KWQEvent.h: Added constructor that takes no parameters which uses the current event from AppKit. Made the click count getter const and added an isDoubleClick that matches the logic used elsewhere. Added a fixState helper method so the constructors can save code.
  • kwq/KWQEvent.mm: (QMouseEvent::QMouseEvent): Factored out the state-fixing code that was in the two existing constructors and added a third constructor that uses the "current event" from AppKit (used above). (QMouseEvent::fixState): Compute state and click count based on event type.
  • fixed first symptom of <rdar://problem/3830936> REGRESSION (125-165): crash due to null font family, hang at changeforamerica.com
  • kwq/KWQFontFamily.mm: (KWQFontFamily::getNSFamily): Handle empty strings specially so we don't run into trouble when the family name is a null string. This prevents the crash, but there are still other problems that may have the same underlying cause in CSS.
  • fixed <rdar://problem/3829808> Safari crashes when adding a DOM node that was removed from an XMLHTTP request result
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): Added nil check before calling scheduleRelayout. This is new code so the nil-dereference is a recent regression.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/3846079> assertion failure in WebHTMLView(WebPrivate) removeTrackingRect at boots.com
  • fixed <rdar://problem/3857737> REGRESSION (165-166): clicking in a text field that's scrolled to the right causes it to scroll all the way left
  • fixed <rdar://problem/3861952> REGRESSION (165-166): selection is cleared when you start to scroll a frame
  • WebView.subproj/WebHTMLViewInternal.h: Added handlingMouseDown flag.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _addTrackingRect:owner:userData:assumeInside:useTrackingNum:]): Allow passing in a tracking number of 0, which means no existing tracking number. (-[WebHTMLView _addTrackingRects:owner:userDataList:assumeInsideList:trackingNums:count:]): Ditto. (-[WebHTMLView removeTrackingRect:]): Allow removing a tracking number of 0, which is a no-op. (-[WebHTMLView _removeTrackingRects:count:]): Ditto. (-[WebHTMLView acceptsFirstResponder]): Changed check to use handlingMouseDown flag instead of mouseDownEvent field since that field is set up too early in the mouse down event handling process. (-[WebHTMLView mouseDown:]): Added code to set handlingMouseDown flag.
  • fixed part of <rdar://problem/3829808> Safari crashes when adding a DOM node that was removed from an XMLHTTP request result
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Changed code around so that it won't try to create a WebResource when the load fails.
  • moved next/previous links into private structure with the rest of WebFrame fields (We have a rule against putting new fields into obejcts that are part of our public API.)
  • WebView.subproj/WebFrame.h: Remove _nextSibling and _previousSibling.
  • WebView.subproj/WebFramePrivate.h: Added nextSibling and previousSibling fields to private class.
  • WebView.subproj/WebFrame.m: Got rid of some tabs in this file. (-[WebFrame _addChild:]): Changed code to use fields inside _private. (-[WebFrame _removeChild:]): Ditto. (-[WebFrame _nextFrameWithWrap:]): Ditto. (-[WebFrame _previousFrameWithWrap:]): Ditto.
10:37 AM Changeset in webkit [8121] by cblu
  • 22 edits in trunk

WebCore:

New fixes for:
<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)
<rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account
<rdar://problem/3902749> REGRESSION (Tiger): missing image symbol does not appear

Reviewed by darin, rjw, kocienda.

  • khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedCSSStyleSheet::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestScript):
  • khtml/misc/loader.h: (khtml::CachedObject::CachedObject): (khtml::CachedObject::response): (khtml::CachedObject::allData):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): (KIO::TransferJobPrivate::~TransferJobPrivate): (KIO::TransferJob::TransferJob): (KIO::TransferJob::assembleResponseHeaders): (KIO::TransferJob::retrieveCharset): (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQCheckCacheObjectStatus): (KWQIsResponseURLEqualToURL): (KWQResponseURL): (KWQResponseMIMEType): (KWQCacheObjectExpiresTime): (khtml::CachedObject::setResponse): (khtml::CachedObject::setAllData):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap):
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle:]): (-[KWQResourceLoader cancel]): (-[KWQResourceLoader reportError]): (-[KWQResourceLoader finishWithData:]):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreResourceLoader.h:

WebKit:

New fixes for:
<rdar://problem/3685766> WebDataSource is missing subresources when they use cached WebCore data
<rdar://problem/3722434> REGRESSION?: Assertion failure trying to drag image in iframe (itapema.sc.gov.br)
<rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account
<rdar://problem/3902749> REGRESSION (Tiger): missing image symbol does not appear

Reviewed by darin, rjw, kocienda.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didFinishLoading]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _internalLoadDelegate]): (-[WebFrame _sendResourceLoadDelegateMessagesForURL:response:length:]):
  • WebView.subproj/WebFrameInternal.h:
10:30 AM Changeset in webkit [8120] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3876093> REGRESSION (166-167): Setting slider control's value from JavaScript has no effect (breaks RSS)
  • khtml/rendering/render_form.cpp: (RenderSlider::updateFromElement): Call setValue to update the value of the DOM element rather than modifying the m_value data member directly. We don't use m_value at all for sliders now, and in fact the code relies on the fact that m_value is null. Setting m_value to a non-null value was causing the bug. (RenderSlider::slotSliderValueChanged): Ditto.
7:31 AM Changeset in webkit [8119] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed remaining bit of <rdar://problem/3814237> REGRESSION (Mail): Copy/paste style does not set color in Mail compose window
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): When translating from an attribute dictionary to a CSS declaration, treat missing values according to the defaults defined in <AppKit/NSAttributedString.h>. Before the code was treating them as "no change", which is incorrect.
  • English.lproj/StringsNotToBeLocalized.txt: Add a string from the above change.

Dec 3, 2004:

5:56 PM Changeset in webkit [8118] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3889411> REGRESSION (125-172): repro crash in khtml::BackgroundLayer::cullEmptyLayers
  • khtml/rendering/render_style.cpp: (BackgroundLayer::cullEmptyLayers): added missing nil check
5:54 PM Changeset in webkit [8117] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (v173+)
The tree is open!

5:42 PM Changeset in webkit [8116]
  • 2 copies in tags/Safari-173

This commit was manufactured by cvs2svn to create tag 'Safari-173'.

5:42 PM Changeset in webkit [8115] by vicki
  • 6 edits in trunk

Safari-173 stamp

2:53 PM Changeset in webkit [8114] by kocienda
  • 26 edits in trunk

WebCore:

Reviewed by me

Roll out some recent changes by Chris that caused a performance regression.
Fix is in hand, but it is a little risky this close to a submission. So,
we have decided to roll back the change with the regression and roll in
the new code after we submit.

  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/misc/htmlattrs.c: (hash_attr): (findAttr):
  • khtml/misc/htmltags.c: (hash_tag): (findTag):
  • khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedObject::setResponse): (CachedCSSStyleSheet::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::slotReceivedResponse): (Cache::requestImage): (Cache::requestScript):
  • khtml/misc/loader.h: (khtml::CachedObject::CachedObject): (khtml::CachedObject::response):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): (KIO::TransferJobPrivate::~TransferJobPrivate): (KIO::TransferJob::TransferJob): (KIO::TransferJob::assembleResponseHeaders): (KIO::TransferJob::retrieveCharset): (KIO::TransferJob::emitResult): (KIO::TransferJob::emitReceivedResponse):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse): (KWQIsResponseURLEqualToURL): (KWQResponseURL): (KWQResponseMIMEType): (KWQResponseTextEncodingName): (KWQResponseHeaderString): (KWQCacheObjectExpiresTime): (KWQLoader::KWQLoader):
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap):
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle]): (-[KWQResourceLoader cancel]): (-[KWQResourceLoader reportError]): (-[KWQResourceLoader finish]):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreResourceLoader.h:

WebKit:

Reviewed by me

Roll out some recent changes by Chris that caused a performance regression.
Fix is in hand, but it is a little risky this close to a submission. So,
we have decided to roll back the change with the regression and roll in
the new code after we submit.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didFinishLoading]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _internalLoadDelegate]):
  • WebView.subproj/WebFrameInternal.h:
2:01 PM Changeset in webkit [8113] by sullivan
  • 2 edits in trunk/WebCore

Vicki gave me special dispensation to check this in though the tree is closed.

Reviewed by Chris.

  • fixed <rdar://problem/3903990> can't tab to all items on www.google.com any more (other pages too?)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): when checking whether we moved the focus to another view, make sure we didn't "move" it to our documentView, because that's no move at all.
1:01 PM Changeset in webkit [8112] by darin
  • 4 edits in trunk/WebCore

Reviewed by Vicki.

  • fixed <rdar://problem/3901109> REGRESSION (171-172): repro crash in DOM::NodeImpl::setChanged at chick-fil-a.com
  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::CSSMutableStyleDeclarationImpl): Added missing initialization for base class and node pointer.
  • fixed a few places that could leave dangling node pointers
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::~HTMLBodyElementImpl): Clear out the node pointer when the node is destroyed.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::~HTMLElementImpl): Ditto.
12:06 PM Changeset in webkit [8111] by cblu
  • 11 edits in trunk/WebCore

Fix for performance regression. My original patch added a signal for passing the data of a resource to its WebCore cache object. This patch passes the data with the preexisting "finished" symbol so we make less calls.
Fixed: <rdar://problem/3903173> REGRESSION (172-TOT): assertion failure and crash in slotAllData logging into hotmail account

Reviewed by rjw.

  • khtml/misc/loader.cpp: (Loader::servePendingRequests): pass data param to slotFinished, removed allData signal (Loader::slotFinished): take data param
  • khtml/misc/loader.h:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::TransferJob): have m_result take a data param, removed m_allData (KIO::TransferJob::emitResult): take data param and pass it
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle:]): take data param and pass it (-[KWQResourceLoader cancel]): pass nil for data (-[KWQResourceLoader reportError]): ditto (-[KWQResourceLoader finishWithData:]): pass data
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): pass data param to slotFinished (KWQSlot::call): added support for slotFinished_Loader, removed slotAllData
10:57 AM Changeset in webkit [8110] by kocienda
  • 5 edits in trunk/WebCore

Reviewed by John

Did some clean up in the Position class as a result of trying to write some new layout
tests and discovering a bug along the way.

I removed these three functions from the Position class:

  1. bool isFirstRenderedPositionOnLine() const;
  2. bool isLastRenderedPositionOnLine() const;
  3. static bool renderersOnDifferentLine(RenderObject *r1, long o1, RenderObject *r2, long o2);
  4. bool inFirstEditableInRootEditableElement() const;

The first two have replacements in the VisiblePosition class, and some code has been
moved to use these new variants. The third function was a helper used only by these
first two function, and can be removed as well. The fourth function was not used by anyone.

  • khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::input): Change over to use VisiblePosition isFirstVisiblePositionOnLine().
  • khtml/editing/visible_position.cpp: (khtml::visiblePositionsOnDifferentLines): Added an additional check for blocks to this function. Incorrect results were being returned when asking about positions at the starts of blocks.
  • khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): Change over to use VisiblePosition isFirstVisiblePositionOnLine(). (DOM::Position::nextCharacterPosition): Change over to use VisiblePosition isLastVisiblePositionOnLine(). (DOM::Position::rendersInDifferentPosition): Removed use of #3 helper in a log message. We can live without it.
  • khtml/xml/dom_position.h: Update header for deletions.
9:31 AM Changeset in webkit [8109] by kocienda
  • 19 edits in trunk

Reviewed by John

Terminology change in execCommand command identifiers. Specifically, the name of
"InsertNewline" command has been changed to "InsertLineBreak". This matches the
terminology used by AppKit. It is also more accurate, since the insertion of a
"br" element is what the command does. The inspiration for this change is so the
-insertNewline AppKit method can be mapped to insert a new "div" element in
a document and avoid ambiguity with what the javascript editing command does.

  • khtml/editing/jsediting.cpp
  • layout-tests/editing/deleting/delete-tab-004.html
  • layout-tests/editing/editing.js
  • layout-tests/editing/inserting/insert-3654864-fix.html
  • layout-tests/editing/inserting/insert-3659587-fix.html
  • layout-tests/editing/inserting/insert-3775316-fix.html
  • layout-tests/editing/inserting/insert-3800346-fix.html
  • layout-tests/editing/inserting/insert-br-001.html
  • layout-tests/editing/inserting/insert-br-002.html
  • layout-tests/editing/inserting/insert-br-003.html
  • layout-tests/editing/inserting/insert-br-004.html
  • layout-tests/editing/inserting/insert-br-005.html
  • layout-tests/editing/inserting/insert-br-006.html
  • layout-tests/editing/inserting/insert-br-007.html
  • layout-tests/editing/inserting/insert-br-008.html
  • layout-tests/editing/inserting/insert-tab-004.html
  • layout-tests/editing/inserting/insert-text-with-newlines.html
  • layout-tests/editing/pasteboard/paste-text-010.html
Note: See TracTimeline for information about the timeline view.