Timeline

Dec 8, 2004:

5:20 PM Changeset in webkit [8159] by rjw

• 3 edits in trunk/WebKit

Fixed <rdar://problem/3911719> REGRESSION: Images no longer scale vertically
Account for scaling correctly when taking into account progressively

loaded images.

Also added implementation of repetition count for animated GIF images.
Also replaced strings with new constants from CFImageProperties.h

Also fixed possible problem with -(NSSize)size implementation,
relevant to Panther only.

Reviewed by Chris.

• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _floatProperty:type:at:]): (-[WebImageData _frameDurationAt:]): (-[WebImageData _repetitionCount]):
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]):

2:54 PM Changeset in webkit [8158] by mjs

• 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/3908017> REGRESSION (172-173): assertion in ObjectImp::construct trying to create JS error (24hourfitness.com)

The fix was to implement copy constructor and assignment operator,
the ones that worked on the base class did not replace the
defaults apparently!

• kjs/protect.h: (KJS::ProtectedValue::ProtectedValue): (KJS::ProtectedValue::operator=): (KJS::ProtectedObject::ProtectedObject): (KJS::ProtectedObject::operator=):

Also fixed a bug in the GC test mode that compares the results of
the old collector and the new collector.

• kjs/value.cpp: (ValueImp::mark):

1:58 PM Changeset in webkit [8157] by cblu

• 4 edits in trunk/WebKit

Removed NPN wrappers since these no longer need to be defined to make the QT plug-in work
since 3828925 has been fixed.

Reviewed by john.

• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): use under-bar symbols since non-under-bar wrappers have been removed
• Plugins.subproj/npapi.m: removed NPN wrappers
• WebKit.exp: removed symbols

8:30 AM Changeset in webkit [8156] by kocienda

• 2 edits in trunk/WebKit

Reviewed by Darin

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): Work around for this bug: <rdar://problem/3908282> REGRESSION (Mail): No drag image dragging selected text in Blot and Mail The reason for the workaround is that this method is called explicitly from the code to generate a drag image, and at that time, getRectsBeingDrawn:count: will return a zero count. This code change uses the passed-in rect when the count is zero.

Dec 7, 2004:

4:27 PM Changeset in webkit [8155] by cblu

• 3 edits in trunk/WebKit

WebKit:

Support for fix for:
<rdar://problem/3734309> Safari doesn't open folders in title bar menu with non-Roman names using Cmd+click

Reviewed by john.

• Misc.subproj/WebNSURLExtras.h:
• Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithUserTypedString:relativeToURL:]): renamed to take relativeToURL parameter (+[NSURL _web_URLWithUserTypedString:]): call _web_URLWithUserTypedString:relativeToURL: with nil for URL

WebBrowser:

Fixed: <rdar://problem/3734309> Safari doesn't open folders in title bar menu with non-Roman names using Cmd+click

Reviewed by john.

• TitleBarButton.m:

(-[TitleBarButton showPathRepresentingPopUpMenu]): use …

since the path returned by [NSURL path] is of the "user typed" variety

3:39 PM Changeset in webkit [8154] by rjw

• 2 edits in trunk/WebKit

Fixed <rdar://problem/3905564> REGRESSION (Tiger); in History menu, pixel size appears but is wrong for standalone images in Safari.

Reviewed by Chris.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer size]):

3:06 PM Changeset in webkit [8153] by rjw

• 17 edits
  4 adds in trunk

WebCore:

Support threaded image decoding on machines w/ > 2 CPUs.

Reviewed by Maciej and Chris.

• khtml/misc/loader.cpp: (CachedImageCallback::notifyUpdate): (CachedImageCallback::notifyFinished): (CachedImageCallback::notifyDecodingError): (CachedImageCallback::handleError): (CachedImageCallback::clear): (CachedImage::CachedImage): (CachedImage::clear): (CachedImage::data): (CachedImage::checkNotify): (Loader::servePendingRequests): (Loader::slotFinished): (Loader::numRequests): (Loader::cancelRequests): (Loader::removeBackgroundDecodingRequest):
• khtml/misc/loader.h: (khtml::CachedImageCallback::CachedImageCallback): (khtml::CachedImageCallback::ref): (khtml::CachedImageCallback::deref): (khtml::CachedImage::decoderCallback):
• khtml/rendering/render_object.cpp: (RenderObject::setPixmap):
• kwq/KWQPixmap.h:
• kwq/KWQPixmap.mm: (-[WebImageCallback initWithCallback:khtml::]): (-[WebImageCallback _commonTermination]): (-[WebImageCallback dealloc]): (-[WebImageCallback finalize]): (-[WebImageCallback notify]): (-[WebImageCallback setImageSourceStatus:]): (-[WebImageCallback status]): (QPixmap::shouldUseThreadedDecoding): (QPixmap::receivedData):
• kwq/WebCoreImageRenderer.h:
• kwq/WebCoreImageRendererFactory.h:
• kwq/WebCoreImageRendererFactory.m: (+[WebCoreImageRendererFactory shouldUseThreadedDecoding]): (+[WebCoreImageRendererFactory setShouldUseThreadedDecoding:]):

WebKit:

Support threaded image decoding on machines w/ > 2 CPUs.

Reviewed by Maciej and Chris.

• Misc.subproj/WebKitSystemBits.h:
• Misc.subproj/WebKitSystemBits.m: (WebSystemMainMemory): (WebNumberOfCPUs):
• WebCoreSupport.subproj/WebImageData.h:
• WebCoreSupport.subproj/WebImageData.m: (+[WebImageData initialize]): (-[WebImageData init]): (-[WebImageData _commonTermination]): (-[WebImageData dealloc]): (-[WebImageData _invalidateImages]): (-[WebImageData _imageSourceOptions]): (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData _createImages]): (-[WebImageData decodeData:isComplete:callback:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]): (drawPattern): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData isNull]): (-[WebImageData size]): (-[WebImageData _frameDurationAt:]): (-[WebImageData _frameDuration]): (+[WebImageData stopAnimationsInView:]): (-[WebImageData addAnimatingRenderer:inView:]): (-[WebImageData removeAnimatingRenderer:]):
• WebCoreSupport.subproj/WebImageDecodeItem.h: Added.
• WebCoreSupport.subproj/WebImageDecodeItem.m: Added. (+[WebImageDecodeItem decodeItemWithImage:data:isComplete:callback:]): (-[WebImageDecodeItem initWithImage:data:isComplete:callback:]): (-[WebImageDecodeItem finalize]): (-[WebImageDecodeItem dealloc]):
• WebCoreSupport.subproj/WebImageDecoder.h: Added.
• WebCoreSupport.subproj/WebImageDecoder.m: Added. (decoderNotifications): (+[WebImageDecoder initialize]): (+[WebImageDecoder notifyMainThread]): (+[WebImageDecoder sharedDecoder]): (+[WebImageDecoder performDecodeWithImage:data:isComplete:callback:]): (+[WebImageDecoder imageDecodesPending]): (+[WebImageDecoder decodeComplete:status:]): (-[WebImageDecoder init]): (-[WebImageDecoder dealloc]): (-[WebImageDecoder finalize]): (-[WebImageDecoder removeItem]): (-[WebImageDecoder addItem:]): (-[WebImageDecoder decodeItem:]): (decoderThread): (startDecoderThread):
• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer initWithData:MIMEType:]): (-[WebImageRenderer initWithContentsOfFile:]): (-[WebImageRenderer incrementalLoadWithBytes:length:complete:callback:]): (-[WebInternalImage incrementalLoadWithBytes:length:complete:callback:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation receivedData:withDataSource:]): (-[WebImageRepresentation receivedError:withDataSource:]): (-[WebImageRepresentation finishedLoadingWithDataSource:]):

WebBrowser:

Added a menu item to enable/disable threaded image decoding.

Reviewed by Maciej and Chris.

• Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): (-[BrowserDocument toggleUseATSUForAllTextDrawing:]): (-[BrowserDocument toggleUseThreadedImageDecoding:]): (-[BrowserDocument validate_toggleUseThreadedImageDecoding:]):

12:46 PM Changeset in webkit [8152] by cblu

• 2 edits in trunk/WebKit

Fix for performance regression.

Reviewed by kevin.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): construct the WebResource without copying the data

12:05 PM Changeset in webkit [8151] by cblu

• 5 edits in trunk/WebKit

Fixed: <rdar://problem/3909243> REGRESSION: large standalone images stop loading part way through

Reviewed by kevin.

• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient addData:]): call super so it buffers the data

11:01 AM Changeset in webkit [8150] by kocienda

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix my NOBODY (OOPS!). John reviewed.

10:13 AM Changeset in webkit [8149] by kocienda

• 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

• khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Fix a problem with my change in thei code yesterday. Call to insertBlockPlaceholderIfNeeded() must be done after new block has been inserted, otherwise a crash can result. Shuffle down call to insertBlockPlaceholderIfNeeded() a couple of lines (where the node is inserted), and all is good.

10:01 AM Changeset in webkit [8148] by kocienda

• 2 edits
  2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3907422> REGRESSION (Mail): Pasting quoted content can place content after body element

• khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Detect when the body element is the "reference block" used for determining the location for inserting content. Do not allow an insert before or after if the reference block is the body. Perform insertNodeAt(0) and appendNode, respectively, in the block-is-body case.
• layout-tests/editing/inserting/insert-3907422-fix-expected.txt: Added.
• layout-tests/editing/inserting/insert-3907422-fix.html: Added.

9:45 AM Changeset in webkit [8147] by darin

• 2 edits in trunk/WebCore

Reviewed by Don.

• fixed <rdar://problem/3908701> REGRESSION: Cursor does not change to "hand" over active links

• kwq/KWQEvent.mm: (positionForEvent): Add NSMouseMoved to list of events that have mouse location.

9:02 AM Changeset in webkit [8146] by kocienda

• 4 edits in trunk/WebCore

Reviewed by John

Changed name of constant from KHTMLInterchangeNewline to AppleInterchangeNewline.
I discussed this with Hyatt and he agreed that going with "Apple" names was OK.

• khtml/editing/html_interchange.h: Name change, as described above.
• khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::isInterchangeNewlineComment): Ditto.
• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): Ditto.

7:09 AM Changeset in webkit [8145] by kocienda

• 1 edit
  4 adds in trunk

Reviewed by me

Added a couple more layout tests.

• layout-tests/editing/deleting/delete-line-013-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-013.html: Added.
• layout-tests/editing/deleting/delete-line-014-expected.txt: Added.
• layout-tests/editing/deleting/delete-line-014.html: Added.