Timeline

Jan 11, 2005:

4:49 PM Changeset in webkit [8340] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3934749> assertion failure in WebBaseNetscapePluginView loading movie

Reviewed by john.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): call canStart before asserting about the webView

4:30 PM Changeset in webkit [8339] by rjw

• 3 edits in trunk/WebCore

Fixed 3922875. Fall back to DOM object is EMBED element
has no associated runtime object.

Reviewed by Chris.

• khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):

3:46 PM Changeset in webkit [8338] by hyatt

• 2 edits in trunk/WebCore

Fix for 3882299, missing content on gibson.com. Change our handling of " and ' in certain states of the parser to match
other browsers.

Reviewed by Maciej

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):

3:43 PM Changeset in webkit [8337] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fixed <rdar://problem/3446838> REGRESSION (Mail): text decorations don't print (e.g. <strike>, underline)

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]): This bottleneck routine for drawing a line was setting the linewidth to 0 when the graphics context was not drawing to the screen. Thus, no lines. Now links are underlined when printing from Safari (as well as Mail).

2:50 PM Changeset in webkit [8336] by rjw

• 2 edits in trunk/WebKit

Fixed 3949145. CG has a much faster API for drawing lines.
Switched over to that new API (CGContextStrokeLineSegments).

Reviewed by John Sullivan.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:withWidth:withColor:]):

2:44 PM Changeset in webkit [8335] by cblu

• 5 edits in trunk/WebCore

Fixed: <rdar://problem/3930733> Mail prints second page of email blank

Reviewed by dave.

• khtml/rendering/render_canvas.cpp: (RenderCanvas::paint): cache the print rect since the dirty rect can get changed during printing
• khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): removed null check since the print rect should never be null
• khtml/rendering/render_list.cpp: (RenderListMarker::paint): ditto
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::adjustPageHeight): don't set the print rect here since this method is not called for the last page

1:25 PM Changeset in webkit [8334] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3948862> REGRESSION: missing images when RTFD is pasted into editable WebView

This problem occurred because we were creating image elements before creating corresponding image resources. The fix is to have AppKit call us back to create the resources before it creates the elements.

Reviewed by john.

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): don't deal with subresources since that's now done by the following method (-[WebHTMLView resourceForData:preferredFilename:]): new handler method called by AppKit

Jan 10, 2005:

3:40 PM Changeset in webkit [8333] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3943648> extra line is inserted after pressing return within quoted text of reply

• khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): This bug was the result of a simple coding mistake. A local variable was erroneously redefined in a deeper scope, and so the result calculated in that deeper scope was not available when tested.

3:28 PM Changeset in webkit [8332] by kocienda

• 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3946852> Option-e goes to next line

• khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Tweak case used to determine when merging content into the start line is done. We plan to change pretty substantially soon to better handle the problem described in <rdar://problem/3937352> Quote level not maintained when copied and pasted within a Mail message. In the meantime, this change does no harm, and fixes the bug.

10:47 AM Changeset in webkit [8331] by kocienda

• 5 edits
  26 adds in trunk

Reviewed by Darin

Fix for this bug:

<rdar://problem/3907005> Applying block styles to a line of text can unexpectedly affect other lines

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): New function which moves "paragraphs" to their own blocks if needed so that a block style can be applied. (khtml::CompositeEditCommand::isMailBlockquote): Moved this function to base class so it can be used more generally. (khtml::ApplyStyleCommand::applyBlockStyle): Pass a node instead of a block to addBlockStyleIfNeeded(). (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Now accepts a node instead of a block for styling. This function also now calls moveParagraphContentsToNewBlockIfNecessary() to make sure that only the current paragraph is styled. (khtml::SetNodeAttributeCommand::doUnapply): Should not assert on undo if old value of attribute was null. Should remove attributue instead.
• khtml/editing/htmlediting.h: Touch function declarations accordingly.
• layout-tests/editing/style/create-block-for-style-001-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-001.html: Added.
• layout-tests/editing/style/create-block-for-style-002-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-002.html: Added.
• layout-tests/editing/style/create-block-for-style-003-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-003.html: Added.
• layout-tests/editing/style/create-block-for-style-004-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-004.html: Added.
• layout-tests/editing/style/create-block-for-style-005-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-005.html: Added.
• layout-tests/editing/style/create-block-for-style-006-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-006.html: Added.
• layout-tests/editing/style/create-block-for-style-007-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-007.html: Added.
• layout-tests/editing/style/create-block-for-style-008-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-008.html: Added.
• layout-tests/editing/style/create-block-for-style-009-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-009.html: Added.
• layout-tests/editing/style/create-block-for-style-010-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-010.html: Added.
• layout-tests/editing/style/create-block-for-style-011-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-011.html: Added.
• layout-tests/editing/style/create-block-for-style-012-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-012.html: Added.
• layout-tests/editing/style/create-block-for-style-013-expected.txt: Added.
• layout-tests/editing/style/create-block-for-style-013.html: Added.

Unrelated updates to these expected results.

• layout-tests/editing/inserting/insert-div-007-expected.txt
• layout-tests/editing/pasteboard/paste-text-013-expected.txt

10:38 AM Changeset in webkit [8330] by cblu

• 3 edits in trunk/WebCore

Fixed: <rdar://problem/3936844> Mail: Messages with rich text do not print

Reviewed by john.

• khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): don't do pagination work if printRect is not set
• khtml/rendering/render_list.cpp: (RenderListMarker::paint): ditto

10:22 AM Changeset in webkit [8329] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

• kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): Return empty string (AKA root locale) if locale pref can not be canonicalized.

9:07 AM Changeset in webkit [8328] by sullivan

• 2 edits in trunk/WebCore

Fixed broken Panther build.

• kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): This recently-added function was using code copy/pasted from CarbonCore UnicodeUtilities. That code used a Tiger-only function, CFLocaleCreateCanonicalLanguageIdentifierFromString. To fix the build, I added a BUILDING_ON_PANTHER #ifdef that avoids the call to the Tiger function. However, the Tiger-only code was wrong; the string generated using CFLocaleCreateCanonicalLanguageIdentifierFromString was not used at all, so I fixed that as well.