⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 19, 2005:

6:09 PM Changeset in webkit [8409] by rjw
  • 2 edits in trunk/WebCore

After further discussion with Real we have decided to NOT include the
additional CLSID for the real plugin. See 3958601.

Reviewed by Darin.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
5:39 PM Changeset in webkit [8408] by rjw
  • 5 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3853676> Browser Crash when accessing CCWeb Progress Page - KJS::Bindings::convertValueToJValue

Fixed the following problems with LiveConnect that are demonstrated by the application
described in 3853676.

  1. If a nil object is passed in an array from Java to JavaScript we will crash.
  2. We sometimes will incorrectly attempt to access a generic JavaScript as a Java runtime object wrapper.
  3. We will sometimes fail to find the correct static method ID.

Reviewed by Maciej.

  • bindings/jni/jni_jsobject.cpp: (JSObject::convertJObjectToValue): (JSObject::listFromJArray):
  • bindings/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getMethodID): (KJS::Bindings::convertValueToJValue):
  • bindings/runtime_array.h:
4:45 PM Changeset in webkit [8407] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line

Previous checkin for this bug was missing some of the patch. Editing snafu with multiple changes in tree.

  • kwq/KWQAccObject.mm: (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]):
4:05 PM Changeset in webkit [8406] by hyatt
  • 2 edits in trunk/WebKit

Fix for 3513067, spaces being lost when RTL text is rendered. Make sure not to allow hangers or spaces
in the margin.

Reviewed by john

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _createATSUTextLayoutForRun:style:]):
4:01 PM Changeset in webkit [8405] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Small, cosmetic change John and I decided to do on my last checkin, but I forgot to do before landing.
3:54 PM Changeset in webkit [8404] by kocienda
  • 21 edits
    6 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3959727> REGRESSION (Mail): Style not preserved on blank lines

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::applyStyle): (khtml::CompositeEditCommand::insertBlockPlaceholder): New function that unconditionally adds a block placeholder. (khtml::CompositeEditCommand::insertBlockPlaceholderIfNeeded): Now returns bool based on whether placeholder was added or not. (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): Now searches all the descendents of a block looking for a placeholder. The old code, which just looked at the last child of a node, started missing once block placeholders became styled (which started happening with this patch). (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Now handles applying typing style to a block placeholder at call time, rather than setting the typing style as a latent style that might be applied later. This is an important part of the bug fix. (khtml::DeleteSelectionCommand::doApply): Now uses bool return value from insertBlockPlaceholderIfNeeded() and passes it along to calculateStyleBeforeInsertion, so the case where a block placeholder needs to be styled can be detected. (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Changed the way this class managed style. Before it would calculate and set typing style for the block added. This is not sufficient. Added blocks need to styled immediately. Some name changes to instance variables in this class due to the change to accommodate this change. (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand): Name changes, as above. (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto. (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto. (khtml::InsertParagraphSeparatorCommand::doApply): Ditto. (khtml::ReplaceSelectionCommand::doApply): Improve check for testing when a placeholder block can be removed in its entirety after the insertion.
  • khtml/editing/htmlediting.h: Update header accordingly.
  • khtml/khtml_part.cpp: (KHTMLPart::selectionComputedStyle): Move position for computed style check downstream before doing check when the position is in an empty block (this makes sure any style on any block placeholder is accounted for).

New layout tests to check bug fix.

  • layout-tests/editing/style/block-style-004-expected.txt: Added.
  • layout-tests/editing/style/block-style-004.html: Added.
  • layout-tests/editing/style/block-style-005-expected.txt: Added.
  • layout-tests/editing/style/block-style-005.html: Added.
  • layout-tests/editing/style/block-style-006-expected.txt: Added.
  • layout-tests/editing/style/block-style-006.html: Added.

Results updated to reflect new block placeholder code.

  • layout-tests/editing/inserting/insert-div-004-expected.txt
  • layout-tests/editing/inserting/insert-div-005-expected.txt
  • layout-tests/editing/inserting/insert-div-006-expected.txt
  • layout-tests/editing/inserting/insert-div-008-expected.txt
  • layout-tests/editing/inserting/insert-div-011-expected.txt
  • layout-tests/editing/inserting/insert-div-012-expected.txt
  • layout-tests/editing/inserting/insert-div-013-expected.txt
  • layout-tests/editing/inserting/insert-div-014-expected.txt
  • layout-tests/editing/inserting/insert-div-015-expected.txt
  • layout-tests/editing/inserting/insert-div-016-expected.txt
  • layout-tests/editing/inserting/insert-div-017-expected.txt
  • layout-tests/editing/inserting/insert-div-018-expected.txt
  • layout-tests/editing/inserting/insert-div-019-expected.txt
  • layout-tests/editing/inserting/insert-div-021-expected.txt
  • layout-tests/editing/inserting/insert-div-022-expected.txt
  • layout-tests/editing/inserting/insert-div-023-expected.txt
  • layout-tests/editing/inserting/insert-div-024-expected.txt
2:57 PM Changeset in webkit [8403] by vicki
  • 2 edits in trunk/WebKit

Reviewed by vicki

  • fixed <rdar://problem/3962559> stopAnimationsInView leaks after cvs-base
  • WebCoreSupport.subproj/WebImageData.m: (+[WebImageData stopAnimationsInView:]): add a release
2:43 PM Changeset in webkit [8402] by hyatt
  • 2 edits in trunk/WebCore

Dont null-check the renderer before submitting, since a script can set it to display:none and still expect the
submission to occur. Fixes bug #3477282.

Reviewed by kdecker

(DOM::HTMLInputElementImpl::defaultEventHandler):

10:39 AM Changeset in webkit [8401] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3961809> plug-in code attempts to load empty URL

Reviewed by john.

  • Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]): don't start load if URL is empty

Jan 18, 2005:

6:34 PM Changeset in webkit [8400] by rjw
  • 22 edits in trunk

WebCore:

Fixed several issues all arising from analysis of plugin detection code at ifilm.com:

Fixed <rdar://problem/3958592> can't script plug-ins if plug-in is invoked with <object> element instead of <embed>
Fixed <rdar://problem/3958597> <object> elements with IDs do not show up as named properties of the document
Fixed <rdar://problem/3960973> DOM objects for plugin elements are not accessible
Fixed <rdar://problem/3958601> need an additional class ID in WebCore for the Real plug-in

We now support accessing scriptable plugin objects that are specified with <applet>, <embed>, or <object>
tags. Also, if any of these elements are named they can be accessed from the document or window objects.
Finally, DOM methods are properties will be forwarded appropriately for the plugin's root scriptable object.

Reviewed by Chris.

  • khtml/dom/html_document.cpp: (HTMLDocument::objects):
  • khtml/dom/html_document.h:
  • khtml/ecma/kjs_dom.cpp: (DOMDocumentProtoFunc::tryCall): (DOMElementProtoFunc::tryCall): (KJS::getRuntimeObject):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): (KJS::HTMLElement::tryGet): (KJS::HTMLCollection::tryGet): (KJS::HTMLCollection::getNamedItems):
  • khtml/ecma/kjs_window.cpp: (Window::get):
  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::traverseNextItem):
  • khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::getObjectInstance):
  • khtml/html/html_objectimpl.h:
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getObjectInstanceForView):

JavaScriptCore:

Fixed several issues all arising from analysis of plugin detection code at ifilm.com:

Fixed <rdar://problem/3958592> can't script plug-ins if plug-in is invoked with <object> element instead of <embed>
Fixed <rdar://problem/3958597> <object> elements with IDs do not show up as named properties of the document
Fixed <rdar://problem/3960973> DOM objects for plugin elements are not accessible
Fixed <rdar://problem/3958601> need an additional class ID in WebCore for the Real plug-in

We now support accessing scriptable plugin objects that are specified with <applet>, <embed>, or <object>
tags. Also, if any of these elements are named they can be accessed from the document or window objects.
Finally, DOM methods are properties will be forwarded appropriately for the plugin's root scriptable object.

Reviewed by Chris.

  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::supportsSetValueOfUndefinedField):
  • bindings/runtime.h: (KJS::Bindings::Instance::supportsSetValueOfUndefinedField):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue):
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::fallbackObject):
  • kjs/object.cpp: (KJS::ObjectImp::ObjectImp):
  • kjs/object.h: (KJS::ObjectImp::forwardingScriptMessage): (KJS::ObjectImp::setForwardingScriptMessage):
3:08 PM Changeset in webkit [8399] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3948123, rolling over link erases nearby text. The repaint rect check for lines was wrong whenever
two lines overlapped.

Reviewed by kocienda

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):
2:58 PM Changeset in webkit [8398] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3960116> Focus rings paint incorrectly for contenteditable blocks in web pages

  • khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): Fix painting of focus rings so that ring only paints around outermost contenteditable elements.
2:52 PM Changeset in webkit [8397] by rjw
  • 2 edits in trunk/JavaScriptCore

Back out a change that was incorrectly committed yesterday.

Reviewed by Chris.

  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
1:03 PM Changeset in webkit [8396] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3959668> accessibilityFocusedUIElement sometimes returns an ignored element; it must not

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityFocusedUIElement]): Return parentObjectUnignored if focused object is ignored.
10:11 AM Changeset in webkit [8395] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3952877> REGRESSION (Mail): Command-left/right-arrows don't work with file attachment

  • khtml/editing/selection.cpp: (khtml::nodeForInlineBox): New helper function used in reimplementation of function below. (khtml::selectionForLine): Reimplemented using line box smarts. I originally wrote this code when I had a less than full understanding of line layout. I can do better now, and my new version no longer fails to notice attachments when doing the kind of navigation mentioned in the bug.
Note: See TracTimeline for information about the timeline view.