⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 4, 2005:

5:49 PM Changeset in webkit [8527] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Rolled out Ken's accidental checkin when committing <rdar://problem/3986155> fix yesterday.

  • khtml/editing/selection.cpp: (khtml::Selection::validate):
5:45 PM Changeset in webkit [8526] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/3758785> Safari no longer works at BankOfAmerica online banking for military users

When closing the document, if a body doesn't exist we now create one. This bug was preventing the onload handler from
firing in cases where there wasn't a body. In the BankOfAmerica case, the page was just a bit of script where the onload
handler redirected to the correct page.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::close):
2:41 PM Changeset in webkit [8525] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3802781> rtf->html pasteboard conversion using xhtml

Reviewed by kocienda.

  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView _excludedElementsForAttributedStringConversion]): new (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call _excludedElementsForAttributedStringConversion
2:18 PM Changeset in webkit [8524] by kocienda
  • 6 edits
    12 adds in trunk

Reviewed by Chris

Fix for this bug:

<rdar://problem/3986155> Insertion point goes to beginning of doc after deleting

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::setStartNode): New convenience to handle reference counting when setting. (khtml::DeleteSelectionCommand::handleGeneralDelete): This contains the crux of the bug fix. Improve tests that detect when a selected node needs to be retained, rather than deleted, to preserve the intent of the user. This has the side effect of causing the insertion point placement code to succeed rather than fail. Before this fix, the failure of the insertion point placement code caused the insertion point to jump to the start of the document, which is the symptom that can be perceived by users when editing.
  • khtml/editing/htmlediting.h: Add setStartNode declaration.
  • khtml/editing/visible_units.cpp: (khtml::startOfBlock): This function had a stubbed-in non-tested implementation. Implement and
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-001.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-002.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-003.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-004.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-005.html: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt: Added.
  • layout-tests/editing/deleting/delete-at-paragraph-boundaries-006.html: Added.
10:45 AM Changeset in webkit [8523]
  • 3 copies in tags/Safari-183

This commit was manufactured by cvs2svn to create tag 'Safari-183'.

10:45 AM Changeset in webkit [8522] by vicki
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Move the Safari-183 marker in the ChangeLog, since we're going to include <rdar://problem/3972905> in today's Safari-183 submission

10:25 AM Changeset in webkit [8521] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3832973> copy text from PowerPoint, paste into Blot (or presumably Mail) and get a single missing image icon

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): prefer RTF and RTFD over images just as NSTextView does

Feb 3, 2005:

5:44 PM Changeset in webkit [8520] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3555137> REGRESSION (125-173): Flash animation can erase parts of chrome (bookmarks bar & tab bar)

convertRect:toView: returns incorrect results inside of viewWillMoveToWindow: with a nil window. Workaround this by catching this case.

Reviewed by darin.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): new (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): clip out the plug-in view when superviewsHaveSuperviews returns NO
5:41 PM Changeset in webkit [8519] by rjw
  • 2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/3972905> CrashTracer: ...36 crashes at com.apple.WebCore: khtml::CSSStyleSelector::applyDeclarations + 120

Revert to old (and correct) behavior of returning runtime object
when passed as a parameter, rather than it's corresponding DOM
object.

Reviewed by Chris.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
4:02 PM Changeset in webkit [8518] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3893513> Sun iPlanet app: when saving to a file it brings up a window with the thing to be saved instead

Reviewed by adele.

  • WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/ldif" to the list of MIME types that our text view doesn't handle
3:57 PM Changeset in webkit [8517] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (183+)
The tree is open!

3:46 PM Changeset in webkit [8516] by vicki
  • 6 edits in trunk

Safari-183 stamp

2:22 PM Changeset in webkit [8515] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/3987419> Stocks and Weather leak what appears to XMLHTTPRequest results

XMLHTTPRequests were causing massive leaks. _webcore_initWithHeaderString: did funky things with
self replacement. Re-wrote to use more traditional factory constructor avoiding self replacement.

Reviewed by David Harrison.

  • kwq/KWQLoader.mm: (+[NSDictionary _webcore_dictionaryWithHeaderString:]): (KWQServeRequest): (KWQServeSynchronousRequest):
2:09 PM Changeset in webkit [8514] by cblu
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: updated
1:59 PM Changeset in webkit [8513] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3989611> Evite style "add vCalendar to calendar" do not work

Reviewed by adele.

  • WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/x-vcalendar" to the list of MIME types our text view doesn't handle
11:56 AM Changeset in webkit [8512] by cblu
  • 2 edits in trunk/WebCore

Fixed: <rdar://problem/3938763> Cannot view Windows Media Player videos (soundtrack is played twice with delay)

Reviewed by hyatt.

  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): set needWidgetUpdate to false right after calling updateWidget because dispatchHTMLEvent can end up calling this method again (HTMLObjectElementImpl::recalcStyle): ditto
10:17 AM Changeset in webkit [8511] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fix deployment build breakage on Panther
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView toggleBaseWritingDirection:]):
Note: See TracTimeline for information about the timeline view.