Timeline

Feb 14, 2005:

5:52 PM Changeset in webkit [8592] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4004305> REGRESSION (Mail): Command-right-arrow on wrapped text goes to end of previous line

• khtml/editing/visible_text.cpp: (khtml::SimplifiedBackwardsTextIterator::advance): Add BR in for <rdar://problem/3917929> fix only if leaving a visible text node.

• khtml/editing/visible_units.cpp: (khtml::endOfWord): Do not move left over a paragraph boundary.

1:09 PM Changeset in webkit [8591] by darin

• 6 edits
  4 deletes in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/3686434> Safari uses too much RAM on file upload, leading to malloc errors and crashes (HP printers)

• khtml/html/html_formimpl.cpp: (DOM::FormDataList::begin): Updated to use a list of FormDataListItem instead of QCString. (DOM::FormDataList::end): Ditto. (DOM::HTMLFormElementImpl::formData): Same here, and also use appendFile rather than appendData when we encounter a path name rather than data. (DOM::HTMLInputElementImpl::appendFormData): Use appendFile here rather than reading the file in; the reading now happens inside WebKit. (DOM::FormDataList::appendString): Updated for FormDataListItem. (DOM::FormDataList::appendFile): Added.

• ForwardingHeaders/kfileitem.h: Emptied out the file; no longer includes KWQKFileItem.h.
• ForwardingHeaders/netaccess.h: Emptied out the file; no longer includes KWQKIONetAccess.h.
• kwq/KWQKFileItem.h: Removed.
• kwq/KWQKFileItem.mm: Removed.
• kwq/KWQKIONetAccess.h: Removed.
• kwq/KWQKIONetAccess.mm: Removed.
• WebCore.pbproj/project.pbxproj: Removed the 4 files above.

• small unrelated fix (not reviewed by John)

• khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Put some logging code outside if statements so it works all the time.

12:06 PM Changeset in webkit [8590] by darin

• 8 edits in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/3686434> Safari uses too much RAM on file upload, leading to malloc errors and crashes (HP printers)

• WebView.subproj/WebFormDataStream.h: Added webSetHTTPBody, which creates and connects an appropriate stream to an NSMutableURLRequest.
• WebView.subproj/WebFormDataStream.m: Added implementation here.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Use webSetHTTPBody.
• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Use webSetHTTPBody.
• WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Use webSetHTTPBody. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.

• English.lproj/StringsNotToBeLocalized.txt: Updated for this change and other recent changes.

10:19 AM Changeset in webkit [8589] by harrison

• 28 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4004305> REGRESSION (Mail): Command-right-arrow on wrapped text goes to end of previous line

Fixed nextLinePosition to calculate affinity rather than take it as a parameter. Propagated the parameter change out to related methods.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::InsertLineBreakCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertTextCommand::input): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::applyStyleToInsertedNodes):
• khtml/editing/selection.cpp: (khtml::Selection::modifyExtendingRightForward): (khtml::Selection::modifyMovingRightForward): (khtml::Selection::modifyExtendingLeftBackward): (khtml::Selection::modifyMovingLeftBackward): (khtml::Selection::modify): (khtml::Selection::validate):
• khtml/editing/visible_position.cpp: (khtml::visiblePositionsOnDifferentLines):
• khtml/editing/visible_units.cpp: (khtml::rootBoxForLine): (khtml::startOfLine): (khtml::endOfLine): (khtml::inSameLine): (khtml::isStartOfLine): (khtml::isEndOfLine): (khtml::previousLinePosition): (khtml::nextLinePosition): (khtml::previousSentencePosition): (khtml::nextSentencePosition): (khtml::previousParagraphPosition): (khtml::nextParagraphPosition):
• khtml/editing/visible_units.h:
• khtml/khtml_events.cpp: (khtml::MouseEvent::offset):
• khtml/khtml_part.cpp: (KHTMLPart::isPointInsideSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
• khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates):
• khtml/rendering/render_block.h:
• khtml/rendering/render_br.cpp: (RenderBR::positionForCoordinates):
• khtml/rendering/render_br.h:
• khtml/rendering/render_container.cpp: (RenderContainer::positionForCoordinates):
• khtml/rendering/render_container.h:
• khtml/rendering/render_inline.cpp: (RenderInline::positionForCoordinates):
• khtml/rendering/render_inline.h:
• khtml/rendering/render_object.cpp: (RenderObject::caretRect): (RenderObject::positionForCoordinates):
• khtml/rendering/render_object.h:
• khtml/rendering/render_replaced.cpp: (RenderReplaced::positionForCoordinates):
• khtml/rendering/render_replaced.h:
• khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates):
• khtml/rendering/render_text.h:
• khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): (DOM::Position::nextCharacterPosition): (DOM::Position::leadingWhitespacePosition): (DOM::Position::trailingWhitespacePosition):
• khtml/xml/dom_position.h:
• kwq/KWQAccObject.mm: (-[KWQAccObject value]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]):
• kwq/KWQKHTMLPart.mm:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge _visiblePositionForPoint:]):