⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 22, 2005:

7:44 PM Changeset in webkit [8665] by rjw
  • 9 edits in trunk

WebCore:

Fixed <rdar://problem/3937203> when a div adds a scrollbar (overflow:auto) we do not get regions

Just set dashboard dirty bit when overflow scrolling changes.

Don't do comparison of regions in before scroll regions are
added, instead do it in WebKit after automatic scroll regions
are added.

Reviewed by Maciej.

  • khtml/css/cssparser.cpp: (CSSParser::parseDashboardRegions): Cleaned up comments
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement): Cleaned up comments
  • khtml/khtmlview.cpp: (KHTMLView::updateDashboardRegions):
  • khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):
  • kwq/WebDashboardRegion.m: (-[WebDashboardRegion isEqual:]):

Webkit:

Fixed <rdar://problem/3937203> when a div adds a scrollbar (overflow:auto) we do not get regions

Compare regions after automatice scroll regions have been
added.

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): (-[WebBridge _compareDashboardRegions:]): (-[WebBridge dashboardRegionsChanged:]):
7:34 PM Changeset in webkit [8664] by rjw
  • 3 edits in trunk/WebKit

Fixed <rdar://problem/4012463> Dashboard widgets don't work with authenticating proxies

Added new SPI for dashboard that just calls default delegate
behavior.

Reviewed by Maciej.

  • WebView.subproj/WebView.m: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
  • WebView.subproj/WebViewPrivate.h:
6:34 PM Changeset in webkit [8663] by cblu
  • 11 edits
    4 adds in trunk

WebCore:

Fixed: <rdar://problem/3976872> Pasted plain text doesn't get the proper style if pasted into newlines

Reviewed by mjs.

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): don't clear the typing style when matching style (khtml::ReplaceSelectionCommand::completeHTMLReplacement): apply the typing style when matching style
  • khtml/editing/jsediting.cpp:
  • khtml/khtml_part.cpp: (KHTMLPart::pasteAndMatchStyle): new
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::issuePasteAndMatchStyleCommand): new
  • kwq/WebCoreBridge.h:
  • layout-tests/editing/editing.js:

WebKit:

Reviewed by mjs.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge issuePasteAndMatchStyleCommand]): support for new "PasteAndMatchStyle" exec command
5:27 PM Changeset in webkit [8662] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • fixed <rdar://problem/4006596> REGRESSION (183-184): crash in DOM::DocumentImpl::setFocusNode(DOM::NodeImpl*)
  • khtml/xml/dom_docimpl.cpp: (widgetForNode): Added helper. (DocumentImpl::setFocusNode): Re-get the widget for the node after calling updateLayout. The updateLayout can destroy the old widget, so we can't keep a stale widget pointer around.
4:10 PM Changeset in webkit [8661] by kocienda
  • 10 edits in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4003463> Mail.app HTML uses inline styling markup not understood by Entourage and Eudora

  • khtml/editing/htmlediting.cpp: (khtml::isEmptyFontTag): Helper for removing <font> tags. (khtml::StyleChange::styleModeForParseMode): Helper to map a document parse mode to a use/don't use legacy-html-styles value. (khtml::StyleChange::checkForLegacyHTMLStyleChange): Add support for colors, font faces, and font sizes. (khtml::ApplyStyleCommand::isHTMLStyleNode): (khtml::ApplyStyleCommand::removeHTMLFontStyle): (khtml::ApplyStyleCommand::applyTextDecorationStyle): Now call styleModeForParseMode to determine whether to use legacy html styles or not. (khtml::ApplyStyleCommand::removeInlineStyle): Now properly removes <font> styles. (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Ditto. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto. (khtml::createFontElement): Helper for applying <font> elements.
  • khtml/editing/htmlediting.h: All the following support the new bits of data we need to store. (khtml::StyleChange::applyFontColor) (khtml::StyleChange::applyFontFace) (khtml::StyleChange::applyFontSize) (khtml::StyleChange::fontColor) (khtml::StyleChange::fontFace) (khtml::StyleChange::fontSize)

Test results updated now that we will write out <font> tags for quirks mode documents.

  • layout-tests/editing/execCommand/modifyForeColorByCharacter-expected.txt
  • layout-tests/editing/style/block-style-004-expected.txt
  • layout-tests/editing/editing/pasteboard/paste-text-011-expected.txt
  • layout-tests/editing/style/block-style-005-expected.txt
  • layout-tests/editing/style/block-style-006-expected.txt
  • layout-tests/editing/style/smoosh-styles-001-expected.txt
  • layout-tests/editing/style/smoosh-styles-002-expected.txt
4:00 PM Changeset in webkit [8660] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/4017066> crash in KJS::ValueImp::dispatchType() every time I load www.nytimes.com/pages/automobiles

When creating option elements, use lowercase "option" instead of
uppercase "OPTION" to create option elements, because only
lowercase works for XHTML.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLSelectCollection::tryPut): (OptionConstructorImp::construct):
3:22 PM Changeset in webkit [8659] by cblu
  • 2 edits
    2 adds in trunk

WebCore fix for: <rdar://problem/3918056> Mail not line breaking my <pre> formatted emails on replies

Mail must 4018993 to fully address the problem.

Reviewed by kocienda.

  • khtml/editing/markup.cpp: (khtml::startMarkup): don't compute style for text in PRE tags (khtml::createMarkup): include PRE if it is an ancestor of the nodes in the range

Feb 21, 2005:

5:32 PM Changeset in webkit [8658] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/4008338> REGRESSION (125-178): opacity style not working, breaks fading images on okcupid.com

There was a long standing bug in cssText(). Double value were always cast int! So,
opacity values values were incorrectly converted to text, i.e. 0.75 became 0.

The problem was newly triggered because we parse the css for opacity *TWICE*. This is a result of
incorrectly "invalidating" the style attribute (from fix for 3790449). The second parse was from
the cssText() of the style.

Reviewed by Hyatt.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::cssText):
4:19 PM Changeset in webkit [8657] by hyatt
  • 2 edits in trunk/WebCore

Fix for 4017204, apply the same fix to the base class nodeAtPoint that was already applied to RenderBlock.
Skip elements with layers and inline flows. Demoted <form>s can end up causing trouble otherwise.

Reviewed by Richard Williamson

  • khtml/rendering/render_box.cpp: (RenderBox::nodeAtPoint):
3:36 PM Changeset in webkit [8656] by hyatt
  • 9 edits in trunk/WebCore

Fix for 4017033, CSS is being parsed twice. Make sure to always validate the style attribute when it is
initially parsed. Add code to clean up decls when the style attribute is completely removed. Add a new
synchronizing boolean that avoids reparsing the style declaration when the attribute is simply
being synced up to the declaration.

Reviewed by John

  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::setChanged):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::invalidateStyleAttribute): (HTMLElementImpl::updateStyleAttributeIfNeeded): (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::~HTMLElementImpl): (HTMLElementImpl::destroyInlineStyleDecl): (HTMLElementImpl::mapToEntry): (HTMLElementImpl::parseHTMLAttribute):
  • khtml/html/html_elementimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): (ElementImpl::setAttribute):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::updateStyleAttributeIfNeeded):
3:24 PM Changeset in webkit [8655] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (188+)

3:17 PM Changeset in webkit [8654]
  • 1 copy in tags/Safari-188

This commit was manufactured by cvs2svn to create tag 'Safari-188'.

3:17 PM Changeset in webkit [8653] by vicki
  • 6 edits in trunk

Safari-188 stamp

2:02 PM Changeset in webkit [8652] by kocienda
  • 9 edits in trunk

Tree was closed. Rolling out.

2:01 PM Changeset in webkit [8651] by kocienda
  • 9 edits in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4003463> Mail.app HTML uses inline styling markup not understood by Entourage and Eudora

  • khtml/editing/htmlediting.cpp: (khtml::isEmptyFontTag): Helper for removing <font> tags. (khtml::StyleChange::styleModeForParseMode): Helper to map a document parse mode to a use/don't use legacy-html-styles value. (khtml::StyleChange::checkForLegacyHTMLStyleChange): Add support for colors, font faces, and font sizes. (khtml::ApplyStyleCommand::isHTMLStyleNode): (khtml::ApplyStyleCommand::removeHTMLFontStyle): (khtml::ApplyStyleCommand::applyTextDecorationStyle): Now call styleModeForParseMode to determine whether to use legacy html styles or not. (khtml::ApplyStyleCommand::removeInlineStyle): Now properly removes <font> styles. (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Ditto. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto. (khtml::createFontElement): Helper for applying <font> elements.
  • khtml/editing/htmlediting.h: All the following support the new bits of data we need to store. (khtml::StyleChange::applyFontColor) (khtml::StyleChange::applyFontFace) (khtml::StyleChange::applyFontSize) (khtml::StyleChange::fontColor) (khtml::StyleChange::fontFace) (khtml::StyleChange::fontSize)

Test results updated now that we will write out <font> tags for quirks mode documents.

  • layout-tests/editing/execCommand/modifyForeColorByCharacter-expected.txt
  • layout-tests/editing/style/block-style-004-expected.txt
  • layout-tests/editing/style/block-style-005-expected.txt
  • layout-tests/editing/style/block-style-006-expected.txt
  • layout-tests/editing/style/smoosh-styles-001-expected.txt
  • layout-tests/editing/style/smoosh-styles-002-expected.txt
1:55 PM Changeset in webkit [8650] by darin
  • 2 edits in trunk/WebCore
  • fixed Panther deployment build
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Put more stuff inside #if.
11:56 AM Changeset in webkit [8649] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3943090> REGRESSION (Mail): Spelling underline incompletely erased following certain steps

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer misspellingLineThickness]): (-[WebTextRenderer misspellingLinePatternWidth]): Replaced #defines with these methods, so others can get the same info.

(-[WebTextRenderer drawLineForMisspelling:withWidth:]):
Keep underline within originally specified bounds.

11:56 AM Changeset in webkit [8648] by harrison
  • 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3943090> REGRESSION (Mail): Spelling underline incompletely erased following certain steps

  • khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): Make sure underline is placed within the text bounds.
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::misspellingLineThickness):
  • kwq/WebCoreTextRenderer.h: Add misspellingLineThickness for use by InlineTextBox::paintMarker.
11:50 AM Changeset in webkit [8647] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4012978> -[DOMRange markupString] crashes when range contains only a text node with a single space
  • khtml/editing/markup.cpp: (khtml::createMarkup): Added updateLayout calls, and added a missing nil check.
9:50 AM Changeset in webkit [8646] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4005435> Safari hung while pasting text into a <textarea> (Panther-only)
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Don't setAutohidesScrollers:YES on Panther.
9:45 AM Changeset in webkit [8645] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/4016358> don't ever display IDN URLs with characters from "possible Latin look-alike" scripts
  • Misc.subproj/WebNSURLExtras.m: (containsPossibleLatinLookalikes): Added. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call containsPossibleLatinLookalikes, and if true, don't decode the host name.
9:33 AM Changeset in webkit [8644] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/4015499> REGRESSION (186-187): pasted quoted text starting with a blank line increases quote level of pasted text when pasted

  • khtml/editing/markup.cpp: (khtml::markup): Changed over to ASSERT instead of assert. (khtml::createMarkup): The issue was that the code to add parents all the way back to the common ancestor block did not check for blocks whose markup had already been added, and could result in adding markup for nodes twice (hence the additional and erroneous quote level). Now there is a new check that will only add markup for those nodes before the start of the selection range. This fixes the bug. (khtml::createFragmentFromMarkup): Changed over to ASSERT instead of assert. (khtml::createFragmentFromText): Ditto.
9:32 AM Changeset in webkit [8643] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/date_object.cpp: (timetUsingCF): Fixed indenting.
Note: See TracTimeline for information about the timeline view.