Timeline

Feb 28, 2005:

5:58 PM Changeset in webkit [8724] by mjs

• 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4002864> REGRESSION(125-146) getElementById in onload fails in a test case involving external resources

Moved management of elementById hashtable from attach/detach to
insertedIntoDocument/removedFromDocument, to avoid being thrown
off by temporary detaches due to style recalcs.

• khtml/xml/dom_elementimpl.cpp: (ElementImpl::insertedIntoDocument): (ElementImpl::removedFromDocument): (ElementImpl::attach): (ElementImpl::updateId):
• khtml/xml/dom_elementimpl.h:

Make sure that insertedIntoDocument is called before firing any
DOM events.

• khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::dispatchChildInsertedEvents):

5:45 PM Changeset in webkit [8723] by hyatt

• 3 edits in trunk/WebCore

Fix for 4028999, safari crashes when resetting if mallocsribble is on. Clip rects were being cleared using dead
render objects. Change the ordering.

Reviewed by rjw

• khtml/rendering/render_box.cpp: (RenderBox::detach):
• khtml/rendering/render_layer.cpp: (RenderLayer::~RenderLayer):

4:49 PM Changeset in webkit [8722] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/4024786> REGRESSION (Mail): "Smart paste" plain-text word into Blot leaves insertion point misplaced

Reviewed by kocienda.

• khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Call updateLayout so caretMinOffset and caretMaxOffset return correct values.

4:07 PM Changeset in webkit [8721] by sullivan

• 5 edits in trunk

WebCore:

Reviewed by Ken.

• WebCore part of fix for <rdar://problem/4023490> REGRESSION (125-185): Tabbing through links on frameset page gets stuck at end (tivofaq.com)

• kwq/WebCoreBridge.h: add nextValidKeyViewOutsideWebFrameViews (code is in WebKit)

WebKit:

Reviewed by Ken.

• WebKit part of fix for <rdar://problem/4023490> REGRESSION (125-185): Tabbing through links on frameset page gets stuck at end (tivofaq.com)

This tab-to-links stuff has been in shaky condition ever since AppKit futzed with
tabbing behavior in Tiger to add support for including the toolbar in the key loop.
I made some changes months ago to compensate for that, but some cases, such as this
one, still weren't fixed.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): new bottleneck method, extracted from nextKeyViewOutsideWebFrameViews; handles nextKeyView or nextValidKeyView depending on parameter. (-[WebBridge nextKeyViewOutsideWebFrameViews]): now calls extracted method (-[WebBridge nextValidKeyViewOutsideWebFrameViews]): new method, calls new bottleneck method

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView nextValidKeyView]): when we're stuck at the end of a nextKeyView chain inside a nexted frame, use nextValidKeyViewOutsideWebFrameViews. Make sure we don't end up looking inside the web frame views while doing this.

3:43 PM Changeset in webkit [8720] by kocienda

• 6 edits
  2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3972665> 8A360: HTML message partially truncated on left hand side, text-indent from Script Editor

• khtml/css/css_computedstyle.cpp: inheritableProperties array now defined in css_valueimpl.cpp.
• khtml/css/css_valueimpl.cpp: Define inheritableProperties array here. (DOM::CSSMutableStyleDeclarationImpl::copyBlockProperties): Use new name for blockProperties, and use the new constant for the number of items in the array. (DOM::CSSMutableStyleDeclarationImpl::removeBlockProperties): Ditto. (DOM::CSSMutableStyleDeclarationImpl::removeInheritableProperties): New function.
• khtml/css/css_valueimpl.h: Declare inheritableProperties array and numInheritableProperties extern so they can be defined in css_valueimpl.cpp and used in css_computedstyle.cpp.
• khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::removeStyleNodes): This code was misguided, and removed too much style from HTML elements. Now, it removes from HTML elements only the styles that we replace later with a call to applyStyle(). Also, add ID_B to list of inline "style" nodes we are willing to remove. Leaving it off was an oversight.

• layout-tests/editing/pasteboard/paste-text-011-expected.txt: ID_B fix made this result change, without any visible change in the test.

New test:

• layout-tests/editing/style/smoosh-styles-003.html
• layout-tests/editing/style/smoosh-styles-003-expected.txt

3:10 PM Changeset in webkit [8719] by rjw

• 2 edits in trunk/WebCore

Fixed <rdar://problem/4026985> CrashTracer: ...14 crashes at com.apple.WebCore: -[KWQPageState invalidate] + 32

Added more nil checking and ASSERTS.
Without a reproducible case this is hard to definitively resolve.

Reviewed by John Sullivan.

• kwq/KWQPageState.mm: (-[KWQPageState invalidate]):

2:51 PM Changeset in webkit [8718] by rjw

• 2 edits in trunk/WebCore

Fixed <rdar://problem/4027702> 3.5% performance regression btwn Safari-188 and Safari-400

I inadvertently checked in some debugging code that disabled
style sharing. Backed out that change.

• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement):

1:16 PM Changeset in webkit [8717] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/4026639> www.bmw.ca configurator does not work with Safari

Reviewed by john.

• khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::tryGet): when frameset.<name of frame child> is called, return the window object of the frame child

9:51 AM Changeset in webkit [8716] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/4026906> Paste of HTML table content can break table structure

• khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::pruneEmptyNodes): Call new isProbablyTableStructureNode() function to prevent removal of empty table structure nodes. (khtml::ReplacementFragment::removeUnrenderedNodesUsingTestRendering): Ditto. (khtml::isProbablyTableStructureNode): New helper function.
• khtml/editing/htmlediting.h: Declare new helper.

9:11 AM Changeset in webkit [8715] by cblu

• 3 edits in trunk/WebCore

Fixed: <rdar://problem/4023566> Stickies: Crash in ReplacementFragment::insertFragmentForTestRendering on paste

Reviewed by kocienda.

• khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): ref and deref the element while it is "floating" (khtml::ReplacementFragment::insertFragmentForTestRendering): ditto (khtml::floatRefdElement): new, keeps an element alive while its ref count is 0 (khtml::createDefaultParagraphElement): removed commented out code (khtml::createBlockPlaceholderElement): ref the element and return it as "floating" (khtml::createFontElement): ditto (khtml::createStyleSpanElement): ditto
• khtml/editing/htmlediting.h:

Feb 27, 2005:

8:21 PM Changeset in webkit [8714] by mjs

• 2 edits in trunk/WebCore

Reviewed by Vicki.

<rdar://problem/3993557> REGRESSION (125-180-ish): getElementsByTagName no longer works with namespace designations

• khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::getElementsByTagNameNS): When no namespace is specified, find elements of the specified name in any namespace to match Mozilla and earlier Safari behavior.