Timeline

Mar 4, 2005:

7:15 PM Changeset in webkit [8791] by kali

• 1 edit in trunk/WebCore/khtml/rendering/render_text.cpp

• forgot to check this in for the previous fix

5:50 PM Changeset in webkit [8790] by sullivan

• 3 edits in trunk/WebCore

Reviewed by Kevin.

• fixed <rdar://problem/4033705> REGRESSION (Mail): Copy/Paste from Excel crashes Mail in KWQKHTMLPart::fontForSelection(bool*) const + 232

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection): Check for nil startNode, not just nil renderer.

5:33 PM Changeset in webkit [8789] by rjw

• 2 edits in trunk/WebKit

Fixed <rdar://problem/3968753> REGRESSION: Poor performance with differing multiple animated GIFs (was fast in Panther)

Disable coalesced updates (in CG). This restores the
panther behavior.

Reviewed by David Harrison.

• WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):

5:28 PM Changeset in webkit [8788] by adele

• 2 edits in trunk/WebKit

Reviewed by Darin.

• English.lproj/StringsNotToBeLocalized.txt: added new strings "text/x-vcf" and "text/x-csv" to the list

5:17 PM Changeset in webkit [8787] by harrison

• 3 edits in trunk/WebCore

Reviewed by Ken, Richard.

<rdar://problem/3996383> REGRESSION (Mail): Deleting all of first line also deletes line ending

Problem was the placeholder check was based on 0 height block, but the block in this
case is the BODY, which has other content even though the paragraph is gone.

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::insertBlockPlaceholder): Now does insert instead of append!

(khtml::CompositeEditCommand::appendBlockPlaceholder):
New. Actually does append.

(khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded):
Renamed from insertBlockPlaceholderIfNeeded because it can insert or append. Also accepts "force insert" flag.

(khtml::CompositeEditCommand::removeBlockPlaceholder):
Renamed for succinctness from removeBlockPlaceholderIfNeeded.

(khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent):
(khtml::DeleteSelectionCommand::moveNodesAfterNode):
Use renamed methods.

(khtml::DeleteSelectionCommand::doApply):
Use addBlockPlaceholderIfNeeded "force insert" flag if deleting whole paragraphs did not leave an empty one.

(khtml::InsertParagraphSeparatorCommand::doApply):
(khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply):
(khtml::InsertTextCommand::input):
Use renamed methods.

• khtml/editing/htmlediting.h: Renamed and new methods per above.

5:02 PM Changeset in webkit [8786] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/4032840> REGRESSION (Mail): crash in RemoveNodeCommand after pasting attachment at end of message

Reviewed by darin.

• khtml/editing/visible_units.cpp: (khtml::endOfParagraph): don't consider text nodes that have no rendered characters

4:02 PM Changeset in webkit [8785] by adele

• 2 edits in trunk/WebKit

Reviewed by Chris.

Fix for <rdar://problem/4032982> Sun iPlanet app: not able to import AddressBook CSV format addresses properly
Fix for <rdar://problem/4032985> Sun iPlanet app: not able to import vCard format addresses properly

• WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/x-csv" and "text/x-vcf" to the list of MIME types that our text view doesn't handle

3:59 PM Changeset in webkit [8784] by rjw

• 4 edits in trunk/WebCore

Fixed <rdar://problem/4034764> REGRESSION(125-188)Viewing text/plain page and going back/forward corrupts HTML pages (google.com)

The parse mode wasn't be restored to the document when going
back.

Reviewed by Hyatt.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):
• kwq/KWQPageState.h:
• kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]):

2:47 PM Changeset in webkit [8783] by darin

• 3 edits in branches/Safari-1-2-branch/WebKit

Rolled in changes from Tiger for IDN spoofing.

2005-03-04 Darin Adler <Darin Adler>

Reviewed by John.

• fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters

• Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Added. Reads file and parses script names. (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession. (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense. Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of containsPossibleLatinLookalikes.
• Resources/IDNScriptWhiteList.txt: Added.
• WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.

• Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

2005-02-21 Darin Adler <Darin Adler>

Reviewed by John.

• fixed <rdar://problem/4016358> don't ever display IDN URLs with characters from "possible Latin look-alike" scripts

• Misc.subproj/WebNSURLExtras.m: (containsPossibleLatinLookalikes): Added. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call containsPossibleLatinLookalikes, and if true, don't decode the host name.

2:47 PM Changeset in webkit [8782] by kocienda

• 2 edits in trunk

Reviewed by me

• layout-tests/editing/style/create-block-for-style-012-expected.txt: Shame on me! I landed my last fix without running layout tests. This one changes in a subtle, but acceptable way.

2:32 PM Changeset in webkit [8781] by kocienda

• 6 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/4032543> REGRESSION (Mail): Mail hangs when quoted text is pasted twice

This code change fixes the bug in a non-obvious way. The root cause of the problem was
that a VisiblePosition created using an affinity originating in Mail code caused
two VisiblePosition objects that should have been equal to differ only in their
affinities, which in turn caused us to run a code path that should not have run.

• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): Added copy constructor. (khtml::VisiblePosition::next): Factored out inline code that used to be here into new setAffinityUsingLinePosition() function. (khtml::isEqualIgnoringAffinity): New helper to handle cases when affinity in equality check does not matter. However, we want to know about such cases where a VisiblePosition differs only by affinity, and the code will assert in development when this happens. (khtml::isNotEqualIgnoringAffinity): Ditto, but not. :) (khtml::setAffinityUsingLinePosition): New helper function mentioned above. This will "correct" upstream affinity to downstream if the affinity does not make a difference for the position.
• khtml/editing/visible_position.h:
• khtml/editing/visible_range.h: Wacky bug. The operator== for this class took VisiblePosition classes!
• khtml/editing/visible_units.cpp: (khtml::isStartOfParagraph): Now performs equality check without regard to affinity. (khtml::isEndOfParagraph): Ditto. (khtml::isStartOfBlock): Ditto. (khtml::isEndOfBlock): Ditto.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): Adjusts the affinity using setAffinityUsingLinePosition() if necessary.

2:24 PM Changeset in webkit [8780] by darin

• 7 edits in trunk

WebCore:

Reviewed by John.

• fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut

• khtml/editing/htmlediting.h: Added insertTextRunWithoutNewlines.
• khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::input): Added assertion to make sure strings with newlines don't get down to this level. (khtml::TypingCommand::insertText): Added. Takes the name of the old function, but is a new level that breaks runs into lines and inserts each one separately. (khtml::TypingCommand::insertTextRunWithoutNewlines): Renamed old insertText to this.

• khtml/dom/dom_string.h: Made substring be a const member function.
• khtml/dom/dom_string.cpp: (DOM::DOMString::substring): Made this const.

WebKit:

Reviewed by John.

• fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): Merged _handleKillRing behavior into this function, since there's now a more-complicated way the startNewKillRingSequence boolean needs to be handled. Set the startNewKillRingSequence boolean after the entire process so changing the selection before and during the editing dosn't clear it. Also change "isTypingAction" parameter to "deletionAction" so we can handle forward delete with this method. (-[WebHTMLView _deleteSelection]): Pass deleteSelectionAction for action rather than NO for isTypingAction, which is the way to say the same thing using the new parameter. (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Refactor to use the _deleteRange method above. Also calls _shouldDeleteRange: for the pre-existing selection case; not doing that before was a bug. (-[WebHTMLView deleteToMark:]): Pass deleteSelectionAction for action rather than NO for isTypingAction, which is the way to say the same thing using the new parameter.

11:37 AM Changeset in webkit [8779] by darin

• 5 edits in trunk

WebCore:

Reviewed by John.

• fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)

• khtml/css/css_valueimpl.cpp: (DOM::isLegalIdentifier): Added. Commented out and not used. (DOM::quoteStringIfNeeded): Quotes the string if needed. For now only if it starts with "#". (DOM::CSSPrimitiveValueImpl::cssText): Call quoteStringIfNeeded when asked for cssText for an arbitrary string, since we need text you can re-parse. (DOM::FontFamilyValueImpl::cssText): Ditto.

• khtml/editing/markup.cpp: (khtml::startMarkup): Added comments about lack of quoting for attributes. (khtml::createMarkup): Ditto.

WebKit:

Reviewed by John.

• fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): Quote font name when calling setFontFamily. (-[WebHTMLView _addToStyle:fontA:fontB:]): Ditto.

11:16 AM Changeset in webkit [8778] by adele

• 2 edits in trunk/WebCore

Reviewed by Maciej

Fix for <rdar://problem/4021711> REGRESSION(125-188) blank pages when browsing forum at cooperativeresearch.org - cached external script problem

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): set flag needToRefCachedScript so we can make sure notifyFinished is called after pendingSrc is set up with the right data from the cached script

9:54 AM Changeset in webkit [8777]

• 1 copy in branches/Safari-1-2-branch/WebKit/Resources/IDNScriptWhiteList.txt

This commit was manufactured by cvs2svn to create branch
'Safari-1-2-branch'.

9:54 AM Changeset in webkit [8776] by darin

• 4 edits
  1 add
  1 delete in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters

• Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Added. Reads file and parses script names. (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession. (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense. Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of containsPossibleLatinLookalikes.
• Resources/IDNScriptWhiteList.txt: Added.
• WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.

• Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

9:37 AM Changeset in webkit [8775] by darin

• 2 edits in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/3937667> REGRESSION (Mail): Zooming a window from titlebar button doesn't paint newly-exposed portions of window

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Re-set-up the visRect if the bounds changes due to layout.

9:18 AM Changeset in webkit [8774] by kocienda

• 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/4029632> Tiger 8A398:- Mail crashes in DOM::NodeImpl::isBlockFlow() after pasting text with alignment style and BR element from Safari

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): VisiblePosition constructor was failing to yield a position for a node just pasted into the document since a layout was needed for the calculation to come out right. Layout added. Crash gone.

12:58 AM Changeset in webkit [8773] by kali

• 1 edit in trunk/WebCore/khtml/rendering/render_text.cpp

• made RenderText::caretRect handle BIDI text correctly in its calculations (3587614)

Mar 3, 2005:

11:45 PM Changeset in webkit [8772] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (v402+). The tree is open.

11:38 PM Changeset in webkit [8771]

• 1 copy in tags/Safari-302

This commit was manufactured by cvs2svn to create tag 'Safari-302'.

11:38 PM Changeset in webkit [8770] by vicki

• 3 edits in trunk

versioning for SUPanWheat, Safari 1.3 (v302)

11:29 PM Changeset in webkit [8769]

• 1 copy in tags/Safari-402

This commit was manufactured by cvs2svn to create tag 'Safari-402'.

11:29 PM Changeset in webkit [8768] by vicki

• 6 edits in trunk

Safari-402 stamp

5:22 PM Changeset in webkit [8767] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3992803> Cannot navigate through list items with the keyboard, you're stuck in the same <li> block unless you click out

Reviewed by harrison.

• khtml/rendering/render_line.cpp: (khtml::RootInlineBox::closestLeafChildForXPos): avoid returning list markers when possible. Also improved heuristic for returning the best InlineBox given the passed X position.

4:05 PM Changeset in webkit [8766] by jens

• 2 edits in trunk/WebKit

<rdar://problem/3991818> REGRESSION: Images scale while loading

3:54 PM Changeset in webkit [8765] by hyatt

• 2 edits in trunk/WebKit

Fix for 3841186, scrollbar shows up disabled when it should not appear at all. Make sure updateScrollers
is never allowed to be re-entrant from any call point by moving the guard inside the function itself.

Reviewed by John Sullivan

• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

3:08 PM Changeset in webkit [8764] by kocienda

• 4 edits in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/4035198> Pasting text with different styles does not get reproducible results

I had a good idea yesterday to improve the way we "fixup" styles after
pasting, but i chose a poor data structure to do it, a map of
nodes-to-styles. In the fixup step, I iterated over the map elements and
did the fixup. However, since the order in which the items would come
out of the map is indeterminate, we got unpredictable results.

So, the concept was good, but the implementation was flawed. I have
fixed this mapping to be a list instead, so the order that nodes are
evaluated in the fixup step is document order. This works nicely.

• khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::~ReplacementFragment): No longer need to explicity deref nodes and styles saved away for later fixup. This is now handled by the new NodeDesiredStyle class. (khtml::ReplacementFragment::computeStylesUsingTestRendering): Now calls computeAndStoreNodeDesiredStyle, function renamed from mapDesiredStyleForNode. Now accepts a QValueList<NodeDesiredStyle> in place of the old map. (khtml::NodeDesiredStyle::NodeDesiredStyle): New class that represents a node-to-style mapping. (khtml::NodeDesiredStyle::~NodeDesiredStyle): Ditto. (khtml::NodeDesiredStyle::operator=): Ditto. (khtml::ReplaceSelectionCommand::doApply): Now calls computeAndStoreNodeDesiredStyle, function renamed from mapDesiredStyleForNode. (khtml::ReplaceSelectionCommand::fixupNodeStyles): Now operates on a QValueList<NodeDesiredStyle> in place of the old map. (khtml::computeAndStoreNodeDesiredStyle): Renamed from mapDesiredStyleForNode. Now operates on a QValueList<NodeDesiredStyle> in place of the old map.
• khtml/editing/htmlediting.h: (khtml::NodeDesiredStyle): New class that represents a node-to-style mapping. (khtml::ReplacementFragment::desiredStyles): Now returns a QValueList<NodeDesiredStyle> in place of the old map.

• layout-tests/editing/style/typing-style-003-expected.txt: Results changed in an acceptable way.