Timeline

Mar 6, 2005:

7:48 PM Changeset in webkit [8804] by darin

• 2 edits in branches/Safari-1-2-branch/WebKit

Rolled in fix from Tiger for IDN spoofing.

2005-03-06 Darin Adler <Darin Adler>

• fixed obvious mistake in IDN script code (luckily it hasn't been in a submission yet!)

• Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Use "index" to index into the array, not "script", which is the script number, not the 32-bit-word index.

7:46 PM Changeset in webkit [8803] by darin

• 2 edits in trunk/WebKit

• fixed obvious mistake in IDN script code (luckily it hasn't been in a submission yet!)

• Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Use "index" to index into the array, not "script", which is the script number, not the 32-bit-word index.

2:33 PM Changeset in webkit [8802] by kali

• 2 edits in trunk/WebCore

• fixed text box search code for caret rect to properly account for BIDI text (4038674)

12:03 AM Changeset in webkit [8801] by kali

• 3 edits in trunk/WebCore

• fixed problem with searching for BIDI text boxes (3587609)
• fixed missing initalizer of RTL flag in WebCoreStyle

Mar 5, 2005:

7:36 PM Changeset in webkit [8800] by kdecker

• 5 edits in trunk/WebKit

Reviewed by Darin.

Fixed: <rdar://problem/4038529> Infinite progress bar loading webcams and other sites that use multipart/x-mixed-replace

The previous patch I landed prevented us from loading multipart/x-mixed-replace but did not always update the progress bar accordingly.
This stops websites from having seemingly infinite progress in the browser UI.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didReceiveResponse:]): If this is "multipart/x-mixed-replace", remove the WebBaseResourceHandleDelegate client from the datasource's subresource array, otherwise -[WebDataSource isLoading] incorrectly returns YES. Also it's possible at this point in time we're done loading now (loaded everything else except for the multipart/x-mixed-replace content) so go ahead and check to see if in fact we're complete.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): ditto

5:37 PM Changeset in webkit [8799] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fixed <rdar://problem/4038417> Mail crashed in StyleChange::checkForLegacyHTMLStyleChange when composing a reply

• khtml/editing/htmlediting.cpp: (khtml::StyleChange::checkForLegacyHTMLStyleChange): Added missing nil check.

3:35 PM Changeset in webkit [8798] by rjw

• 2 edits in trunk/WebKit

Fixed panther build problem. Shouldn't include
changes for 3968753 on panther.

Reviewed by John.

• WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):

3:20 PM Changeset in webkit [8797] by darin

• 2 edits in trunk/WebCore

Reviewed by Don.

• fixed <rdar://problem/4038478> Crash in renderer viewing RSS feed at feed://wvs.topleftpixel.com/index.rdf

• khtml/xml/dom_docimpl.cpp: (widgetForNode): Check for nil before going from node to renderer.

3:08 PM Changeset in webkit [8796] by darin

• 2 edits in trunk/WebCore

Reviewed by Richard.

• fixed <rdar://problem/4037700> Every character typed causes stat call for /usr/share/icu/icudt32b_char.brk

• khtml/rendering/render_text.cpp: (getCharacterBreakIterator): Added. Helper that sets up an iterator for the passed-in text. Shares a single global iterator (fast, albeit not thread-safe). (RenderText::previousOffset): Changed to call getCharacterBreakIterator. (RenderText::nextOffset): Ditto.

2:40 PM Changeset in webkit [8795] by kocienda

• 2 edits
  2 adds in trunk

Reviewed by Darin

Fix for this bug:

<rdar://problem/4038267> REGRESSION (Mail): Crash copying and pasting end of paragraph

Code to handle content that has a "logical" newline at the end of the pasted content, and the code
to adjust the selection at the end of the paste operation made an assumption that at least one
node had been inserted by the paste command. This is not necessarily true in the case where the sole content
in the pasted content is one of these "logical" newlines. Adjust some code around so that we don't deref
null, but still adjust the selection correctly for this case. In each of the two functions below, some
null checks have been added, and some code has been rearranged a little bit to continue on through
the end of completeHTMLReplacement, even if no nodes have been inserted. The patch looks bigger and more
complicated than the conceptual change.

• khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply) (khtml::ReplaceSelectionCommand::completeHTMLReplacement)

• layout-tests/editing/pasteboard/paste-4038267-fix-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-4038267-fix.html: Added.

11:20 AM Changeset in webkit [8794] by darin

• 2 edits in trunk/WebCore

Reviewed by John.

• fixed <rdar://problem/4025918> images copied from Safari with relative src URLs aren't pasted into Mail messages (KURL resolves base URLs incorrectly)

• kwq/KWQKURL.mm: (KURL::KURL): Add a slash at the start of the path if a relative part is adding a path onto a URL that has "pre-path" bits like host name, but no path yet. This doesn't come up for http because in that case we add a trailing "/" as part of canonicalization.

11:17 AM Changeset in webkit [8793] by darin

• 3 edits in trunk/WebKit

Reviewed by John.

• fixed <rdar://problem/4034603> REGRESSION (185-188): RadarWeb can't send enclosures anymore

• WebView.subproj/WebFormDataStream.m: (closeCurrentStream): Release currentData when closing the stream. (advanceCurrentStream): Set up and retain currentData when the current stream is reading that data, so the data won't be released while in use. (formCreate): Initialize currentData to NULL.

• fixed <rdar://problem/4037562> Tiger8A402: Help Viewer crashed when viewing help for iChat (infinite recursion in WebView)

• WebView.subproj/WebView.m: (-[WebView _responderValidateUserInterfaceItem:]): Check for the case where we ourselves are the responder. This avoids an infinite loop. The actual code to perform operations avoids this with a global variable, but this lighter weight solution is sufficient here because validate operations don't call through to the next responder.

7:39 AM Changeset in webkit [8792] by sullivan

• 1 edit in trunk/WebCore/khtml/editing/htmlediting.cpp

Rolled out a couple of assertion-related changes I accidentally checked in.