Timeline

Mar 10, 2005:

5:43 PM Changeset in webkit [8858] by rjw

• 5 edits in trunk/WebKit

Fixed <rdar://problem/4040321> Exception: Someone's trying to encode a WebDataRequestParameters instance

Reviewed by Darin.

If a delegate returns a mutated applewebdata: request in it's willSendRequest:
method, we don't load using the WebDataRequest. Instead we do a normal load.
Unfortunately, if the request they return is mutated *copy* of the applewebdata:
request it will hold the applewebdata: special properties. These properties
will be encoded into the cache. They should not be. So, to fix, we sanitize the
request, by removing the special properties from the request.

Note that we had to dig into the private guts of NSURLRequest because there is
no public mechanism to remove properties from a request, see 4046775.

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]):
• WebView.subproj/WebDataProtocol.h:
• WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestExternalRequest]): (-[NSURLRequest _webDataRequestSanitize]):

5:27 PM Changeset in webkit [8857]

• 3 copies in tags/Safari-405

This commit was manufactured by cvs2svn to create tag 'Safari-405'.

5:27 PM Changeset in webkit [8856]

• 3 copies in tags/Safari-305

This commit was manufactured by cvs2svn to create tag 'Safari-305'.

5:27 PM Changeset in webkit [8855] by mjs

• 2 edits in trunk/WebKit

Reviewed by Vicki.

<rdar://problem/4046510> REGRESSION (TOT): All Flash and Shockwave plugin-based web content missing

• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):

5:18 PM Changeset in webkit [8854] by darin

• 2 edits in trunk/WebCore

Reviewed by Richard.

• fixed <rdar://problem/4037700> Every character typed causes stat call for /usr/share/icu/icudt32b_char.brk

• khtml/rendering/render_text.cpp: (getCharacterBreakIterator): Set boolean "got iterator" to true.

4:49 PM Changeset in webkit [8853] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (v405+). The tree is open!

4:42 PM Changeset in webkit [8852] by vicki

• 3 edits in trunk

versioning for SUPanWheat, Safari 1.3 (v305)

4:37 PM Changeset in webkit [8851] by vicki

• 6 edits in trunk

Safari-405 stamp (skipped 404 since it ends in a "4")

2:05 PM Changeset in webkit [8850] by darin

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/4042867> "Bigger" changes the font size of too much text when the selection is on a style-change boundary

• khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): Advance out of the starting text node if we're at the end of it.

1:59 PM Changeset in webkit [8849] by darin

• 2 edits in trunk/WebCore

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): Fixed assertion for nested calls to write.

1:54 PM Changeset in webkit [8848] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4032346> REGRESSION (Mail): changing 1st line of a URL that wraps to two lines doesn't always update 2nd line

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::matchedEndLine): Look at first clean line in case line wrap implicitly dirtied it.

1:43 PM Changeset in webkit [8847] by mjs

• 2 edits in trunk/WebCore

Reviewed by Vicki.

<rdar://problem/4046018> REGRESSION (TOT): RSS pages don't display anything

• kwq/WebCoreBridge.mm: (-[WebCoreBridge canLoadURL:fromReferrer:hideReferrer:]): Exempt feed: and feeds: pages from the local file security check.

1:40 PM Changeset in webkit [8846] by darin

• 2 edits in trunk/WebCore

Change written by Steve Peters, reviewed by me.

• fixed <rdar://problem/4045924> improve compareBoundaryPoints to make style changes faster

• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::compareBoundaryPoints): Do early outs in a couple of the loops to make things faster.

1:26 PM Changeset in webkit [8845] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Vicki.

• fixed <rdar://problem/4045843> Going back/forward to error page hits assertion in -[WebDataSource(WebPrivate) _setData:]

• WebView.subproj/WebDataSource.m: (-[WebDataSource _setData:]): Removed bogus assertion

1:09 PM Changeset in webkit [8844] by jens

• 5 edits in trunk/WebCore

Fixes <rdar://problem/4040848> "REGR: Sun security-check demo applet does not load". Includes restoring part of the old NodeImpl::closeRenderer mechanism.

11:30 AM Changeset in webkit [8843] by darin

• 1 edit in trunk/WebKit/ChangeLog

Reviewed by Darin.

• fixed <rdar://problem/3997044> default encoding for non-Latin incorrect

• WebKit/WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]): Call CFStringGetUserDefaultEncoding to get region, and TECGetWebTextEncodings to get the first encoding to determine the default encoding.

11:29 AM Changeset in webkit [8842] by darin

• 1 edit in trunk/WebKit/WebView.subproj/WebPreferences.m

Fixed an indenting problem that crept in with the last check-in.

9:24 AM Changeset in webkit [8841] by kocienda

• 6 edits in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/4024929> REGRESSION (Mail): Pasting text with multiple reply levels removes one level instead of all

The code to figure out which node to use to merge into an existing line did not drill into the first inline element
as needed to make the feature work as user expect. Instead, it looked at the first node, and if it was a block, it
skipped that node. This worked for some cases (including the important "paste-as-quotation" case) but obviously
doesn't work for content quoted more than once.

Now, mergeStartNode() will look for the first node in pasted content that is not a block. It will now also look
for nodes specially marked by Mail as a node added to make "Paste As Quotation" work. It won't skip those.

NOTE: This change will break Mail's "Paste As Quotation" feature for TOT WebKit users, but this is only a temporary
problem that will exist until we sync up with Mail's pending change to mark nodes as needed in its pasteAsQuotation:
method.

• khtml/editing/html_interchange.h: Add ApplePasteAsQuotation constant used to check for "marked" blockquotes.
• khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::mergeStartNode): Look for first node that is either not a block or is marked as an ApplePasteAsQuotation node. (khtml::isMailPasteAsQuotationNode): New helper that looks for nodes marked with ApplePasteAsQuotation.
• khtml/editing/htmlediting.h: Updated header for new function.

This test result changed is an acceptable way.

• layout-tests/editing/pasteboard/paste-text-013-expected.txt
• layout-tests/editing/pasteboard/paste-text-013.html

NOTE: This change causes a regression in this layout test:

• layout-tests/editing/pasteboard/paste-text-013.html

This problem will need to be fixed separately, and this bug has been filed to track this problem:
<rdar://problem/4045513> Copying and pasting selection starting at end of paragraph can incorrectly remove line break

Mar 9, 2005:

8:04 PM Changeset in webkit [8840] by mjs

• 9 edits in trunk/WebCore

Reviewed by Richard.

<rdar://problem/4040776> Dashboard (Weather widget) is a memory hog

Change things around so the event listeners for XMLHttpRequest
mark their JS listener objects instead of holding a hard
reference, to avoid an unbreakable reference cycle.

• khtml/ecma/kjs_events.cpp: (JSAbstractEventListener::JSAbstractEventListener): (JSAbstractEventListener::~JSAbstractEventListener): (JSAbstractEventListener::handleEvent): (JSAbstractEventListener::eventListenerType): (JSUnprotectedEventListener::JSUnprotectedEventListener): (JSUnprotectedEventListener::~JSUnprotectedEventListener): (JSUnprotectedEventListener::listenerObj): (JSUnprotectedEventListener::windowObj): (JSUnprotectedEventListener::mark): (JSEventListener::JSEventListener): (JSEventListener::~JSEventListener): (JSEventListener::listenerObj): (JSEventListener::windowObj): (JSLazyEventListener::JSLazyEventListener):
• khtml/ecma/kjs_events.h:
• khtml/ecma/kjs_html.h:
• khtml/ecma/kjs_window.cpp: (Window::getJSEventListener): (Window::getJSUnprotectedEventListener):
• khtml/ecma/kjs_window.h:
• khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::putValue): (KJS::XMLHttpRequest::mark):
• khtml/ecma/xmlhttprequest.h:
• khtml/khtml_part.h:

7:21 PM Changeset in webkit [8839] by goldsmit

• 1 edit in trunk/WebKit/WebView.subproj/WebPreferences.m

3997044 Use TECGetWebTextEncodings for default encoding per user language

5:34 PM Changeset in webkit [8838] by rjw

• 2 edits in trunk/WebKit

Reviewed by Richard.

• fixed <rdar://problem/4034175> REGRESSION (Mail): Can't use any font with style Light/Condensed/Semibold/Extrabold, etc

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): Use a constant instead of hard-coded weight for clarity. (-[WebHTMLView _originalFontA]): Ditto. (-[WebHTMLView _originalFontB]): Ditto. (-[WebHTMLView _addToStyle:fontA:fontB:]): Add code to detect the case where the family name is not good enough to specify the font precisely. In that case, use the Postscript font name instead. Also change variable names so it's easier to understand the method.

5:00 PM Changeset in webkit [8837] by mjs

• 17 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/4005575> Arbitrary file disclosure vulnerability due to ability to load local html from remote content

• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::putValue):
• khtml/ecma/kjs_window.cpp: (Window::put): (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):
• khtml/khtml_part.cpp: (KHTMLPart::begin): (KHTMLPart::scheduleLocationChange): (KHTMLPart::slotRedirect): (KHTMLPart::processObjectRequest):
• khtml/khtml_part.h:
• khtml/khtmlpart_p.h:
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLRequest): (KWQKHTMLPart::urlSelected): (KWQKHTMLPart::createPart):
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (hasCaseInsensitivePrefix): (-[WebCoreBridge didNotOpenURL:pageCache:]): (-[WebCoreBridge canLoadURL:fromReferrer:hideReferrer:]):

WebKit:

Reviewed by Darin.

<rdar://problem/4005575> Arbitrary file disclosure vulnerability due to ability to load local html from remote content

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): (-[WebBridge startLoadingResource:withURL:customHeaders:]): (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
• WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:intoChild:]):
• WebView.subproj/WebFramePrivate.h:

2:30 PM Changeset in webkit [8836] by rjw

• 5 edits in trunk

WebKit:

Fixed <rdar://problem/4032938> Safari: text layout for MS P Gothic font is corrupted

The AppKit and ATS reports that MS P Gothic is fixed pitch. It is
not! This is another case of "fixed pitch" being wrong. I've
coalesced all the special cases into our isFontFixedPitch:, and
used a dictionary to improve speed. No performance regression.

Reviewed by Maciej.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _computeWidthForSpace]):
• WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]): (-[WebTextRendererFactory isFontFixedPitch:]):

WebCore:

Fixed <rdar://problem/4032938> Safari: text layout for MS P Gothic font is corrupted

Remove our hacked special case now we have our own cache of
which fonts are fixed pitch.

Reviewed by Maciej.

• kwq/KWQFont.mm: (QFont::isFixedPitch):

11:49 AM Changeset in webkit [8835] by harrison

• 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4037141> REGRESSION (Mail): Pasting deletes preceding blank lines with certain steps

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): Add check for anonymous text after blocks.

11:00 AM Changeset in webkit [8834] by darin

• 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4040388> REGRESSION (172-173): nonrepro crash in -[NSString(WebNSURLExtras) _web_isUserVisibleURL]

• Misc.subproj/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): Fixed some pointer expressions that didn't include the index in the expression. (readIDNScriptWhiteListFile): Removed NSLog statements in here since we decided they aren't useful and they will write some messages on Tiger.

10:37 AM Changeset in webkit [8833] by darin

• 2 edits in trunk/WebKit

• DOM.subproj/DOMPrivate.h: Checked in file copied from WebCore.

10:21 AM Changeset in webkit [8832] by darin

• 1 edit in trunk/WebKit/ChangeLog

Updated bug number in Richard's change.