Timeline

Mar 12, 2005:

5:58 PM Changeset in webkit [8869] by mjs

• 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4046144> RSS pages leave a hole in local file security policy (need to revert feed: exemption)

• kwq/WebCoreBridge.mm: (-[WebCoreBridge canLoadURL:fromReferrer:hideReferrer:]): Revert emergency workaround for Safari RSS, now that a new Syndication has been submitted.

4:51 PM Changeset in webkit [8868] by mjs

• 13 edits in trunk

Reviewed by Kevin.

<rdar://problem/4026787> text typed after a link (pasted or Mail Link to this Page) is part of the link, underlined and colored blue

The concept of this change is every time you type at the very
start or very end of a link (even if nested in further inner
elements), the typed text goes outside the link instead of inside.

• khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): Check whether we are at the first visible position or last visible position of a special element. For now this only includes HTML A elements that are links (i.e. they have an href). (khtml::isSpecialElement): Helper function that identifies special elements (for now only links). (khtml::isFirstVisiblePositionInSpecialElement): Checks if a given DOM position is equivalent to the first visible position in some containing editable special element. (khtml::positionBeforeNode): Returns the DOM position immediately before a node. (khtml::positionBeforeContainingSpecialElement): Gives a DOM position immediately before the outermost editable containing special element where the passed-in position is equivalent to the first visible position. (khtml::maxRangeOffset): Helper to get the maximum allowed range/position offset for a node, does the right thing based on whether the node would use a character offset or child offset. (khtml::isLastVisiblePositionInSpecialElement): Similar to above, but for end of node instead of start. (khtml::positionAfterNode): Ditto. (khtml::positionAfterContainingSpecialElement): Ditto.

Some layout tests changed - I looked over all the diffs and found
that the only changes were "junk nodes" like empty spans and text
nodes moving from one spot in the tree to another. These changes
are all harmless and do not affect layout or future editing.

• layout-tests/editing/inserting/typing-003-expected.txt:
• layout-tests/editing/style/remove-underline-across-paragraph-expected.txt:
• layout-tests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
• layout-tests/editing/style/remove-underline-after-paragraph-expected.txt:
• layout-tests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
• layout-tests/editing/style/remove-underline-expected.txt:
• layout-tests/editing/style/remove-underline-from-stylesheet-expected.txt:
• layout-tests/editing/style/remove-underline-in-bold-expected.txt:
• layout-tests/editing/style/typing-style-003-expected.txt:
• layout-tests/editing/style/unbold-in-bold-expected.txt:
• layout-tests/editing/style/underline-expected.txt:

Mar 11, 2005:

4:43 PM Changeset in webkit [8867] by adele

• 2 edits in trunk/WebCore

backing out fix for <rdar://problem/4021711> REGRESSION (125-188): blank pages when browsing forum at cooperativeresearch.org - cached external script problem

This caused the following regressions (that we know of):
<rdar://problem/4047445> REGRESSION (Safari-400-403?): Some or all page contents sometimes don't appear (macworld.com)
<rdar://problem/4046153> 8a409: Problem loading Citibank page in Safari 2 (403)
<rdar://problem/4047801> REGRESSION (402-403): .Mac homepage links don't work

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler):

12:54 PM Changeset in webkit [8866] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.

11:08 AM Changeset in webkit [8865] by kocienda

• 1 edit
  1 add in trunk/WebCore

Reviewed by me

• ForwardingHeaders/editing/visible_units.h: Added.

10:43 AM Changeset in webkit [8864] by kocienda

• 2 edits
  6 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/4045521> Hitting return key with full line selected does not add blank line as it should

• khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Removed some "special-case" code from this function that would look for a selection that started and ended in a different block, and would then bail right after the deletion of the selection without inserting a paragraph separator. This was just wrong. So, the code change is removal only. When the general-case code runs instead of the erroneous special-case code, the bug goes away.

New tests:

• layout-tests/editing/inserting/return-key-with-selection-001-expected.txt: Added.
• layout-tests/editing/inserting/return-key-with-selection-001.html: Added.
• layout-tests/editing/inserting/return-key-with-selection-002-expected.txt: Added.
• layout-tests/editing/inserting/return-key-with-selection-002.html: Added.
• layout-tests/editing/inserting/return-key-with-selection-003-expected.txt: Added.
• layout-tests/editing/inserting/return-key-with-selection-003.html: Added.

9:40 AM Changeset in webkit [8863] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4009446> AX: kAXTextMarkerForPositionParameterizedAttribute not working correctly (required for Dictionary pop-up)

• kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]): Comment changes.

(-[KWQAccObject doAXTextMarkerForPosition:]):
Dig into widgets.

(-[KWQAccObject doAXBoundsForTextMarkerRange:]):
Use the selection's document instead of the top document, to accommodate frames, etc.

(-[KWQAccObject accessibilityAttributeValue:forParameter:]):
Fixed parameter processing to look for NSValue instead of AXValue.

9:32 AM Changeset in webkit [8862] by vicki

• 1 edit in trunk/WebKit/ChangeLog

move the Safari-405 release marker, since <rdar://problem/4046510> will be included in 405

9:27 AM Changeset in webkit [8861] by vicki

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

move the Safari-405 release marker, since we're including <rdar://problem/4037700> in Safari-405

8:52 AM Changeset in webkit [8860] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/3972665> 8A360: HTML message partially truncated on left hand side, text-indent from Script Editor

This was fixed, then regressed with Harrison's fix for this bug:

<rdar://problem/3948453> Can't type accented chars as first character in Stickies widget

• khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): My now addresses both problems in a way that they no longer clobber each other.

8:30 AM Changeset in webkit [8859] by kocienda

• 6 edits
  20 adds in trunk

Reviewed by John

Fix for these bugs:

<rdar://problem/4045511> Copying and pasting end-of-paragraph selection puts insertion point in wrong place
<rdar://problem/4045513> Copying and pasting selection starting at end of paragraph can incorrectly remove line break

The copy/paste code before this patch had no notion of a "logical newline" at the start of the selection. We have
had a similar notion for "logical newline" at the end of the selection for quite some time. To fix these bugs, we
need to introduce the same idea for selection starts.

• khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::ReplacementFragment): Process the "logical newline" at start as we write it out in markup. Set the bit we added to this object to signify we have such a newline. (khtml::ReplaceSelectionCommand::doApply): Many, many changes to introduce the new "logical newline" at start concept. I also tried to simply the code that sets the start position for inserting content to be pasted. I also improved a weakness in the smart-paste code. Now, we check before and after the paste for whether we need to add a leading or trailing space. The code previous to this patch only did a "before" check, with the result that we sometimes added a second space. In other words, the code did not realize that DOM changes done by pasting could cause formerly unrendered whitespace to become rendered. Also moved line placeholder clean up code to its own function. (khtml::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): New helper that further refines the notion of when we can remove a line placeholder. The definition is now, "If a line placeholder is at the visible start and visible end of its line, keep it; otherwise remove it".
• khtml/editing/htmlediting.h: Declare new functions. Rework inlines in ReplacementFragment class to account for addition of new "logical newline" at start concept. (khtml::ReplacementFragment::hasInterchangeNewlineAtStart): New accessor. (khtml::ReplacementFragment::hasInterchangeNewlineAtEnd): Renamed from hasInterchangeNewline(), since before we only had a bit for the end, hence we did not need to distinguish it from the start.
• khtml/editing/markup.cpp: (khtml::createMarkup): Added code to detect and write out markup for cases where we have a "logical newline" at start.
• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::startPosition): New helper. (DOM::RangeImpl::endPosition): Ditto.
• khtml/xml/dom2_rangeimpl.h: Declare new helpers.

New tests:

• layout-tests/editing/pasteboard/paste-line-endings-001-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-001.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-002-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-002.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-003-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-003.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-004-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-004.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-005-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-005.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-006-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-006.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-007-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-007.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-008-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-008.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-009-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-009.html: Added.
• layout-tests/editing/pasteboard/paste-line-endings-010-expected.txt: Added.
• layout-tests/editing/pasteboard/paste-line-endings-010.html: Added.