Timeline
Mar 14, 2005:
- 8:00 PM Changeset in webkit [8891] by
-
- 2 edits in trunk/WebKit
Fix <rdar://problem/4051389> 8A413: gifs animating too fast
Reviewed by Maciej.
Match Mozilla's policy for minimum frame duration, which is somewhat odd:
<= 0.01 sec use .1 sec, otherwise use specified duration.
- WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _frameDurationAt:]):
- 6:06 PM Changeset in webkit [8890] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin, Maciej.
<rdar://problem/4046103> REGRESSION (Mail): clicking after style change sets insertion point incorrectly
Also fixes crash by adding nil check.
- khtml/editing/htmlediting.cpp: (khtml::MoveSelectionCommand::doApply): Check the node for nil.
- khtml/khtml_part.cpp: (KHTMLPart::khtmlMouseReleaseEvent): Use the node from the event rather than from the selection.
- 5:45 PM Changeset in webkit [8889] by
-
- 4 edits in trunk/WebKit
Reviewed by Harrison.
- fixed <rdar://problem/4049776> Seed: Mail: Disable spellcheck leaves red artifacts
- WebView.subproj/WebFrameInternal.h: Added _unmarkAllMisspellings.
- WebView.subproj/WebFrame.m: (-[WebFrame _unmarkAllMisspellings]): Added. Calls unmarkAllMisspellings on the bridge and self and all subframes.
- WebView.subproj/WebView.m: (-[WebView setContinuousSpellCheckingEnabled:]): Call _unmarkAllMisspellings on the main frame when turning continuous spell checking off.
- 5:05 PM Changeset in webkit [8888] by
-
- 4 edits in trunk/WebCore
Reviewed by Harrison.
- fixed <rdar://problem/4049776> Seed: Mail: Disable spellcheck leaves red artifacts
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): Set markers list to be "auto-delete" so they don't all leak. (DocumentImpl::removeMarker): Remove markers list for a node when the last marker is removed for that node. Otherwise, we can have empty marker lists for each node forever until the document goes away. (DocumentImpl::removeAllMarkers): Added code to dirty the markers. (DocumentImpl::shiftMarkers): Remove unneeded empty check.
- kwq/WebCoreBridge.h: Added unmarkAllMisspellings for WebKit.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge unmarkAllMisspellings]): Added. Calls removeAllMarkers.
- 4:50 PM Changeset in webkit [8887] by
-
- 4 edits in trunk
WebKit:
Fixed <rdar://problem/4027928> Tiger_8A394:Acrobat crashes while tried to remove the subscription errors by clicking on "Would you like to remove the subscription" from Tracker details view pane
The Acrobat application triggers loads of new documents in it's policy delegate. This
ultimately causes the WebHTMLView to be released before their event handlers have
returned. To bullet proof against this case we retain/release self before passing
the event on for further handling.
Reviewed by Maciej.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView scrollWheel:]): (-[WebHTMLView mouseDown:]): (-[WebHTMLView mouseDragged:]): (-[WebHTMLView mouseUp:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]): (-[WebHTMLView performKeyEquivalent:]):
WebCore:
Fixed <rdar://problem/4027928> Tiger_8A394:Acrobat crashes while tried to remove the subscription errors by clicking on "Would you like to remove the subscription" from Tracker details view pane
A document may be deleted as a consequence of handling an event,
as was the case with Acrobat.app. Ensure that the document is still valid
before passing the event on for further handling.
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchUIEvent):
- 4:43 PM Changeset in webkit [8886] by
-
- 2 edits in trunk/WebCore
Reviewed by me
Added a couple of comments about setChanged() to this code based on my experiences with 4047028.
- khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::addParsedProperties) (DOM::CSSMutableStyleDeclarationImpl::merge)
- 4:26 PM Changeset in webkit [8885] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/4047028> Changing quote levels on stylized text causes it to be sent as colored (Blue). Tiger8A410
- khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::removePropertiesInSet): This function now calls setChanged() at the end of its loop if any properties were removed. This makes the style system update correctly in response to changes made by this function. The code to paste removes style from the pasted content in a preliminary step, and the fact that the style system did not update properly left unwanted color declarations in the document.
- 3:50 PM Changeset in webkit [8884]
-
- 5 copies in tags/Safari-406
This commit was manufactured by cvs2svn to create tag 'Safari-406'.
- 3:50 PM Changeset in webkit [8883]
-
- 5 copies in tags/Safari-306
This commit was manufactured by cvs2svn to create tag 'Safari-306'.
- 3:50 PM Changeset in webkit [8882] by
-
- 5 edits in trunk/WebKit
- roll out the fix for 4040321, since it is still pending CCC review.
2005-03-10 Richard Williamson <rjw@apple.com>
Fixed <rdar://problem/4040321> Exception: Someone's trying to encode a WebDataRequestParameters instance
Reviewed by Darin.
If a delegate returns a mutated applewebdata: request in it's willSendRequest:
method, we don't load using the WebDataRequest. Instead we do a normal load.
Unfortunately, if the request they return is mutated *copy* of the applewebdata:
request it will hold the applewebdata: special properties. These properties
will be encoded into the cache. They should not be. So, to fix, we sanitize the
request, by removing the special properties from the request.
Note that we had to dig into the private guts of NSURLRequest because there is
no public mechanism to remove properties from a request, see 4046775.
- WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate willSendRequest:redirectResponse:]):
- WebView.subproj/WebDataProtocol.h:
- WebView.subproj/WebDataProtocol.m: (-[NSURLRequest _webDataRequestExternalRequest]): (-[NSURLRequest _webDataRequestSanitize]):
- 3:33 PM Changeset in webkit [8881] by
-
- 2 edits in trunk/WebCore
- roll out this change for now, since it was denied by CCC
2005-03-11 David Harrison <harrison@apple.com>
Reviewed by Darin.
<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.
- 2:09 PM Changeset in webkit [8880] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/4050403> Mail crashes after pasting and deleting the content of one Excel cell
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Add some null checks to the code. This fixes the crash, although following the steps described in the bug by John Sullivan on 3/14/05 at 10:49 AM will leave us with a "blank line" in the document that cannot be removed (this is actually an empty table). This is undesirable, however, work Maciej is doing to fix the general-case problem of trying to edit constructs we do not handle well in editing should fix this particular case, making the deletion of this "blank line" possible. Maciej is doing this work as part of this bug: <rdar://problem/4036051> Hard to select (and thus delete) an IFRAME in an editable WebView
- 1:49 PM Changeset in webkit [8879] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
Fix for this bug:
<rdar://problem/4029632> Mail crashes in DOM::NodeImpl::isBlockFlow() after pasting text with alignment style and BR element from Safari
The problem is that removeInlineStyle() can remove nodes, and if either the start or end node of the
selection at the time of the call to removeInlineStyle() was in a node that got removed, bad things
would happen. The fix is described below.
- khtml/editing/htmlediting.cpp: (khtml::maxRangeOffset): Moved this static function to a different place in the file so the code below can use it. (khtml::ApplyStyleCommand::applyInlineStyle): Calling removeInlineStyle() now has the side effect of setting the command's ending selection. Now resets start and end using the ending selection after the call to removeInlineStyle() as it is done elsewhere in this function. (khtml::ApplyStyleCommand::removeInlineStyle): Track the removal of the start or end node based on the positions passed in. If either the start or the end node is removed as part of style removal, set an appropriate replacement start or end that is still in the document.
- 1:40 PM Changeset in webkit [8878] by
-
- 3 edits in trunk
versioning for tip of tree, Safari 2.0 (406+)
- 1:36 PM Changeset in webkit [8877] by
-
- 3 edits in trunk
versioning for SUPanWheat, Safari 1.3 (v306)
- 1:21 PM Changeset in webkit [8876] by
-
- 6 edits in trunk
Safari-406 stamp
- 9:58 AM Changeset in webkit [8875] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin
I need to roll out Kevin's change to fix 3667701. It breaks contextual fragments, and hence breaks
paste in editing (among other things).
- khtml/html/htmltokenizer.cpp: Roll out recent change. (khtml::HTMLTokenizer::write)
- khtml/html/htmltokenizer.h: Ditto.
- 9:49 AM Changeset in webkit [8874] by
-
- 3 edits in trunk/WebKit
Reviewed by Ken and Maciej.
- fixed <rdar://problem/4049040> REGRESSION (403-405): security check prevents user stylesheet from loading (Dictionary.app doesn't work at all!)
- Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): Allow plug-in subresource streams to load with any URL, ignoring the "canLoadURL" method's restriction (only file URLs can load other file URLs), which now applies only to main resources, like web pages in frames or object tags and plug-in main resources.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:customHeaders:]): Allow subresources to load with any URL, as above. This allows things like images, stylesheets, and JavaScript to be loaded without the "canLoadURL" method's restriction. (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto. (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Ditto.
- 9:49 AM Changeset in webkit [8873] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken and Maciej.
- fixed <rdar://problem/4049040> REGRESSION (403-405): security check prevents user stylesheet from loading (Dictionary.app doesn't work at all!)
- kwq/WebCoreBridge.mm: (-[WebCoreBridge canLoadURL:fromReferrer:hideReferrer:]): Changed to give "applewebdata:" documents the same privileges to open local files that "file:" documents have.
- 7:04 AM Changeset in webkit [8872] by
-
- 3 edits in trunk/WebCore
Reviewed by mjs.
Fixed: <rdar://problem/3667701> crash in KHTMLPart::jScriptEnabled()
The problem here was that the tokenizer would continue to receive chunks of data from the loader already
after the view and part had been destroyed. Situations like this could arise when clicking on another link
while still loading the current view, or during self test where we rapidly open, load, and close browser
windows very fast.
- khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::write): Simple nil check against the view.
- khtml/html/htmltokenizer.h: Changed the view pointer from a standard pointer to a QGuardedPtr. The tokenizer's handle to the view will now automatically nil-out and never dangle.
Mar 13, 2005:
- 1:35 PM Changeset in webkit [8871] by
-
- 3 edits6 adds in trunk
Reviewed by John and Ken.
- fixed <rdar://problem/4044347> REGRESSION (Mail): Control-K in particular message moves insertion point to previous line
Tweaked the deleting code, and added three new deleting layout tests to confirm the new code works.
- khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed special case with comment that said it was for the case where a "selection contains only a BR right after a block ended". This code was being triggered in more cases than just that one, and in all the cases I tested, the general delete code works fine. (khtml::DeleteSelectionCommand::handleGeneralDelete): Changed the code that decides whether to delete an entire block to understand the case where the end block is outside the start block, but contains the start block. In that case, we want to delete the entire block. Not deleting the block was causing us to delete just the <br>, and not the enclosing <div> in the case in the bug.
- layout-tests/editing/deleting/delete-line-015-expected.txt: Added.
- layout-tests/editing/deleting/delete-line-015.html: Added.
- layout-tests/editing/deleting/delete-line-016-expected.txt: Added.
- layout-tests/editing/deleting/delete-line-016.html: Added.
- layout-tests/editing/deleting/delete-line-017-expected.txt: Added.
- layout-tests/editing/deleting/delete-line-017.html: Added.
- layout-tests/editing/style/smoosh-styles-002-expected.txt: Updated to improved results. With the code change, the deletion now deletes more than it used to. The old results had an empty text node and <h1> element that were both 0-sized, and now we delete both of those.
- 9:29 AM Changeset in webkit [8870] by
-
- 2 edits in trunk/WebCore
- fixed <rdar://problem/4049172> REGRESSION (403-405): Gmail: text box in "Invite a friend" section overlaps other sections
Rolled out fix for <rdar://problem/3952698> Function buttons do not display properly with Telia Webmail
- khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth): Back to previous version of this file.
