Context Navigation

khtml/dom/html_form.cpp: (HTMLInputElement::click):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::click): (HTMLElementImpl::accessKeyAction):
khtml/html/html_elementimpl.h:
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::submitClick): (DOM::HTMLButtonElementImpl::click): (DOM::HTMLButtonElementImpl::accessKeyAction): (DOM::HTMLInputElementImpl::click): (DOM::HTMLInputElementImpl::accessKeyAction): (DOM::HTMLInputElementImpl::defaultEventHandler): (DOM::HTMLLabelElementImpl::accessKeyAction): (DOM::HTMLSelectElementImpl::accessKeyAction): (DOM::HTMLTextAreaElementImpl::accessKeyAction):
khtml/html/html_formimpl.h:
khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::defaultEventHandler): (HTMLAnchorElementImpl::accessKeyAction):
khtml/html/html_inlineimpl.h:
khtml/rendering/render_form.cpp: (RenderFileButton::click):
khtml/rendering/render_form.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler):
khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::accessKeyAction):
kwq/DOMHTML.mm: (-[DOMHTMLInputElement click]):
kwq/KWQButton.h:
kwq/KWQButton.mm: (QButton::click):
kwq/KWQFileButton.h:
kwq/KWQFileButton.mm: (KWQFileButton::click):

Add accessKeyAction parameter about whether to limit to HTMLElementImpl subclasses that JavaScript wants, or to apply to others as well.

Add click() parameter about whether to send the mousedown and mouseup events in addition to the click event.

kwq/KWQAccObject.mm: (-[KWQAccObject mouseButtonListener]): Locate a mousedown, mouseup, or click handler in the current element and its ancestors.

(-[KWQAccObject actionElement]):
(-[KWQAccObject accessibilityIsIgnored]):
(-[KWQAccObject accessibilityPerformAction:]):
Consider mouseButtonListener.

2:56 PM Changeset in webkit [8922] by rjw

4 edits in trunk/WebKit

Fixed <rdar://problem/4057004> Data from XMLHTTPRequest is never dealloced

WebDataSource keeps an array of all the NSURLResponses associated
with the load for a page. This is used to playback delegate messages
when loading from the page cache. However, after the document
has completed it's initial load, we continue to keep track of responses.
So, this has the consequence of keeping all the responses for a page
around for the life of the page. NSURLResponses are now very
heavy. They indirectly reference the resource data (via the
download assessment dictionary). This fix will keep
references to responses around for those resources loaded during initial
page load, but not after that point.

Reviewed by Ken.

WebView.subproj/WebDataSource.m: (-[WebDataSource _addResponse:]): (-[WebDataSource _stopRecordingResponses]):
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame _opened]):

12:41 PM Changeset in webkit [8921] by sullivan

7 edits in trunk/WebCore

Reviewed by Darin.

fixed <rdar://problem/4002164> maps that include start and end location don't print right from maps.google.com

I thought I checked this in yesterday but a ChangeLog conflict aborted my checkin
without me noticing.

khtml/rendering/render_style.cpp: (RenderStyle::diff): flag name changed from _should_correct_text_color to _force_backgrounds_to_white

khtml/rendering/render_style.h: (khtml::RenderStyle::InheritedFlags::operator==): flag name changed from _should_correct_text_color to _force_backgrounds_to_white (khtml::RenderStyle::setBitDefaults): ditto (khtml::RenderStyle::forceBackgroundsToWhite): ditto, and method name changed too (khtml::RenderStyle::setForceBackgroundsToWhite): ditto

khtml/rendering/render_text.cpp: (InlineTextBox::paint): updated for name change; also, compare text against white instead of current bg color because we no longer actually modify the bg color (previously we would always set the bg color to white, so the result is the same)

khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): updated for name change

kwq/WebCoreBridge.mm: (-[WebCoreBridge styleSheetForPrinting]): removed this method (-[WebCoreBridge reapplyStylesForDeviceType:]): removed the code that called styleSheetForPrinting; we no longer use a stylesheet for this behavior.

khtml/rendering/render_box.cpp: (RenderBox::paintBackgroundExtended): If forceBackgroundsToWhite flag is set, convert background images and background colors to white background color with no background image.

9:49 AM Changeset in webkit [8920] by kocienda

2 edits in trunk/WebKit

Reviewed by Darin

Fix for this bug:

<rdar://problem/4053729> Copy/paste of page with frames into Blot or Mail does nothing and loses insertion point

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedArchive]): Wrap frameset documents in an iframe, so they can be pasted into existing documents which will have a body or frameset of their own.

9:32 AM Changeset in webkit [8919] by kocienda

3 edits in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/4056718> Pasting quotes the entire message

khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): After pasting, nodes are moved to the block containing the end of the pasted content in certain cases. This move logic used to stop once it moved all the siblings of the node following the last node of the pasted-in content. This means that block elements could get moved, and if the pasted-in content included a mail blockquote, this could result in one quote level getting added. The fix is to stop the move of nodes once a <br>, block element, or <table> is seen. This only affected one of the many test cases we have for such scenarios, and the change to that result makes sense given the code change.
layout-tests/editing/pasteboard/paste-text-003-expected.txt: This test result changed in a way that adequately tests the behavior change, so I did not add a new test.

7:56 AM Changeset in webkit [8918] by kocienda

2 edits in trunk/WebCore

Reviewed by Harrison

Fix for this bug:

<rdar://problem/4051809> 8A413: Cursor-up in a mail message sometimes gets stuck (with specific reproducible case)

khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Consider two lines: line-above and line-below. If the caret position in line-below was at an x coordinate between half way through the x coordinate of the last character on the line-above and the end of that same character, this bug would happen since the positioning code would assume that it could create a VisiblePosition with a DOWNSTREAM affinity. Now, I check to see if the character position on the line-above is the last character on that line, and if it is, I use UPSTREAM as the affinity.

Mar 17, 2005:

2:59 PM Changeset in webkit [8917] by vicki

3 edits in trunk

versioning for TOT, Safari 2.0 (407+)

2:48 PM Changeset in webkit [8916]

1 copy in tags/Safari-307

This commit was manufactured by cvs2svn to create tag 'Safari-307'.

2:48 PM Changeset in webkit [8915] by vicki

3 edits in trunk

versioning for Safari 1.3 (307) on SUPanWheat

2:41 PM Changeset in webkit [8914]

1 copy in tags/Safari-407

This commit was manufactured by cvs2svn to create tag 'Safari-407'.

2:41 PM Changeset in webkit [8913] by vicki

6 edits in trunk

Safari-407 stamp

1:43 PM Changeset in webkit [8912] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/4055562> REGRESSION (Tiger): Safari doesn't draw progressively-loaded JPEGs (www.theregister.co.uk, www.titantalk.com)

Anothe side effect of lazy loading of image meta data. We now
don't cache image size until size meta data is actually available.

Reviewed by Darin.

WebCoreSupport.subproj/WebImageData.m: (-[WebImageData size]):

11:09 AM Changeset in webkit [8911] by harrison

2 edits in trunk/WebCore

Reviewed by Darin, Ken.

khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::setEndingSelection): Fixed typo so that it calls setEndingSelection rather than setStartingSelection. Commented out this unused method, tho, since this is late in Tiger. Proved unused by successful build after temporarily removing method declaration or implemenation.

9:57 AM Changeset in webkit [8910] by kdecker

2 edits in trunk/WebCore

Reviewed by mjs.

Fixed <rdar://problem/4046665> REGRESSION (403-405): mypage.apple.com login does not work (hits assertion in Development build)

kwq/WebCoreBridge.mm: (-[WebCoreBridge canLoadURL:fromReferrer:hideReferrer:]): Check always came back false when callers would send a nil NSURL to this method. Now we allow the empty url cases, eg., <frame src="">

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed