⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 20, 2005:

9:10 PM Changeset in webkit [9853] by mjs
  • 13 edits
    2 adds in trunk

Reviewed by Geoff.

  • fix handling of special properties of the HTML document object. Now we completely match IE.

Test cases added:

  • layout-tests/fast/dom/HTMLDocument/document-special-properties.html: Added; new exhaustive test case.
  • layout-tests/fast/dom/HTMLDocument/document-special-properties-expected.txt: Added.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): Check for named and doc extra named items. (KJS::HTMLDocument::get): Return the appropriate element, window or collection by name; give such named items precedence over built-in and custom properties.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::get): Replace quirky &* idiom with call to get().
  • khtml/html/html_baseimpl.cpp: (HTMLIFrameElementImpl::parseMappedAttribute): Track by name as a doc extra named item. (HTMLIFrameElementImpl::insertedIntoDocument): ditto (HTMLIFrameElementImpl::removedFromDocument): ditto
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_documentimpl.cpp: (DOM::addItemToMap): Factored out from addNamedItem (DOM::removeItemFromMap): Factored out from removeNamedItem (DOM::HTMLDocumentImpl::addNamedItem): refactored (DOM::HTMLDocumentImpl::removeNamedItem): refactored (DOM::HTMLDocumentImpl::addDocExtraNamedItem): new method - maintains a hashtable of the "extra" named items for a document, which are iframes by name and applets and embeds by id. (DOM::HTMLDocumentImpl::removeDocExtraNamedItem): ditto (DOM::HTMLDocumentImpl::hasDocExtraNamedItem): ditto
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::traverseNextItem): Remove support for DOC_NAMEABLE_ITEMS collection - no longer needed. (DOM::HTMLNameCollectionImpl::traverseNextItem): Add support for DOCUMENT_NAMED_ITEMS, implementing the correct document rule.
  • khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::parseMappedAttribute): Track by id as doc extra named item (DOM::HTMLAppletElementImpl::insertedIntoDocument): ditto (DOM::HTMLAppletElementImpl::removedFromDocument): ditto (DOM::HTMLObjectElementImpl::parseMappedAttribute): ditto (DOM::HTMLObjectElementImpl::insertedIntoDocument): ditto (DOM::HTMLObjectElementImpl::removedFromDocument): ditto
  • khtml/html/html_objectimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::nameableItems): removed - no longer used (DocumentImpl::documentNamedItems): added
  • khtml/xml/dom_docimpl.h:
3:55 PM Changeset in webkit [9852] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Vicki Murley.

  • removed some form-related methods that weren't being used anywhere, in preparation for weaning WebKit's WebFormDelegate protocol from NSView.

Test cases added: none, no behavior change

  • kwq/KWQTextField.mm:
  • kwq/WebCoreBridge.h: removed these methods: -control:didFailToFormatString:errorDescription: -control:didFailToValidatePartialString:errorDescription: -control:isValidObject:

WebKit:

Reviewed by Vicki Murley.

  • removed some form-related methods that weren't being used anywhere, in preparation for weaning WebKit's WebFormDelegate protocol from NSView.
  • WebCoreSupport.subproj/WebBridge.m:
  • WebView.subproj/WebFormDelegate.h:
  • WebView.subproj/WebFormDelegate.m: removed these methods: -control:didFailToFormatString:errorDescription: -control:didFailToValidatePartialString:errorDescription: -control:isValidObject:
1:36 PM Changeset in webkit [9851] by adele
  • 2 edits in trunk/WebKit

Merged fix for:
<rdar://problem/4125127> [WebKit] horizontal rulers don't render on Safari on web.apple.com

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]):
1:04 PM Changeset in webkit [9850] by adele
  • 2 edits in trunk/WebKit

Merged fix for :
<rdar://problem/4118278> mail divide by zero navigating messages

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]):
12:55 PM Changeset in webkit [9849] by adele
  • 2 edits in trunk/WebCore

Rolling fix for <rdar://problem/4046602> back in.

2005-03-11 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::markMisspellings): Nil check checker.
11:34 AM Changeset in webkit [9848] by sullivan
  • 1 edit in trunk/WebKit/ChangeLog

Fixed reviewer name from previous checkin.

11:30 AM Changeset in webkit [9847] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Adele Amchan.

  • added -[WebView selectedFrame] to SPI (pending public API), needed for 4180958
  • WebView.subproj/WebView.m: (-[WebView selectedFrame]): new method, extracted from _selectedOrMainFrame (-[WebView _selectedOrMainFrame]): now calls extracted method
  • WebView.subproj/WebViewPrivate.h: add -selectedFrame to PendingPublic category
11:17 AM Changeset in webkit [9846] by adele
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • fixed <rdar://problem/4181058> 8C45: Safari repro crash with document.write (DOM::NodeImpl::dispatchEvent)

Test cases added:

  • manual-tests/textfield-onblur.html: Added.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): added nil check for widget, since it can get deleted during an event.
12:29 AM Changeset in webkit [9845] by mjs
  • 4 edits in trunk

JavaScriptCore:

Patch from Trey Matteson <​trey@usa.net>, reviewed by me.

  • JavaScriptCore.pbproj/project.pbxproj: Generate symbols even for Deployment.

WebCore:

Patch from Trey Matteson <​trey@usa.net>, reviewed by me.

  • WebCore.pbproj/project.pbxproj: Generate symbols even for Deployment.

Jul 19, 2005:

9:04 PM Changeset in webkit [9844] by mjs
  • 3 edits in trunk

Reviewed by Kevin.

  • fixed some mistakes in my previous checkin
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::parseMappedAttribute): Take name attribute out of the "do nothing" case (duh).
  • layout-tests/fast/dom/Window/window-special-properties-expected.txt: Update for change to the text at the top.
7:35 PM Changeset in webkit [9843] by mjs
  • 15 edits
    3 adds in trunk

Reviewed by Darin.

  • fix handling of special properties of the Window object. now we almost completely match Win IE.

Test cases added:

  • layout-tests/fast/dom/Window/window-special-properties-expected.txt: Added.
  • layout-tests/fast/dom/Window/window-special-properties.html: Added.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::HTMLDocument::tryGet):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::get): (KJS::Window::hasOwnProperty):
  • khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::addNamedItem): (DOM::HTMLDocumentImpl::removeNamedItem): (DOM::HTMLDocumentImpl::hasNamedItem):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::attach): (DOM::HTMLFormElementImpl::insertedIntoDocument): (DOM::HTMLFormElementImpl::removedFromDocument): (DOM::HTMLFormElementImpl::parseMappedAttribute):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseMappedAttribute): (HTMLImageElementImpl::attach): (HTMLImageElementImpl::insertedIntoDocument): (HTMLImageElementImpl::removedFromDocument):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::HTMLCollectionImpl): (DOM::HTMLCollectionImpl::traverseNextItem): (DOM::HTMLCollectionImpl::namedItem): (DOM::HTMLNameCollectionImpl::HTMLNameCollectionImpl): (DOM::HTMLNameCollectionImpl::traverseNextItem): (DOM::HTMLFormCollectionImpl::getNamedFormItem): (DOM::HTMLFormCollectionImpl::nextNamedItem):
  • khtml/html/html_miscimpl.h: (DOM::HTMLCollectionImpl::):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::parseMappedAttribute): (DOM::HTMLAppletElementImpl::insertedIntoDocument): (DOM::HTMLAppletElementImpl::removedFromDocument): (DOM::HTMLEmbedElementImpl::parseMappedAttribute): (DOM::HTMLEmbedElementImpl::attach): (DOM::HTMLEmbedElementImpl::insertedIntoDocument): (DOM::HTMLEmbedElementImpl::removedFromDocument): (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLObjectElementImpl::detach): (DOM::HTMLObjectElementImpl::insertedIntoDocument): (DOM::HTMLObjectElementImpl::removedFromDocument):
  • khtml/html/html_objectimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::windowNamedItems):
  • khtml/xml/dom_docimpl.h:
7:23 PM Changeset in webkit [9842] by ggaren
  • 3 edits in trunk/JavaScriptCore

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3991
JSC doesn't implement Array.prototype.toLocaleString()

-test failure: ecma_3/Array/15.4.4.3-1.js

Reviewed by mjs.

  • kjs/array_object.cpp: (ArrayProtoFuncImp::call): now searches for toString and toLocaleString overrides in the array's elements
  • tests/mozilla/expected.html: failures are under 100! woohoo!
7:04 PM Changeset in webkit [9841] by ggaren
  • 3 edits
    1 add in trunk/WebCore

-rolled in patch by Anders Carlsson <​andersca@mac.com> for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3751
REGRESSION: affects Blogger, GMail & Wikipedia: empty textarea's which should have content

Reviewed by mjs.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::defaultValue): (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h:

Test cases added:

  • manual-tests/textarea-after-stylesheet-link.html: Added. Test is manual because the result doesn't show up in DumpRenderTree
6:17 PM Changeset in webkit [9840] by justing
  • 2 edits in trunk/WebCore

Added a virtual deconstructor to fix gcc4 build warning

  • khtml/rendering/render_theme.h: (khtml::RenderTheme::~RenderTheme):
5:50 PM Changeset in webkit [9839] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Darin Adler.

  • cleaned up code related to dealing with the "selected frame"; fixes radar bugs 4118830 and 4118820
  • WebView.subproj/WebTextView.m: (-[WebTextView resignFirstResponder]): call deselectAll here instead of replicating its guts, just for clarity
  • WebView.subproj/WebViewInternal.h: eliminated category WebInternal; all of these methods were used only inside WebView.m, so I moved them into the existing category WebFileInternal that was declared and implemented in WebView.m
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): updated for name changes. Also, uses new _deselectFrame: to clear the selection if the found text is in a different frame. (-[WebView pasteboardTypesForSelection]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView setSelectedDOMRange:affinity:]): (-[WebView selectedDOMRange]): (-[WebView selectionAffinity]): (-[WebView setTypingStyle:]): (-[WebView typingStyle]): (-[WebView styleDeclarationWithText:]): (-[WebView replaceSelectionWithNode:]): (-[WebView replaceSelectionWithText:]): (-[WebView replaceSelectionWithMarkupString:]): (-[WebView replaceSelectionWithArchive:]): (-[WebView deleteSelection]): (-[WebView applyStyle:]): updated for name changes only

(-[WebView _frameIsSelected:]):
new method, returns YES if given frame has a non-zero-length selection
(-[WebView _deselectFrame:]):
new method, clears selection from given frame
(-[WebView _findSelectedFrameStartingFromFrame:]):
new method, recursive helper used by _findSelectedFrame
(-[WebView _findSelectedFrame]):
new method, finds first frame that returns YES for _frameIsSelected, or nil
(-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]):
new method, recursive helper used by _debugCheckForMultipleSelectedFrames
(-[WebView _debugCheckForMultipleSelectedFrames]):
new method for debugging, fires an assertion if there's more than one selected frame.
(-[WebView _selectedOrMainFrame]):
renamed from _frameForCurrentSelection, which was a misleading name since the returned
frame does not necessarily have a selection (or even focus). Now checks for a selected
but non-focused frame if the first responder is not in any frame. Also, moved in file
from WebInternal category to WebFileInternal category.
(-[WebView _bridgeForSelectedOrMainFrame]):
renamed from _bridgeForCurrentSelection, which was a misleading name for the same
reasons as _frameForCurrentSelection. Also, moved in file from WebInternal category to
WebFileInternal category.
(-[WebView _isLoading]):
(-[WebView _frameViewAtWindowPoint:]):
(-[WebView _bridgeAtPoint:]):
just moved in file from WebInternal category to WebFileInternal category

5:45 PM Changeset in webkit [9838] by hyatt
  • 6 edits
    4 adds in trunk/WebCore

Adding support for the "checkbox" appearance value. This is not yet implemented, but the
methods are now stubbed out and will get called.

Reviewed by mjs

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle): (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/html4.css:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::createRenderer):
  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
  • khtml/rendering/render_theme.cpp: Added. (khtml::RenderTheme::adjustStyle): (khtml::RenderTheme::paint):
  • khtml/rendering/render_theme.h: Added.
  • khtml/rendering/render_theme_mac.h: Added.
  • khtml/rendering/render_theme_mac.mm: Added. (khtml::theme): (khtml::RenderThemeMac::adjustCheckboxStyle): (khtml::RenderThemeMac::paintCheckbox):
4:44 PM Changeset in webkit [9837] by hyatt
  • 5 edits in trunk/WebCore

Fix performance regressions from attribute QName landing.

Reviewed by mjs

  • khtml/html/htmltokenizer.cpp: (khtml::Token::addAttribute): (khtml::HTMLTokenizer::write):

Make sure attributes have a faster constructor that can avoid the copy of QualifiedNames.

Make sure to grab the part from the document outside the loop, so that it is not fetched
over and over again for every character in the source.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):

Only call paintCaret if the block is actually editable.

  • khtml/xml/dom_atomicstring.h: (DOM::operator!=):
  • khtml/xml/dom_elementimpl.h: (DOM::AttributeImpl::AttributeImpl): (DOM::AttributeImpl::~AttributeImpl): (DOM::MappedAttributeImpl::MappedAttributeImpl):

Add != comparison operator with a char* to speed up the / check for attribute invalidity.

3:41 PM Changeset in webkit [9836] by vicki
  • 5 edits
    2 adds in trunk/WebCore

Reviewed by Maciej.

Test cases added:

  • manual-tests/scrollIntoView-horizontal.html: Added.
  • manual-tests/scrollIntoView-vertical.html: Added.
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView): Added.
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::): (KJS::DOMElement::):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMElementProtoFunc::tryCall): glue for new scrollIntoView function
2:18 PM Changeset in webkit [9835] by ggaren
  • 141 edits in trunk

Reviewed by hyatt.

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine):

Lots of new test case results because previous results had inappropriately
split text runs.

  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/box_properties/border-expected.txt:
  • layout-tests/css1/box_properties/border_bottom-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left-expected.txt:
  • layout-tests/css1/box_properties/border_left_inline-expected.txt:
  • layout-tests/css1/box_properties/border_left_width-expected.txt:
  • layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right-expected.txt:
  • layout-tests/css1/box_properties/border_right_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right_width-expected.txt:
  • layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top-expected.txt:
  • layout-tests/css1/box_properties/border_top_inline-expected.txt:
  • layout-tests/css1/box_properties/border_top_width-expected.txt:
  • layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
  • layout-tests/css1/box_properties/border_width-expected.txt:
  • layout-tests/css1/box_properties/border_width_inline-expected.txt:
  • layout-tests/css1/box_properties/clear_float-expected.txt:
  • layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
  • layout-tests/css1/box_properties/float_margin-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/box_properties/height-expected.txt:
  • layout-tests/css1/box_properties/margin-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_left-expected.txt:
  • layout-tests/css1/box_properties/margin_left_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_right-expected.txt:
  • layout-tests/css1/box_properties/margin_right_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_top-expected.txt:
  • layout-tests/css1/box_properties/margin_top_inline-expected.txt:
  • layout-tests/css1/box_properties/padding-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_left-expected.txt:
  • layout-tests/css1/box_properties/padding_left_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_right-expected.txt:
  • layout-tests/css1/box_properties/padding_right_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_top-expected.txt:
  • layout-tests/css1/box_properties/padding_top_inline-expected.txt:
  • layout-tests/css1/box_properties/width-expected.txt:
  • layout-tests/css1/classification/display-expected.txt:
  • layout-tests/css1/color_and_background/background_position-expected.txt:
  • layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/font_properties/font_size-expected.txt:
  • layout-tests/css1/formatting_model/canvas-expected.txt:
  • layout-tests/css1/formatting_model/floating_elements-expected.txt:
  • layout-tests/css1/formatting_model/height_of_lines-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/formatting_model/replaced_elements-expected.txt:
  • layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/css1/text_properties/letter_spacing-expected.txt:
  • layout-tests/css1/text_properties/line_height-expected.txt:
  • layout-tests/css1/text_properties/text_indent-expected.txt:
  • layout-tests/css1/text_properties/vertical_align-expected.txt:
  • layout-tests/css1/text_properties/word_spacing-expected.txt:
  • layout-tests/css1/units/length_units-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-001-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-002-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-003-expected.txt:
  • layout-tests/editing/style/relative-font-size-change-004-expected.txt:
  • layout-tests/editing/style/smoosh-styles-003-expected.txt:
  • layout-tests/fast/block/basic/018-expected.txt:
  • layout-tests/fast/block/float/002-expected.txt:
  • layout-tests/fast/block/float/021-expected.txt:
  • layout-tests/fast/block/float/023-expected.txt:
  • layout-tests/fast/block/float/024-expected.txt:
  • layout-tests/fast/block/float/029-expected.txt:
  • layout-tests/fast/block/float/030-expected.txt:
  • layout-tests/fast/block/margin-collapse/043-expected.txt:
  • layout-tests/fast/block/margin-collapse/101-expected.txt:
  • layout-tests/fast/block/positioning/060-expected.txt:
  • layout-tests/fast/block/positioning/auto/001-expected.txt:
  • layout-tests/fast/block/positioning/auto/002-expected.txt:
  • layout-tests/fast/block/positioning/auto/003-expected.txt:
  • layout-tests/fast/block/positioning/auto/004-expected.txt:
  • layout-tests/fast/block/positioning/auto/005-expected.txt:
  • layout-tests/fast/block/positioning/auto/006-expected.txt:
  • layout-tests/fast/clip/001-expected.txt:
  • layout-tests/fast/clip/002-expected.txt:
  • layout-tests/fast/clip/003-expected.txt:
  • layout-tests/fast/clip/004-expected.txt:
  • layout-tests/fast/clip/005-expected.txt:
  • layout-tests/fast/clip/006-expected.txt:
  • layout-tests/fast/clip/007-expected.txt:
  • layout-tests/fast/clip/008-expected.txt:
  • layout-tests/fast/clip/009-expected.txt:
  • layout-tests/fast/clip/010-expected.txt:
  • layout-tests/fast/clip/011-expected.txt:
  • layout-tests/fast/clip/012-expected.txt:
  • layout-tests/fast/clip/013-expected.txt:
  • layout-tests/fast/clip/014-expected.txt:
  • layout-tests/fast/clip/015-expected.txt:
  • layout-tests/fast/clip/016-expected.txt:
  • layout-tests/fast/css-generated-content/012-expected.txt:
  • layout-tests/fast/css/008-expected.txt:
  • layout-tests/fast/css/MarqueeLayoutTest-expected.txt:
  • layout-tests/fast/css/apple-prefix-expected.txt:
  • layout-tests/fast/dom/quadraticCurveTo-expected.txt:
  • layout-tests/fast/dynamic/noninlinebadness-expected.txt:
  • layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
  • layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
  • layout-tests/fast/flexbox/001-expected.txt:
  • layout-tests/fast/flexbox/004-expected.txt:
  • layout-tests/fast/flexbox/007-expected.txt:
  • layout-tests/fast/flexbox/008-expected.txt:
  • layout-tests/fast/flexbox/009-expected.txt:
  • layout-tests/fast/flexbox/010-expected.txt:
  • layout-tests/fast/flexbox/012-expected.txt:
  • layout-tests/fast/flexbox/013-expected.txt:
  • layout-tests/fast/flexbox/014-expected.txt:
  • layout-tests/fast/flexbox/015-expected.txt:
  • layout-tests/fast/flexbox/018-expected.txt:
  • layout-tests/fast/flexbox/019-expected.txt:
  • layout-tests/fast/flexbox/020-expected.txt:
  • layout-tests/fast/flexbox/021-expected.txt:
  • layout-tests/fast/flexbox/022-expected.txt:
  • layout-tests/fast/flexbox/023-expected.txt:
  • layout-tests/fast/flexbox/024-expected.txt:
  • layout-tests/fast/invalid/012-expected.txt:
  • layout-tests/fast/invalid/016-expected.txt:
  • layout-tests/fast/invalid/nestedh3s-expected.txt:
  • layout-tests/fast/lists/003-expected.txt:
  • layout-tests/fast/replaced/004-expected.txt:
  • layout-tests/fast/selectors/166-expected.txt:
  • layout-tests/fast/table/032-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/text/basic/003-expected.txt:
  • layout-tests/fast/text/basic/004-expected.txt:
  • layout-tests/fast/text/basic/005-expected.txt:
  • layout-tests/fast/text/basic/009-expected.txt:
2:16 PM Changeset in webkit [9834] by darin
  • 3 edits in trunk/JavaScriptCore
  • fixed the build
  • kjs/lookup.h: (KJS::lookupPut): Remove bogus const; was preventing WebCore from compiling (not sure why this didn't affect my other build machine).
  • one other tiny tweak (so sue me)
  • bindings/runtime_root.cpp: Remove unneeded declaration.
12:52 PM Changeset in webkit [9833] by darin
  • 25 edits in trunk

JavaScriptCore:

Reviewed by Geoff Garen.

  • eliminated try wrappers for get/put/call since we don't use C++ exceptions any more
  • kjs/lookup.h: Changed tryCall in IMPLEMENT_PROTOFUNC here to call. It doesn't make sense for this macro to use the name tryCall anyway, since that's specific to how WebCore used this, so this is good anyway. On the other hand, it might be a problem for KDOM or KSVG, in which case we'll need another macro for them, since JavaScriptCore should presumably not have the C++ exception support.

WebCore:

Reviewed by Geoff Garen.

Test cases added: None. Structural change only.

  • eliminated try wrappers for get/put/call since we don't use C++ exceptions any more
  • khtml/ecma/kjs_binding.cpp: Removed DOMObject::get, DOMObject::set, DOMFunction::get, and DOMFunction::call.
  • khtml/ecma/kjs_binding.h: Removed get, set, tryGet, trySet, call, tryCall from DOMObject and DOMFunction. Removed DOMObjectLookupGet, DOMObjectLookupGetValue, and DOMObjectLookupPut. We can just do things the normal way now.

The rest of the changes are just renames and removal of a couple stray tryCall wrappers.

tryGet -> get
tryPut -> put
tryCall -> call
putValue -> putValueProperty
DOMObjectLookupGet -> lookupGet
DOMObjectLookupGetValue -> lookupGetValue
DOMObjectLookupPut -> lookupPut

  • khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::call):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::get): (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMCSSStyleDeclarationProtoFunc::call): (KJS::DOMStyleSheet::get): (KJS::DOMStyleSheet::put): (KJS::DOMStyleSheetList::get): (KJS::DOMStyleSheetListFunc::call): (KJS::DOMMediaList::get): (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::call): (KJS::DOMCSSStyleSheet::get): (KJS::DOMCSSStyleSheetProtoFunc::call): (KJS::DOMCSSRuleList::get): (KJS::DOMCSSRuleListFunc::call): (KJS::DOMCSSRule::get): (KJS::DOMCSSRule::put): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSRuleFunc::call): (KJS::CSSRuleConstructor::get): (KJS::DOMCSSValue::get): (KJS::DOMCSSValue::put): (KJS::CSSValueConstructor::get): (KJS::DOMCSSPrimitiveValue::get): (KJS::DOMCSSPrimitiveValueProtoFunc::call): (KJS::CSSPrimitiveValueConstructor::get): (KJS::DOMCSSValueList::get): (KJS::DOMCSSValueListFunc::call): (KJS::DOMRGBColor::get): (KJS::DOMRect::get): (KJS::DOMCounter::get):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::get): (KJS::DOMNode::put): (KJS::DOMNode::putValueProperty): (KJS::DOMNodeProtoFunc::call): (KJS::DOMNodeList::get): (KJS::DOMNodeList::call): (KJS::DOMNodeListFunc::call): (KJS::DOMAttr::get): (KJS::DOMAttr::put): (KJS::DOMAttr::putValueProperty): (KJS::DOMDocument::get): (KJS::DOMDocument::put): (KJS::DOMDocument::putValueProperty): (KJS::DOMDocumentProtoFunc::call): (KJS::DOMElement::get): (KJS::DOMElementProtoFunc::call): (KJS::DOMDOMImplementationProtoFunc::call): (KJS::DOMDocumentType::get): (KJS::DOMNamedNodeMap::get): (KJS::DOMNamedNodeMapProtoFunc::call): (KJS::DOMProcessingInstruction::get): (KJS::DOMProcessingInstruction::put): (KJS::DOMNotation::get): (KJS::DOMEntity::get): (KJS::NodeConstructor::get): (KJS::DOMExceptionConstructor::get): (KJS::DOMNamedNodesCollection::get): (KJS::DOMCharacterData::get): (KJS::DOMCharacterData::put): (KJS::DOMCharacterDataProtoFunc::call): (KJS::DOMText::get): (KJS::DOMTextProtoFunc::call):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (KJS::EventConstructor::get): (KJS::DOMEvent::get): (KJS::DOMEvent::put): (KJS::DOMEvent::putValueProperty): (KJS::DOMEventProtoFunc::call): (KJS::EventExceptionConstructor::get): (KJS::DOMUIEvent::get): (KJS::DOMUIEventProtoFunc::call): (KJS::DOMMouseEvent::get): (KJS::DOMMouseEventProtoFunc::call): (KJS::DOMKeyboardEvent::get): (KJS::DOMKeyboardEventProtoFunc::call): (KJS::MutationEventConstructor::get): (KJS::DOMMutationEvent::get): (KJS::DOMMutationEventProtoFunc::call): (KJS::DOMWheelEvent::get): (KJS::DOMWheelEventProtoFunc::call): (KJS::Clipboard::get): (KJS::Clipboard::put): (KJS::Clipboard::putValueProperty): (KJS::ClipboardProtoFunc::call):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::call): (KJS::HTMLDocument::get): (KJS::KJS::HTMLDocument::put): (KJS::KJS::HTMLDocument::putValueProperty): (KJS::KJS::HTMLElement::get): (KJS::KJS::HTMLElementFunction::call): (KJS::KJS::HTMLElement::put): (KJS::HTMLElement::putValueProperty): (KJS::KJS::HTMLCollection::get): (KJS::KJS::HTMLCollection::call): (KJS::KJS::HTMLCollectionProtoFunc::call): (KJS::KJS::HTMLSelectCollection::get): (KJS::KJS::HTMLSelectCollection::put): (KJS::Image::get): (KJS::Image::put): (KJS::Image::putValueProperty): (KJS::KJS::Context2DFunction::call): (KJS::Context2D::get): (KJS::Context2D::put): (KJS::Context2D::putValueProperty): (KJS::GradientFunction::call): (KJS::Gradient::get): (KJS::Gradient::put): (KJS::Gradient::putValueProperty): (KJS::ImagePattern::get): (KJS::ImagePattern::put): (KJS::ImagePattern::putValueProperty):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginsFunc::call): (KJS::NavigatorFunc::call):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::get): (KJS::DOMRangeProtoFunc::call): (KJS::RangeConstructor::get):
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::get): (KJS::DOMNodeIteratorProtoFunc::call): (KJS::NodeFilterConstructor::get): (KJS::DOMNodeFilterProtoFunc::call): (KJS::DOMTreeWalker::get): (KJS::DOMTreeWalker::put): (KJS::DOMTreeWalkerProtoFunc::call):
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractView::get): (KJS::DOMAbstractViewFunc::call):
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::call): (KJS::LocationFunc::call): (KJS::SelectionFunc::call): (KJS::HistoryFunc::call): (KJS::KonquerorFunc::call):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::get): (KJS::XMLHttpRequest::put): (KJS::XMLHttpRequest::putValueProperty): (KJS::XMLHttpRequestProtoFunc::call):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::call):
12:48 PM Changeset in webkit [9832] by darin
  • 2 edits in trunk/WebKit

Reviewed by Geoff Garen.

  • improve handling of plug-ins when the WebView or a superview is hidden with -[NSView setHidden]
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Add "hidden" to the list of reasons to clip out all plug-in drawing.
11:43 AM Changeset in webkit [9831] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed broken bi-di layout tests: the "dir" attribute was broken
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Fix one case that said "direction" where it should say "dir".
11:35 AM Changeset in webkit [9830] by darin
  • 3 edits in trunk
  • updated results of two tests that reflect properly-preserved namespace prefixes for attributes
  • layout-tests/fast/dom/dom-parse-serialize-display-expected.txt:
  • layout-tests/fast/dom/dom-parse-serialize-expected.txt:
10:11 AM Changeset in webkit [9829] by sullivan
  • 4 edits in trunk/WebKit

Written by Trey Matteson <​trey@usa.net>
Reviewed by John Sullivan.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4049

scroll position not restored when going back/forward at ebay

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4061

When going back/forward to some pages, they redraw at top before restoring scroll position

The short story is that attempting to restore the scroll position
at the time when the first layout finishes addresses both of these
issues. An explanation of the underlying race condition is in
a large comment near -_restoreScrollPosition.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge didFirstLayout]): Pass through to WebFrame.
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Get rid of attempt to restoreScrollPosition that never did anything because the docView was always 0x0 size at that point. (-[WebFrame _opened]): Get rid of redundant call to restoreScrollPosition. The imminent call to layoutCompleted makes the same call. (-[WebFrame _didFirstLayout]): Restore the scroll position on first layout, if we're doing a b/f nav.
  • WebView.subproj/WebFrameInternal.h:
Note: See TracTimeline for information about the timeline view.