⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 28, 2005:

11:21 PM Changeset in webkit [9945] by eseidel
  • 3 edits in trunk

Bug #: 3936
Submitted by: Ben La Monica
Reviewed by: darin, eseidel

11:11 PM Changeset in webkit [9944] by ggaren
  • in /

file project.pbxproj was added on branch Safari-2-0-branch on 2005-07-29 23:29:41 +0000

11:11 PM Changeset in webkit [9943] by eseidel
  • 23 edits in trunk

Bug #: 4154
Submitted by: eseidel
Reviewed by: mjs

  • WebCore.xcodeproj/project.pbxproj: Added SVG files back.
  • kdom/css/CSSCharsetRule.cpp:
  • kdom/css/CSSFontFaceRule.cpp:
  • kdom/css/CSSImportRule.cpp:
  • kdom/css/CSSMediaRule.cpp:
  • kdom/css/CSSPageRule.cpp:
  • kdom/css/CSSPrimitiveValue.cpp:
  • kdom/css/CSSRule.cpp:
  • kdom/css/CSSRuleList.cpp:
  • kdom/css/CSSStyleDeclaration.cpp:
  • kdom/css/CSSStyleRule.cpp:
  • kdom/css/CSSStyleSheet.cpp:
  • kdom/css/CSSValue.cpp:
  • kdom/css/CSSValueList.cpp:
  • kdom/css/Counter.cpp:
  • kdom/css/DocumentStyle.cpp:
  • kdom/css/MediaList.cpp:
  • kdom/css/RGBColor.cpp:
  • kdom/css/Rect.cpp:
  • kdom/css/StyleSheet.cpp:
  • kdom/css/StyleSheetList.cpp:
  • kdom/ecma/DOMLookup.h: Hacked around mjs's latest JSC change. Fixed #include statements to build under Xcode 2.1. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4154
10:26 PM Changeset in webkit [9942] by eseidel
  • 1 edit
    5 adds in trunk/WebKitTools

Bug #: 4156
Submitted by: eseidel
Reviewed by: ggaren

7:45 PM Changeset in webkit [9941] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Manual message.

7:42 PM Changeset in webkit [9940] by hyatt
  • 2 edits in trunk/WebCore/kwq

Manual message, having commit issues.

7:40 PM Changeset in webkit [9939] by hyatt
  • 5 edits in trunk/WebCore/khtml

Test?

4:27 PM Changeset in webkit [9938] by hyatt
  • 7 edits in trunk/WebCore

Implement support for the :checked, :enabled and :disabled pseudo-classes.

Reviewed by john

  • khtml/css/css_base.cpp: (CSSSelector::extractPseudoType):
  • khtml/css/css_base.h: (DOM::CSSSelector::):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/html/html_formimpl.h: (DOM::HTMLGenericFormElementImpl::isControl): (DOM::HTMLGenericFormElementImpl::isEnabled): (DOM::HTMLInputElementImpl::isChecked):
  • khtml/rendering/render_theme.cpp: (khtml::RenderTheme::isChecked): (khtml::RenderTheme::isEnabled):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isControl): (DOM::NodeImpl::isEnabled): (DOM::NodeImpl::isChecked):
3:52 PM Changeset in webkit [9937] by bdakin
  • 2 edits in trunk/WebCore

This is a fix for <rdar://problem/4190684>. Hyatt and I
(okay, mostly Hyatt) wrote this for Cayenne so that they
can change the value of a style of a rule and have everything
update dynamically without causing a crash.

Reviewed by Hyatt

Test cases added: (NONE)

  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::setChanged):
2:28 PM Changeset in webkit [9936] by cblu
  • 5 edits in trunk/WebCore

Moved non-AppKit related code from RenderThemeMac to RenderTheme so potentially other RenderTheme subclasses can inherit more behavior.

Reviewed by hyatt.

  • khtml/rendering/render_theme.cpp: (khtml::RenderTheme::baselinePosition): (khtml::RenderTheme::isControlContainer): (khtml::RenderTheme::sizeForFont): (khtml::RenderTheme::setSizeFromFont): (khtml::RenderTheme::setCheckboxSize): (khtml::RenderTheme::adjustCheckboxStyle):
  • khtml/rendering/render_theme.h:
  • khtml/rendering/render_theme_mac.h:
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::sizeForFont):
1:47 PM Changeset in webkit [9935] by hyatt
  • 11 edits in trunk/WebCore

Make sure :focus is not matched when the window is not key.
This involved adding a check to the style selector and also
removing the hack from the painter that turned off outline:auto
drawing when the window wasn't key.

Added support for control tinting when the window resigns/becomes
key.

Reviewed by john

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
  • khtml/khtml_part.h: (KHTMLPart::displaysWithFocusAttributes):
  • khtml/rendering/render_theme.cpp: (khtml::RenderTheme::paint): (khtml::RenderTheme::isChecked): (khtml::RenderTheme::isEnabled): (khtml::RenderTheme::isFocused): (khtml::RenderTheme::isPressed):
  • khtml/rendering/render_theme.h: (khtml::RenderTheme::controlSupportsTints):
  • khtml/rendering/render_theme_mac.h:
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::controlSupportsTints):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes):
  • kwq/KWQPainter.h: (QPainter::updatingControlTints): (QPainter::setUpdatingControlTints):
  • kwq/KWQPainter.mm: (QPainter::QPainter): (QPainter::initFocusRing): (QPainter::addFocusRingRect): (QPainter::drawFocusRing):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:]):
1:30 PM Changeset in webkit [9934] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Beth Dakin.

  • removed method -[WebHTMLRepresentation elementForView:], which was SPI used only for Safari autofill. Tip of tree Safari no longer includes any calls to this method. Also, Tiger Safari never gets around to actually calling it due to the other recent form-SPI-related changes, so removing this method doesn't break Tiger Safari running on tip of tree WebKit (though autofill continues to not work in that configuration).
  • WebView.subproj/WebHTMLRepresentation.h:
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation elementForView:]): removed

Jul 27, 2005:

10:15 PM Changeset in webkit [9933] by justing
  • 3 edits
    2 adds in trunk

Reviewed by ken

Fix for <rdar://problems/4038408&4154187&4125381&4125087>

Mail: Editing at the bottom of a quoted block makes the text blue in certain cases

Test cases added:

  • layout-tests/editing/deleting/delete-4038408-fix-expected.txt: Added.
  • layout-tests/editing/deleting/delete-4038408-fix.html: Added.
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::saveTypingStyleState): (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): (khtml::DeleteSelectionCommand::clearTransientState):
  • khtml/editing/delete_selection_command.h:
4:44 PM Changeset in webkit [9932] by ggaren
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Test cases added:

  • layout-tests/fast/js/toString-overrides-expected.txt: Added.
  • layout-tests/fast/js/toString-overrides.html: Added.
  • kjs/array_object.cpp: (ArrayProtoFuncImp::call):

WebCore:

Test cases added:

  • layout-tests/fast/js/toString-overrides-expected.txt: Added.
  • layout-tests/fast/js/toString-overrides.html: Added.
4:41 PM Changeset in webkit [9931] by bdakin
  • 3 edits
    2 adds in trunk

Fix submitted by: Andrew Wellington <​proton@wiretapped.net>
Reviewed by Beth Dakin.

This is a fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3406 and
<rdar://problem/3204011>. It does not solve all of the problems with
text-transform: capitalize, but it does fix some of the more notable
problems regarding apostrophes (like on amazon.com), and does not cause
any regressions (i.e., some things about text-transform are still wrong and some
of those things are wrong in different ways than they were wrong before, but
the patch does not seem to cause anything that was right to be newly
wrong.

Test cases added: another text-transform test, see below

  • khtml/xml/dom_stringimpl.cpp: Here is the fix. (DOM::DOMStringImpl::capitalize):
  • layout-tests/css1/text_properties/text-transCapitalize-expected.txt: Added. New test case.
  • layout-tests/css1/text_properties/text-transCapitalize.html: Added. New test case.
  • layout-tests/css1/text_properties/text_transform-expected.txt: New expected results...

here are some instances where things were wrong before but are
wrong in new ways now.

4:10 PM Changeset in webkit [9930] by ggaren
  • in /

file project.pbxproj was added on branch Safari-2-0-branch on 2005-07-29 23:23:35 +0000

4:10 PM Changeset in webkit [9929] by mjs
  • 12 edits in trunk/JavaScriptCore

Changes by Michael Kahl, reviewed by me.

  • fixed <rdar://problem/4194278> Need better debugging support in JavaScriptCore
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/debugger.cpp: (KJS::AttachedInterpreter::AttachedInterpreter): (KJS::AttachedInterpreter::~AttachedInterpreter): (Debugger::~Debugger): (Debugger::attach): (Debugger::detach): (Debugger::sourceParsed):
  • kjs/debugger.h:
  • kjs/function.cpp: (KJS::FunctionImp::call): (KJS::GlobalFuncImp::call):
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/grammar.y:
  • kjs/internal.cpp: (Parser::parse): (InterpreterImp::evaluate):
  • kjs/internal.h: (KJS::InterpreterImp::setDebugger):
  • kjs/interpreter.cpp:
  • kjs/interpreter.h: (KJS::Interpreter::imp):
  • kjs/nodes.cpp:
3:35 PM Changeset in webkit [9928] by sullivan
  • 2 edits in trunk/WebKit

Patch by Trey Matteson <​trey@usa.net>
Reviewed by me.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4169

scaling PDF view up leaves later HTML view scaled too

An additional step of separating scaling of HTML and PDF. If we do a zoom and there
are no docViews that track the common scaling factor, then don't change it. Thus in
the common PDF case where it is the only doc view, scaling the PDF does not affect
HTML pages loaded in the same window.

  • WebView.subproj/WebView.m: (-[WebView canMakeTextSmaller]): Pass 0 for new scaling factor, since we just querying. (-[WebView canMakeTextLarger]): Ditto. (-[WebView makeTextSmaller:]): Pass new scaling factor. (-[WebView makeTextLarger:]): Ditto. (-[WebView canMakeTextStandardSize]): Pass 0 for new scaling factor. (-[WebView makeTextStandardSize:]): Pass new scaling factor. (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]): The meat of the change is that this Swiss Army Knife also takes a new scaling factor, which it will set as the common scaling factor if it finds any doc views that are able to be scaled which track the common scaling factor.
2:36 PM Changeset in webkit [9927] by ggaren
  • in /

file project.pbxproj was added on branch Safari-2-0-branch on 2005-07-29 23:31:52 +0000

2:36 PM Changeset in webkit [9926] by sullivan
  • 14 edits in trunk/WebKit

Patch by Trey Matteson <​trey@usa.net>
Reviewed by me.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4015

PDF views should remember viewing mode, scroll position across back/forward
Note this doesn't work within frames because of a PDFKit bug - see 4164

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4091

PDF views should keep a separate scaling factor from shared text scaling factor

Basic idea #1 is that we now have a general mechanism for a WebDocView to save/restore some UI
state to the WebHistoryItem.
Basic idea #2 is that _WebDocumentTextSizing is expanded to allow for the case of a WebDocView
keeping its own notion of a scaling factor. WebPDFView's -_tracksCommonSizeFactor has justification.

  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem setViewState:]): New methods to hold PList of arbitrary WebView state (-[WebHistoryItem viewState]):
  • History.subproj/WebHistoryItemPrivate.h:
  • WebKit.xcodeproj/project.pbxproj: Add Quartz to framework path so we can import PDFKit files
  • WebView.subproj/WebDocumentInternal.h: New methods added to _WebDocumentTextSizing. Also the _ prefix is sufficient instead of _web_WebDocumentTextSizing. Added _WebDocumentViewState protocol.
  • WebView.subproj/WebFrame.m: (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Rename of save/restore methods. (-[WebFrame _detachFromParent]): Ditto (-[WebFrame _transitionToCommitted:]): Ditto (-[WebFrame _checkLoadCompleteForThisFrame]): Ditto (-[WebFrame _loadItem:withLoadType:]): Ditto (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): Ditto (-[WebFrame _saveViewStateToItem:]): Call doc view to retrieve view state. (-[WebFrame _restoreViewState]): Call doc view to set view state. (-[WebFrame _scrollToTop]): Nuked dead code. (-[WebFrame _textSizeMultiplierChanged]): This work now appears in WebView. (-[WebFrame _saveDocumentAndScrollState]): Same rename, one code cleanup. (-[WebFrame _accumulateDocumentViews:]): Add our docview to the array, call kids. (-[WebFrame _documentViews]): New helper to return all docviews. (-[WebFrame _didFirstLayout]): Same name change.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebHTMLView.m: Removed redundant category decl. (-[WebHTMLView _makeTextSmaller:]): Implement new protocol. (-[WebHTMLView _makeTextLarger:]): (-[WebHTMLView _makeTextStandardSize:]): (-[WebHTMLView _tracksCommonSizeFactor]):
  • WebView.subproj/WebPDFRepresentation.m: Tweak #imports.
  • WebView.subproj/WebPDFView.h:
  • WebView.subproj/WebPDFView.m: (-[WebPDFView _menuItemsFromPDFKitForEvent:]): No longer intercept context menu text sizing items. (-[WebPDFView setDataSource:]): No longer track the WebView's scaling factor. (-[WebPDFView scrollPoint]): Dig through PDFKit view tree to get real scroll position (-[WebPDFView setScrollPoint:]): Ditto (-[WebPDFView viewState]): Return bundle of viewing params (-[WebPDFView setViewState:]): Restore bundle of viewing params (-[WebPDFView _makeTextSmaller:]): Implement new text sizing protocol (-[WebPDFView _makeTextLarger:]): (-[WebPDFView _makeTextStandardSize:]): (-[WebPDFView _tracksCommonSizeFactor]): (-[WebPDFView _canMakeTextSmaller]): (-[WebPDFView _canMakeTextLarger]): (-[WebPDFView _canMakeTextStandardSize]):
  • WebView.subproj/WebTextView.m: (-[WebTextView _makeTextSmaller:]): Implement new text sizing protocol (-[WebTextView _makeTextLarger:]): (-[WebTextView _makeTextStandardSize:]): (-[WebTextView _tracksCommonSizeFactor]):
  • WebView.subproj/WebView.m: (-[WebView setTextSizeMultiplier:]): Calling docViews is now more complicates than just posting

a notification to the frame.

(-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:]): Workhorse

that sends the text sizing method to the right doc views.

(-[WebView canMakeTextSmaller]): Call workhorse.
(-[WebView canMakeTextLarger]): Ditto
(-[WebView makeTextSmaller:]): Ditto
(-[WebView makeTextLarger:]): Ditto
(-[WebView canMakeTextStandardSize]): Ditto
(-[WebView makeTextStandardSize:]): Ditto

2:08 PM Changeset in webkit [9925] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4161594> quadraticCurveTo() method in <canvas> APIs JS bindings does not exist

2005-06-29 Geoffrey Garen <​ggaren@apple.com>

Patch by Antoine Quint <​ml@graougraou.com>

-fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3648
quadraticCurveTo() method in <canvas> APIs JS bindings does not exist

Reviewed by Darin.

  • khtml/ecma/kjs_html.cpp:
12:54 PM Changeset in webkit [9924] by ggaren
  • 3 edits
    2 adds in trunk

JavaScriptCore:

  • Test cases added:
  • layout-tests/fast/js/date-big-setdate-expected.txt: Added.
  • layout-tests/fast/js/date-big-setdate.html: Added.

Reviewed by darin.

  • kjs/date_object.cpp: (DateProtoFuncImp::call):

WebCore:

Test cases added:

  • layout-tests/fast/js/date-big-setdate-expected.txt: Added.
  • layout-tests/fast/js/date-big-setdate.html: Added.
11:55 AM Changeset in webkit [9923] by hyatt
  • 3 edits in trunk/WebCore

Remove the "enforce a square size" rule for checkboxes. WinIE
doesn't do this, and I'm not sure where I came up with it.

Fix a bug in isFocusable that was causing disabled form
controls with no corresponding widget to still get focus!
(This bug affected my new checkbox but also <input type=image>
and the HTML4 button!)

Reviewed by ggaren

  • khtml/html/html_formimpl.cpp:
  • khtml/rendering/render_theme_mac.mm:
11:22 AM Changeset in webkit [9922] by ggaren
  • 6 edits
    2 adds in trunk

JavaScriptCore:

-rolled in patch by Carsten Guenther <​cguenther@gmail.com>
for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3759
Date object enhancements

Test cases added:

  • layout-tests/fast/js/date-preserve-milliseconds-expected.txt: Added.
  • layout-tests/fast/js/date-preserve-milliseconds.html: Added.

Reviewed by darin.

  • kjs/date_object.cpp: (timeFromArgs): (DateProtoFuncImp::call): (DateObjectImp::construct): (DateObjectFuncImp::call): (KJS::makeTime):
  • kjs/date_object.h:
  • tests/mozilla/expected.html:

WebCore:

-added testcase for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3759
Date object enhancements

Reviewed by darin.

Test cases added:

  • layout-tests/fast/js/date-preserve-milliseconds-expected.txt: Added.
  • layout-tests/fast/js/date-preserve-milliseconds.html: Added.
10:34 AM Changeset in webkit [9921] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-05-24 Richard Williamson <​rjw@apple.com>

Fixed <rdar://problem/4127061> <canvas> backing store should be zero filled

Use calloc instead of malloc to ensure zero filled backing store.

Reviewed by Darin.

  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::createDrawingContext):
Note: See TracTimeline for information about the timeline view.