⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 1, 2005:

5:51 PM Changeset in webkit [10003] by ggaren
  • 3 edits
    2 adds in trunk

WebCore:

-landed layout tests for fix to <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Fix reviewed by darin.

Test cases added:

  • manual-tests/open-after-close.html: Added.
  • manual-tests/resources/open-after-close-popup.html: Added.

WebKit:

-fixed <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Reviewed by darin.

Test cases added:

  • manual-tests/open-after-close.html: Added.
  • manual-tests/resources/open-after-close-popup.html: Added.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): We now remove a WebView from WebViewSets when the WebView is *scheduled* to close.
4:56 PM Changeset in webkit [10002] by ggaren
  • 6 edits in branches/Safari-2-0-branch

Updating projects and make files for XCode 2.1.

3:23 PM Changeset in webkit [10001] by hyatt
  • 1 edit in trunk/WebCore/khtml/rendering/render_theme_mac.h

Forgot to commit part of my previous patch.

2:31 PM Changeset in webkit [10000] by sullivan
  • 2 edits in trunk/WebKit
  • PublicHeaderChangesFromTiger.txt: added a comment about isTextField -> _isTextField
2:23 PM Changeset in webkit [9999] by hyatt
  • 4 edits in trunk/WebCore

Fix bugzilla bug 4219, crash because we tried to do the fake paint
when layout was not updated yet.

Also landing accessibility for checkboxes.

Reviewed by darin/mjs (accessibility), kocienda(crash)

  • ChangeLog:
  • khtml/rendering/render_theme.h: (khtml::RenderTheme::supportsControlTints):
  • kwq/KWQAccObject.mm: (-[KWQAccObject actionElement]): (-[KWQAccObject role]): (-[KWQAccObject roleDescription]): (-[KWQAccObject value]): (boundingBoxRect): (-[KWQAccObject accessibilityIsIgnored]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityIsAttributeSettable:]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes):
2:19 PM Changeset in webkit [9998] by sullivan
  • 2 edits in trunk/WebKit

Patch by Trey Matteson <​trey@usa.net>
Reviewed by me.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4255

underlines still print too thick

The real problem here is that we have code that scales a 0 width line to always
be width=1.0 in device space. I'm leaving that in for the screen, but when printing
a width of 0.5 looks good.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
12:11 PM Changeset in webkit [9997] by eseidel
  • 2 edits in trunk/WebKit

Bug #: 4211
Submitted by: eseidel
Reviewed by: darin

10:50 AM Changeset in webkit [9996] by sullivan
  • 8 edits in trunk/WebKit

Patch by Trey Matteson <​trey@usa.net>
Reviewed by me.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4014

PDF files by default load with a poor choice of sizing

For now the various PDF viewing settings are sticky, stored in 2 new defaults. Since
there are a number of ways these settings are changed, I made a proxy for the PDFView
through which all view changing messages are sent. The proxy adds the behavior of
updating the defaults upon any change.

  • Misc.subproj/WebNSDictionaryExtras.h:
  • Misc.subproj/WebNSDictionaryExtras.m: (-[NSMutableDictionary _webkit_setFloat:forKey:]): New support method.
  • WebView.subproj/WebPDFView.h:
  • WebView.subproj/WebPDFView.m: (-[WebPDFView initWithFrame:]): Create proxy for PDFView. (-[WebPDFView dealloc]): Free proxy. (-[WebPDFView _menuItemsFromPDFKitForEvent:]): For relevant context menu items, set the

target to the proxy instead of the PDFView.

(-[WebPDFView _readPDFDefaults]): Init PDFView with settings from defaults.
(-[WebPDFView layout]): Call _readPDFDefaults, once. This turned out to be the best hook.
(-[WebPDFView _makeTextSmaller:]): Change PDFView via proxy
(-[WebPDFView _makeTextLarger:]): Ditto
(-[WebPDFView _makeTextStandardSize:]): Ditto
(-[PDFPrefUpdatingProxy initWithView:]): trivial
(-[PDFPrefUpdatingProxy forwardInvocation:]): Forward the msg, then update defaults
(-[PDFPrefUpdatingProxy methodSignatureForSelector:]): Simple forwarding support.

  • WebView.subproj/WebPreferenceKeysPrivate.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): Set initial values for new PDF viewing defaults. (-[WebPreferences _integerValueForKey:]): Nuke stray comment. (-[WebPreferences _floatValueForKey:]): New simple support method. (-[WebPreferences _setFloatValue:forKey:]): Ditto. (-[WebPreferences PDFScaleFactor]): 4 accessors for new defaults (-[WebPreferences setPDFScaleFactor:]): (-[WebPreferences PDFDisplayMode]): (-[WebPreferences setPDFDisplayMode:]):
  • WebView.subproj/WebPreferencesPrivate.h:
9:19 AM Changeset in webkit [9995] by justing
  • 2 edits in trunk/WebKit

Patch by Trey Matteson <​trey@usa.net>

Reviewed by Maciej.

Fixed <​http://bugzilla.opendarwin.org/show_bug.cgi?id=4226>

link underlines print too thickly

Reinstate the fix made by sullivan on 1/11/05. There was a merge
error with an mjs fix on 1/13/05.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
9:12 AM Changeset in webkit [9994] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Beth Dakin.

Test cases added: none, this only affects Safari forms autofill

Moved the recently-added isTextField method out of the public DOMExtensions.h
and into the private DOMPrivate.h for now, and renamed it with a leading
underscore. We want to make some sort of public API that covers this, but not
necessarily this exact method, so we'll leave it out of the public API until we've
thought about this more.

  • kwq/DOMExtensions.h: remove isTextField
  • kwq/DOMPrivate.h: add _isTextField. Also added some #imports that make this file more standalone.
  • kwq/DOMHTML.mm: (-[DOMHTMLInputElement _isTextField]): moved this method and added leading underscore.
2:06 AM Changeset in webkit [9993] by eseidel
  • 8 edits in trunk/WebCore

Bug #: 4211
Submitted by: eseidel
Reviewed by: darin

  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (getSharedContext): moved from QPainter -> CG
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (CGShadingRefForLinearGradient): removed comment (CGShadingRefForRadialGradient): removed comment
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::call): moved from QPainter -> CG (KJS::colorRefFromValue): moved from QPainter -> CG (KJS::Gradient::getShading): moved from QPainter -> CG
  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::createDrawingContext):moved from QPainter -> CG
  • kwq/KWQColor.mm: (CGColorFromNSColor): moved from QPainter -> CG
  • kwq/KWQPainter.h: removed colorspace calls
  • kwq/KWQPainter.mm: removed colorspace calls (QPainter::clearFocusRing): moved from QPainter -> CG Removed use of WebKitGraphicsBridge Colorspace SPIs, as well as corresponding QPainter colorspace "choke-point" methods. This fixes colors for WebCore+SVG (since it wasn't linking in webkit). WebKit code removal in separate commit. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4211

Jul 31, 2005:

10:02 PM Changeset in webkit [9992] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • remove uses of Mac-OS-X-specific MAX macro
  • remove one of the many excess "APPLE_CHANGES" ifdefs
  • kjs/collector.cpp: (KJS::Collector::allocate): Use std::max instead of MAX.
  • kjs/property_map.cpp: (KJS::PropertyMap::rehash): Ditto.
  • kjs/ustring.cpp: (KJS::UChar::toLower): Take out non-ICU code path. (KJS::UChar::toUpper): Ditto. (KJS::UString::spliceSubstringsWithSeparators): Use std::max instead of MAX.
9:31 PM Changeset in webkit [9991] by darin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • remove uses of Mac-OS-X-specific MAX macro in non-Mac-OS-X-specific code
  • khtml/misc/arena.cpp: (ArenaAllocate): Use std::max instead of MAX.
  • khtml/misc/loader.cpp: (Cache::setSize): Use kMax instead of MAX.
  • khtml/rendering/render_form.cpp: (RenderLineEdit::setSelectionStart): Ditto. (RenderLineEdit::setSelectionEnd): Ditto. (RenderLineEdit::setSelectionRange): Ditto.
8:25 PM Changeset in webkit [9990] by hyatt
  • 3 edits in trunk/WebCore

No editor working

8:20 PM Changeset in webkit [9989] by justing
  • 2 edits
    2 adds in trunk

Reviewed by mjs

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=3359> Crash on hover with certain styles on the text applied

If a zero length render object (such as a text node that has been set to "") occured at the
end of a line, it was previously given a non-zero sized run. Iteration over such a node would cause
a crash.

Test cases added:

  • layout-tests/traversal/size-zero-run-expected.txt: Added.
  • layout-tests/traversal/size-zero-run.html: Added.
  • khtml/rendering/bidi.cpp: (khtml::appendRun):
6:58 PM Changeset in webkit [9988] by darin
  • 3 edits in trunk/WebKitTools
  • a little tools cleanup
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Moved options from target to project as a whole. Removed unused Default configuration.
  • Scripts/check-dom-results: Added license header, comment to explain purpose of tool.
6:56 PM Changeset in webkit [9987] by justing
  • in /

file delete-br-011-expected.txt was added on branch Safari-2-0-branch on 2005-08-04 02:37:36 +0000

6:56 PM Changeset in webkit [9986] by darin
  • 299 edits in trunk/LayoutTests

Update results for change in DumpRenderTree tool to log editing
delegate method calls.

6:56 PM Changeset in webkit [9985] by justing
  • in /

file delete-4038408-fix-expected.txt was added on branch Safari-2-0-branch on 2005-08-04 02:04:17 +0000

6:55 PM Changeset in webkit [9984] by darin
  • 2 edits in trunk/WebKitTools

Reviewed and landed by Darin Adler.

Add logging of editing delegate calls for regression checking.

  • DumpRenderTree/DumpRenderTree.m: (main): setup editing delegate

(-[DOMNode dumpPath]):
(-[DOMRange dump]):

utility for editing delegate logging

(-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
(-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
(-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
(-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
(-[EditingDelegate webView:shouldDeleteDOMRange:]):
(-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
(-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
(-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
(-[EditingDelegate webViewDidBeginEditing:]):
(-[EditingDelegate webViewDidChange:]):
(-[EditingDelegate webViewDidEndEditing:]):
(-[EditingDelegate webViewDidChangeTypingStyle:]):

log corresponding editing delegate methods

(-[EditingDelegate webViewDidChangeSelection:]):

log selection except when clearing selection after end of test (uses existing "done" flag)

(dumpRenderTree):

added clearing of selection after test

1:02 PM Changeset in webkit [9983] by eseidel
  • 2 edits
    4 adds in trunk/WebKitTools

Bug #: 4208
Submitted by: eseidel
Reviewed by: hyatt

12:51 PM Changeset in webkit [9982] by eseidel
  • 6 edits
    1 add in trunk

Bug #: 4234
Submitted by: eseidel
Reviewed by: hyatt

  • WebCore-svg.exp: Added.
  • WebCore.xcodeproj/project.pbxproj: Uses WebCore+SVG.exp
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEFloodQuartz::getCIFilter): Fixed longjmp warning.
  • kdom/css/impl/CSSStyleSelector.cpp: (CSSStyleSelector::applyRule): Fixed "un-initialized" warning.
  • kdom/ecma/DOMLookup.h: Removed <iostream>
  • ksvg2/impl/svgpathparser.cpp: Removed <iostream> Several fixes required to make Deployment style builds compile correctly. Also WebCore-svg.exp symbols were added both when generating WebCore-combined.exp as well as for generating a new WebCore+SVG.exp export file for the Deployment style builds, allowing DrawTest to link properly. A few other small warnings were caught and fixed. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4234
Note: See TracTimeline for information about the timeline view.