Context Navigation

khtml/xml/dom_elementimpl.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoView): Added.
khtml/ecma/kjs_dom.h: (KJS::DOMNode::): (KJS::DOMElement::):
khtml/ecma/kjs_dom.cpp: (KJS::DOMElementProtoFunc::tryCall): glue for new scrollIntoView function

(these two files were modified on the branch only, not required in TOT fix)

khtml/dom/dom_element.cpp: (Element::scrollIntoView):
khtml/dom/dom_element.h:

5:40 PM Changeset in webkit [10028] by rjw

1 edit in trunk/JavaScriptCore/bindings/objc/objc_class.mm

Submitted by: rjw@apple.com
Reviewed by: cblu@apple.com
Fixed hard capacity limit on the method and field cache use for the ObjC bindings.

<rdar://problem/4204416> Dashboard client crashes when too many ObjC methods are called

2:49 PM Changeset in webkit [10027] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT. Also fixes:
<rdar://problem/4077814> Gradual slowing down of Safari eventually requiring Quit and relaunch

2005-07-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dave Hyatt.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4153

WebView.subproj/WebFrame.m: (-[WebFrame _purgePageCache]): Find the oldest candidate for purging that is not a snapback item.

2:23 PM Changeset in webkit [10026] by vicki

2 edits
1 add in trunk/WebCore

Reviewed by Beth and Hyatt.

<rdar://problem/4196646> target returns text node when it should return the parent node

Test cases added: manual-tests/mouseevents-on-textnodes.html

khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): if the targetNode is a text node, set the targetNode to the parent node

1:55 PM Changeset in webkit [10025] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4128727> many DOM classes not exported (can't add categories or do other things that require class name linking)

WebCore-combined.exp:
WebCore.exp:

9:47 AM Changeset in webkit [10024] by bdakin

3 edits in trunk/WebKit

Reviewed by cblu

Removing calls to WKCreateUncorrectedRGBColorSpace and
WKCreateUncorrectedGrayColorSpace in WebKit to patch up
TOT...Eric removed them from WebCore last night.

WebCoreSupport.subproj/WebImageData.m:
WebCoreSupport.subproj/WebImageRenderer.m: (WebCGColorSpaceCreateRGB): (WebCGColorSpaceCreateGray):

Aug 2, 2005:

5:07 PM Changeset in webkit [10023] by bdibello

1 edit
4 adds in trunk

Reviewed by Geoffrey Garen.

Test cases added: getting and setting button.value

layout-tests/fast/dom/HTMLButtonElement/value/getset-expected.txt: Added.
layout-tests/fast/dom/HTMLButtonElement/value/getset.html: Added.

5:02 PM Changeset in webkit [10022] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-29 Geoffrey Garen <ggaren@apple.com>

fixed: <rdar://problem/3461547> can't use document.writeln() on windows opened via window.open("about:blank") in same function <rdar://problem/3725977> A_WINDOW.document.write() content overwritten when first parameter to window.open is provided <rdar://problem/4101498> SAP: window.write in same call chain as window.open fails to write if URL parameter is provided <rdar://problem/4179028> document.write in same function as window.open fails to write new content (4056) http://bugzilla.opendarwin.org/show_bug.cgi?id=4056 document.write in same function as window.open fails to write new content

Reviewed by darin.

Test cases added:

manual-tests/resources/write-after-open-popup.html: Added.

khtml/khtml_part.cpp: (KHTMLPart::didExplicitOpen): now cancels any pending redirection

4:10 PM Changeset in webkit [10021] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-14 Justin Garcia <justin.garcia@apple.com>

Patch by Anders Carlsson and justin

Reviewed by mjs

Fixes the following related bugs:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3298> insertRow generates DOM Exception if TABLE does not possess a TBODY
<rdar://problem/4045213> insertRow fails on a <table> that has no <tbody> but does have other children in the DOM
<rdar://problem/3609576> insertRow() on table object containing any characters but no TR & TD elements fails (3476)

Does a better job of maintaining the firstBody variable so that it's not invalidated on .innerHTML = ""
Better check for when to add an implicit tbody to hold the inserted row.

Test cases added: (NONE)

layout-tests/fast/dom/HTMLTableElement/insert-row-expected.txt: Added.
layout-tests/fast/dom/HTMLTableElement/insert-row.html: Added.

khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::~HTMLTableElementImpl): (DOM::HTMLTableElementImpl::setTBody): (DOM::HTMLTableElementImpl::insertRow): (DOM::HTMLTableElementImpl::addChild): (DOM::HTMLTableElementImpl::childrenChanged):
khtml/html/html_tableimpl.h:

4:06 PM Changeset in webkit [10020] by ggaren

2 edits in branches/Safari-2-0-branch/JavaScriptCore

minor tweak to last checkin

kjs/debugger.h: restored a comment I shouldn't have deleted

3:50 PM Changeset in webkit [10019] by ggaren

14 edits
7 adds in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch

mjs 05/07/29 20:00:34

Changes by Michael Kahl, reviewed by me.

Test cases added: No tests, this code only affects debugging.

fixed <rdar://problem/4164112> MASTER: JavaScript debugging support

WebCore-combined.exp:
WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
kwq/WebCoreScriptDebugger.h: Added.
kwq/WebCoreScriptDebugger.mm: Added. (toNSString): (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): (WebCoreScriptDebuggerImp::sourceParsed): (WebCoreScriptDebuggerImp::callEvent): (WebCoreScriptDebuggerImp::atStatement): (WebCoreScriptDebuggerImp::returnEvent): (-[WebCoreScriptDebugger initWithDelegate:]): (-[WebCoreScriptDebugger dealloc]): (-[WebCoreScriptDebugger delegate]): (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]): (-[WebCoreScriptCallFrame _setWrapper:]): (-[WebCoreScriptCallFrame _convertValueToObjcValue:]): (-[WebCoreScriptCallFrame dealloc]): (-[WebCoreScriptCallFrame wrapper]): (-[WebCoreScriptCallFrame caller]): (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame exception]): (-[WebCoreScriptCallFrame evaluateWebScript:]):

WebKit:

Merged fix from TOT to Safari-2-0-branch

mjs 05/07/29 20:00:34

Changes by Michael Kahl, reviewed by me.

Test cases added: No tests, this code only affects debugging.

fixed <rdar://problem/4164112> MASTER: JavaScript debugging support

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge windowObjectCleared]):
WebCoreSupport.subproj/WebSubresourceLoader.m:
WebKit.xcodeproj/project.pbxproj:
WebView.subproj/WebDefaultScriptDebugDelegate.h: Added.
WebView.subproj/WebDefaultScriptDebugDelegate.m: Added. (+[WebDefaultScriptDebugDelegate sharedScriptDebugDelegate]): (-[WebDefaultScriptDebugDelegate webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebDefaultScriptDebugDelegate webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
WebView.subproj/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _attachScriptDebugger]):
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebScriptDebugDelegate.h: Added.
WebView.subproj/WebScriptDebugDelegate.m: Added. (-[WebScriptDebugger initWithWebFrame:]): (-[WebScriptDebugger dealloc]): (-[WebScriptDebugger globalObject]): (-[WebScriptDebugger newWrapperForFrame:]): (-[WebScriptDebugger parsedSource:fromURL:sourceId:]): (-[WebScriptDebugger enteredFrame:sourceId:line:]): (-[WebScriptDebugger hitStatement:sourceId:line:]): (-[WebScriptDebugger leavingFrame:sourceId:line:]): (-[WebScriptCallFrame _initWithFrame:]): (-[WebScriptCallFrame dealloc]): (-[WebScriptCallFrame setUserInfo:]): (-[WebScriptCallFrame userInfo]): (-[WebScriptCallFrame caller]): (-[WebScriptCallFrame scopeChain]): (-[WebScriptCallFrame functionName]): (-[WebScriptCallFrame exception]): (-[WebScriptCallFrame evaluateWebScript:]):
WebView.subproj/WebScriptDebugDelegatePrivate.h: Added.
WebView.subproj/WebView.h:
WebView.subproj/WebView.m: (-[WebViewPrivate dealloc]): (-[WebView _scriptDebugDelegateForwarder]): (-[WebView setScriptDebugDelegate:]): (-[WebView scriptDebugDelegate]):
WebView.subproj/WebViewInternal.h:
WebView.subproj/WebViewPrivate.h:

3:23 PM Changeset in webkit [10018] by adele

2 edits in branches/Safari-2-0-branch/WebCore

small change to fix build bustage.

khtml/ecma/kjs_binding.h: use '.' instead of '->'. On the branch, self returns an Object instead of an ObjectImp *

2:39 PM Changeset in webkit [10017] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-25 Vicki Murley <vicki@apple.com>

Reviewed by Beth Dakin.

fixed <rdar://problem/4011544> selecting an item from a <select> menu with the mouse doesn't place the focus on the menu

Test cases added:

manual-tests/focus-select-when-clicked.html: Added.

kwq/KWQComboBox.mm: (-[KWQPopUpButton needsPanelToBecomeKey]): override this NSView method to return YES

2:35 PM Changeset in webkit [10016] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-06-29 Anders Carlsson <andersca@mac.com>

Reviewed and landed by Darin Adler.

Fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=3274> document() not supported

Test cases added:

layout-tests/fast/xsl/document-function-expected.txt: Added.
layout-tests/fast/xsl/document-function.xml: Added.
layout-tests/fast/xsl/document-function.xsl: Added.
layout-tests/fast/xsl/resources/document-function-source.xml: Added.

khtml/xsl/xslt_processorimpl.cpp: (DOM::parseErrorFunc): Stub to prevent errors from getting written to the console.

(DOM::stylesheetLoadFunc):
Fetch and parse documents.

(DOM::XSLTProcessorImpl::transformDocument):
Use the processor as the global variable instead of the
style sheet.

khtml/xsl/xslt_processorimpl.h: (DOM::XSLTProcessorImpl::stylesheet): (DOM::XSLTProcessorImpl::sourceDocument): Add accessors for source document and stylesheet.

2:26 PM Changeset in webkit [10015] by adele

27 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merged from TOT to Safari-2-0-branch.

2005-07-27 Maciej Stachowiak <mjs@apple.com>

Changes by Michael Kahl, reviewed by me.

fixed <rdar://problem/4194278> Need better debugging support in JavaScriptCore

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/debugger.cpp: (KJS::AttachedInterpreter::AttachedInterpreter): (KJS::AttachedInterpreter::~AttachedInterpreter): (Debugger::~Debugger): (Debugger::attach): (Debugger::detach): (Debugger::sourceParsed):
kjs/debugger.h:
kjs/function.cpp: (KJS::FunctionImp::call): (KJS::GlobalFuncImp::call):
kjs/function_object.cpp: (FunctionObjectImp::construct):
kjs/grammar.y:
kjs/internal.cpp: (Parser::parse): (InterpreterImp::evaluate):
kjs/internal.h: (KJS::InterpreterImp::setDebugger):
kjs/interpreter.cpp:
kjs/interpreter.h: (KJS::Interpreter::imp):
kjs/nodes.cpp:

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-07-03 Maciej Stachowiak <mjs@apple.com>

Original patch from Mark Rowe <opendarwin.org@bdash.net.nz>, reviewed by me.
Fixes to patch by me, reviewed by John Sullivan.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3293

Test cases added:

layout-tests/fast/js/has-own-property.html: Added - tests this change.
layout-tests/fast/js/eval-var-decl.html: Added - test depends on this change.

khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::hasOwnProperty):
khtml/ecma/kjs_css.h:
khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::hasOwnProperty): (KJS::DOMElement::tryGet): (KJS::DOMNamedNodeMap::hasOwnProperty):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::hasOwnProperty): (KJS::HTMLDocument::tryGet): (KJS::KJS::HTMLElement::hasOwnProperty): (KJS::KJS::HTMLCollection::hasOwnProperty):
khtml/ecma/kjs_html.h:
khtml/ecma/kjs_window.cpp: (KJS::Window::hasOwnProperty): (KJS::Konqueror::hasOwnProperty):
khtml/ecma/kjs_window.h:

1:39 PM Changeset in webkit [10014] by ggaren

13 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged from TOT to Safari-2-0-branch.

2005-07-27 Maciej Stachowiak <mjs@apple.com>

Changes by Michael Kahl, reviewed by me.

fixed <rdar://problem/4194278> Need better debugging support in JavaScriptCore

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/debugger.cpp: (KJS::AttachedInterpreter::AttachedInterpreter): (KJS::AttachedInterpreter::~AttachedInterpreter): (Debugger::~Debugger): (Debugger::attach): (Debugger::detach): (Debugger::sourceParsed):
kjs/debugger.h:
kjs/function.cpp: (KJS::FunctionImp::call): (KJS::GlobalFuncImp::call):
kjs/function_object.cpp: (FunctionObjectImp::construct):
kjs/grammar.y:
kjs/internal.cpp: (Parser::parse): (InterpreterImp::evaluate):
kjs/internal.h: (KJS::InterpreterImp::setDebugger):
kjs/interpreter.cpp:
kjs/interpreter.h: (KJS::Interpreter::imp):
kjs/nodes.cpp:

1:36 PM Changeset in webkit [10013] by ggaren

6 adds
1 delete in /

fixed build failure on Safari-2-0-branch

DumpRenderTree/DumpRenderTree.xcodeproj/.cvsignore: Added.
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added.
DumpRenderTree/project.pbxproj: Removed.

1:28 PM Changeset in webkit [10012] by hyatt

13 edits
3 deletes in trunk

landed layout tests for fix to <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Fix reviewed by darin.

Test cases added:

manual-tests/open-after-close.html: Added.
manual-tests/resources/open-after-close-popup.html: Added.

10:28 AM Changeset in webkit [10011] by ggaren

1 edit in trunk/WebKit/ChangeLog

Fixed Changelog entry.

10:26 AM Changeset in webkit [10010] by ggaren

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fixed last Changelog entry.

10:19 AM Changeset in webkit [10009] by ggaren

1 edit in trunk/WebKit/ChangeLog

Fixing previous Changelog entry.

10:14 AM Changeset in webkit [10008] by sullivan

4 edits in trunk/WebKit

Reviewed by Darin Adler.

Preemptively moved some WebMenuItemTag values from SPI to API, in anticipation of
approval from macosx-api-reviewers. Retitled one of them in response to API reviewers feedback:
WebMenuItemSearchInGoogle -> WebMenuItemSearchWeb

Note that as a side effect of this change, the actual numbers used for these WebMenuItemTags has
changed from what it was in Tiger. This causes "Search in Spotlight", "Search in Google", and
"Look Up in Dictionary" to not appear in Tiger Safari if running on tip of tree WebKit.

WebView.subproj/WebUIDelegatePrivate.h: removed WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchInGoogle, and WebMenuItemTagLookUpInDictionary

WebView.subproj/WebUIDelegate.h: added WebMenuItemTagSearchInSpotlight, WebMenuItemTagSearchWeb, and WebMenuItemTagLookUpInDictionary

WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): updated for rename (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): ditto (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): ditto

9:58 AM Changeset in webkit [10007] by adele

4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-05-20 Chris Blumenberg <cblu@apple.com>

Fixed: <rdar://problem/4098786> sync. XMLHttpRequest works w/o AllowNetworkAccess key because load delegate is not consulted

Synchronous loads did not cause the willSendRequest method on the resource load delegate to be called. This is the method that Dashboard uses to enforce AllowNetworkAccess and this must be called to avoid exploits.

Reviewed by sullivan.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:] so synthetic resource load delegate methods are called and the data is saved as a WebResource for resources in the WebCore cache.

(-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): call [WebFrame _requestFromDelegateForRequest:identifier:error:],
respect its result, do the load and then call [WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]
for synchronous loads

WebView.subproj/WebFrame.m: (-[WebFrame _opened]): call [WebFrame _requestFromDelegateForRequest:identifier:error:] then [WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:] so synthetic resource load delegate methods are called for subresrources in the page cache

(-[WebFrame _requestFromDelegateForRequest:identifier:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
This method calls identifierForInitialRequest and willSendRequest.

(-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): new, was part of the removed _sendResourceLoadDelegateMessagesForURL:::
This method calls the remaining resource load delegate messages.

(-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]): new, saves the resource and calls
[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]

WebView.subproj/WebFrameInternal.h:

9:52 AM Changeset in webkit [10006] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-08 Vicki Murley <vicki@apple.com>

fixed by Trey Matteson <trey@usa.net>, reviewed by Maciej.

Test cases added: (NONE)

<rdar://problem/4109893> REGRESSION: back/forward broken at wsj.com, worked in v185
Also written as http://bugzilla.opendarwin.org/show_bug.cgi?id=3901

Broken by security fix for 4005575: Arbitrary file disclosure vulnerability due to ability to load local html from remote content

The root of this bug is that URLs for subframes of a page are sometimes added to the back/forward list. This happens a lot at
wsj.com, and I believe it would happen for many or all sites that use JS to cons up a URL for an iframe and then load it.

The security fix changed the code path to go through openURLRequest, but only openURL had the logic to guess if
the current navigation was done in response to a user gesture. openURLRequest always assumed it was a user gesture,
and thus all uses of this code path would place an item in the b/f list.

kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::userGestureHint): Factored code from openURL. (KWQKHTMLPart::openURL): Call newly factored code. (KWQKHTMLPart::openURLRequest): Newly call newly factored code.

9:47 AM Changeset in webkit [10005] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-28 Beth Dakin <Beth Dakin>

This is a fix for <rdar://problem/4190684>. Hyatt and I
(okay, mostly Hyatt) wrote this for Cayenne so that they
can change the value of a style of a rule and have everything
update dynamically without causing a crash.

Reviewed by Hyatt

Test cases added: (NONE)

khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::setChanged):

9:39 AM Changeset in webkit [10004] by adele

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged from TOT to Safari-2-0-branch.

2005-06-30 Kevin Decker <kdecker@apple.com>

Reviewed by rjw.

fixed: <rdar://problem/4166838> failed assertion in`Interpreter::lockCount() > 0

no layout test added; this is in the bindings code.

bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): make sure to lock and unlock the interpreter around allocations.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed