Context Navigation

← Previous Period
Next Period →

Timeline

Aug 11, 2005:

6:53 PM Changeset in webkit [10147] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-08-11 Beth Dakin <Beth Dakin>

Reviewed by Vicki

This is a fix for <rdar://problem/4141161> REGRESSION (Tiger): WebKit does not display in composited Carbon windows.
I basically did what Troy suggests in his bug comments, and everything seems to work fine!

Carbon.subproj/HIViewAdapter.m: (-[HIViewAdapter setNeedsDisplayInRect:]):

6:35 PM Changeset in webkit [10146] by adele

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-11 Adele Peterson <adele@apple.com>

Reviewed by Darin.

Test cases added: (NONE)

-fixed <rdar://problem/4166839> CSS font-family and font-size ignored on <select> element with size > 1

Changed KWQListBox to get the font from the widget.

kwq/KWQListBox.h: added setFont method
kwq/KWQListBox.mm: (QListBox::setFont): Added. (QListBox::sizeForNumberOfLines): if the new font is the same as the system font, use the old system for cacheing the text renderer. Otherwise, create a text renderer based on the new font, and a bold version of the new font. (-[KWQTableView drawRow:clipRect:]): ditto. (-[KWQTableView initWithListBox:]): moved setRowHeight call to fontChanged, so the height will reflect the new font. (-[KWQTableView fontChanged]): Added.

6:30 PM Changeset in webkit [10145] by adele

3 edits in trunk/WebCore

Reviewed by Darin.

Test cases added: (NONE)

-fixed <rdar://problem/4166839> CSS font-family and font-size ignored on <select> element with size > 1

Changed KWQListBox to get the font from the widget.

kwq/KWQListBox.h: added setFont method
kwq/KWQListBox.mm: (QListBox::setFont): Added. (QListBox::sizeForNumberOfLines): if the new font is the same as the system font, use the old system for cacheing the text renderer. Otherwise, create a text renderer based on the new font, and a bold version of the new font. (-[KWQTableView drawRow:clipRect:]): ditto. (-[KWQTableView initWithListBox:]): moved setRowHeight call to fontChanged, so the height will reflect the new font. (-[KWQTableView fontChanged]): Added.

4:10 PM Changeset in webkit [10144] by bdakin

2 edits in trunk/WebKit

Reviewed by Vicki

This is a fix for <rdar://problem/4141161> REGRESSION (Tiger): WebKit does not display in composited Carbon windows.
I basically did what Troy suggests in his bug comments, and everything seems to work fine!

Carbon.subproj/HIViewAdapter.m: (-[HIViewAdapter setNeedsDisplayInRect:]):

2:37 PM Changeset in webkit [10143] by hyatt

2 edits
2 adds in trunk

Refine the baseline alignment rule for inline blocks to cover for a hole in the spec. The spec doesnt say what to do
for overflow cases, e.g., when the last line is clipped, when the overflow box is scrolled, or even when overflow is
visible but the last line is outside your content box. We just revert to the old behavior in those cases. Hopefully
the spec will be clarified to explain what the right behavior is.

Reviewed by beth

Test cases added: fast/inline-block/tricky-baseline.html

khtml/rendering/render_block.cpp: (khtml::RenderBlock::baselinePosition):

1:57 PM Changeset in webkit [10142] by mjs

1 edit
1 add in trunk/JavaScriptCore

added missing file from earlier checkin

kjs/grammar_types.h: Added. (KJS::makeNodePair): (KJS::makeNodeWithIdent):

11:58 AM Changeset in webkit [10141] by eseidel

4 edits in trunk/WebCore

Bug #: 4384
Submitted by: eseidel
Reviewed by: darin

WebCore+SVG/DrawView.mm: (-[DrawViewPrivate drawRect:]): added additional NULL check.
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): removed NSLog.
kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw): removed NSLog. Removed debugging logs, and fixed crasher for empty SVGs. http://bugzilla.opendarwin.org/show_bug.cgi?id=4384

10:40 AM Changeset in webkit [10140] by ggaren

2 edits in trunk

layout-tests/fast/js/date-big-setdate.html: fixed title

4:58 AM Changeset in webkit [10139] by eseidel

2 edits in trunk/WebKitTools

Bug #: 4385
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel

DrawTest/TestController.m: (-[TestController imagePathForSVGPath:]): Fixed support for using TextViewer with the layout-tests. http://bugzilla.opendarwin.org/show_bug.cgi?id=4385

4:35 AM Changeset in webkit [10138] by eseidel

903 edits in trunk

Bug #: 4382
Submitted by: eseidel

No review needed, copyright update in comments.
All kdom, ksvg2, and kcanvas files affected.
http://bugzilla.opendarwin.org/show_bug.cgi?id=4382

3:57 AM Changeset in webkit [10137] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

kjs/date_object.cpp: (timetUsingCF): Fix one of the date tests my making the CF version of mktime have the same quirk about the DST field as the real mktime.
tests/mozilla/expected.html: Updated for newly fixed test.

3:34 AM Changeset in webkit [10136] by mjs

2 edits in trunk/JavaScriptCore

updated for one of the tests that Darin incidentally fixed.

tests/mozilla/expected.html:

3:26 AM Changeset in webkit [10135] by mjs

8 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

Refactor assignment grammar to avoid Reference type, and to later
be able to take advantage of writeable PropertySlots, when those
are added. I also fixed a minor bug, turning a function to a
string lost parentheses, I made sure they are printed at least
where semantically significant.

Test cases: see WebCore

kjs/grammar.y: Change grammar so that assignment expressions are parsed directly to nodes that know how to set the kind of location being assigned, instead of having a generic assign node that counts on evaluateReference.
kjs/lexer.cpp: Include grammar_types.h.
kjs/nodes.cpp: (BracketAccessorNode): Renamed from AccessorNode1 for clarity. (DotAccessorNode): Renamed from AccessorNode2 for clarity. (combineForAssignment): Inline function for doing the proper kind of operation for various update assignments like += or *=. (AssignResolveNode): Node that handles assignment to a bare identifier. (AssignDotNode): Node that handles assignments of the form EXPR . IDENT = EXPR (AssignBracketNode): EXPR [ IDENT ] = EXPR
kjs/nodes.h: Updated for declarations/renames of new classes.
kjs/nodes2string.cpp: (GroupNode::streamTo): Fixed to print parens around the expression. (BracketAccessorNode::streamTo): Renamed. (DotAccessorNode::streamTo): Renamed. (AssignResolveNode::streamTo): Added. (AssignBracketNode::streamTo): Added. (AssignDotNode::streamTo): Added. (streamAssignmentOperatorTo): helper function for the above
kjs/property_slot.h: (KJS::PropertySlot::isSet): Made this const.

WebCore:

Reviewed by Geoff.

Test cases added:

layout-tests/fast/js/assign.html: Added. Test case for assignment to make sure I didn't break anything.
layout-tests/fast/js/code-serialize-paren.html: Added, test case for a minor bug I fixed where parens were not getting serialized at all when turning a function into a string.

2:39 AM Changeset in webkit [10134] by mjs

10 edits in trunk

WebCore:

At Least Rougly Glanced At by Anders.

fix change with totally breaks the layout tests.

Changed all the tests below to avoid dumping more than once -
since this now prints more than one separator, it totally throws
off the layout test driver so it needs to be avoided.

layout-tests/dom/html/level2/html/HTMLFormElement10-expected.txt:
layout-tests/dom/html/level2/html/HTMLFormElement10.html:
layout-tests/dom/html/level2/html/HTMLFormElement10.js:
layout-tests/fast/events/onunload-expected.txt:
layout-tests/fast/events/onunload.html:
layout-tests/fast/js/location-assign-expected.txt:
layout-tests/fast/js/location-assign.html:

WebKitTools:

At Least Rougly Glanced At by Anders.

fix change with totally breaks the layout tests.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Make tests unready if you start another load, to avoid dumping twice accidentally.

Aug 10, 2005:

8:38 PM Changeset in webkit [10133] by eseidel

2 edits in trunk/WebKitTools

Bug #: 3840
Submitted by: Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by: darin

DumpRenderTree/DumpRenderTree.m: Added support for rendering to a PNG file. http://bugzilla.opendarwin.org/show_bug.cgi?id=3840

6:39 PM Changeset in webkit [10132] by adele

2 edits in branches/Safari-2-0-branch/WebKit

Changes made to WebSubresourceLoader.m need to be made on WebSubresourceClient.m, since the file was renamed on TOT.

WebCoreSupport.subproj/WebSubresourceClient.m:

6:28 PM Changeset in webkit [10131] by ggaren

1 edit
4 adds in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

6:01 PM Changeset in webkit [10130] by vicki

12 edits in trunk

Changes from Curt Arnold, reviewed by Vicki.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4174 (DOM layout tests involving two
documents fail due to test framework problem), and update expected results for tests
affected by this change.

layout-tests/dom/html/level1/core/hc_attrappendchild5-expected.txt:
layout-tests/dom/html/level1/core/hc_attrinsertbefore6-expected.txt:
layout-tests/dom/html/level1/core/hc_elementwrongdocumenterr-expected.txt:
layout-tests/dom/html/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
layout-tests/dom/html/level1/core/hc_nodeappendchildnewchilddiffdocument-expected.txt:
layout-tests/dom/html/level1/core/hc_nodeinsertbeforenewchilddiffdocument-expected.txt:
layout-tests/dom/html/level1/core/hc_nodereplacechildnewchilddiffdocument-expected.txt:
layout-tests/dom/html/level1/core/selfhtml.js:
layout-tests/dom/html/level2/core/selfhtml.js:
layout-tests/dom/html/level2/events/selfhtml.js:
layout-tests/dom/html/level2/html/selfhtml.js:

5:42 PM Changeset in webkit [10129] by eseidel

1 edit
16 adds
8 deletes in trunk

Bug #: 4338
Submitted by: eseidel
Reviewed by: darin

svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/script-handle-03-b.svg: Added.
svg-tests/W3C-SVG-1.1/script-handle-03-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/script-handle-04-b.svg: Added.
svg-tests/W3C-SVG-1.1/script-handle-04-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-01-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-01-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-02-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-02-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-03-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-03-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-04-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-04-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-05-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-05-b.svg-disabled: Removed.
svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Added.
svg-tests/W3C-SVG-1.1/struct-dom-06-b.svg: Added.
svg-tests/W3C-SVG-1.1/struct-dom-06-b.svg-disabled: Removed. Re-enabled previously crashing SVG test cases: http://bugzilla.opendarwin.org/show_bug.cgi?id=4338

5:28 PM Changeset in webkit [10128] by adele

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-10 Vicki Murley <vicki@apple.com>

Reviewed by John.

attempted fix for <rdar://problem/4070895> 8A428: Unrepro Safari crash on friendster.com (XMLHttpRequest::changeState)

Test cases added: None - there are no known reproducible cases of this crash

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): add checks for NULL document

3:46 PM Changeset in webkit [10127] by vicki

2 edits in trunk/WebCore

Reviewed by John.

attempted fix for <rdar://problem/4070895> 8A428: Unrepro Safari crash on friendster.com (XMLHttpRequest::changeState)

Test cases added: None - there are no known reproducible cases of this crash

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): add checks for NULL document

2:55 PM Changeset in webkit [10126] by adele

in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:14:56 +0000

2:55 PM Changeset in webkit [10125] by adele

in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:15:00 +0000

2:55 PM Changeset in webkit [10124] by adele

6 edits in trunk

Bumping version to 420+

Info.plist:

2:54 PM Changeset in webkit [10123] by adele

in /

file Info.plist was added on branch Safari-2-0-branch on 2005-08-23 19:15:09 +0000

2:41 PM Changeset in webkit [10122] by adele

5 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2005-08-10 Geoffrey Garen <ggaren@apple.com>

-fixed <rdar://problem/4151132> REGRESSION: Some applet liveconnect calls
throws privilege exception.

Reviewed by richard and mjs.

-I removed the global static JavaClass cache, since it violated Java
security to cache classes between websites and applets.

bindings/jni/jni_class.cpp:

-removed global static cache dictionary
-instance constructor and destructor now do the work that used to
be done by static factory methods
-removed obsolete functions

(JavaClass::JavaClass):
(JavaClass::~JavaClass):

bindings/jni/jni_class.h:

-removed obsolete function declarations
-made copying private since it's unused and it's also not clear
excatly how copying would work with Java security
-made default construction private since it's meaningless

bindings/jni/jni_instance.cpp:

-removed obsolete functions

(JavaInstance::~JavaInstance):
(JavaInstance::getClass):

bindings/jni/jni_instance.h:

-made copying private since it's unused and it's also not clear

excatly how copying would work with Java security
-made default construction private since it's meaningless

1:51 PM Changeset in webkit [10121] by ggaren