⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 17, 2005:

11:17 PM Changeset in webkit [10250] by mjs
  • 1 edit
    1 add in trunk/WebKitTools
  • add file that I forgot in the last checkin
  • DumpRenderTree/ImageDiff.m: Added. (main): (getImageFromStdin): (compareImages): (getDifferenceBitmap): (computePercentageDifferent):
10:59 PM Changeset in webkit [10249] by mjs
  • 6 edits in trunk/WebKitTools

Changes by Ben Lamonica and Eric Seidel, reviewed mostly by Eric and
somewhat by me, and also tweaked by me a little bit.

  • better support for pixel-dumping
  • use checksums of the images so the tests are fast
  • change output format to make the tests run faster
  • don't dump pixel results for tests that dump as text
  • DumpKCanvasTree/DumpKCanvasTree.m: (main): (dumpRenderTree): (md5HashStringForBitmap): (dumpPixelTests): (constrainSizeToMaximum): (getBitmapImageRepForSVGDocument):
  • DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.m: (main): (dump): (dumpRenderTree): (md5HashStringForBitmap):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • Scripts/run-webkit-tests:
9:23 PM Changeset in webkit [10248] by mjs
  • 134 edits in trunk

Reviewed by Darin.

  • layout-tests/fast/css/acid2.html: Replaced nonexistent remote URL that takes a very long time to time out, with a nonexistent local URL.
  • kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Remove hack to turn off scrollbars.
  • Updated many test results now that the layout tests properly do scrollbars when appropriate
  • layout-tests/css1/basic/comments-expected.txt:
  • layout-tests/css1/basic/containment-expected.txt:
  • layout-tests/css1/basic/id_as_selector-expected.txt:
  • layout-tests/css1/basic/inheritance-expected.txt:
  • layout-tests/css1/box_properties/border-expected.txt:
  • layout-tests/css1/box_properties/border_bottom-expected.txt:
  • layout-tests/css1/box_properties/border_bottom_width-expected.txt:
  • layout-tests/css1/box_properties/border_left-expected.txt:
  • layout-tests/css1/box_properties/border_left_width-expected.txt:
  • layout-tests/css1/box_properties/border_right_inline-expected.txt:
  • layout-tests/css1/box_properties/border_right_width-expected.txt:
  • layout-tests/css1/box_properties/border_style-expected.txt:
  • layout-tests/css1/box_properties/border_top-expected.txt:
  • layout-tests/css1/box_properties/border_top_width-expected.txt:
  • layout-tests/css1/box_properties/border_width-expected.txt:
  • layout-tests/css1/box_properties/clear-expected.txt:
  • layout-tests/css1/box_properties/clear_float-expected.txt:
  • layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
  • layout-tests/css1/box_properties/float_margin-expected.txt:
  • layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
  • layout-tests/css1/box_properties/height-expected.txt:
  • layout-tests/css1/box_properties/margin-expected.txt:
  • layout-tests/css1/box_properties/margin_bottom-expected.txt:
  • layout-tests/css1/box_properties/margin_inline-expected.txt:
  • layout-tests/css1/box_properties/margin_left-expected.txt:
  • layout-tests/css1/box_properties/margin_right-expected.txt:
  • layout-tests/css1/box_properties/margin_top-expected.txt:
  • layout-tests/css1/box_properties/padding-expected.txt:
  • layout-tests/css1/box_properties/padding_bottom-expected.txt:
  • layout-tests/css1/box_properties/padding_inline-expected.txt:
  • layout-tests/css1/box_properties/padding_left-expected.txt:
  • layout-tests/css1/box_properties/padding_right-expected.txt:
  • layout-tests/css1/box_properties/padding_top-expected.txt:
  • layout-tests/css1/box_properties/width-expected.txt:
  • layout-tests/css1/cascade/cascade_order-expected.txt:
  • layout-tests/css1/classification/display-expected.txt:
  • layout-tests/css1/classification/list_style_type-expected.txt:
  • layout-tests/css1/classification/white_space-expected.txt:
  • layout-tests/css1/color_and_background/background-expected.txt:
  • layout-tests/css1/color_and_background/background_attachment-expected.txt:
  • layout-tests/css1/color_and_background/background_position-expected.txt:
  • layout-tests/css1/color_and_background/background_repeat-expected.txt:
  • layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
  • layout-tests/css1/font_properties/font-expected.txt:
  • layout-tests/css1/font_properties/font_family-expected.txt:
  • layout-tests/css1/font_properties/font_size-expected.txt:
  • layout-tests/css1/font_properties/font_weight-expected.txt:
  • layout-tests/css1/formatting_model/floating_elements-expected.txt:
  • layout-tests/css1/formatting_model/height_of_lines-expected.txt:
  • layout-tests/css1/formatting_model/horizontal_formatting-expected.txt:
  • layout-tests/css1/formatting_model/inline_elements-expected.txt:
  • layout-tests/css1/formatting_model/replaced_elements-expected.txt:
  • layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
  • layout-tests/css1/pseudo/anchor-expected.txt:
  • layout-tests/css1/pseudo/firstletter-expected.txt:
  • layout-tests/css1/pseudo/firstline-expected.txt:
  • layout-tests/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • layout-tests/css1/text_properties/letter_spacing-expected.txt:
  • layout-tests/css1/text_properties/line_height-expected.txt:
  • layout-tests/css1/text_properties/text-transCapitalize-expected.txt:
  • layout-tests/css1/text_properties/text_decoration-expected.txt:
  • layout-tests/css1/text_properties/text_indent-expected.txt:
  • layout-tests/css1/text_properties/text_transform-expected.txt:
  • layout-tests/css1/text_properties/vertical_align-expected.txt:
  • layout-tests/css1/text_properties/word_spacing-expected.txt:
  • layout-tests/css1/units/color_units-expected.txt:
  • layout-tests/css1/units/length_units-expected.txt:
  • layout-tests/dom/html/level2/html/HTMLBaseElement02-expected.txt:
  • layout-tests/editing/inserting/insert-div-023-expected.txt:
  • layout-tests/editing/selection/select-all-001-expected.txt:
  • layout-tests/editing/selection/select-all-002-expected.txt:
  • layout-tests/editing/selection/select-all-003-expected.txt:
  • layout-tests/editing/selection/select-all-004-expected.txt:
  • layout-tests/editing/selection/unrendered-001-expected.txt:
  • layout-tests/editing/selection/unrendered-002-expected.txt:
  • layout-tests/editing/selection/unrendered-003-expected.txt:
  • layout-tests/editing/selection/unrendered-004-expected.txt:
  • layout-tests/editing/selection/unrendered-005-expected.txt:
  • layout-tests/fast/block/basic/013-expected.txt:
  • layout-tests/fast/block/basic/016-expected.txt:
  • layout-tests/fast/block/float/008-expected.txt:
  • layout-tests/fast/block/float/013-expected.txt:
  • layout-tests/fast/block/float/019-expected.txt:
  • layout-tests/fast/block/float/021-expected.txt:
  • layout-tests/fast/block/float/025-expected.txt:
  • layout-tests/fast/block/float/026-expected.txt:
  • layout-tests/fast/block/float/027-expected.txt:
  • layout-tests/fast/block/float/028-expected.txt:
  • layout-tests/fast/block/float/032-expected.txt:
  • layout-tests/fast/block/float/033-expected.txt:
  • layout-tests/fast/block/margin-collapse/103-expected.txt:
  • layout-tests/fast/block/positioning/047-expected.txt:
  • layout-tests/fast/block/positioning/051-expected.txt:
  • layout-tests/fast/block/positioning/055-expected.txt:
  • layout-tests/fast/block/positioning/auto/007-expected.txt:
  • layout-tests/fast/css/005-expected.txt:
  • layout-tests/fast/css/MarqueeLayoutTest-expected.txt:
  • layout-tests/fast/css/word-space-extra-expected.txt:
  • layout-tests/fast/dom/attr_dead_doc-expected.txt:
  • layout-tests/fast/dom/features-expected.txt:
  • layout-tests/fast/dynamic/008-expected.txt:
  • layout-tests/fast/dynamic/flash-replacement-test-expected.txt:
  • layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
  • layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
  • layout-tests/fast/flexbox/016-expected.txt:
  • layout-tests/fast/forms/form-element-geometry-expected.txt:
  • layout-tests/fast/frames/001-expected.txt:
  • layout-tests/fast/frames/002-expected.txt:
  • layout-tests/fast/frames/contentWindow_Frame-expected.txt:
  • layout-tests/fast/frames/contentWindow_iFrame-expected.txt:
  • layout-tests/fast/frames/empty-frame-src-expected.txt:
  • layout-tests/fast/frames/frameElement-frame-expected.txt:
  • layout-tests/fast/frames/frameElement-iframe-expected.txt:
  • layout-tests/fast/frames/invalid-expected.txt:
  • layout-tests/fast/frames/valid-expected.txt:
  • layout-tests/fast/inline-block/003-expected.txt:
  • layout-tests/fast/js/window-object-cross-frame-calls-expected.txt:
  • layout-tests/fast/lists/008-expected.txt:
  • layout-tests/fast/replaced/005-expected.txt:
  • layout-tests/fast/replaced/007-expected.txt:
  • layout-tests/fast/selectors/166-expected.txt:
  • layout-tests/fast/table/023-expected.txt:
  • layout-tests/fast/table/034-expected.txt:
  • layout-tests/fast/table/040-expected.txt:
  • layout-tests/fast/table/border-collapsing/004-expected.txt:
  • layout-tests/fast/table/height-percent-test-expected.txt:
  • layout-tests/fast/table/wide-colspan-expected.txt:
  • layout-tests/fast/table/wide-column-expected.txt:
  • layout-tests/fast/text/whitespace/024-expected.txt:
  • layout-tests/fast/tokenizer/004-expected.txt:
  • layout-tests/traversal/tree-walker-004-expected.txt:
5:31 PM Changeset in webkit [10247] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Test cases added: (NONE)

This is a fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4499
which describes a memory leak that happens on bugzilla after
searching for all open WebKit bugs.

  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::resize): When resizing to 0, free the old data after setting it

to NULL.

5:25 PM Changeset in webkit [10246] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fix mysterious CGImageSource error message and possibly crash on layout tests.
  • WebView.subproj/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]): Retain the data source since it may prematurely self-destruct otherwise. (-[WebMainResourceLoader cancelWithError:]): ditto
5:20 PM Changeset in webkit [10245]
  • 89 copies
    2 deletes in tags/WebCore-415~13~2

This commit was manufactured by cvs2svn to create tag
'WebCore-415~13~2'.

5:20 PM Changeset in webkit [10244] by adele
  • 2 edits in branches/Safari-OC-branch/WebCore

Merged fix from TOT to branch

2005-08-17 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin, adele

Fixes <rdar://problem/4219869> REGRESSION (OC): First frame never draws if it's delayed

A recent change uncovered a bug where on early returns from KHTMLView::layout(), layoutSchedulingEnabled
was not reset to true, preventing later layouts from occuring.

  • khtml/khtmlview.cpp: (KHTMLView::layout):
5:19 PM Changeset in webkit [10243] by adele
  • 2 edits in branches/Safari-OC-branch/WebCore

Merged fix from TOT to branch

2005-08-17 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin, adele

Fixes <rdar://problem/4219869> REGRESSION (OC): First frame never draws if it's delayed

A recent change uncovered a bug where on early returns from KHTMLView::layout(), layoutSchedulingEnabled
was not reset to true, preventing later layouts from occuring.

  • khtml/khtmlview.cpp: (KHTMLView::layout):
5:15 PM Changeset in webkit [10242] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to branch

2005-08-17 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin, adele

Fixes <rdar://problem/4219869> REGRESSION (OC): First frame never draws if it's delayed

A recent change uncovered a bug where on early returns from KHTMLView::layout(), layoutSchedulingEnabled
was not reset to true, preventing later layouts from occuring.

  • khtml/khtmlview.cpp: (KHTMLView::layout):
5:13 PM Changeset in webkit [10241]
  • 69 copies
    2 deletes in tags/WebCore-315~10

This commit was manufactured by cvs2svn to create tag
'WebCore-315~10'.

5:13 PM Changeset in webkit [10240] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for branch - WebCore-315.10

5:11 PM Changeset in webkit [10239] by adele
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to branch

2005-08-17 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin, adele

Fixes <rdar://problem/4219869> REGRESSION (OC): First frame never draws if it's delayed

A recent change uncovered a bug where on early returns from KHTMLView::layout(), layoutSchedulingEnabled
was not reset to true, preventing later layouts from occuring.

  • khtml/khtmlview.cpp: (KHTMLView::layout):
5:03 PM Changeset in webkit [10238] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin, adele

Fixes <rdar://problem/4219869> REGRESSION (OC): First frame never draws if it's delayed

A recent change uncovered a bug where on early returns from KHTMLView::layout(), layoutSchedulingEnabled
was not reset to true, preventing later layouts from occuring.

  • khtml/khtmlview.cpp: (KHTMLView::layout):
4:25 PM Changeset in webkit [10237] by vicki
  • 2 edits in branches/Safari-1-3-branch/WebCore

Reviewed by Darin.

  • fix <rdar://problem/4217250> REGRESSION (OC): crash loading XML file with <script> tag in it
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement): make sure elements that id themselves as scripts are also HTML elements
2:41 PM Changeset in webkit [10236] by vicki
  • 2 edits in branches/Safari-OC-branch/WebCore

Reviewed by Darin.

  • fix <rdar://problem/4217250> REGRESSION (OC): crash loading XML file with <script> tag in it
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement): make sure that elements that id themselves as scripts are also HTML elements
2:21 PM Changeset in webkit [10235] by vicki
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Darin.

  • fix <rdar://problem/4217250> REGRESSION (OC): crash loading XML file with <script> tag in it
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement): make sure that elements that id themselves as scripts are also HTML elements
2:08 PM Changeset in webkit [10234] by darin
  • 10 edits in trunk

Reviewed and landed by Darin.

  • layout-tests/dom/html/level2/events/dispatchEvent08.js: Updated.
  • layout-tests/dom/html/level2/events/dispatchEvent09.js: Ditto.
  • layout-tests/dom/html/level2/events/dispatchEvent10.js: Ditto.
  • layout-tests/dom/html/level2/events/dispatchEvent11.js: Ditto.
  • layout-tests/dom/html/level2/events/dispatchEvent12.js: Ditto.
  • layout-tests/dom/html/level2/events/dispatchEvent13.js: Ditto.
  • layout-tests/dom/html/level2/events/dispatchEvent11-expected.txt: Now succeeds.
  • layout-tests/dom/html/level2/events/dispatchEvent12-expected.txt: Now fails.
  • layout-tests/dom/html/level2/events/dispatchEvent13-expected.txt: Now succeeds.
1:12 PM Changeset in webkit [10233] by justing
  • 5 edits in trunk/WebCore

Reviewed by rjw

Addresses <rdar://problem/4192534> new frame load delegate SPI needed for Dashboard

Call handledOnloadEvents bridge method after load events are dispatched in a frame

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitClose):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::handledOnloadEvents):
  • kwq/WebCoreBridge.h:
1:11 PM Changeset in webkit [10232] by justing
  • 6 edits in trunk/WebKit

Reviewed by rjw

Addresses <rdar://problem/4192534> new frame load delegate SPI needed for Dashboard

Added handledOnloadEvents delegate method (private for now)

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge handledOnloadEvents]):
  • WebView.subproj/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _handledOnloadEvents]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebViewPrivate.h:
11:27 AM Changeset in webkit [10231] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-08-16 Darin Adler <Darin Adler>

Reviewed by Trey.

  • improved fix for <rdar://problem/4211631>, tiled images tiled incorrectly when printing or drawing offscreen
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]): Fix pattern phase origin to use the image tile origin, which is clearly right, rather than the image rectangle, which isn't right, but often is the same.
11:14 AM Changeset in webkit [10230] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Geoff Garen.

  • fixed <rdar://problem/4219817> Particular icon database + bookmarks + history crashes Safari on launch
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]): Move line that might remove last reference to iconURL to the end of the block.
11:06 AM Changeset in webkit [10229] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fixed merge error from last checkin.

  • khtml/html/html_miscimpl.cpp: (HTMLBaseFontElementImpl::~HTMLBaseFontElementImpl): (HTMLCollectionImpl::~HTMLCollectionImpl):
1:07 AM Changeset in webkit [10228] by vicki
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4175734> Crash trying to retrieve data with XMLHttpRequest with Content-Type: empty

Test cases added:

  • manual-tests/xmlhttprequest-contenttype-empty.html: Added.
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): allow empty entries when splitting to create the mime type string, otherwise we access a garbage pointer when stripping whitespace

Aug 16, 2005:

10:01 PM Changeset in webkit [10227] by darin
  • 2 edits in trunk/WebKit

Reviewed by Trey.

  • improved fix for <rdar://problem/4211631>, tiled images tiled incorrectly when printing or drawing offscreen
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]): Fix pattern phase origin to use the image tile origin, which is clearly right, rather than the image rectangle, which isn't right, but often is the same.
9:06 PM Changeset in webkit [10226] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed bug that was causing a crash when running layout tests
  • khtml/ecma/kjs_binding.h: Remove unused deleteDOMObject.
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMObject): Move code in here from forgetDOMObject. (KJS::ScriptInterpreter::getDOMNodeForDocument): For the null-document case, use the general DOM objects map rather than a per-document map. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Ditto. (KJS::ScriptInterpreter::putDOMNodeForDocument): Ditto. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Assert that document is not null.
6:31 PM Changeset in webkit [10225] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-08-16 Adele Peterson <​adele@apple.com>

Reviewed by John.

  • fixed <rdar://problem/4210320> URL tooltips should display a URL for elements that submit forms

When the setShowsURLsInToolTips preference is set, we will display a tooltip containing
the form's url when you mouse over a submit button.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
6:29 PM Changeset in webkit [10224] by adele
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/4210320> URL tooltips should display a URL for elements that submit forms

When the setShowsURLsInToolTips preference is set, we will display a tooltip containing
the form's url when you mouse over a submit button.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]):
6:07 PM Changeset in webkit [10223] by darin
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

  • changed main_thread_malloc so we don't have two conflicting versions of the same function This fixes a crash I was seeing running the WebKit tests.
  • khtml/misc/main_thread_malloc.h: Took out all the ifdefs from this header.
  • khtml/misc/main_thread_malloc.cpp: Added non-NDEBUG versions of the functions that just call the system malloc, and put the NDEBUG versions in an #else.
  • WebCore-tests.exp: Export the new stuff so the tests still work.
6:00 PM Changeset in webkit [10222] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • fixed crash in one of the JavaScript tests (introduced by my throwError change)
  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded): Check if the exception is an object before setting the file and line number properties on it. Something to think about in the future -- do we really want to do this on any object that's thrown? How about limiting it to error objects that were created by the JavaScript engine?
  • changed kjs_fast_malloc so we don't have two conflicting versions of the same function
  • kjs/fast_malloc.h: Took out all the ifdefs from this header.
  • kjs/fast_malloc.cpp: Added non-NDEBUG versions of the functions that just call the system malloc, and put the NDEBUG versions in an #else.
5:45 PM Changeset in webkit [10221] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4219015> HTMLCollections leak their info (reproducible on sony.com)

2005-08-15 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

  • fixed leak of HTML collection info - this can build up to hundreds of leaks pretty quickly

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4450

  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::HTMLCollectionImpl): Initialize new m_ownsInfo member. (DOM::HTMLCollectionImpl::~HTMLCollectionImpl): Delete info if owned. (DOM::HTMLCollectionImpl::resetCollectionInfo): When creating new info, indicate that it's owned.
  • khtml/html/html_miscimpl.h: Declare new member.
5:05 PM Changeset in webkit [10220] by darin
  • 5 edits in branches/pcre-6-1-branch/JavaScriptCore

More UTF-16 hacking; also updated the project file to merge with TOT.

4:57 PM Changeset in webkit [10219] by mjs
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed leak of HTML collection info - this can build up to hundreds of leaks pretty quickly

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4450

  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::HTMLCollectionImpl): Initialize new m_ownsInfo member. (DOM::HTMLCollectionImpl::~HTMLCollectionImpl): Delete info if owned. (DOM::HTMLCollectionImpl::resetCollectionInfo): When creating new info, indicate that it's owned.
  • khtml/html/html_miscimpl.h: Declare new member.
3:01 PM Changeset in webkit [10218] by darin
  • 9 edits
    1 add in trunk/JavaScriptCore

Reviewed by Geoff.

  • clean up exported symbols that are not in a "KJS" namespace
  • bindings/NP_jsobject.cpp: (identiferFromNPIdentifier): Marked this function static so it no longer has external linkage.
  • bindings/c/c_utility.h: Put all this stuff inside the KJS namespace.
  • bindings/c/c_utility.cpp: Also marked some globals static so they don't have external linkage; not as important given the namespace.
  • bindings/npruntime.cpp: Marked functions static so they no longer have internal linkage. Also removed unused _NPN_SetExceptionWithUTF8 function (not in header, had C++ linkage!).
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): Call KJS_GetCreatedJavaVMs using the soft linking header, instead of calling the JNI call. This allows processes to link both JavaScriptCore and JavaVM without a symbol conflict.
  • bindings/softlinking.c: (loadFramework): Marked this function static so it no longer has external linkage. (getFunctionPointer): Ditto. (KJS_GetCreatedJavaVMs): Renamed this so it has a KJS prefix.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added softlinking.h.
  • bindings/softlinking.h: Added.
  • kjs/nodes2string.cpp: (streamAssignmentOperatorTo): Marked this function static so it no longer has external linkage.
2:53 PM Changeset in webkit [10217] by harrison
  • 2 edits in trunk/WebCore

<rdar://problem/4119646> assertion failure in DOM::Position::upstream at babelfish.com
<rdar://problem/4125949> Assertion failure clicking outside of textarea in page containing only textarea

Removed asserts that did not account for iterating from a nested node to its parent.

Test cases added: n/a for assert removal

  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): (DOM::Position::downstream):
2:25 PM Changeset in webkit [10216] by adele
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-08-15 Darin <Darin Adler>

Reviewed by Beth.

This is a fix for <rdar://problem/4211631> tiled images tiled incorrectly when printing or
drawing offscreen.

Cayenne found there was a problem when they were trying to take screen shots of widgets, and
it was ultimately a problem with the way we tile images. Darin was able to fix the problem
by replacing some confusing hacked code with CG calls.

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData tileInRect:fromPoint:context:]):
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage tileInRect:fromPoint:context:]):
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForMisspelling:withWidth:]):
12:03 PM Changeset in webkit [10215] by darin
  • 40 edits
    2 deletes in trunk

WebCore:

Reviewed by Beth Dakin.

  • removed Panther-only code that was not being compiled and was simply "bit-rotting"
  • WebCorePrefix.h:
  • khtml/misc/loader.cpp: (CachedImage::CachedImage):
  • khtml/rendering/render_canvasimage.cpp:
  • kwq/KWQAccObject.mm: (-[KWQAccObject roleDescription]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityIsAttributeSettable:]):
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox):
  • kwq/KWQFoundationExtras.h: (KWQCFAutorelease):
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap): (QPixmap::receivedData):
  • kwq/KWQString.h: (QChar::direction):
  • kwq/KWQTextArea.mm: (-[KWQTextArea tile]):
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController string]):
  • kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID):
  • kwq/WebCoreScrollView.m:

WebKit:

Reviewed by Beth Dakin.

  • removed Panther-only code that was not being compiled and was simply "bit-rotting"
  • Misc.subproj/WebFileDatabase.m: (-[WebFileDatabase _createLRUList:]): (+[WebFileDatabase _syncLoop:]):
  • Misc.subproj/WebKitErrors.m: (registerErrors):
  • Misc.subproj/WebNSObjectExtras.h: (WebCFAutorelease):
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_declareAndWriteDragImage:URL:title:archive:source:]):
  • WebCoreSupport.subproj/WebImageData.h:
  • WebCoreSupport.subproj/WebImageDecodeItem.h:
  • WebCoreSupport.subproj/WebImageDecodeItem.m:
  • WebCoreSupport.subproj/WebImageDecoder.h:
  • WebCoreSupport.subproj/WebImageDecoder.m: (decoderThread): (startDecoderThread):
  • WebCoreSupport.subproj/WebKeyGeneration.cpp: Removed.
  • WebCoreSupport.subproj/WebKeyGeneration.h: Removed.
  • WebCoreSupport.subproj/WebKeyGenerator.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (getUncachedWidth): (_drawGlyphs):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory getBytes:fromTextMarker:length:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebKitPrefix.h:
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]): (+[WebDataSource _repTypesAllowImageTypeOmission:]): (-[WebDataSource isLoading]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (localizedMenuTitleFromAppKit): (-[WebDefaultUIDelegate menuItemWithTag:]): (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
  • WebView.subproj/WebFormDataStream.m: (formCanRead): (webSetHTTPBody):
  • WebView.subproj/WebFrameView.m: (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:chosePlainText:]): (-[WebHTMLView resourceForData:preferredFilename:]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView validateUserInterfaceItem:]): (-[WebHTMLView _attributeStringFromDOMRange:]): (-[WebHTMLView toggleBaseWritingDirection:]): (-[WebHTMLView changeBaseWritingDirection:]):
  • WebView.subproj/WebPDFRepresentation.h:
  • WebView.subproj/WebPDFRepresentation.m:
  • WebView.subproj/WebPDFView.h:
  • WebView.subproj/WebPDFView.m:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences _systemCFStringEncoding]):
  • WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
11:28 AM Changeset in webkit [10214] by vicki
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix ChangeLog typo from my last checkin. Remove NONE from the layout-test section.

10:36 AM Changeset in webkit [10213] by darin
  • 11 edits in trunk

WebCore:

Reviewed by Beth Dakin.

  • removed some unnecessary code
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::imageFromRect): Remove code to call setAdditionalPatternPhase since that is no longer needed.
  • kwq/WebCoreGraphicsBridge.h: Remove unused setAdditionalPatternPhase, createRGBColorSpace, createGrayColorSpace, and createCMYKColorSpace methods.
  • kwq/WebCoreGraphicsBridge.m: Ditto.

WebKit:

Reviewed by Beth Dakin.

  • removed some unnecessary code
  • WebCoreSupport.subproj/WebGraphicsBridge.h: Removed pattern-phase related field and methods.
  • WebCoreSupport.subproj/WebGraphicsBridge.m: Ditto.
  • WebCoreSupport.subproj/WebImageData.m: Tweaked formatting and removed some unused code inside #if and comments.
  • WebCoreSupport.subproj/WebImageRenderer.h: Removed USE_CGIMAGEREF (which is always true now).
  • WebCoreSupport.subproj/WebImageRenderer.m: Removed old non-CGImageRef code.
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]): Removed non-USE_CGIMAGEREF code. (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): Ditto. (-[WebImageRendererFactory imageRendererWithSize:]): Ditto. (-[WebImageRendererFactory imageRendererWithName:]): Ditto.
2:17 AM Changeset in webkit [10212] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4445
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

1:58 AM Changeset in webkit [10211] by eseidel
  • 15 edits in trunk

Bug #: 4431
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::needsTemporaryBuffer):
  • kcanvas/device/KRenderingPaintServerSolid.cpp: (KRenderingPaintServerSolid::opacity):
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/KRenderingStyle.cpp: (KRenderingStyle::Private::Private): (KRenderingStyle::opacity): (KRenderingStyle::setOpacity):
  • kcanvas/device/KRenderingStyle.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::draw):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw):
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStyleToContext):
  • ksvg2/core/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::opacity): (KCanvasRenderingStyle::setOpacity):
  • ksvg2/core/KCanvasRenderingStyle.h: Change all references to Opacity to use floats. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4431
12:39 AM Changeset in webkit [10210] by eseidel
  • 5 edits in trunk

Bug #: 4453
Submitted by: eseidel
Reviewed by: mjs

  • WebCore.xcodeproj/project.pbxproj: bison cleanup.
  • kdom/ecma/DOMLookup.h: now uses throwError
  • kdom/ecma/Ecma.cpp: (Ecma::~Ecma): now uses clearProperties
  • kdom/ecma/GlobalObject.cpp: now uses throwError (GlobalObject::clear): now uses clearProperties (GlobalObjectFunc::callAsFunction): now uses throwError Fixes necessary for WebCore+SVG after 4437. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4453
Note: See TracTimeline for information about the timeline view.