⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 23, 2005:

7:50 PM Changeset in webkit [10311] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged another version of reset which is used in our xmlhttprequest leak fix.

  • khtml/misc/shared.h: (khtml::SharedPtr::reset):
6:46 PM Changeset in webkit [10310] by vicki
  • 2 edits
    2 adds in trunk/WebCore

Reviewed by Adele.

  • fixed <rdar://problem/4229177> REGRESSION (Denver): crash dispatching mouse events (4608)

Test cases added:

  • manual-tests/mouseevent-on-closeddoc.html: Added.
  • manual-tests/resources/mouseevent-on-closeddoc.html: Added.
  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): add nil check
5:49 PM Changeset in webkit [10309] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-22 David Harrison <​harrison@apple.com>

Reviewed by Justin.

<rdar://problem/4221384> Denver Regression: stickies widget crashed on 8F15 when pasting text

Test cases added: None. Problem triggered by simple paste, which lots of the
editing tests already do, but also required particular memory layout/cleanup state, which
is not specifiable in our tests.

  • khtml/editing/markup.cpp: (khtml::createFragmentFromText): Ref the new paragraph element right away, rather than allocating more memory first.
5:45 PM Changeset in webkit [10308] by adele
  • 6 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-08-17 Justin Garcia <​justin.garcia@apple.com>

Reviewed by rjw

Addresses <rdar://problem/4192534> new frame load delegate SPI needed for Dashboard

Added handledOnloadEvents delegate method (private for now)

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge handledOnloadEvents]):
  • WebView.subproj/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _handledOnloadEvents]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebViewPrivate.h:
5:34 PM Changeset in webkit [10307] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Beth Dakin.

  • fixed <rdar://problem/4229167> 14 leaks of WebFileButton and associated objects, seen after running webkit layout tests
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge fileButtonWithDelegate:]): this method was returning a retained object; I added an autorelease
5:24 PM Changeset in webkit [10306] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4221431> avoid icon database thrash for 1% speedup on HTML iBench

2005-08-14 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]): Be more aggressive about returning early, because updating the database does some expensive data structure copies.
5:17 PM Changeset in webkit [10305] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4220776> memory leak in KWQArrayImpl::resize() at bugzilla.opendarwin.org

2005-08-17 Beth Dakin <Beth Dakin>

Reviewed by Maciej

Test cases added: (NONE)

This is a fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4499
which describes a memory leak that happens on bugzilla after
searching for all open WebKit bugs.

  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::resize): When resizing to 0, free the old data after setting it

to NULL.

5:13 PM Changeset in webkit [10304] by adele
  • 8 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
<rdar://problem/4221430> Safari HTML iBench performance can be improved through inlining and allocator tweaks

2005-08-14 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • kwq/KWQArrayImpl.h: (KWQArrayImpl::size):
  • kwq/KWQArrayImpl.mm:
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQRefPtr.h: (::KWQRefPtr): (::operator): (::ref): (::unref):
  • kwq/KWQValueListImpl.h: (KWQValueListIteratorImpl::KWQValueListIteratorImpl): (KWQValueListIteratorImpl::operator==): (KWQValueListIteratorImpl::operator!=): (KWQValueListIteratorImpl::node): (KWQValueListIteratorImpl::operator++): (KWQValueListIteratorImpl::operator--): (KWQValueListNodeImpl::KWQValueListNodeImpl):
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::KWQValueListPrivate::~KWQValueListPrivate):
5:03 PM Changeset in webkit [10303] by adele
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-08-22 John Sullivan <​sullivan@apple.com>

Reviewed by Beth Dakin.

  • fixed <rdar://problem/4227019> Several 32-byte leaks after choosing pop-up menu at dzone198.apple.com

Test cases added: none, doesn't affect layout. I did execute run-layout-tests to verify that there
were no surprises though.

  • khtml/ecma/xmlhttprequest.h: use SharedPtr for onReadyStateChangeListener and onLoadListener
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): use notNull() instead of testing SharedPtrs against 0 (KJS::XMLHttpRequest::putValueProperty): use reset() to set values of SharedPtrs; eliminate ref()s that had no deref()s (KJS::XMLHttpRequest::mark): use notNull() instead of testing SharedPtrs against 0 (KJS::XMLHttpRequest::XMLHttpRequest): don't initialize SharedPtrs (KJS::XMLHttpRequest::changeState): use notNull() instead of testing SharedPtrs against 0
5:03 PM Changeset in webkit [10302]
  • 5 copies in branches/Safari-2-0-branch

This commit was manufactured by cvs2svn to create branch
'Safari-2-0-branch'.

4:56 PM Changeset in webkit [10301] by adele
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-08-23 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Darin.

  • fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4604 LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout <rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604)
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]): Added missing call to ATSUDisposeTextLayout.
4:03 PM Changeset in webkit [10300] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: 4590
Submitted by: eseidel
Reviewed by: mjs

4:00 PM Changeset in webkit [10299] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
3:53 PM Changeset in webkit [10298] by darin
  • 4 edits in trunk

Reviewed by John.

  • khtml/html/htmlparser.cpp: (HTMLParser::getNode): Remove code to omit children of <nolayer>.
  • layout-tests/fast/dom/no-elements.html: Update test for new behavior.
  • layout-tests/fast/dom/no-elements-expected.txt: Updated test results.
3:42 PM Changeset in webkit [10297] by darin
  • 2 edits in trunk
  • fixed test that was accessing a remote resource by accident
  • layout-tests/fast/lists/009.html: Correct URL to be relative.
3:27 PM Changeset in webkit [10296]
  • 11 copies in tags/Safari-2-0-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-2-0-anchor'.

3:27 PM Changeset in webkit [10295] by darin
  • 1 add in trunk/WebCore/ChangeLog-2005-12-19

New change log. Old one was getting too big.

3:11 PM Changeset in webkit [10294] by adele
  • 1 edit in branches/Safari-2-0-branch/WebCore/WebCore.xcodeproj/project.pbxproj

Make WebCoreScriptDebugger.h a private header to make the Development builds work

3:06 PM Changeset in webkit [10293] by adele
  • 1 edit in branches/Safari-2-0-branch/WebCore/WebCore.xcodeproj/project.pbxproj

Making WebCoreUnicode.h a private header on the branch. Needed for Development builds.

2:42 PM Changeset in webkit [10292] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4604 LEAK -[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:] leaks an ATSUTextLayout <rdar://problem/4228787> ATSUTextLayout leak in _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs: (4604)
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:includePartialGlyphs:]): Added missing call to ATSUDisposeTextLayout.
12:25 PM Changeset in webkit [10291] by harrison
  • 2 edits
    2 adds in trunk

Reviewed by Darin.

<rdar://problem/4226539> REGRESSION: Blank content at ​http://www.the-leaky-cauldron.org/ with Denver and TOT

Test cases added:

  • layout-tests/fast/parser/comments-expected.txt: Added.
  • layout-tests/fast/parser/comments.html: Added.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment): When non-space follows comment end, ignore that comment end.
12:15 PM Changeset in webkit [10290] by adele
  • 12 edits
    3 adds
    53 deletes in branches/Safari-2-0-branch

Change to native targets on the branch.

11:32 AM Changeset in webkit [10289] by justing
  • 6 edits in trunk/WebCore

Reviewed by mjs

Temporary workaround for gcc-5216+ bug 4213314. Don't use NSMake* convenience methods inside KWQ_BLOCK_EXCEPTIONS.

  • kwq/KWQKConfigBase.mm: (KConfig::readEntry):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQPainter.mm: (QPainter::drawTiledPixmap):
  • kwq/KWQScrollView.mm: (QScrollView::resizeContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents): (QScrollView::setContentsPosRecursive): (QScrollView::ensureVisible): (QScrollView::ensureRectVisibleCentered):
9:45 AM Changeset in webkit [10288] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Beth Dakin.

  • fixed <rdar://problem/4227019> Several 32-byte leaks after choosing pop-up menu at dzone198.apple.com

Test cases added: none, doesn't affect layout. I did execute run-layout-tests to verify that there
were no surprises though.

  • khtml/ecma/xmlhttprequest.h: use SharedPtr for onReadyStateChangeListener and onLoadListener
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): use notNull() instead of testing SharedPtrs against 0 (KJS::XMLHttpRequest::putValueProperty): use reset() to set values of SharedPtrs; eliminate ref()s that had no deref()s (KJS::XMLHttpRequest::mark): use notNull() instead of testing SharedPtrs against 0 (KJS::XMLHttpRequest::XMLHttpRequest): don't initialize SharedPtrs (KJS::XMLHttpRequest::changeState): use notNull() instead of testing SharedPtrs against 0

Aug 22, 2005:

6:22 PM Changeset in webkit [10287] by ggaren
  • 4 edits in trunk/WebKit
  • fixed <rdar://problem/4227011> Debugger SPI should be removed from WebView.h API

Reviewed by mjs and adele.

Cut and pasted debugging SPI from WebView to WebView(WebPendingPublic)

  • WebView.subproj/WebView.h:
  • WebView.subproj/WebView.m: (-[WebView setScriptDebugDelegate:]): (-[WebView scriptDebugDelegate]):
  • WebView.subproj/WebViewPrivate.h:
1:24 PM Changeset in webkit [10286] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4221384> Denver Regression: stickies widget crashed on 8F15 when pasting text

Test cases added: None. Problem triggered by simple paste, which lots of the
editing tests already do, but also required particular memory layout/cleanup state, which
is not specifiable in our tests.

  • khtml/editing/markup.cpp: (khtml::createFragmentFromText): Ref the new paragraph element right away, rather than allocating more memory first.
11:53 AM Changeset in webkit [10285] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4554
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::inputImage): null check (KCanvasFEBlendQuartz::getCIFilter): ditto (KCanvasFEColorMatrixQuartz::getCIFilter): ditto (KCanvasFEMergeQuartz::getCIFilter): ditto Added NULL checks to avoid throwing Obj-C exceptions from CoreImage either when rendering bad SVGs or in cases where we do not yet implement a certain SVG filter element. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4554
11:43 AM Changeset in webkit [10284] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: 4585
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: darin

11:24 AM Changeset in webkit [10283] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: 4581
Submitted by: eseidel
Reviewed by: darin

11:17 AM Changeset in webkit [10282] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4580
Submitted by: eseidel
Reviewed by: darin

11:13 AM Changeset in webkit [10281] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4577
Submitted by: eseidel
Reviewed by: darin

3:45 AM Changeset in webkit [10280] by eseidel
  • 6 edits in trunk

Bug #: 4463
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw):
  • svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Group opacity was doubly-applied. This patch fixes that. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4463
2:30 AM Changeset in webkit [10279] by eseidel
  • 24 edits in trunk

Bug #: 4553
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

  • kcanvas/device/quartz/QuartzSupport.mm: (CGPathToCFStringApplierFunction): Fixed output for curves.
  • svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-path-01-b-expected.txt: Fixed output for curves and updated tests accordingly. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4553
12:45 AM Changeset in webkit [10278] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 4550
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::filtersEnabled): (KRenderingDeviceQuartz::setFiltersEnabled): (KRenderingDeviceQuartz::hardwareRenderingEnabled): (KRenderingDeviceQuartz::setHardwareRenderingEnabled): Added ability to disable hardware rendering (for testing). ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4550
Note: See TracTimeline for information about the timeline view.