⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 2, 2005:

3:56 PM Changeset in webkit [10452]
  • 337 copies
    33 deletes in tags/Safari-416~6

This commit was manufactured by cvs2svn to create tag 'Safari-416~6'.

3:56 PM Changeset in webkit [10451] by adele
  • 6 edits in branches/Safari-2-0-branch

Versioning for Safari-2-0-branch - Safari-416.6

3:27 PM Changeset in webkit [10450] by adele
  • 4 edits in branches/Safari-2-0-branch

JavaScriptCore:

Merged fix from TOT to Safari-2-0-branch

2005-09-02 Beth Dakin <Beth Dakin>

Fix for <rdar://problem/4235531> Regression: Safari crash in KWQStringData::makeUnicode
The other half of the fix is in WebCore.

Fix written by Maciej and Darin.
Reviewed by me/Maciej

As Maciej said in Radar: These problems was caused by a conflict between some of our custom
allocators, causing them to return null. Symptom is typically a null pointer dereference in
a place where it might be expected an allocation has just occurred.

  • kjs/fast_malloc.cpp: Added #define for MORECORE_CONTIGUOUS, MORECORE_CANNOT_TRIM,

and MALLOC_FAILURE_ACTION.

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-09-02 Beth Dakin <Beth Dakin>

Fix for <rdar://problem/4235531> Denver Regression: Safari crash in KWQStringData::makeUnicode
The other half of the fix is in JavaScriptCore

Fix written by Maciej and Darin.
Reviewed by me/Maciej

As Maciej said in Radar: These problems was caused by a conflict between some of our custom
allocators, causing them to return null. Symptom is typically a null pointer dereference in
a place where it might be expected an allocation has just occurred.

  • khtml/misc/main_thread_malloc.cpp: Added #define for MORECORE_CONTIGUOUS, MORECORE_CANNOT_TRIM,

and MALLOC_FAILURE_ACTION.

3:14 PM Changeset in webkit [10449] by adele
  • 9 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-02 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Test cases updated: manual-tests/select_hr.html:
updated for case where selection is changed for a list box that has an <hr> in its list items, even though it doesn't appear in the list.

  • khtml/rendering/render_form.cpp: (RenderSelect::slotSelectionChanged): Added counter that increments only for visible list items (options and optgroups). Before this change, list boxes that had invisible <hr>s could have the visible selected option get out of sync from the selected state. (RenderSelect::updateSelection): ditto.
  • kwq/KWQListBox.h: Changed enum from ItemType to KWQListBoxItemType and values to KWQListBoxOption, KWQListBoxGroupLabel, and KWQListBoxSeparator. (KWQListBoxItem::KWQListBoxItem): ditto. (QListBox::appendItem): ditto. (QListBox::appendGroupLabel): ditto.
  • kwq/KWQListBox.mm: (QListBox::appendItem): ditto. (QListBox::sizeForNumberOfLines): ditto. (-[KWQTableView tableView:shouldSelectRow:]): ditto. (-[KWQTableView drawRow:clipRect:]): ditto.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): ditto. (QComboBox::appendGroupLabel): ditto. (QComboBox::appendSeparator): ditto.
  • kwq/KWQComboBox.mm: (QComboBox::setTitle): ditto. (QComboBox::appendItem): ditto. (QComboBox::sizeHint): ditto. (QComboBox::populateMenu): ditto.

2005-08-31 Adele Peterson <​adele@apple.com>

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4229189> add a way to get a separator into a <select>

This will allow an <hr> within a select element to display a separator in a popup menu.
These extra elements are added to our listItems array, which we use internally. But this should not
affect JavaScript operations, such as getting an index of an option element, or getting the length of the select,
or getting the selected index. In these cases, the <hr>s will be ignored.

Test cases added:

  • manual-tests/select_hr.html: Added.
  • khtml/html/html_formimpl.h: (DOM::HTMLSelectElementImpl::listItems): Now that our listItems can also contain <hr>s, I've changed listItems to be a QMemArray<HTMLElementImpl*> instead of QMemArray<HTMLGenericFormElementImpl*> (DOM::HTMLOptGroupElementImpl::checkDTD): Added check for <hr>
  • khtml/html/html_formimpl.cpp: (DOM::HTMLSelectElementImpl::checkDTD): Added check for <hr> (DOM::HTMLSelectElementImpl::add): Added check for <hr> so these elements can be added through Javascript. (DOM::HTMLSelectElementImpl::recalcListItems): Added case for <hr> to add the element to the listItems array. (DOM::HTMLSelectElementImpl::selectedIndex): Updated type for array of listItems. (DOM::HTMLSelectElementImpl::setSelectedIndex): ditto. (DOM::HTMLSelectElementImpl::length): ditto. (DOM::HTMLSelectElementImpl::remove): ditto. (DOM::HTMLSelectElementImpl::value): ditto. (DOM::HTMLSelectElementImpl::setValue): ditto. (DOM::HTMLSelectElementImpl::state): ditto. (DOM::HTMLSelectElementImpl::restoreState): ditto. (DOM::HTMLSelectElementImpl::appendFormData): ditto. (DOM::HTMLSelectElementImpl::optionToListIndex): ditto. (DOM::HTMLSelectElementImpl::listToOptionIndex): ditto. (DOM::HTMLSelectElementImpl::reset): ditto. (DOM::HTMLSelectElementImpl::notifyOptionSelected): ditto. (DOM::HTMLOptionElementImpl::index): ditto.
  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): If the list item is an <hr>, and we're not using a ListBox, then we call appendSeparator on the widget. (RenderSelect::layout): Updated type for array of listItems. (RenderSelect::slotSelected): ditto. (RenderSelect::slotSelectionChanged): ditto. (RenderSelect::updateSelection): ditto.
  • kwq/KWQListBox.h: Added ItemType enum with the following values: Option, GroupLabel, and Separator. (KWQListBoxItem::KWQListBoxItem): Updated to use ItemType instead of old isGroupLabel bool. (QListBox::appendItem): ditto. (QListBox::appendGroupLabel): ditto.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): the private version of appendItem used to take isLabel as a parameter. Now it takes an ItemType. (QComboBox::appendGroupLabel): calls appendItem with an ItemType of GroupLabel (QComboBox::appendSeparator): calls appendItem with an ItemType of Separator
  • kwq/KWQComboBox.mm: (QComboBox::setTitle): Updated to check for the ItemType instead of the old isGroupLabel bool. (QComboBox::appendItem): If the new item is a Separator, then we add a separatorItem to the popup menu. (QComboBox::sizeHint): Updated to check for the ItemType instead of the old isGroupLabel bool. (QComboBox::populateMenu): If the new item is a Separator, then we add a separatorItem to the popup menu.
  • kwq/KWQListBox.mm: (QListBox::appendItem): Updated to use the ItemType instead of the old isLabel bool. (QListBox::sizeForNumberOfLines): ditto. (-[KWQTableView tableView:shouldSelectRow:]): ditto. (-[KWQTableView drawRow:clipRect:]): ditto.
2:34 PM Changeset in webkit [10448] by adele
  • 7 edits in trunk/WebCore

Reviewed by Darin.

Test cases updated: manual-tests/select_hr.html:
updated for case where selection is changed for a list box that has an <hr> in its list items, even though it doesn't appear in the list.

  • khtml/rendering/render_form.cpp: (RenderSelect::slotSelectionChanged): Added counter that increments only for visible list items (options and optgroups). Before this change, list boxes that had invisible <hr>s could have the visible selected option get out of sync from the selected state. (RenderSelect::updateSelection): ditto.
  • kwq/KWQListBox.h: Changed enum from ItemType to KWQListBoxItemType and values to KWQListBoxOption, KWQListBoxGroupLabel, and KWQListBoxSeparator. (KWQListBoxItem::KWQListBoxItem): ditto. (QListBox::appendItem): ditto. (QListBox::appendGroupLabel): ditto.
  • kwq/KWQListBox.mm: (QListBox::appendItem): ditto. (QListBox::sizeForNumberOfLines): ditto. (-[KWQTableView tableView:shouldSelectRow:]): ditto. (-[KWQTableView drawRow:clipRect:]): ditto.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): ditto. (QComboBox::appendGroupLabel): ditto. (QComboBox::appendSeparator): ditto.
  • kwq/KWQComboBox.mm: (QComboBox::setTitle): ditto. (QComboBox::appendItem): ditto. (QComboBox::sizeHint): ditto. (QComboBox::populateMenu): ditto.
11:08 AM Changeset in webkit [10447] by bdakin
  • 4 edits in trunk

* empty log message *

9:47 AM Changeset in webkit [10446] by darin
  • 1 edit
    2 adds
    1 delete in trunk
  • added back a test now that Vicki fixed it so it no longer crashes
  • layout-tests/dom/html/level2/html/HTMLFrameElement09.html: Added.
  • layout-tests/dom/html/level2/html/HTMLFrameElement09-expected.txt: Added.
  • layout-tests/dom/html/level2/html/HTMLFrameElement09.html-disabled: Removed.
9:45 AM Changeset in webkit [10445] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/editing/apply_style_command.h: Change m_style to be a SharedPtr.
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): Added use of SharedPtr. (khtml::StyleChange::currentlyHasStyle): Ditto. (khtml::ApplyStyleCommand::ApplyStyleCommand): Ditto. (khtml::ApplyStyleCommand::~ApplyStyleCommand): Ditto. (khtml::ApplyStyleCommand::doApply): Ditto. (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): Ditto. (khtml::ApplyStyleCommand::removeCSSStyle): Ditto. (khtml::hasTextDecorationProperty): Ditto. (khtml::ApplyStyleCommand::extractTextDecorationStyle): Ditto. (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): Ditto. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Ditto. (khtml::ApplyStyleCommand::removeInlineStyle): Ditto. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto. (khtml::ApplyStyleCommand::computedFontSize): Ditto.
4:15 AM Changeset in webkit [10444] by eseidel
  • 12 edits
    1 add in trunk

Bug #: 4799
Submitted by: eseidel
Reviewed by: mjs

  • ForwardingHeaders/q3ptrdict.h: Added.
  • kdom/cache/KDOMCacheHelper.h:
  • kdom/cache/KDOMCachedDocument.cpp: (CachedDocument::checkNotify): (CachedDocument::error):
  • kdom/cache/KDOMCachedImage.cpp: (CachedImage::do_notify): (CachedImage::movieStatus): (CachedImage::data): (CachedImage::error):
  • kdom/cache/KDOMCachedObject.h:
  • kdom/cache/KDOMCachedScript.cpp: (CachedScript::checkNotify):
  • kdom/cache/KDOMCachedStyleSheet.cpp: (CachedStyleSheet::checkNotify): (CachedStyleSheet::error):
  • kdom/cache/KDOMLoader.cpp: (DocumentLoader::setAutoloadImages): (DocumentLoader::setShowAnimations): (Loader::numRequests): (Loader::cancelRequests): (Loader::jobForRequest):
  • kdom/cache/KDOMLoader.h:
  • kdom/ecma/Ecma.cpp: (Ecma::createEventListener):
  • kdom/ecma/ScriptInterpreter.cpp: (ScriptInterpreter::mark):
  • kwq/KWQPtrDict.h: Re-ran scripts from previous commit, now including QPtrDict. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4799
3:03 AM Changeset in webkit [10443] by eseidel
  • 101 edits
    10 adds in trunk

Bug #: 4799
Submitted by: eseidel
Reviewed by: mjs

  • ForwardingHeaders/q3cstring.h: Added.
  • ForwardingHeaders/q3dict.h: Added.
  • ForwardingHeaders/q3intdict.h: Added.
  • ForwardingHeaders/q3memarray.h: Added.
  • ForwardingHeaders/q3paintdevicemetrics.h: Added.
  • ForwardingHeaders/q3ptrcollection.h: Added.
  • ForwardingHeaders/q3ptrlist.h: Added.
  • ForwardingHeaders/q3ptrstack.h: Added.
  • ForwardingHeaders/q3valuelist.h: Added.
  • ForwardingHeaders/q3valuevector.h: Added.
  • kcanvas/KCanvas.cpp: (KCanvas::setCanvasSize): (KCanvas::invalidate):
  • kcanvas/KCanvasFilters.h: (KCanvasFEColorMatrix::values): (KCanvasFEColorMatrix::setValues):
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasRegistry.cpp: (operator<<):
  • kcanvas/KCanvasRegistry.h:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.h: (operator<<):
  • kcanvas/KCanvasTypes.h:
  • kcanvas/KCanvasView.cpp:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingDeviceFactory.cpp: (KRenderingDeviceFactory::request): (KRenderingDeviceFactory::deviceList):
  • kcanvas/device/KRenderingDeviceFactory.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (KCSortedGradientStopList::compareItems):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingStyle.h:
  • kdom/KDOMSettings.cpp: (KDOMSettings::isAdFiltered):
  • kdom/cache/KDOMCache.cpp: (Cache::init): (Cache::hasPending): (Cache::statistics):
  • kdom/cache/KDOMCache.h:
  • kdom/cache/KDOMCacheHelper.h:
  • kdom/cache/KDOMLoader.cpp: (Loader::numRequests): (Loader::cancelRequests):
  • kdom/cache/KDOMLoader.h:
  • kdom/core/DOMList.h:
  • kdom/core/DocumentImpl.cpp: (DocumentImpl::getElementById): (DocumentImpl::setPaintDevice): (DocumentImpl::getId):
  • kdom/core/DocumentImpl.h: (KDOM::DocumentImpl::paintDeviceMetrics): (KDOM::DocumentImpl::IdNameMapping::~IdNameMapping):
  • kdom/core/NamedNodeMapImpl.cpp: (RONamedNodeMapImpl::RONamedNodeMapImpl): (RONamedNodeMapImpl::getNamedItem):
  • kdom/core/NamedNodeMapImpl.h:
  • kdom/core/NodeImpl.cpp: (NodeImpl::compareDocumentPosition):
  • kdom/core/TextImpl.cpp: (TextImpl::wholeText): (TextImpl::checkChildren): (TextImpl::replaceWholeText): (TextImpl::logicallyAdjacentTextNodes):
  • kdom/core/TextImpl.h:
  • kdom/css/CSSPrimitiveValueImpl.cpp: (CSSPrimitiveValueImpl::computeLength): (CSSPrimitiveValueImpl::computeLengthFloat):
  • kdom/css/CSSPrimitiveValueImpl.h:
  • kdom/css/CSSRuleListImpl.h:
  • kdom/css/CSSStyleDeclarationImpl.cpp: (CSSStyleDeclarationImpl::CSSStyleDeclarationImpl): (CSSStyleDeclarationImpl::operator=): (CSSStyleDeclarationImpl::cssText): (CSSStyleDeclarationImpl::setCssText): (CSSStyleDeclarationImpl::getPropertyCSSValue): (CSSStyleDeclarationImpl::removeProperty): (CSSStyleDeclarationImpl::getPropertyPriority): (CSSStyleDeclarationImpl::setProperty):
  • kdom/css/CSSStyleDeclarationImpl.h: (KDOM::CSSStyleDeclarationImpl::values):
  • kdom/css/CSSStyleRuleImpl.cpp: (CSSStyleRuleImpl::setSelector):
  • kdom/css/CSSStyleRuleImpl.h: (KDOM::CSSStyleRuleImpl::selector):
  • kdom/css/CSSStyleSelector.cpp: (CSSStyleSelector::CSSStyleSelector): (CSSStyleSelector::computeFontSizes): (CSSStyleSelector::computeFontSizesFor): (nextFontSize): (CSSStyleSelector::addInlineDeclarations): (CSSStyleSelector::buildLists): (CSSStyleSelectorList::CSSStyleSelectorList): (CSSStyleSelectorList::append): (CSSStyleSelectorList::collect): (CSSOrderedPropertyList::compareItems): (CSSOrderedPropertyList::append): (CSSStyleSelector::convertToLength): (CSSStyleSelector::applyRule):
  • kdom/css/CSSStyleSelector.h: (KDOM::CSSStyleSelector::fontSizes): (KDOM::CSSStyleSelector::fixedFontSizes):
  • kdom/css/CSSStyleSheetImpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl):
  • kdom/css/CSSValueListImpl.cpp: (CSSValueListImpl::cssText):
  • kdom/css/CSSValueListImpl.h:
  • kdom/css/Font.cpp: (Font::update):
  • kdom/css/Font.h:
  • kdom/css/KDOMCSSParser.cpp: (CSSParser::createStyleDeclaration): (CSSParser::createCSSStyleDeclaration):
  • kdom/css/KDOMCSSParser.h:
  • kdom/css/MediaListImpl.cpp: (MediaListImpl::mediaText): (MediaListImpl::deleteMedium):
  • kdom/css/MediaListImpl.h:
  • kdom/css/StyleBaseImpl.cpp: (StyleBaseImpl::setParsedValue):
  • kdom/css/StyleBaseImpl.h:
  • kdom/css/StyleSheetListImpl.cpp: (StyleSheetListImpl::~StyleSheetListImpl): (StyleSheetListImpl::length): (StyleSheetListImpl::item):
  • kdom/css/StyleSheetListImpl.h:
  • kdom/ecma/ScriptInterpreter.cpp: (ScriptInterpreter::forgetDOMObject):
  • kdom/events/EventTargetImpl.cpp: (EventTargetImpl::addEventListener): (EventTargetImpl::removeEventListener): (EventTargetImpl::dispatchEvent): (EventTargetImpl::handleLocalEvents):
  • kdom/events/EventTargetImpl.h:
  • kdom/ls/LSParserImpl.cpp: (LSParserImpl::parse):
  • kdom/parser/KDOMDocumentBuilder.cpp:
  • kdom/xpath/impl/expression.cpp: (Expression::~Expression): (Expression::optimize): (Expression::isConstant):
  • kdom/xpath/impl/expression.h:
  • kdom/xpath/impl/functions.cpp: (Function::setArguments): (FunctionLibrary::getFunction):
  • kdom/xpath/impl/functions.h:
  • kdom/xpath/impl/path.cpp: (Path::~Path): (Path::optimize): (Path::doEvaluate): (Path::dump):
  • kdom/xpath/impl/path.h:
  • kdom/xpath/impl/step.cpp: (Step::Step): (Step::~Step): (Step::evaluate): (Step::optimize): (Step::dump):
  • kdom/xpath/impl/step.h:
  • kdom/xpath/impl/tokenizer.cpp: (Tokenizer::isAxisName): (Tokenizer::isNodeTypeName):
  • kdom/xpath/impl/tokenizer.h:
  • kdom/xpath/impl/util.h:
  • kdom/xpath/impl/variablereference.cpp: (VariableReference::doEvaluate):
  • kdom/xpointer/impl/ElementSchemeImpl.cpp: (ElementSchemeImpl::evaluate):
  • kdom/xpointer/impl/ElementSchemeImpl.h:
  • kdom/xpointer/impl/XPointerEvaluatorImpl.cpp: (XPointerEvaluatorImpl::createXPointer):
  • kdom/xpointer/impl/XPointerExpressionImpl.cpp:
  • kdom/xpointer/impl/XPointerExpressionImpl.h:
  • ksvg2/KSVGFactory.cpp: (KSVGFactory::createPartObject): (KSVGFactory::registerPart):
  • ksvg2/KSVGFactory.h: (KSVG::KSVGFactory::partList):
  • ksvg2/css/KSVGCSSParser.cpp: (SVGCSSParser::createCSSStyleDeclaration):
  • ksvg2/css/KSVGCSSParser.h:
  • ksvg2/css/SVGCSSStyleDeclarationImpl.cpp: (SVGCSSStyleDeclarationImpl::SVGCSSStyleDeclarationImpl):
  • ksvg2/css/SVGCSSStyleDeclarationImpl.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp: (SVGCSSStyleSelector::loadDefaultStyle): (SVGCSSStyleSelector::addExtraDeclarations):
  • ksvg2/css/SVGCSSStyleSelector.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::updateStroke): (KCanvasRenderingStyle::cssPrimitiveToLength):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (SVGTimer::notifyAll):
  • ksvg2/misc/KSVGTimeScheduler.h:
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::finishedParsing): (SVGDocumentImpl::recalcStyleSelector):
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::createCanvasItem):
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::pixelUnitToMillimeterX): (SVGSVGElementImpl::pixelUnitToMillimeterY):
  • kwq/KWQCString.h: Added #define q->q3.
  • kwq/KWQCollection.h:
  • kwq/KWQDict.h:
  • kwq/KWQIntDict.h:
  • kwq/KWQMemArray.h:
  • kwq/KWQPaintDeviceMetrics.h:
  • kwq/KWQPtrList.h:
  • kwq/KWQPtrStack.h:
  • kwq/KWQValueList.h:
  • kwq/KWQValueVector.h: Pulled over first section of Qt4 changes from kdom, mapping existing Qt3 classes to their new Qt4 names and adding necessary #defines to kwq to allow supporting both names. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4799

Sep 1, 2005:

5:19 PM Changeset in webkit [10442] by vicki
  • 2 edits in trunk/WebCore

Reviewed by John.

Test cases added: No new tests, HTMLFrameElement09.html covers this crash

  • fixed <rdar://problem/4224088> crash in KWQKHTMLPart::handledOnloadEvents loading test HTMLFrameElement09.html
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitClose): nil check on the part
5:02 PM Changeset in webkit [10441]
  • 21 copies
    3 deletes in tags/WebKit-312~5~1

This commit was manufactured by cvs2svn to create tag
'WebKit-312~5~1'.

5:02 PM Changeset in webkit [10440] by adele
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning for Safari-1-3-branch - WebKit-312.5.1

4:58 PM Changeset in webkit [10439] by adele
  • 3 edits in branches/Safari-1-3-branch/WebKit

Merged fix for <rdar://problem/4208261> from TOT to Safari-1-3-branch

2005-05-17 Chris Blumenberg <​cblu@apple.com>

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

Reviewed by mjs.

  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error
4:40 PM Changeset in webkit [10438] by darin
  • 2 edits
    2 adds in trunk

Reviewed by Maciej.

  • fixed <rdar://problem/3524912> repro crash in KHTMLParser::parseToken, due to parser's current element being destroyed (www.gnnetcom.dk)

Test cases added:

  • layout-tests/fast/parser/remove-parser-current-node.html: Added.
  • layout-tests/fast/parser/remove-parser-current-node-expected.txt: Added.
  • khtml/html/htmlparser.cpp: Changed block stack to hold a SharedPtr to the nodes in the stack -- needed because they might be destroyed by JavaScript. (HTMLParser::insertNode): Don't call attach() on the new node if the parent node isn't also attached. This happens when the parent node is no longer in the DOM tree because it was removed by JavaScript. (HTMLParser::popNestedHeaderTag): Updated since node is now a SharedPtr. (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Ditto. (HTMLParser::popOneBlock): Ditto.
12:41 PM Changeset in webkit [10437] by sullivan
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Excluded a known system leak to reduce noise; added comments about which leaks are being excluded.
11:57 AM Changeset in webkit [10436] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4790
Submitted by: eseidel
Reviewed by: sullivan

11:51 AM Changeset in webkit [10435] by tomernic
  • 2 edits in trunk/WebKitTools

Change made by Darin, reviewed by John and myself.

  • Allow semicolons at the end of method declarations (this is for method implementations; the semicolon is required for interface declarations).
  • Scripts/prepare-ChangeLog:
11:03 AM Changeset in webkit [10434] by harrison
  • 10 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4054701> assertion failure in khtml::isEqualIgnoringAffinity using VoiceOver in new Mail message

Problem was that an AXTextMarker was erroneously given UPSTREAM affinity. Fixed by having the
VisiblePosition constructors make the actual affinity DOWNSTREAM if UPSTREAM was specified, but
the Position is not at a line wrap.

Test cases added:

There is no way to automate a test for this because it requires using the AX APIs, which are
not available to the tests.
A manual test involves creating an email and using VoiceOver on it. Seems like too much.

  • khtml/editing/selection.h:
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): (khtml::VisiblePosition::next):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::nextBoundary): (khtml::endOfLine):
  • khtml/khtml_part.cpp: (KHTMLPart::findTextNext): (KHTMLPart::selectFrameElementInParentIfFullySelected):
  • khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]):
10:40 AM Changeset in webkit [10433] by adele
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4229189> add a way to get a separator into a <select>

This will allow an <hr> within a select element to display a separator in a popup menu.
These extra elements are added to our listItems array, which we use internally. But this should not
affect JavaScript operations, such as getting an index of an option element, or getting the length of the select,
or getting the selected index. In these cases, the <hr>s will be ignored.

Test cases added:

  • manual-tests/select_hr.html: Added.
  • khtml/html/html_formimpl.h: (DOM::HTMLSelectElementImpl::listItems): Now that our listItems can also contain <hr>s, I've changed listItems to be a QMemArray<HTMLElementImpl*> instead of QMemArray<HTMLGenericFormElementImpl*> (DOM::HTMLOptGroupElementImpl::checkDTD): Added check for <hr>
  • khtml/html/html_formimpl.cpp: (DOM::HTMLSelectElementImpl::checkDTD): Added check for <hr> (DOM::HTMLSelectElementImpl::add): Added check for <hr> so these elements can be added through Javascript. (DOM::HTMLSelectElementImpl::recalcListItems): Added case for <hr> to add the element to the listItems array. (DOM::HTMLSelectElementImpl::selectedIndex): Updated type for array of listItems. (DOM::HTMLSelectElementImpl::setSelectedIndex): ditto. (DOM::HTMLSelectElementImpl::length): ditto. (DOM::HTMLSelectElementImpl::remove): ditto. (DOM::HTMLSelectElementImpl::value): ditto. (DOM::HTMLSelectElementImpl::setValue): ditto. (DOM::HTMLSelectElementImpl::state): ditto. (DOM::HTMLSelectElementImpl::restoreState): ditto. (DOM::HTMLSelectElementImpl::appendFormData): ditto. (DOM::HTMLSelectElementImpl::optionToListIndex): ditto. (DOM::HTMLSelectElementImpl::listToOptionIndex): ditto. (DOM::HTMLSelectElementImpl::reset): ditto. (DOM::HTMLSelectElementImpl::notifyOptionSelected): ditto. (DOM::HTMLOptionElementImpl::index): ditto.
  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): If the list item is an <hr>, and we're not using a ListBox, then we call appendSeparator on the widget. (RenderSelect::layout): Updated type for array of listItems. (RenderSelect::slotSelected): ditto. (RenderSelect::slotSelectionChanged): ditto. (RenderSelect::updateSelection): ditto.
  • kwq/KWQListBox.h: Added ItemType enum with the following values: Option, GroupLabel, and Separator. (KWQListBoxItem::KWQListBoxItem): Updated to use ItemType instead of old isGroupLabel bool. (QListBox::appendItem): ditto. (QListBox::appendGroupLabel): ditto.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): the private version of appendItem used to take isLabel as a parameter. Now it takes an ItemType. (QComboBox::appendGroupLabel): calls appendItem with an ItemType of GroupLabel (QComboBox::appendSeparator): calls appendItem with an ItemType of Separator
  • kwq/KWQComboBox.mm: (QComboBox::setTitle): Updated to check for the ItemType instead of the old isGroupLabel bool. (QComboBox::appendItem): If the new item is a Separator, then we add a separatorItem to the popup menu. (QComboBox::sizeHint): Updated to check for the ItemType instead of the old isGroupLabel bool. (QComboBox::populateMenu): If the new item is a Separator, then we add a separatorItem to the popup menu.
  • kwq/KWQListBox.mm: (QListBox::appendItem): Updated to use the ItemType instead of the old isLabel bool. (QListBox::sizeForNumberOfLines): ditto. (-[KWQTableView tableView:shouldSelectRow:]): ditto. (-[KWQTableView drawRow:clipRect:]): ditto.
9:21 AM Changeset in webkit [10432] by darin
  • 3 edits
    1 add in trunk/WebCore

Reviewed and landed by Darin.

Test cases added:

  • manual-tests/word-spacing-highlight.html: Added.
  • khtml/rendering/render_text.h: (InlineTextBox::textObject): Made inline.
  • khtml/rendering/render_text.cpp: (InlineTextBox::selectionRect): Add word spacing in as necessary when computing the rect.
3:12 AM Changeset in webkit [10431] by eseidel
  • 1 edit
    5 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none

Removing unused files from SVG repository, no review requested.

  • ksvg2/dom/SVGAElement.cpp: Removed.
  • ksvg2/dom/SVGAElement.h: Removed.
  • ksvg2/dom/SVGAngle.cpp: Removed.
  • ksvg2/dom/SVGAngle.h: Removed.
  • ksvg2/dom/SVGAnimateColorElement.cpp: Removed.
  • ksvg2/dom/SVGAnimateColorElement.h: Removed.
  • ksvg2/dom/SVGAnimateElement.cpp: Removed.
  • ksvg2/dom/SVGAnimateElement.h: Removed.
  • ksvg2/dom/SVGAnimateTransformElement.cpp: Removed.
  • ksvg2/dom/SVGAnimateTransformElement.h: Removed.
  • ksvg2/dom/SVGAnimatedAngle.cpp: Removed.
  • ksvg2/dom/SVGAnimatedAngle.h: Removed.
  • ksvg2/dom/SVGAnimatedBoolean.cpp: Removed.
  • ksvg2/dom/SVGAnimatedBoolean.h: Removed.
  • ksvg2/dom/SVGAnimatedEnumeration.cpp: Removed.
  • ksvg2/dom/SVGAnimatedEnumeration.h: Removed.
  • ksvg2/dom/SVGAnimatedInteger.cpp: Removed.
  • ksvg2/dom/SVGAnimatedInteger.h: Removed.
  • ksvg2/dom/SVGAnimatedLength.cpp: Removed.
  • ksvg2/dom/SVGAnimatedLength.h: Removed.
  • ksvg2/dom/SVGAnimatedLengthList.cpp: Removed.
  • ksvg2/dom/SVGAnimatedLengthList.h: Removed.
  • ksvg2/dom/SVGAnimatedNumber.cpp: Removed.
  • ksvg2/dom/SVGAnimatedNumber.h: Removed.
  • ksvg2/dom/SVGAnimatedNumberList.cpp: Removed.
  • ksvg2/dom/SVGAnimatedNumberList.h: Removed.
  • ksvg2/dom/SVGAnimatedPathData.cpp: Removed.
  • ksvg2/dom/SVGAnimatedPathData.h: Removed.
  • ksvg2/dom/SVGAnimatedPoints.cpp: Removed.
  • ksvg2/dom/SVGAnimatedPoints.h: Removed.
  • ksvg2/dom/SVGAnimatedPreserveAspectRatio.cpp: Removed.
  • ksvg2/dom/SVGAnimatedPreserveAspectRatio.h: Removed.
  • ksvg2/dom/SVGAnimatedRect.cpp: Removed.
  • ksvg2/dom/SVGAnimatedRect.h: Removed.
  • ksvg2/dom/SVGAnimatedString.cpp: Removed.
  • ksvg2/dom/SVGAnimatedString.h: Removed.
  • ksvg2/dom/SVGAnimatedTransformList.cpp: Removed.
  • ksvg2/dom/SVGAnimatedTransformList.h: Removed.
  • ksvg2/dom/SVGAnimationElement.cpp: Removed.
  • ksvg2/dom/SVGAnimationElement.h: Removed.
  • ksvg2/dom/SVGCircleElement.cpp: Removed.
  • ksvg2/dom/SVGCircleElement.h: Removed.
  • ksvg2/dom/SVGClipPathElement.cpp: Removed.
  • ksvg2/dom/SVGClipPathElement.h: Removed.
  • ksvg2/dom/SVGColor.cpp: Removed.
  • ksvg2/dom/SVGColor.h: Removed.
  • ksvg2/dom/SVGComponentTransferFunctionElement.cpp: Removed.
  • ksvg2/dom/SVGComponentTransferFunctionElement.h: Removed.
  • ksvg2/dom/SVGDOMImplementation.cpp: Removed.
  • ksvg2/dom/SVGDOMImplementation.h: Removed.
  • ksvg2/dom/SVGDefsElement.cpp: Removed.
  • ksvg2/dom/SVGDefsElement.h: Removed.
  • ksvg2/dom/SVGDescElement.cpp: Removed.
  • ksvg2/dom/SVGDescElement.h: Removed.
  • ksvg2/dom/SVGDocument.cpp: Removed.
  • ksvg2/dom/SVGDocument.h: Removed.
  • ksvg2/dom/SVGElement.cpp: Removed.
  • ksvg2/dom/SVGElement.h: Removed.
  • ksvg2/dom/SVGElementInstance.cpp: Removed.
  • ksvg2/dom/SVGElementInstance.h: Removed.
  • ksvg2/dom/SVGElementInstanceList.cpp: Removed.
  • ksvg2/dom/SVGElementInstanceList.h: Removed.
  • ksvg2/dom/SVGEllipseElement.cpp: Removed.
  • ksvg2/dom/SVGEllipseElement.h: Removed.
  • ksvg2/dom/SVGException.cpp: Removed.
  • ksvg2/dom/SVGException.h: Removed.
  • ksvg2/dom/SVGExternalResourcesRequired.cpp: Removed.
  • ksvg2/dom/SVGExternalResourcesRequired.h: Removed.
  • ksvg2/dom/SVGFEBlendElement.cpp: Removed.
  • ksvg2/dom/SVGFEBlendElement.h: Removed.
  • ksvg2/dom/SVGFEColorMatrixElement.cpp: Removed.
  • ksvg2/dom/SVGFEColorMatrixElement.h: Removed.
  • ksvg2/dom/SVGFEComponentTransferElement.cpp: Removed.
  • ksvg2/dom/SVGFEComponentTransferElement.h: Removed.
  • ksvg2/dom/SVGFECompositeElement.cpp: Removed.
  • ksvg2/dom/SVGFECompositeElement.h: Removed.
  • ksvg2/dom/SVGFEFloodElement.cpp: Removed.
  • ksvg2/dom/SVGFEFloodElement.h: Removed.
  • ksvg2/dom/SVGFEFuncAElement.cpp: Removed.
  • ksvg2/dom/SVGFEFuncAElement.h: Removed.
  • ksvg2/dom/SVGFEFuncBElement.cpp: Removed.
  • ksvg2/dom/SVGFEFuncBElement.h: Removed.
  • ksvg2/dom/SVGFEFuncGElement.cpp: Removed.
  • ksvg2/dom/SVGFEFuncGElement.h: Removed.
  • ksvg2/dom/SVGFEFuncRElement.cpp: Removed.
  • ksvg2/dom/SVGFEFuncRElement.h: Removed.
  • ksvg2/dom/SVGFEGaussianBlurElement.cpp: Removed.
  • ksvg2/dom/SVGFEGaussianBlurElement.h: Removed.
  • ksvg2/dom/SVGFEImageElement.cpp: Removed.
  • ksvg2/dom/SVGFEImageElement.h: Removed.
  • ksvg2/dom/SVGFEMergeElement.cpp: Removed.
  • ksvg2/dom/SVGFEMergeElement.h: Removed.
  • ksvg2/dom/SVGFEMergeNodeElement.cpp: Removed.
  • ksvg2/dom/SVGFEMergeNodeElement.h: Removed.
  • ksvg2/dom/SVGFEOffsetElement.cpp: Removed.
  • ksvg2/dom/SVGFEOffsetElement.h: Removed.
  • ksvg2/dom/SVGFETileElement.cpp: Removed.
  • ksvg2/dom/SVGFETileElement.h: Removed.
  • ksvg2/dom/SVGFETurbulenceElement.cpp: Removed.
  • ksvg2/dom/SVGFETurbulenceElement.h: Removed.
  • ksvg2/dom/SVGFilterElement.cpp: Removed.
  • ksvg2/dom/SVGFilterElement.h: Removed.
  • ksvg2/dom/SVGFilterPrimitiveStandardAttributes.cpp: Removed.
  • ksvg2/dom/SVGFilterPrimitiveStandardAttributes.h: Removed.
  • ksvg2/dom/SVGFitToViewBox.cpp: Removed.
  • ksvg2/dom/SVGFitToViewBox.h: Removed.
  • ksvg2/dom/SVGGElement.cpp: Removed.
  • ksvg2/dom/SVGGElement.h: Removed.
  • ksvg2/dom/SVGGradientElement.cpp: Removed.
  • ksvg2/dom/SVGGradientElement.h: Removed.
  • ksvg2/dom/SVGImageElement.cpp: Removed.
  • ksvg2/dom/SVGImageElement.h: Removed.
  • ksvg2/dom/SVGLangSpace.cpp: Removed.
  • ksvg2/dom/SVGLangSpace.h: Removed.
  • ksvg2/dom/SVGLength.cpp: Removed.
  • ksvg2/dom/SVGLength.h: Removed.
  • ksvg2/dom/SVGLengthList.cpp: Removed.
  • ksvg2/dom/SVGLengthList.h: Removed.
  • ksvg2/dom/SVGLineElement.cpp: Removed.
  • ksvg2/dom/SVGLineElement.h: Removed.
  • ksvg2/dom/SVGLinearGradientElement.cpp: Removed.
  • ksvg2/dom/SVGLinearGradientElement.h: Removed.
  • ksvg2/dom/SVGLocatable.cpp: Removed.
  • ksvg2/dom/SVGLocatable.h: Removed.
  • ksvg2/dom/SVGMarkerElement.cpp: Removed.
  • ksvg2/dom/SVGMarkerElement.h: Removed.
  • ksvg2/dom/SVGMatrix.cpp: Removed.
  • ksvg2/dom/SVGMatrix.h: Removed.
  • ksvg2/dom/SVGNumber.cpp: Removed.
  • ksvg2/dom/SVGNumber.h: Removed.
  • ksvg2/dom/SVGNumberList.cpp: Removed.
  • ksvg2/dom/SVGNumberList.h: Removed.
  • ksvg2/dom/SVGPaint.cpp: Removed.
  • ksvg2/dom/SVGPaint.h: Removed.
  • ksvg2/dom/SVGPathElement.cpp: Removed.
  • ksvg2/dom/SVGPathElement.h: Removed.
  • ksvg2/dom/SVGPathSeg.cpp: Removed.
  • ksvg2/dom/SVGPathSeg.h: Removed.
  • ksvg2/dom/SVGPathSegArc.cpp: Removed.
  • ksvg2/dom/SVGPathSegArc.h: Removed.
  • ksvg2/dom/SVGPathSegClosePath.cpp: Removed.
  • ksvg2/dom/SVGPathSegClosePath.h: Removed.
  • ksvg2/dom/SVGPathSegCurvetoCubic.cpp: Removed.
  • ksvg2/dom/SVGPathSegCurvetoCubic.h: Removed.
  • ksvg2/dom/SVGPathSegCurvetoCubicSmooth.cpp: Removed.
  • ksvg2/dom/SVGPathSegCurvetoCubicSmooth.h: Removed.
  • ksvg2/dom/SVGPathSegCurvetoQuadratic.cpp: Removed.
  • ksvg2/dom/SVGPathSegCurvetoQuadratic.h: Removed.
  • ksvg2/dom/SVGPathSegCurvetoQuadraticSmooth.cpp: Removed.
  • ksvg2/dom/SVGPathSegCurvetoQuadraticSmooth.h: Removed.
  • ksvg2/dom/SVGPathSegLineto.cpp: Removed.
  • ksvg2/dom/SVGPathSegLineto.h: Removed.
  • ksvg2/dom/SVGPathSegLinetoHorizontal.cpp: Removed.
  • ksvg2/dom/SVGPathSegLinetoHorizontal.h: Removed.
  • ksvg2/dom/SVGPathSegLinetoVertical.cpp: Removed.
  • ksvg2/dom/SVGPathSegLinetoVertical.h: Removed.
  • ksvg2/dom/SVGPathSegList.cpp: Removed.
  • ksvg2/dom/SVGPathSegList.h: Removed.
  • ksvg2/dom/SVGPathSegMoveto.cpp: Removed.
  • ksvg2/dom/SVGPathSegMoveto.h: Removed.
  • ksvg2/dom/SVGPatternElement.cpp: Removed.
  • ksvg2/dom/SVGPatternElement.h: Removed.
  • ksvg2/dom/SVGPoint.cpp: Removed.
  • ksvg2/dom/SVGPoint.h: Removed.
  • ksvg2/dom/SVGPointList.cpp: Removed.
  • ksvg2/dom/SVGPointList.h: Removed.
  • ksvg2/dom/SVGPolygonElement.cpp: Removed.
  • ksvg2/dom/SVGPolygonElement.h: Removed.
  • ksvg2/dom/SVGPolylineElement.cpp: Removed.
  • ksvg2/dom/SVGPolylineElement.h: Removed.
  • ksvg2/dom/SVGPreserveAspectRatio.cpp: Removed.
  • ksvg2/dom/SVGPreserveAspectRatio.h: Removed.
  • ksvg2/dom/SVGRadialGradientElement.cpp: Removed.
  • ksvg2/dom/SVGRadialGradientElement.h: Removed.
  • ksvg2/dom/SVGRect.cpp: Removed.
  • ksvg2/dom/SVGRect.h: Removed.
  • ksvg2/dom/SVGRectElement.cpp: Removed.
  • ksvg2/dom/SVGRectElement.h: Removed.
  • ksvg2/dom/SVGSVGElement.cpp: Removed.
  • ksvg2/dom/SVGSVGElement.h: Removed.
  • ksvg2/dom/SVGScriptElement.cpp: Removed.
  • ksvg2/dom/SVGScriptElement.h: Removed.
  • ksvg2/dom/SVGSetElement.cpp: Removed.
  • ksvg2/dom/SVGSetElement.h: Removed.
  • ksvg2/dom/SVGStopElement.cpp: Removed.
  • ksvg2/dom/SVGStopElement.h: Removed.
  • ksvg2/dom/SVGStringList.cpp: Removed.
  • ksvg2/dom/SVGStringList.h: Removed.
  • ksvg2/dom/SVGStylable.cpp: Removed.
  • ksvg2/dom/SVGStylable.h: Removed.
  • ksvg2/dom/SVGStyleElement.cpp: Removed.
  • ksvg2/dom/SVGStyleElement.h: Removed.
  • ksvg2/dom/SVGSwitchElement.cpp: Removed.
  • ksvg2/dom/SVGSwitchElement.h: Removed.
  • ksvg2/dom/SVGSymbolElement.cpp: Removed.
  • ksvg2/dom/SVGSymbolElement.h: Removed.
  • ksvg2/dom/SVGTSpanElement.cpp: Removed.
  • ksvg2/dom/SVGTSpanElement.h: Removed.
  • ksvg2/dom/SVGTests.cpp: Removed.
  • ksvg2/dom/SVGTests.h: Removed.
  • ksvg2/dom/SVGTextContentElement.cpp: Removed.
  • ksvg2/dom/SVGTextContentElement.h: Removed.
  • ksvg2/dom/SVGTextElement.cpp: Removed.
  • ksvg2/dom/SVGTextElement.h: Removed.
  • ksvg2/dom/SVGTextPositioningElement.cpp: Removed.
  • ksvg2/dom/SVGTextPositioningElement.h: Removed.
  • ksvg2/dom/SVGTitleElement.cpp: Removed.
  • ksvg2/dom/SVGTitleElement.h: Removed.
  • ksvg2/dom/SVGTransform.cpp: Removed.
  • ksvg2/dom/SVGTransform.h: Removed.
  • ksvg2/dom/SVGTransformList.cpp: Removed.
  • ksvg2/dom/SVGTransformList.h: Removed.
  • ksvg2/dom/SVGTransformable.cpp: Removed.
  • ksvg2/dom/SVGTransformable.h: Removed.
  • ksvg2/dom/SVGURIReference.cpp: Removed.
  • ksvg2/dom/SVGURIReference.h: Removed.
  • ksvg2/dom/SVGUseElement.cpp: Removed.
  • ksvg2/dom/SVGUseElement.h: Removed.
  • ksvg2/dom/SVGViewElement.cpp: Removed.
  • ksvg2/dom/SVGViewElement.h: Removed.
  • ksvg2/dom/SVGZoomAndPan.cpp: Removed.
  • ksvg2/dom/SVGZoomAndPan.h: Removed.
  • ksvg2/events/SVGEvent.cpp: Removed.
  • ksvg2/events/SVGEvent.h: Removed.
  • ksvg2/events/SVGZoomEvent.cpp: Removed.
  • ksvg2/events/SVGZoomEvent.h: Removed.
2:39 AM Changeset in webkit [10430] by eseidel
  • 158 edits in trunk

Bug #: 4790
Submitted by: eseidel
Reviewed by: mjs

  • WebCore+SVG/DrawCanvasItem.mm: header include changes.
  • WebCore+SVG/DrawDocument.mm:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kdom/cache/KDOMLoader.cpp:
  • kdom/core/AttrImpl.h:
  • kdom/core/CDATASectionImpl.h:
  • kdom/core/CDFInterface.cpp:
  • kdom/core/CDFInterface.h:
  • kdom/core/CharacterDataImpl.h:
  • kdom/core/CommentImpl.h:
  • kdom/core/DOMConfigurationImpl.h:
  • kdom/core/DOMImplementationImpl.cpp:
  • kdom/core/DocumentFragmentImpl.h:
  • kdom/core/DocumentImpl.cpp:
  • kdom/core/DocumentImpl.h:
  • kdom/core/DocumentTypeImpl.h:
  • kdom/core/ElementImpl.h:
  • kdom/core/EntityImpl.h:
  • kdom/core/EntityReferenceImpl.h:
  • kdom/core/NamedAttrMapImpl.h:
  • kdom/core/NamedNodeMapImpl.h:
  • kdom/core/NodeImpl.h:
  • kdom/core/NotationImpl.h:
  • kdom/core/ProcessingInstructionImpl.h:
  • kdom/core/TagNodeListImpl.h:
  • kdom/core/TextImpl.h:
  • kdom/core/XMLElementImpl.h:
  • kdom/css/CSSCharsetRuleImpl.h:
  • kdom/css/CSSFontFaceRuleImpl.h:
  • kdom/css/CSSHelper.h:
  • kdom/css/CSSImageValueImpl.cpp:
  • kdom/css/CSSImageValueImpl.h:
  • kdom/css/CSSImportRuleImpl.h:
  • kdom/css/CSSMediaRuleImpl.h:
  • kdom/css/CSSPageRuleImpl.h:
  • kdom/css/CSSPrimitiveValueImpl.cpp:
  • kdom/css/CSSPrimitiveValueImpl.h:
  • kdom/css/CSSRuleImpl.h:
  • kdom/css/CSSStyleDeclarationImpl.cpp:
  • kdom/css/CSSStyleDeclarationImpl.h:
  • kdom/css/CSSStyleRuleImpl.h:
  • kdom/css/CSSStyleSelector.cpp:
  • kdom/css/CSSStyleSelector.h:
  • kdom/css/CSSStyleSheetImpl.h:
  • kdom/css/CSSUnknownRuleImpl.h:
  • kdom/css/CSSValueImpl.h:
  • kdom/css/CSSValueListImpl.h:
  • kdom/css/DocumentCSSImpl.h:
  • kdom/css/KDOMCSSParser.cpp:
  • kdom/css/KDOMCSSParser.h:
  • kdom/css/MediaListImpl.h:
  • kdom/css/RenderStyle.h:
  • kdom/css/RenderStyleDefs.h:
  • kdom/css/StyleBaseImpl.cpp:
  • kdom/css/StyleBaseImpl.h:
  • kdom/css/StyleSheetImpl.h:
  • kdom/css/kdomparsercss.y:
  • kdom/events/EventListenerImpl.h:
  • kdom/events/KeyboardEventImpl.h:
  • kdom/events/MouseEventImpl.h:
  • kdom/events/MutationEventImpl.h:
  • kdom/events/UIEventImpl.h:
  • kdom/ls/LSParserImpl.h:
  • kdom/ls/LSSerializerFilterImpl.h:
  • kdom/parser/KDOMParser.h:
  • kdom/range/DocumentRangeImpl.cpp:
  • kdom/traversal/NodeIteratorImpl.h:
  • kdom/traversal/TreeWalkerImpl.h:
  • kdom/xpath/XPathNamespaceImpl.h:
  • ksvg2/css/KSVGCSSParser.cpp:
  • ksvg2/css/KSVGCSSParser.h:
  • ksvg2/css/SVGCSSStyleDeclarationImpl.cpp:
  • ksvg2/css/SVGCSSStyleDeclarationImpl.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/css/SVGCSSStyleSelector.h:
  • ksvg2/css/SVGCSSStyleSheetImpl.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/ecma/GlobalObject.cpp:
  • ksvg2/events/SVGEvent.cpp:
  • ksvg2/events/SVGEventImpl.h:
  • ksvg2/events/SVGZoomEvent.cpp:
  • ksvg2/events/SVGZoomEventImpl.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/CDFInterface.cpp:
  • ksvg2/svg/CDFInterface.h:
  • ksvg2/svg/SVGAElementImpl.cpp:
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGCircleElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGElementImpl.h:
  • ksvg2/svg/SVGElementInstanceImpl.h:
  • ksvg2/svg/SVGEllipseElementImpl.cpp:
  • ksvg2/svg/SVGExternalResourcesRequiredImpl.cpp:
  • ksvg2/svg/SVGFEBlendElementImpl.cpp:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
  • ksvg2/svg/SVGFECompositeElementImpl.cpp:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeNodeElementImpl.cpp:
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp:
  • ksvg2/svg/SVGFETileElementImpl.cpp:
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
  • ksvg2/svg/SVGFilterElementImpl.cpp:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGImageElementImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.cpp:
  • ksvg2/svg/SVGLengthImpl.h:
  • ksvg2/svg/SVGLineElementImpl.cpp:
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGMarkerElementImpl.cpp:
  • ksvg2/svg/SVGPathElementImpl.cpp:
  • ksvg2/svg/SVGPathSegClosePathImpl.h:
  • ksvg2/svg/SVGPathSegImpl.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontalImpl.h:
  • ksvg2/svg/SVGPathSegLinetoImpl.h:
  • ksvg2/svg/SVGPathSegLinetoVerticalImpl.h:
  • ksvg2/svg/SVGPathSegMovetoImpl.h:
  • ksvg2/svg/SVGPatternElementImpl.cpp:
  • ksvg2/svg/SVGPolyElementImpl.cpp:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp:
  • ksvg2/svg/SVGRectElementImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGScriptElementImpl.cpp:
  • ksvg2/svg/SVGStopElementImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGSwitchElementImpl.cpp:
  • ksvg2/svg/SVGTestsImpl.cpp:
  • ksvg2/svg/SVGTextContentElementImpl.cpp:
  • ksvg2/svg/SVGTextPositioningElementImpl.cpp:
  • ksvg2/svg/SVGTransformableImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.cpp:
  • ksvg2/svg/SVGUseElementImpl.cpp:
  • ksvg2/svg/SVGViewElementImpl.cpp:
  • ksvg2/svg/SVGZoomAndPanImpl.cpp: I renamed: kdom/impl -> kdom/core kdom/css/impl/* -> kdom/css/* kdom/css/impl/* -> kdom/css/* kdom/ls/impl/* -> kdom/ls/* kdom/events/impl/* -> kdom/events/* kdom/range/impl/* -> kdom/range/* kdom/traversal/impl/* -> kdom/traversal/* ksvg2/core -> ksvg2/misc kdom/impl -> kdom/svg ksvg2/css/impl/* -> ksvg2/css/* ksvg2/events/impl/* -> ksvg2/events/* And made all the necessary header include and project file changes. This now brings our source tree fully up-to-date with all the recent kdom/ksvg2 file re-orgs (which were done per our request). ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4790
12:35 AM Changeset in webkit [10429] by eseidel
  • 834 edits in trunk

Bug #: 4752
Submitted by: eseidel
Reviewed by: mjs

Replaced tabs with spaces throughout all of SVGSupport, excepting
kdom/xpath upon specific request of the kdom/xpath maintainer.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4752

Note: See TracTimeline for information about the timeline view.