Timeline

Sep 12, 2005:

5:32 PM Changeset in webkit [10528]

• 227 copies
  14 deletes in tags/WebCore-417

This commit was manufactured by cvs2svn to create tag 'WebCore-417'.

5:32 PM Changeset in webkit [10527] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin and Adele.

A workaround for a GCC bug, Justin to file a radar with a reduction soon.

• kwq/KWQPainter.mm: (QPainter::drawFloatPixmap):

5:28 PM Changeset in webkit [10526] by adele

• 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin and Adele.

A workaround for a GCC bug, Justin to file a radar with a reduction soon.

• kwq/KWQPainter.mm: (QPainter::drawFloatPixmap):

2:53 PM Changeset in webkit [10525] by eseidel

• 5 edits in trunk

Bug #: none
Submitted by: eseidel
Reviewed by: none, build fix only for svg.

Fixes build after qstring() -> string() rename this weekend.

• kdom/Helper.cpp: (parseLength):
• kdom/core/DOMStringImpl.cpp: (DOMStringImpl::toInt):
• kdom/core/DocumentImpl.cpp: (DocumentImpl::getId):
• kdom/css/CSSStyleSelector.cpp: (checkPseudoState):

Sep 11, 2005:

9:42 PM Changeset in webkit [10524] by darin

• 2 edits
  2 adds in trunk

Reviewed by John Sullivan.

• fixed <rdar://problem/4126166> using JavaScript-assigned accesskeys crashes Safari - DOM::NodeImpl::dispatchEvent

Test cases added:

• layout-tests/fast/events/access-key-self-destruct.html: Added.
• layout-tests/fast/events/access-key-self-destruct-expected.txt: Added.

• khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchMouseEvent): Ref the node for the duration with a SharedPtr; this helps in cases where the last reference to the node goes away inside the event handler.

8:43 PM Changeset in webkit [10523] by darin

• 1 edit in trunk/WebCore/khtml/xml/dom_atomicstringlist.h

Forgot to check this in (was mentioned in ChangeLog).

8:40 PM Changeset in webkit [10522] by darin

• 7 edits in trunk/WebCore

Reviewed by Eric.

• changed back the name of a couple of string() functions that were renamed to qstring() by accident

• kwq/KWQString.h: (QConstString::string): Changed function name back to string() from qstring(). This is a function from Qt, so the name needs to match Qt -- that's just how KWQ works.

• khtml/xml/dom_atomicstringlist.h: Changed the name of the function that returns the current AtomicString to string() back from qstring()!

• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): Use string() instead of qstring(). (khtml::checkPseudoState): Ditto. (khtml::CSSStyleSelector::checkOneSelector): Ditto.
• khtml/dom/dom_string.cpp: (DOM::DOMString::percentage): Ditto.
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::finish): Ditto.
• khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::DOMStringImpl): Small tweak to streamline a tiny bit by using an already-computed boolean instead of re-checking a couple of data members. (DOM::parseLength): Use string() instead of qstring(). (DOM::DOMStringImpl::toInt): Ditto.

• removed some dead code

• khtml/xml/dom_elementimpl.cpp: Removed XMLElementImpl.

10:04 AM Changeset in webkit [10521] by darin

• 6 edits in trunk

WebKit:

Reviewed, tweaked, and landed by Darin.

• fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4286 .Mac prefpane crashes when Safari using CVS WebKit is running

• WebView.subproj/WebView.m: (-[WebView initWithFrame:frameName:groupName:]): If ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH, and WEBKIT_UNSET_DYLD_FRAMEWORK_PATH is set in the environment, then unset DYLD_FRAMEWORK_PATH.

• WebKit.xcodeproj/project.pbxproj: Set ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in configurations other than Default -- we don't want that code in production builds, but we want it in builds we do ourselves and nightly builds.

WebKitTools:

Reviewed, tweaked, and landed by Darin.

• fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4286 .Mac prefpane crashes when Safari using CVS WebKit is running

• Scripts/run-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH.
• Scripts/run-webkit-app: Ditto.

3:41 AM Changeset in webkit [10520] by eseidel

• 2 edits in trunk/JavaScriptCore

Bug #: 4932
Submitted by: eseidel
Reviewed by: self, only affects SVG; build fix.

• JavaScriptCore.xcodeproj/project.pbxproj: Fixed JSC+SVG Fixed JavaScriptCore+SVG after PCRE 6.1 merger. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4932

2:28 AM Changeset in webkit [10519] by darin

• 2 edits in trunk/WebKitTools

• Scripts/run-webkit-tests: Oops. Use spaces, not tabs.

2:23 AM Changeset in webkit [10518] by darin

• 2 edits in trunk/WebKitTools

Reviewed by Eric.

• Scripts/run-webkit-tests: Sort tests with a new "pathcmp" function that's better in two ways: 1) puts all files in a directory before any files in a subdirectory, and 2) sort file names with numeric digits in them in a logical way, so test-33 will come before test-3.