⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 22, 2005:

8:54 PM Changeset in webkit [10602] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4649
Submitted by: Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>
Reviewed by: eseidel

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: Deployment build fix.
8:31 PM Changeset in webkit [10601] by eseidel
  • 10 edits
    2 deletes in trunk/WebKitTools

Bug #: 5003
Submitted by: eseidel
Reviewed by: mjs

Update tools for WebCore+SVG -> WebCore rename.
Also fold several SVG specific tools into their original
WebCore counterparts.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5003

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • DumpKCanvasTree/DumpKCanvasTree.xcodeproj/project.pbxproj:
  • Scripts/build-drawtest:
  • Scripts/build-dumpkcanvastree:
  • Scripts/build-webcore-svg: Removed.
  • Scripts/build-webkit: added --svg option
  • Scripts/run-drawtest:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm: various additions.
  • checkout: added --svg option
  • checkout-svg: Removed.
8:28 PM Changeset in webkit [10600] by eseidel
  • 7 edits
    8 adds in trunk/WebCore

Bug #: 5003
Submitted by: eseidel
Reviewed by: hyatt

Added KDOM and KCanvas wrapper objects for the WebCore DOM
and WebCore render tree. This allows using SVG in any
WebKit app, including Safari.
Also added extensions to QPainter to return a
KRenderingDeviceContext object to be passed into KCanvas.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5003

  • WebCore+SVG/dom_kdomdocumentwrapper.cpp: Added. (KDOMDocumentWrapperImpl::renderingDevice): (KDOMDocumentWrapperImpl::KDOMDocumentWrapperImpl): (KDOMDocumentWrapperImpl::~KDOMDocumentWrapperImpl): (DOM::KDOMDocumentWrapperImpl::createTokenizer): (KDOMDocumentWrapperImpl::svgView):
  • WebCore+SVG/dom_kdomdocumentwrapper.h: Added.
  • WebCore+SVG/dom_kdomnodetreewrapper.cpp: Added. (DOM::KDOMNodeTreeWrapperImpl::KDOMNodeTreeWrapperImpl): (KDOMNodeTreeWrapperImpl::~KDOMNodeTreeWrapperImpl): (KDOMNodeTreeWrapperImpl::attach): (KDOMNodeTreeWrapperImpl::createRenderer):
  • WebCore+SVG/dom_kdomnodetreewrapper.h: Added.
  • WebCore+SVG/render_kcanvaswrapper.cpp: Added. (RenderKCanvasWrapper::RenderKCanvasWrapper): (RenderKCanvasWrapper::~RenderKCanvasWrapper): (RenderKCanvasWrapper::layout): (RenderKCanvasWrapper::paint): (RenderKCanvasWrapper::intrinsicWidth): (RenderKCanvasWrapper::intrinsicHeight):
  • WebCore+SVG/render_kcanvaswrapper.h: Added. (khtml::RenderKCanvasWrapper::renderName): (khtml::RenderKCanvasWrapper::setCanvas):
  • WebCore+SVG/xml_kdomtokenizer.cpp: Added. (KDOMTokenizer::KDOMTokenizer): (KDOMTokenizer::~KDOMTokenizer): (KDOMTokenizer::documentWrapper): (KDOMTokenizer::write): (KDOMTokenizer::setOnHold): (KDOMTokenizer::finish): (KDOMTokenizer::isWaitingForScripts): (khtml::newKDOMTokenizer):
  • WebCore+SVG/xml_kdomtokenizer.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/khtml_part.cpp: (KHTMLPart::begin):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createKDOMDocument):
  • khtml/xml/dom_docimpl.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): (QPainterPrivate::~QPainterPrivate): (QPainter::renderingDeviceContext):
4:33 PM Changeset in webkit [10599]
  • 80 copies
    5 deletes in tags/JavaScriptCore-416~9

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~9'.

4:33 PM Changeset in webkit [10598] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Added versioning for JavaScriptCore-416.9 submission.

1:09 PM Changeset in webkit [10597] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by darin and mjs.

  • kjs/simple_number.h: changed enums to indenpendent constants to clarify types (KJS::isNegativeZero): changed to static function - no reason to export (KJS::SimpleNumber::rightShiftSignExtended): new function for clarity (KJS::SimpleNumber::make): specified cast as reinterpret_cast (KJS::SimpleNumber::is): changed to use uintptr_t for portability (KJS::SimpleNumber::value): changed to use uintptr_t and rightShiftSignExtended (KJS::SimpleNumber::fits): inverted tests - probably only a performance win for double (KJS::SimpleNumber::integerFits): ditto
12:28 PM Changeset in webkit [10596] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore
  • Fixed <rdar://problem/4263434> <rdar://problem/4263434> Denver 8F29 Regression: KJS::InterpreterImp::mark() crash

Fix by mjs, review by Geoff.

  • kjs/internal.cpp: (KJS::InterpreterImp::mark): Added a null check on globExec in case a garbage collection occurs inside InterpreterImp::globalInit (called from InterpreterImp::InterpreterImp), at which point globExec has not yet been initialized.
12:22 PM Changeset in webkit [10595] by thatcher
  • 3 edits in branches/Safari-Den-branch/JavaScriptCore

Merges fixes from TOT to Safari-Den-branch

2005-09-20 Geoffrey Garen <​ggaren@apple.com>

  • More changes needed to fix <rdar://problem/4214783> 8F29 REGRESSION(Denver/Chardonnay): kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Added InterpreterLocks in some places in the bindings we missed before.

Reviewed by john.

  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp):
12:19 PM Changeset in webkit [10594] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMDocumentNode): Don't use a static (global) identifier for the string "document" -- instead just create one each time. This eliminates the kjs_fast_malloc assertion on quit and does not create a significant performance regression because this is done at most once per JavaScript window object.
12:14 PM Changeset in webkit [10593] by thatcher
  • 3 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-09-20 Geoffrey Garen <​ggaren@apple.com>

  • More changes needed to fix <rdar://problem/4214783> 8F29 REGRESSION(Denver/Chardonnay): kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Added InterpreterLocks in some places in the bindings we missed before.

Reviewed by john.

  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): (KJS::Bindings::removeNativeReference): (RootObject::removeAllNativeReferences):
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::~RootObject): (KJS::Bindings::RootObject::setRootObjectImp):

Sep 21, 2005:

2:58 PM Changeset in webkit [10592] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore
  • Fixed <rdar://problem/4263434> <rdar://problem/4263434> Denver 8F29 Regression: KJS::InterpreterImp::mark() crash

Fix by mjs, review by Geoff.

  • kjs/internal.cpp: (KJS::InterpreterImp::mark): Added a null check on globExec in case a garbage collection occurs inside InterpreterImp::globalInit (called from InterpreterImp::InterpreterImp), at which point globExec has not yet been initialized.
2:52 PM Changeset in webkit [10591] by hyatt
  • 5 edits in trunk/LayoutTests/editing

Update editing tests to fix failures.

2:05 PM Changeset in webkit [10590] by vicki
  • 4 edits
    24 adds in trunk

Changes by Romain Brestac, reviewed by Darin.

  • khtml/misc/loader.cpp: (CachedXSLStyleSheet::CachedXSLStyleSheet): (CachedXSLStyleSheet::data):
  • khtml/misc/loader.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::addToResult): (DOM::XSLTProcessorImpl::documentFromXMLDocPtr):

Test cases added:

  • layout-tests/fast/xsl/resources/unicode.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc-cyr.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc.xsl: Added.
  • layout-tests/fast/xsl/resources/xslt-enc16.xsl: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc-cyr.xml: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc.xml: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc16-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc16.xml: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.png: Added.
  • layout-tests/fast/xsl/xslt-enc16to16-expected.txt: Added.
  • layout-tests/fast/xsl/xslt-enc16to16.xml: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.checksum: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.png: Added.
  • layout-tests/fast/xsl/xslt_unicode-expected.txt: Added.
  • layout-tests/fast/xsl/xslt_unicode.xml: Added.
10:32 AM Changeset in webkit [10589] by vicki
  • 5 edits
    8 adds in trunk

Reviewed by Darin.

  • fix these bugs <rdar://problem/3579812> HTMLTableElement.insertRow(n) inserts row at the beginning of the table (4043) <rdar://problem/3711188> HTMLTableElement.insertRow() doesn't respect passed index
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::insertRow): if the index is the same as the number of rows in the section, we should append

Update test results for /fast/dynamic/013.html. In the old version the the rows
and cells were children of the first table section, a tfoot. They are now children
of the second table section, a tbody. Our rendering now matches Gecko and Win IE
(according to yusufg on #webkit, comparing with 013-expected.png) for this case.

  • layout-tests/fast/dynamic/013-expected.checksum:
  • layout-tests/fast/dynamic/013-expected.png:
  • layout-tests/fast/dynamic/013-expected.txt:

Test cases added:

  • layout-tests/fast/dynamic/014-expected.checksum: Added.
  • layout-tests/fast/dynamic/014-expected.png: Added.
  • layout-tests/fast/dynamic/014-expected.txt: Added.
  • layout-tests/fast/dynamic/014.html: Added.
  • layout-tests/fast/dynamic/015-expected.checksum: Added.
  • layout-tests/fast/dynamic/015-expected.png: Added.
  • layout-tests/fast/dynamic/015-expected.txt: Added.
  • layout-tests/fast/dynamic/015.html: Added.
Note: See TracTimeline for information about the timeline view.