⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 28, 2005:

7:59 PM Changeset in webkit [10659]
  • 81 copies
    5 deletes in tags/JavaScriptCore-416~10

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~10'.

7:59 PM Changeset in webkit [10658] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Merges fixes from TOT to Safari-Den-branch

2005-09-28 Geoffrey Garen <ggaren@apple.com>

  • Fixed <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): If the timezone isn't specified, rather than returning invalidDate, substitute the local timezone. This matches the behavior of FF/IE.
7:58 PM Changeset in webkit [10657]
  • 68 copies
    5 deletes in tags/JavaScriptCore-417

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417'.

7:58 PM Changeset in webkit [10656] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-09-28 Geoffrey Garen <ggaren@apple.com>

  • Fixed <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): If the timezone isn't specified, rather than returning invalidDate, substitute the local timezone. This matches the behavior of FF/IE.
6:55 PM Changeset in webkit [10655] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • Fixed <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): If the timezone isn't specified, rather than returning invalidDate, substitute the local timezone. This matches the behavior of FF/IE.
3:27 PM Changeset in webkit [10654] by mjs
  • 3 edits in trunk/JavaScriptCore

Patch from George Staikos, reviewed by me.

  • fixed some compile issues on Linux
  • kjs/property_slot.h:
  • kjs/simple_number.h:
3:01 PM Changeset in webkit [10653] by mjs
  • 21 edits
    9 adds
    5 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/internal.cpp: (KJS::interpreterMap): Function that fetches the interpreter map on demand. (KJS::InterpreterImp::InterpreterImp): Replace use of InterpreterMap class with an appropriate HashMap. (KJS::InterpreterImp::clear): ditto (KJS::InterpreterImp::interpreterWithGlobalObject): ditto
  • kjs/interpreter_map.cpp: Removed.
  • kjs/interpreter_map.h: Removed.

The HashMap/HashSet code (copied and slightly tweaked from WebCore)

  • kxmlcore/HashFunctions.h: Added. (KXMLCore::4): (KXMLCore::8): (KXMLCore::): (KXMLCore::PointerHash::hash): (KXMLCore::PointerHash::equal):
  • kxmlcore/HashMap.h: Added. (KXMLCore::extractFirst): (KXMLCore::HashMap::HashMap): (KXMLCore::::size): (KXMLCore::::capacity): (KXMLCore::::isEmpty): (KXMLCore::::begin): (KXMLCore::::end): (KXMLCore::::find): (KXMLCore::::contains): (KXMLCore::::set): (KXMLCore::::get): (KXMLCore::::remove): (KXMLCore::::clear): (KXMLCore::deleteAllValues):
  • kxmlcore/HashMapPtrSpec.h: Added. (KXMLCore::PointerHashIteratorAdapter::PointerHashIteratorAdapter): (KXMLCore::PointerHashIteratorAdapter::operator*): (KXMLCore::PointerHashIteratorAdapter::operator->): (KXMLCore::PointerHashIteratorAdapter::operator++): (KXMLCore::PointerHashIteratorAdapter::operator==): (KXMLCore::PointerHashIteratorAdapter::operator!=): (KXMLCore::PointerHashConstIteratorAdapter::PointerHashConstIteratorAdapter): (KXMLCore::PointerHashConstIteratorAdapter::operator*): (KXMLCore::PointerHashConstIteratorAdapter::operator->): (KXMLCore::PointerHashConstIteratorAdapter::operator++): (KXMLCore::PointerHashConstIteratorAdapter::operator==): (KXMLCore::PointerHashConstIteratorAdapter::operator!=): (KXMLCore::):
  • kxmlcore/HashSet.h: Added. (KXMLCore::identityExtract): (KXMLCore::convertAdapter): (KXMLCore::HashSet::HashSet): (KXMLCore::::size): (KXMLCore::::capacity): (KXMLCore::::isEmpty): (KXMLCore::::begin): (KXMLCore::::end): (KXMLCore::::find): (KXMLCore::::contains): (KXMLCore::::insert): (KXMLCore::::remove): (KXMLCore::::clear):
  • kxmlcore/HashTable.cpp: Added. (KXMLCore::HashTableStats::~HashTableStats): (KXMLCore::HashTableStats::recordCollisionAtCount):
  • kxmlcore/HashTable.h: Added. (KXMLCore::HashTableIterator::skipEmptyBuckets): (KXMLCore::HashTableIterator::HashTableIterator): (KXMLCore::HashTableIterator::operator*): (KXMLCore::HashTableIterator::operator->): (KXMLCore::HashTableIterator::operator++): (KXMLCore::HashTableIterator::operator==): (KXMLCore::HashTableIterator::operator!=): (KXMLCore::HashTableConstIterator::HashTableConstIterator): (KXMLCore::HashTableConstIterator::operator*): (KXMLCore::HashTableConstIterator::operator->): (KXMLCore::HashTableConstIterator::skipEmptyBuckets): (KXMLCore::HashTableConstIterator::operator++): (KXMLCore::HashTableConstIterator::operator==): (KXMLCore::HashTableConstIterator::operator!=): (KXMLCore::HashTable::HashTable): (KXMLCore::HashTable::~HashTable): (KXMLCore::HashTable::begin): (KXMLCore::HashTable::end): (KXMLCore::HashTable::size): (KXMLCore::HashTable::capacity): (KXMLCore::HashTable::insert): (KXMLCore::HashTable::isEmptyBucket): (KXMLCore::HashTable::isDeletedBucket): (KXMLCore::HashTable::isEmptyOrDeletedBucket): (KXMLCore::HashTable::hash): (KXMLCore::HashTable::equal): (KXMLCore::HashTable::identityConvert): (KXMLCore::HashTable::extractKey): (KXMLCore::HashTable::lookup): (KXMLCore::HashTable::shouldExpand): (KXMLCore::HashTable::mustRehashInPlace): (KXMLCore::HashTable::shouldShrink): (KXMLCore::HashTable::shrink): (KXMLCore::HashTable::clearBucket): (KXMLCore::HashTable::deleteBucket): (KXMLCore::HashTable::makeLookupResult): (KXMLCore::HashTable::makeIterator): (KXMLCore::HashTable::makeConstIterator): (KXMLCore::::lookup): (KXMLCore::::insert): (KXMLCore::::reinsert): (KXMLCore::::find): (KXMLCore::::contains): (KXMLCore::::remove): (KXMLCore::::allocateTable): (KXMLCore::::expand): (KXMLCore::::rehash): (KXMLCore::::clear): (KXMLCore::::HashTable): (KXMLCore::::swap): (KXMLCore::::operator): (KXMLCore::::checkTableConsistency): (KXMLCore::::checkTableConsistencyExceptSize):
  • kxmlcore/HashTraits.h: Added. (KXMLCore::HashTraits::emptyValue): (KXMLCore::): (KXMLCore::PairHashTraits::emptyValue): (KXMLCore::PairHashTraits::deletedValue):

WebCore:

Reviewed by Eric.

  • ForwardingHeaders/kxmlcore/HashMap.h: Added.
  • ForwardingHeaders/kxmlcore/HashSet.h: Added.
  • ForwardingHeaders/misc/hashmap.h: Removed.
  • ForwardingHeaders/misc/hashset.h: Removed.
  • ForwardingHeaders/misc/pointerhash.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSRuleSet::getIDRules): (khtml::CSSRuleSet::getClassRules): (khtml::CSSRuleSet::getTagRules): (khtml::CSSRuleSet::getUniversalRules): (khtml::CSSRuleSet::addToRuleSet):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/html/html_documentimpl.cpp: (DOM::addItemToMap):
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_elementimpl.cpp:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::radioButtonChecked):
  • khtml/html/html_formimpl.h:
  • khtml/html/htmlfactory.cpp: (DOM::HTMLElementFactory::createHTMLElement):
  • khtml/html/htmlparser.cpp: (HTMLParser::getNode):
  • khtml/xml/dom_atomicstring.cpp:
  • khtml/xml/dom_qname.cpp:
  • khtml/xml/dom_stringimpl.h: (KXMLCore::): (KXMLCore::CaseInsensitiveHash::hash): (KXMLCore::CaseInsensitiveHash::equal):
  • khtml/xml/xml_tokenizer.cpp:
  • kwq/DOM.mm: (ObjCEventListener::ObjCEventListener):
2:04 PM Changeset in webkit [10652] by justing
  • 5 edits in trunk/WebKit

Reviewed by geoff

Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded

  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]): Now calls signalFinish and saveResource.

(-[WebSubresourceLoader signalFinish]):
Added. Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.

(-[WebSubresourceLoader didFinishLoading]):

  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol signalFinish]): Similar to above

(-[NSURLProtocol didFinishLoading]):

1:55 PM Changeset in webkit [10651] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Don't check if the text dump matches.
1:40 PM Changeset in webkit [10650] by darin
  • 5 edits in trunk
  • layout-tests/fast/js/array-every.html: Fixed test case; one of the tests was using the wrong function, so it wasn't testing what it claimed it was.
  • layout-tests/fast/js/array-every-expected.txt: Updated test result; one section now has a different result.
  • layout-tests/fast/js/const.html: Added a test case that checks that variables after the first in a const declaration are also const; this was broken until my recent change to the JavaScript grammar.
  • layout-tests/fast/js/const-expected.txt: Updated test results.
11:52 AM Changeset in webkit [10649]
  • 51 copies
    22 deletes in tags/WebKit-417

This commit was manufactured by cvs2svn to create tag 'WebKit-417'.

11:52 AM Changeset in webkit [10648]
  • 231 copies
    14 deletes in tags/WebCore-417~1

This commit was manufactured by cvs2svn to create tag
'WebCore-417~1'.

11:52 AM Changeset in webkit [10647] by thatcher
  • 6 edits in branches/Safari-2-0-branch

Versioning to 417 and WebCore-417.1

11:51 AM Changeset in webkit [10646] by darin
  • 6 edits
    3 deletes in trunk/JavaScriptCore

Reviewed by Maciej.

  • update grammar to fix conflicts; fixes one of our test cases because it resolves the relationship between function expressions and declarations in the way required by the ECMA specification
  • kjs/grammar.y: Added lots of new grammar rules so we have no conflicts. A new set of rules for "no bracket or function at start of expression" and another set of rules for "no in anywhere in expression". Also simplified the handling of try to use only a single node and used operator precedence to get rid of the conflict in handling of if and else. Also used a macro to streamline the handling of automatic semicolons and changed parenthesis handling to use a virtual function.
  • kjs/nodes.h: Added nodeInsideAllParens, removed unused abortStatement. (KJS::TryNode::TryNode): Updated to hold catch and finally blocks directly instead of using a special node for each.
  • kjs/nodes.cpp: (Node::createErrorCompletion): Added. Used instead of throwError when creating errors that should not be in a completion rather than an ExecState. (Node::throwUndefinedVariableError): Added. Sets source location unlike the call it replaces. (Node::nodeInsideAllParens): Added. (GroupNode::nodeInsideAllParens): Added. (StatListNode::execute): Removed code to move exceptions into completion objects; that's now done solely by the KJS_CHECKEXCEPTION macro. (TryNode::execute): Include execution of catch and finally here rather than using separate nodes. (FuncDeclNode::execute): Moved here, no longer inline.
  • kjs/nodes2string.cpp: (TryNode::streamTo): Updated for change. (FuncDeclNode::streamTo): Ditto. (FuncExprNode::streamTo): Ditto.
  • kjs/kjs-test: Removed. Was part of "make check".
  • kjs/kjs-test.chk: Ditto.
  • kjs/test.js: Ditto.
  • tests/mozilla/expected.html: Updated because one more test succeeds.
11:47 AM Changeset in webkit [12201] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptGlue

Versioning to 417

11:43 AM Changeset in webkit [10645] by adele
  • 5 edits
    1 add in trunk/WebKit

Reviewed by John.

Moved _downloadWithLoadingConnection and _downloadWithRequestfrom WebDownload.h to WebDownloadInternal.h

  • Misc.subproj/WebDownload.h:
  • Misc.subproj/WebDownloadInternal.h: Added.
  • WebKit.xcodeproj/project.pbxproj: Added WebDownloadInternal.h
  • WebView.subproj/WebMainResourceLoader.m: Added import of WebDownloadInternal.h
  • WebView.subproj/WebView.m: ditto.
11:24 AM Changeset in webkit [10644] by thatcher
  • 9 edits in branches/Safari-2-0-branch/WebCore

Merge over of various leak fixes from TOT to Safari-2-0-branch

<rdar://problem/4231952> leaks of DOMStringImpl called from HTMLTokenizer::processToken, seen running WebKit tests
<rdar://problem/4231978> many leaks of StyleSurroundData called beneath RenderStyle::setMarginTop, seen running webkit tests
<rdar://problem/4232017> many leaks of StyleInheritedData called from different RenderStyle methods, seen running webkit tests
<rdar://problem/4232175> leak of RenderObject called from RenderContainer::updatePseudoChild, seen running webkit tests
<rdar://problem/4232214> many leaks of RenderStyle from CSSStyleSelector::pseudoStyleForElement, seen running webkit tests
<rdar://problem/4232252> many leaks of RenderStyle called beneath NodeImpl::createRendererIfNeeded, seen running webkit tests
<rdar://problem/4232263> many leaks of RenderObject called from TextImpl::createRenderer, seen running webkit tests
<rdar://problem/4232303> many objects leaked from HTMLTokenizer::parseTag() within -[WebView paste:], seen running webkit tests (probably affects Mail)
<rdar://problem/4232355> leak of DOMStringImpl called from RenderTextFragment::originalString, seen running webkit tests
<rdar://problem/4232371> leak of DOMStringImpl called from DOMStringImpl::substring, seen running webkit tests
<rdar://problem/4232588> many leaks beneath ApplyStyleCommand::mergeEndWithNextIfIdentical, seen running webkit tests (probably affects Mail)
<rdar://problem/4232812> leaks of NodeImpl called from HTMLParser::textCreateErrorCheck, seen running webkit tests
<rdar://problem/4233683> leaks of NodeImpl called from HTMLElementImpl::setOuterText, seen running webkit tests
<rdar://problem/4233690> leaks of StyleBackgroundData called within setBackgroundColor, seen running webkit tests
<rdar://problem/4233701> leaks inside QFontMetrics::setFont, seen running webkit tests
<rdar://problem/4233800> leak inside DOM::DocumentImpl::DocumentImpl, seen running webkit tests
<rdar://problem/4236218> many leaks of StyleBaseImpl within -[WebCoreBridge markupStringFromRange:nodes:] within -[WebHTMLView copy:]
<rdar://problem/4238024> leak of DocumentFragmentImpl if parseXMLDocumentFragment fails
<rdar://problem/4241457> many callers of removeChild are leaking the removed node

  • khtml/editing/markup.cpp: (khtml::createMarkup):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): (HTMLElementImpl::setOuterText):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::setCaption): (HTMLTableElementImpl::setTHead): (HTMLTableElementImpl::setTFoot): (HTMLTableElementImpl::setTBody):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::remove): (NodeImpl::normalize):
10:48 AM Changeset in webkit [10643] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning of JavaScriptCore-416.10

Sep 27, 2005:

10:06 PM Changeset in webkit [10642] by eseidel
  • 20 edits in trunk

Bug #: 3914
Submitted by: eseidel
Reviewed by: mjs

Removed 19 uses of dynamic_cast.
Part of this came by making EventTarget abstract, and moving
the necessary implementations up into NodeImpl.
http://bugzilla.opendarwin.org/show_bug.cgi?id=3914

  • kdom/Helper.h: comment cleanup
  • kdom/bindings/IDLCodeGeneratorJs.pm: tabs -> spaces
  • kdom/core/NodeImpl.cpp: Moved EventTarget methods (NodeImpl::addEventListener): (NodeImpl::removeEventListener): (NodeImpl::dispatchEvent):
  • kdom/core/NodeImpl.h: (KDOM::NodeImpl::isSVGElement):
  • kdom/events/EventTargetImpl.cpp: Moved methods to NodeImpl
  • kdom/events/EventTargetImpl.h:
  • kdom/ls/DOMImplementationLSImpl.cpp: disabled LSParserImpl (DOMImplementationLSImpl::createLSParser):
  • ksvg2/ecma/Ecma.cpp: (Ecma::setupDocument):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetElement): (SVGAnimationElementImpl::targetAttribute): (SVGAnimationElementImpl::setTargetAttribute):
  • ksvg2/svg/SVGElementImpl.h: (KSVG::SVGElementImpl::isSVGElement): (KSVG::SVGElementImpl::isStyled): (KSVG::SVGElementImpl::isSVG): (KSVG::svg_dynamic_cast):
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::x): (SVGFilterPrimitiveStandardAttributesImpl::y): (SVGFilterPrimitiveStandardAttributesImpl::width): (SVGFilterPrimitiveStandardAttributesImpl::height): (SVGFilterPrimitiveStandardAttributesImpl::result):
  • ksvg2/svg/SVGHelper.cpp: (SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getCTM):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::notifyAttributeChange):
  • ksvg2/svg/SVGSVGElementImpl.h: (KSVG::SVGSVGElementImpl::isSVG):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::attach): (SVGStyledElementImpl::detach):
  • ksvg2/svg/SVGStyledElementImpl.h: (KSVG::SVGStyledElementImpl::isStyled):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::close):
7:25 PM Changeset in webkit [10641] by adele
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Changed ints to size_t where appropriate.

  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::collect): (KJS::Collector::size): (KJS::Collector::numInterpreters): (KJS::Collector::numGCNotAllowedObjects): (KJS::Collector::numReferencedObjects):
  • kjs/collector.h:

WebCore:

Reviewed by Maciej.

Changing ints to size_t where appropriate.

  • kwq/WebCoreJavaScript.h:
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript objectCount]): (+[WebCoreJavaScript interpreterCount]): (+[WebCoreJavaScript noGCAllowedObjectCount]): (+[WebCoreJavaScript referencedObjectCount]):

WebKit:

Reviewed by Maciej.

Changed ints to size_t where appropriate.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptInterpretersCount]): (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
  • WebView.subproj/WebPreferences.m: (-[WebPreferences _pageCacheSize]): (-[WebPreferences _objectCacheSize]):
  • WebView.subproj/WebPreferencesPrivate.h:
6:48 PM Changeset in webkit [12200] by adele
  • 2 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

<rdar://problem/4223297> JavaScriptGlue: Submit 64-bit compatible versions of your API and SPIs by September 15

  • JavaScriptGlue.h: Changed UInt32 to CFTypeID for JSTypeID
5:49 PM Changeset in webkit [10640] by eseidel
  • 6 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed, svg build fix only.

  • WebCore+SVG/DrawView.mm:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Updated from KWQAssertions.h to kxmlcore/Assertions.h
5:07 PM Changeset in webkit [10639] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: kevin

4:41 PM Changeset in webkit [10638] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

2005-09-26 Geoffrey Garen <ggaren@apple.com>

  • Fixed <rdar://problem/4244084> Denver Regression: Date.setUTCFullYear() broken

Reviewed by John.

  • kjs/date_object.cpp: (KJS::makeTime): Changed to use localtime_r to avoid blowing away the results from a previous call to localtime farther up the stack.
4:39 PM Changeset in webkit [10637] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

2005-09-26 Geoffrey Garen <ggaren@apple.com>

  • Fixed <rdar://problem/4244084> Denver Regression: Date.setUTCFullYear() broken

Reviewed by John.

  • kjs/date_object.cpp: (KJS::makeTime): Changed to use localtime_r to avoid blowing away the results from a previous call to localtime farther up the stack.
4:38 PM Changeset in webkit [10636] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 3537
Submitted by: eseidel
Reviewed by: mjs

4:36 PM Changeset in webkit [10635] by eseidel
  • 1 edit
    2 adds in trunk

Bug #: 3537
Submitted by: eseidel
Reviewed by: mjs

Test cases for JSC fix:
http://bugzilla.opendarwin.org/show_bug.cgi?id=3537

Test cases added:

  • layout-tests/fast/js/object-prototype-constructor-expected.txt: Added.
  • layout-tests/fast/js/object-prototype-constructor.html: Added.
3:37 PM Changeset in webkit [10634] by mjs
  • 142 edits
    14 adds
    9 deletes in trunk

JavaScriptCore:

Reviewed by John.

I also moved SharedPtr and the assertion code from WebCore into a
new kxmlcore directory.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::collect):
  • kjs/config.h:
  • kjs/fast_malloc.cpp: Removed.
  • kjs/fast_malloc.h: Removed.
  • kjs/function.cpp:
  • kjs/function.h:
  • kjs/function_object.cpp:
  • kjs/identifier.cpp: (KJS::Identifier::add):
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp:
  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::rehash):
  • kjs/scope_chain.h:
  • kjs/shared_ptr.h: Removed.
  • kjs/string_object.cpp: (StringObjectFuncImp::callAsFunction):
  • kjs/ustring.cpp: (KJS::UString::Rep::createCopying): (KJS::UString::Rep::destroy): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::spliceSubstringsWithSeparators): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::detach):
  • kjs/ustring.h:
  • kxmlcore/Assertions.h: Added.
  • kxmlcore/Assertions.mm: Added.
  • kxmlcore/FastMalloc.cpp: Added. (KXMLCore::LgFloor): (KXMLCore::SizeClass): (KXMLCore::ByteSizeForClass): (KXMLCore::InitSizeClasses): (KXMLCore::MetaDataAlloc): (KXMLCore::PageHeapAllocator::Init): (KXMLCore::PageHeapAllocator::New): (KXMLCore::PageHeapAllocator::Delete): (KXMLCore::PageHeapAllocator::inuse): (KXMLCore::pages): (KXMLCore::AllocationSize): (KXMLCore::Event): (KXMLCore::NewSpan): (KXMLCore::DeleteSpan): (KXMLCore::DLL_Init): (KXMLCore::DLL_Remove): (KXMLCore::DLL_IsEmpty): (KXMLCore::DLL_Length): (KXMLCore::DLL_Print): (KXMLCore::DLL_Prepend): (KXMLCore::DLL_InsertOrdered): (KXMLCore::): (KXMLCore::TCMalloc_PageHeap::GetDescriptor): (KXMLCore::TCMalloc_PageHeap::SystemBytes): (KXMLCore::TCMalloc_PageHeap::FreeBytes): (KXMLCore::TCMalloc_PageHeap::RecordSpan): (KXMLCore::TCMalloc_PageHeap::TCMalloc_PageHeap): (KXMLCore::TCMalloc_PageHeap::New): (KXMLCore::TCMalloc_PageHeap::Split): (KXMLCore::TCMalloc_PageHeap::Carve): (KXMLCore::TCMalloc_PageHeap::Delete): (KXMLCore::TCMalloc_PageHeap::RegisterSizeClass): (KXMLCore::TCMalloc_PageHeap::Dump): (KXMLCore::TCMalloc_PageHeap::GrowHeap): (KXMLCore::TCMalloc_PageHeap::Check): (KXMLCore::TCMalloc_PageHeap::CheckList): (KXMLCore::TCMalloc_ThreadCache_FreeList::Init): (KXMLCore::TCMalloc_ThreadCache_FreeList::length): (KXMLCore::TCMalloc_ThreadCache_FreeList::empty): (KXMLCore::TCMalloc_ThreadCache_FreeList::lowwatermark): (KXMLCore::TCMalloc_ThreadCache_FreeList::clear_lowwatermark): (KXMLCore::TCMalloc_ThreadCache_FreeList::Push): (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop): (KXMLCore::TCMalloc_ThreadCache::freelist_length): (KXMLCore::TCMalloc_ThreadCache::Size): (KXMLCore::TCMalloc_Central_FreeList::length): (KXMLCore::TCMalloc_Central_FreeList::Init): (KXMLCore::TCMalloc_Central_FreeList::Insert): (KXMLCore::TCMalloc_Central_FreeList::Remove): (KXMLCore::TCMalloc_Central_FreeList::Populate): (KXMLCore::TCMalloc_ThreadCache::SampleAllocation): (KXMLCore::TCMalloc_ThreadCache::Init): (KXMLCore::TCMalloc_ThreadCache::Cleanup): (KXMLCore::TCMalloc_ThreadCache::Allocate): (KXMLCore::TCMalloc_ThreadCache::Deallocate): (KXMLCore::TCMalloc_ThreadCache::FetchFromCentralCache): (KXMLCore::TCMalloc_ThreadCache::ReleaseToCentralCache): (KXMLCore::TCMalloc_ThreadCache::Scavenge): (KXMLCore::TCMalloc_ThreadCache::GetCache): (KXMLCore::TCMalloc_ThreadCache::GetCacheIfPresent): (KXMLCore::TCMalloc_ThreadCache::PickNextSample): (KXMLCore::TCMalloc_ThreadCache::InitModule): (KXMLCore::TCMalloc_ThreadCache::InitTSD): (KXMLCore::TCMalloc_ThreadCache::CreateCacheIfNecessary): (KXMLCore::TCMalloc_ThreadCache::DeleteCache): (KXMLCore::TCMalloc_ThreadCache::RecomputeThreadCacheSize): (KXMLCore::TCMalloc_ThreadCache::Print): (KXMLCore::ExtractStats): (KXMLCore::DumpStats): (KXMLCore::PrintStats): (KXMLCore::DumpStackTraces): (KXMLCore::TCMallocImplementation::GetStats): (KXMLCore::TCMallocImplementation::ReadStackTraces): (KXMLCore::TCMallocImplementation::GetNumericProperty): (KXMLCore::TCMallocImplementation::SetNumericProperty): (KXMLCore::DoSampledAllocation): (KXMLCore::do_malloc): (KXMLCore::do_free): (KXMLCore::do_memalign): (KXMLCore::TCMallocGuard::TCMallocGuard): (KXMLCore::TCMallocGuard::~TCMallocGuard): (KXMLCore::malloc): (KXMLCore::free): (KXMLCore::calloc): (KXMLCore::cfree): (KXMLCore::realloc): (KXMLCore::memalign): (KXMLCore::posix_memalign): (KXMLCore::valloc): (KXMLCore::pvalloc): (KXMLCore::malloc_stats): (KXMLCore::mallopt): (KXMLCore::mallinfo):
  • kxmlcore/FastMalloc.h: Added. (KXMLCore::FastAllocated::operator new): (KXMLCore::FastAllocated::operator delete): (KXMLCore::FastAllocated::operator new[]): (KXMLCore::FastAllocated::operator delete[]):
  • kxmlcore/SharedPtr.h: Added. (KXMLCore::SharedPtr::SharedPtr): (KXMLCore::SharedPtr::~SharedPtr): (KXMLCore::SharedPtr::isNull): (KXMLCore::SharedPtr::notNull): (KXMLCore::SharedPtr::reset): (KXMLCore::SharedPtr::get): (KXMLCore::SharedPtr::operator*): (KXMLCore::SharedPtr::operator->): (KXMLCore::SharedPtr::operator!): (KXMLCore::SharedPtr::operator bool): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):
  • kxmlcore/TCPageMap.h: Added. (TCMalloc_PageMap1::TCMalloc_PageMap1): (TCMalloc_PageMap1::Ensure): (TCMalloc_PageMap1::get): (TCMalloc_PageMap1::set): (TCMalloc_PageMap2::TCMalloc_PageMap2): (TCMalloc_PageMap2::get): (TCMalloc_PageMap2::set): (TCMalloc_PageMap2::Ensure): (TCMalloc_PageMap3::NewNode): (TCMalloc_PageMap3::TCMalloc_PageMap3): (TCMalloc_PageMap3::get): (TCMalloc_PageMap3::set): (TCMalloc_PageMap3::Ensure):
  • kxmlcore/TCSpinLock.h: Added. (TCMalloc_SpinLock::Init): (TCMalloc_SpinLock::Finalize): (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock): (TCMalloc_SpinLockHolder::TCMalloc_SpinLockHolder): (TCMalloc_SpinLockHolder::~TCMalloc_SpinLockHolder):
  • kxmlcore/TCSystemAlloc.cpp: Added. (TrySbrk): (TryMmap): (TryDevMem): (TCMalloc_SystemAlloc):
  • kxmlcore/TCSystemAlloc.h: Added.

WebCore:

Reviewed by John.

I also moved SharedPtr and the assertion code from WebCore into a
new kxmlcore directory.

  • ForwardingHeaders/kjs/shared_ptr.h: Removed.
  • ForwardingHeaders/kxmlcore/Assertions.h: Added.
  • ForwardingHeaders/kxmlcore/FastMalloc.h: Added.
  • ForwardingHeaders/kxmlcore/SharedPtr.h: Added.
  • ForwardingHeaders/misc/main_thread_malloc.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_base.h:
  • khtml/css/css_computedstyle.cpp:
  • khtml/css/css_ruleimpl.h:
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/append_node_command.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/break_blockquote_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_from_text_node_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/edit_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_into_text_node_command.cpp:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_node_before_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/join_text_nodes_command.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/merge_identical_elements_command.cpp:
  • khtml/editing/move_selection_command.cpp:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/remove_css_property_command.cpp:
  • khtml/editing/remove_node_attribute_command.cpp:
  • khtml/editing/remove_node_command.cpp:
  • khtml/editing/remove_node_preserving_children_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/set_node_attribute_command.cpp:
  • khtml/editing/split_element_command.cpp:
  • khtml/editing/split_text_node_command.cpp:
  • khtml/editing/split_text_node_containing_element.cpp:
  • khtml/editing/typing_command.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/editing/visible_position.h:
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp:
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlparser.cpp:
  • khtml/khtmlpart_p.h:
  • khtml/misc/arena.cpp: (ArenaAllocate): (FreeArenaList): (ArenaFinish):
  • khtml/misc/hashtable.h: (khtml::HashTable::~HashTable): (khtml::::allocateTable): (khtml::::rehash): (khtml::::clear): (khtml::::HashTable):
  • khtml/misc/loader.cpp:
  • khtml/misc/main_thread_malloc.cpp: Removed.
  • khtml/misc/main_thread_malloc.h: Removed.
  • khtml/misc/shared.h:
  • khtml/rendering/render_style.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom2_traversalimpl.h:
  • khtml/xml/dom2_viewsimpl.h:
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::clearAttributes): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::addAttribute): (NamedAttrMapImpl::removeAttribute):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp:
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_position.cpp:
  • khtml/xml/dom_stringimpl.h:
  • kwq/DOM-CSS.mm:
  • kwq/DOM.mm:
  • kwq/DOMEvents.mm:
  • kwq/DOMHTML.mm:
  • kwq/DOMInternal.mm:
  • kwq/DOMViews.mm:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::KWQArrayPrivate::KWQArrayPrivate): (KWQArrayImpl::KWQArrayPrivate::~KWQArrayPrivate): (KWQArrayImpl::resize):
  • kwq/KWQAssertions.h: Removed.
  • kwq/KWQAssertions.m: Removed.
  • kwq/KWQButton.mm:
  • kwq/KWQCString.mm:
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm:
  • kwq/KWQColor.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQEditCommand.mm:
  • kwq/KWQExceptions.h:
  • kwq/KWQFileButton.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFormData.mm:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQKPartsBrowserInterface.mm:
  • kwq/KWQKURL.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQListImpl.mm:
  • kwq/KWQLogging.h:
  • kwq/KWQLogging.m:
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQObject.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQResourceLoader.mm:
  • kwq/KWQSignal.mm:
  • kwq/KWQSlot.mm:
  • kwq/KWQString.h:
  • kwq/KWQString.mm: (ALLOC_QCHAR): (QString::setBufferFromCFString): (allocatePageNode):
  • kwq/KWQTextArea.mm:
  • kwq/KWQTextCodec.mm:
  • kwq/KWQTextEdit.mm:
  • kwq/KWQTextField.mm:
  • kwq/KWQTimer.mm:
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm:
  • kwq/WebCoreBridge.mm:
  • kwq/WebCoreCookieAdapter.m:
  • kwq/WebCoreGraphicsBridge.m:
  • kwq/WebCoreImageRendererFactory.m:
  • kwq/WebCoreKeyGenerator.m:
  • kwq/WebCoreTextRendererFactory.mm:
  • kwq/WebCoreViewFactory.m:
12:18 AM Changeset in webkit [10633] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: 5141
Submitted by: eseidel
Reviewed by: none needed, svg build fix only.

Note: See TracTimeline for information about the timeline view.