⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 30, 2005:

11:28 PM Changeset in webkit [10689] by thatcher
  • 3 edits in branches/Safari-2-0-branch/JavaScriptCore

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Fixed by Geoffrey Garen.

Reviewed by Andrew Wooster.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
11:14 PM Changeset in webkit [10688]
  • 82 copies
    5 deletes in tags/JavaScriptCore-416~12

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~12'.

11:14 PM Changeset in webkit [10687] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning to JavaScriptCore-416.12, also amending the ChangeLog to show the correct reviewer.

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Fixed by Geoffrey Garen.

Reviewed by Andrew Wooster.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
7:52 PM Changeset in webkit [10686] by thatcher
  • 3 edits in branches/Safari-Den-branch/JavaScriptCore

<rdar://problem/4277521> JS exceptions don't carry file/line information (3327)

Reviewed by Geoff someone.

Sends file and line numbers with JS exceptions.

  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded):
  • kjs/nodes.h:
4:18 PM Changeset in webkit [10685] by eseidel
  • 1 add in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Moved WebCore/layout-tests to LayoutTests

2:52 PM Changeset in webkit [10684] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Moved layout-tests to ../LayoutTests

2:44 PM Changeset in webkit [10683] by eseidel
  • 6 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: xenon

Updated all the scripts for the move:
WebCore/layout-tests -> LayoutTests

  • Scripts/check-dom-results:
  • Scripts/prepare-ChangeLog:
  • Scripts/run-webkit-tests:
  • Scripts/update-webkit: added --no-tests
  • checkout: added --no-tests
10:57 AM Changeset in webkit [10682]
  • 68 copies
    5 deletes in tags/JavaScriptCore-417~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~1'.

10:57 AM Changeset in webkit [10681] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.1

10:55 AM Changeset in webkit [10680] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merges fixes from TOT to Safari-2-0-branch

2005-09-29 Geoffrey Garen <ggaren@apple.com>

  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by mjs.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)
10:47 AM Changeset in webkit [10679]
  • 81 copies
    5 deletes in tags/JavaScriptCore-416~11

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~11'.

10:47 AM Changeset in webkit [10678] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Versioning to JavaScriptCore-416.11

10:45 AM Changeset in webkit [10677] by thatcher
  • 2 edits in branches/Safari-Den-branch/JavaScriptCore

Merges fixes from TOT to Safari-Den-branch

2005-09-29 Geoffrey Garen <ggaren@apple.com>

  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by mjs.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)
9:35 AM Changeset in webkit [10676] by ggaren
  • 2 edits in trunk

Patch reviewed by john.

  • layout-tests/fast/js/date-parse-test.html: Added a test case for <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com
9:16 AM Changeset in webkit [10675] by ggaren
  • 2 edits in trunk/JavaScriptCore
  • Second cut at fixing <rdar://problem/4275206> Denver Regression: Seed: Past Editions of Opinions display "NAN/Undefined" for www.washingtonpost.com

Reviewed by john.

  • kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Intead of creating a timezone when one isn't specified, just rely on the fallback logic, which will do it for you. Also, return invalidDate if the date includes trailing garbage. (Somewhat accidentally, the timezone logic used to catch trailing garbage.)

Added test case to fast/js/date-parse-test.html.

12:03 AM Changeset in webkit [10674]
  • 52 copies
    22 deletes in tags/WebKit-416~9

This commit was manufactured by cvs2svn to create tag 'WebKit-416~9'.

12:03 AM Changeset in webkit [10673] by thatcher
  • 2 edits in branches/Safari-Den-branch/WebKit

Versioning to WebKit-416.9

Sep 29, 2005:

11:59 PM Changeset in webkit [10672]
  • 52 copies
    22 deletes in tags/WebKit-417~1

This commit was manufactured by cvs2svn to create tag 'WebKit-417~1'.

11:59 PM Changeset in webkit [10671] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning to WebKit-417.1

11:53 PM Changeset in webkit [10670] by thatcher
  • 5 edits in branches/Safari-Den-branch/WebKit

Merged fix from TOT to Safari-Den-branch

2005-09-28 Justin Garcia <justin.garcia@apple.com>

Reviewed by geoff

Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded

  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]): Now calls signalFinish and saveResource.

(-[WebSubresourceLoader signalFinish]):
Added. Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.

(-[WebSubresourceLoader didFinishLoading]):

  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol signalFinish]): Similar to above

(-[NSURLProtocol didFinishLoading]):

11:50 PM Changeset in webkit [10669] by thatcher
  • 5 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-09-28 Justin Garcia <justin.garcia@apple.com>

Reviewed by geoff

Fixed <rdar://problem/4276596> multipart/x-mixed-replace: saved inline images appear only partially loaded
Fixed <rdar://problem/4265439> progress bar should look complete even if there is some more multipart content being loaded

  • WebCoreSupport.subproj/WebSubresourceLoader.h:
  • WebCoreSupport.subproj/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveResponse:]): Now calls signalFinish and saveResource.

(-[WebSubresourceLoader signalFinish]):
Added. Does the part of didFinishLoading that signals to the WebDataSource and load delegates that the load is finished.

(-[WebSubresourceLoader didFinishLoading]):

  • WebView.subproj/WebLoader.h:
  • WebView.subproj/WebLoader.m: (-[NSURLProtocol signalFinish]): Similar to above

(-[NSURLProtocol didFinishLoading]):

10:06 PM Changeset in webkit [10668]
  • 234 copies
    14 deletes in tags/WebCore-417~2

This commit was manufactured by cvs2svn to create tag
'WebCore-417~2'.

10:06 PM Changeset in webkit [10667] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.2

9:57 PM Changeset in webkit [10666] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merge over of various leak fixes from TOT to Safari-2-0-branch

2005-09-29 Timothy Hatcher <timothy@apple.com>

Fixes build failures on a future release train.

Reviewed by Maciej.

Test cases added: (None needed.)

  • kwq/KWQPointArray.h: check if NSPoint is the same as CGPoint
  • kwq/KWQRect.h: check if NSRect is the same as CGRect
  • kwq/KWQSize.h: check if NSSize is the same as CGSize
9:04 PM Changeset in webkit [10665] by thatcher
  • 7 edits in trunk/WebCore

Fixes build failures on a future release train.

Reviewed by Maciej.

Test cases added: (None needed.)

  • kwq/KWQPointArray.h: check if NSPoint is the same as CGPoint
  • kwq/KWQPoint.mm: ditto
  • kwq/KWQRect.h: check if NSRect is the same as CGRect
  • kwq/KWQRect.mm: ditto
  • kwq/KWQSize.h: check if NSSize is the same as CGSize
  • kwq/KWQSize.mm: ditto
5:03 PM Changeset in webkit [10664] by hyatt
  • 7 edits in trunk/WebCore

Add support for parsing of the CSS3 box-sizing property. This
property will have to be fully implemented for form controls that
respect border and padding (buttons, textfields, list boxes, etc.).

Reviewed by john

Test cases added: (NONE, property just being parsed, not supported)

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/cssvalues.in:
  • khtml/rendering/render_style.cpp: (StyleBoxData::StyleBoxData): (StyleBoxData::operator==): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::boxSizing): (khtml::RenderStyle::setBoxSizing): (khtml::RenderStyle::initialBoxSizing):
3:05 PM Changeset in webkit [10663] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 5176
Submitted by: Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by: darin

Fix JSC memory smasher in TOT.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5176

  • pcre/pcre_exec.c: (match):
1:10 PM Changeset in webkit [10662] by hyatt
  • 19 edits in trunk/WebCore

Make all form controls treat width: auto as width:intrinsic and
add support for intrinsic widths when computing sizes of
block-level flows.

Rename the term Variable to Auto, since this more accurately
matches the term in the CSS spec.

Reviewed by darin

Test cases added: (None needed, <button> and <legend> test this)

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/misc/khtmllayout.h: (khtml::): (khtml::Length::width): (khtml::Length::minWidth): (khtml::Length::isAuto): (khtml::Length::isIntrinsicOrAuto):
  • khtml/rendering/bidi.cpp: (khtml::getBPMWidth):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::MarginInfo::MarginInfo): (khtml::RenderBlock::isSelfCollapsingBlock): (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::determineHorizontalPosition): (khtml::getBPMWidth): (khtml::RenderBlock::calcInlineMinMaxWidth): (khtml::shouldCheckLines):
  • khtml/rendering/render_box.cpp: (RenderBox::getClipRect): (RenderBox::relativePositionOffset): (RenderBox::calcWidth): (RenderBox::calcWidthUsing): (RenderBox::sizesToIntrinsicWidth): (RenderBox::calcHorizontalMargins): (RenderBox::calcHeight): (RenderBox::calcHeightUsing): (RenderBox::calcPercentageHeight): (RenderBox::availableHeightUsing): (RenderBox::calcAbsoluteHorizontal): (RenderBox::calcAbsoluteHorizontalValues): (RenderBox::calcAbsoluteVertical): (RenderBox::calcAbsoluteVerticalValues):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth): (khtml::RenderFlexibleBox::layoutVerticalBox):
  • khtml/rendering/render_form.cpp: (RenderFormElement::addIntrinsicMarginsIfAllowed): (RenderSlider::calcMinMaxWidth):
  • khtml/rendering/render_layer.cpp: (khtml::Marquee::updateMarqueeStyle):
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::marginLeft): (khtml::InlineFlowBox::marginRight):
  • khtml/rendering/render_object.cpp: (RenderObject::hasStaticX): (RenderObject::hasStaticY): (RenderObject::paddingTop): (RenderObject::paddingBottom): (RenderObject::paddingLeft): (RenderObject::paddingRight): (RenderObject::usesLineWidth):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
  • khtml/rendering/render_style.cpp: (StyleSurroundData::StyleSurroundData):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::resetPadding): (khtml::RenderStyle::initialPadding):
  • khtml/rendering/render_table.cpp: (RenderTable::setStyle): (RenderTable::calcWidth): (RenderTableSection::addCell): (RenderTableSection::layoutRows):
  • khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setSizeFromFont): (khtml::RenderThemeMac::setCheckboxSize): (khtml::RenderThemeMac::setRadioSize):
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::calcWidthArray): (FixedTableLayout::layout): (AutoTableLayout::recalcColumn): (AutoTableLayout::fullRecalc): (shouldScaleColumns): (AutoTableLayout::calcEffectiveWidth): (AutoTableLayout::layout):
12:47 AM Changeset in webkit [10661] by justing
  • 9 edits
    11 adds in trunk

Reviewed by harrison

<rdar://problem/4278698> Adding a space inside whitespace:pre text collapses space
<rdar://problem/4076267> Mail behaves oddly when pasting in text with leading/trailing whitespace
<rdar://problem/4063751> Redo Typing can add extra space characters
<rdar://problem/4120558> Mail/WebKit: Repeated capitalizeWord command deletes spaces and does not capitalize

Reblance whitespace was finding the extent of surrounding whitespace incorrectly.
createFragmentFromMarkup was not dealing with the special cases for spaces at the start/end
of a line. InsertTextCommand was removing collapsable whitespace without regard for the
whitespace mode. createFragmentFromMarkup and RebalanceWhitespace command now use one method
to produce rebalanced sequences. Removed special case whitespace handling from
InsertTextCommand, that's RebalanceWhiteSpaceCommand's job.

Test cases added:

  • layout-tests/editing/inserting/4278698.html: Added.
  • layout-tests/editing/pasteboard/4076267-2.html: Added.
  • layout-tests/editing/pasteboard/4076267-3.html: Added.
  • layout-tests/editing/pasteboard/4076267.html: Added.
  • layout-tests/editing/undo/4063751.html: Added.
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::rebalanceWhitespaceAt): Added. The old convenience method, rebalanceWhitespace, can probably be removed, because there is never a non-caret selection after an editing command.
  • khtml/editing/composite_edit_command.h:
  • khtml/editing/htmlediting.cpp: (khtml::rebalanceWhitespaceInTextNode):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
  • khtml/editing/insert_text_command.h:
  • khtml/editing/markup.cpp: (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText):
  • khtml/editing/rebalance_whitespace_command.cpp: (khtml::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): (khtml::isWhitespace): Changed from isNBSP to include all forms of whitespace, to aid readability. (khtml::RebalanceWhitespaceCommand::doApply): (khtml::RebalanceWhitespaceCommand::doUnapply): Removed the unused m_downstreamOffset
  • layout-tests/editing/editingStyle.css: Added.
12:24 AM Changeset in webkit [10660] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: 5179
Submitted by: Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by: mjs

Note: See TracTimeline for information about the timeline view.