⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 8, 2005:

9:45 PM Changeset in webkit [10800] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff.
Tweaked and landed by Darin.

  • kjs/date_object.cpp: (KJS::skipSpacesAndComments): Take a pointer, and advance it past spaces, and also past anything enclosed in parentheses. (KJS::KRFCDate_parseDate): Use skipSpacesAndComments wherever we formerly had code to skip spaces.

LayoutTests:

  • fast/js/date-parse-comments-test-expected.txt: Added.
  • fast/js/date-parse-comments-test.html: Added.
9:36 PM Changeset in webkit [10799] by darin
  • 1 edit
    3 adds in trunk/LayoutTests
  • fast/xsl/xslt-entity-enc.xml: Added.
  • fast/xsl/resources/xslt-entity-enc.xsl: Added.
  • fast/xsl/xslt-entity-enc-expected.txt: Added.
9:25 PM Changeset in webkit [10798] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed, tweaked, and landed by Darin.

  • kjs/config.h: Make sure HAVE_MMAP and HAVE_SBRK are off for Win32. Turn HAVE_ERRNO_H on for Mac OS X. Sort defines so they are easy to compare with each other. Remove #undef of DEBUG_COLLECTOR.
  • pcre/pcre_exec.c: (match): Work around strange MSVC complaint by splitting the definition of a local variable into a separate declaration and initialization.
9:17 PM Changeset in webkit [10797] by darin
  • 7 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.

No layout test added: only affects plain text view and requires loading the
file in multiple chunks.

  • WebCore.exp: Added WebCoreTextDecoder.
  • kwq/WebCoreTextDecoder.h: Added.
  • kwq/WebCoreTextDecoder.mm: Added.
  • WebCore.xcodeproj/project.pbxproj: Added files, made header private (SPI).

WebKit:

Reviewed by Maciej.

  • WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation finishedLoadingWithDataSource:]): Call flushReceivedData on the WebTextView so it can decode any final bytes.
  • WebView.subproj/WebTextView.h: Added WebCoreTextDecoder field and flushReceivedData method.
  • WebView.subproj/WebTextView.m: (-[WebTextView dealloc]): Release WebCoreTextDecoder. (-[WebTextView appendReceivedData:fromDataSource:]): Create a WebCoreTextDecoder to decode the text; use the textEncodingName from the data source. Use it to decode instead of the data source's stringWithData. (-[WebTextView flushReceivedData]): Call flush on the decoder and append any last bytes to the text view.
8:50 PM Changeset in webkit [10796] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/css/acid2-pixel-expected.checksum: Added.
  • fast/css/acid2-pixel-expected.png: Added.
  • fast/css/acid2-pixel-expected.txt: Added.
  • fast/css/acid2-pixel.html: Added.
8:37 PM Changeset in webkit [10795] by darin
  • 3 edits in trunk/LayoutTests

Reviewed by Geoff Garen.

  • fast/js/date-big-setmonth.html: Changed to compare expected result with a Date value rather than with a constant. Also write out final result as a date rather than as a constant.
  • fast/js/date-big-setmonth-expected.txt: Updated.
8:31 PM Changeset in webkit [10794] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/form-data-encoding-expected.txt: Added.
  • fast/forms/form-data-encoding.html: Added.

WebCore:

Reviewed by Maciej.

Added one layout test.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): Pass true to the fromUnicode function to request entity encoding. (DOM::FormDataList::appendString): Ditto.
  • kwq/KWQTextCodec.h: Add boolean parameter to request entity-style encoding for characters that can't be expressed in the desired encoding.
  • kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Added code to entity-encode characters that can't be expressed in the desired encoding.
7:57 PM Changeset in webkit [10793] by darin
  • 4 edits
    5 adds in trunk

LayoutTests:

Reviewed by Darin.

  • editing/input/text-input-controller-expected.txt: Added.
  • editing/input/text-input-controller.html: Added.

WebKitTools:

Reviewed, rearranged and landed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]): Create a text input controller and put it in a property of the window object.
  • DumpRenderTree/TextInputController.h: Added.
  • DumpRenderTree/TextInputController.m: Added.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added files.
7:36 PM Changeset in webkit [10792] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • kwq/KWQListBox.mm: (KWQTableViewTypeSelectCallback): Added. (-[KWQTableView finalize]): Deallocate the UCTypeSelect object. (-[KWQTableView dealloc]): Ditto. (-[KWQTableView keyUp:]): If character typed is a graphic character, pass it along to the UCTypeSelect object and use it to type select, otherwise flush the object.
  • manual-tests/select-element-type-select.html: Added.
7:14 PM Changeset in webkit [10791] by darin
  • 12 edits in trunk

LayoutTests:

  • fast/dom/HTMLElement/bdo.html: Updated test, no longer says to expect failure.
  • fast/dom/HTMLElement/bdo-expected.checksum: Correct results.
  • fast/dom/HTMLElement/bdo-expected.png: Ditto.
  • fast/dom/HTMLElement/bdo-expected.txt: Ditto.
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated to expect correct results for the section done with <bdo>.
  • fast/text/international/bidi-LDB-2-HTML-expected.png: Ditto.
  • fast/text/international/bidi-LDB-2-HTML-expected.txt: Ditto.

WebCore:

Reviewed by Darin.

Fixes the results of some existing layout tests.

  • khtml/xml/dom_elementimpl.h: Add eBDO to the list of entry types so there's a way to keep <bdo> dir attribute mappings separate from those of other elements.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::mapToEntry): Add special case to use eBDO for the dir attribute on elements with the <bdo> tag. (HTMLElementImpl::parseMappedAttribute): Use bidi-override for the unicode-bidi CSS property when setting it based on the dir attribute on a <bdo> tag. Along with the change above this obviates the need for an HTMLElementImpl subclass for <bdo>, but we could refactor it that way later if we decide there's an advantage to doing it that way.
  • khtml/css/html4.css: Remove the rules about <bdo>. They are insufficient, and now they are also unnecessary with the changes above.
6:46 PM Changeset in webkit [10790] by darin
  • 8 edits
    12 adds in trunk

LayoutTests:

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4898
(Failures in dbaron's bidi ordering tests).

  • fast/dom/HTMLElement/bdo-expected.txt: Updated for differently-breaking text runs.
  • fast/text/international/bidi-override-expected.txt: Updated because override characters no longer show up in the render tree.
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
  • fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
  • fast/text/international/bidi-LDB-2-CSS-expected.txt: Added.
  • fast/text/international/bidi-LDB-2-CSS.html: Added.
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
  • fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
  • fast/text/international/bidi-LDB-2-HTML-expected.txt: Added.
  • fast/text/international/bidi-LDB-2-HTML.html: Added.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt: Added.
  • fast/text/international/bidi-LDB-2-formatting-characters.html: Added.
  • fast/text/international/bidi-explicit-embedding-expected.checksum: Updated to now-correct results.
  • fast/text/international/bidi-explicit-embedding-expected.png: Ditto.
  • fast/text/international/bidi-explicit-embedding-expected.txt: Ditto.

WebCore:

Reviewed by Darin.

Added 3 dbaron bidi ordering tests to LayoutTests.

  • khtml/rendering/bidi.cpp: (khtml::deleteBidiRuns): (khtml::Bidinext): (khtml::appendRunsForObject): (khtml::embed): (khtml::RenderBlock::bidiReorderLine):
3:45 AM Changeset in webkit [10789] by eseidel
  • 1 edit
    4 adds in trunk

Bug #: 5240
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Almost forgot the layout test for the last commit. ;)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5240

  • svg-tests/custom/use-forward-refs-expected.checksum: Added.
  • svg-tests/custom/use-forward-refs-expected.png: Added.
  • svg-tests/custom/use-forward-refs-expected.txt: Added.
  • svg-tests/custom/use-forward-refs.svg: Added.
2:18 AM Changeset in webkit [10788] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 5240
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fix to handle forward referencing <use> elements.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5240

  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::executeScripts): delayed close. (SVGDocumentImpl::addForwardReference): new function.
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::close): delay close, if missing reference.

Oct 7, 2005:

5:51 PM Changeset in webkit [10787] by harrison
  • 7 edits in trunk/LayoutTests

Reviewed by Justin.

Adjusted expected results after fixing position code in
<rdar://problem/4064017> "Safari crashes at -[WebCoreBridge firstRectForDOMRange:] + 92"

  • editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • editing/selection/3690703-expected.txt:
  • editing/selection/3690719-expected.txt:
  • editing/selection/select-all-004-expected.txt:
5:50 PM Changeset in webkit [10786] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Justin.

"<rdar://problem/4064017> Safari crashes at -[WebCoreBridge firstRectForDOMRange:] + 92"

  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): Do not insert placeholder if selection ends at a BR.

(khtml::DeleteSelectionCommand::handleGeneralDelete):
No need to preserve starting BR because insertPlaceholderForAncestorBlockContent already did.

  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): (DOM::Position::downstream): Fixed to return original position instead of invisible position when no suitable position found upstream.
5:18 PM Changeset in webkit [12204] by thatcher
  • 2 edits
    1 add in trunk/JavaScriptGlue

Reviewed by Maciej.

Build fix, needed to disable RTTI. Upgraded to a native target.

  • JavaScriptGlue.xcodeproj/project.pbxproj:
  • Info.plist
11:38 AM Changeset in webkit [10785] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • pass the current form to the isindex constructor, so that isindex doesn't malfunction in the case of a misnested form
  • khtml/html/htmlparser.cpp: (HTMLParser::handleIsindex):
11:31 AM Changeset in webkit [10784] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Omernick.

WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

  • WebView.subproj/WebUIDelegatePrivate.h: New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was running in. Eventually we'll deprecate the old three methods in favor of these in the public API.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Call version of the delegate method that has the frame parameter if the delegate supports it. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): ditto (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): ditto
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. Doesn't actually use the frame parameter here yet though.
Note: See TracTimeline for information about the timeline view.