Context Navigation

Move the default padding for buttons into the CSS file. It will
get overridden by Aqua buttons but be honored by all other types
of buttons. This allows the author to override it as well when
customizing.

khtml/rendering/render_block.h: Make paintChildren virtual so that RenderButton can push a clip and pop a clip when painting children.

khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations): Let the theme now decide whether the border/background should still be painted after the theme has painted. This allows buttons to paint custom borders but still use a pretty OS X background for the button face.

khtml/rendering/render_button.cpp: (khtml::RenderButton::paintChildren): Overridden to push/pop a clip so that the contents of a button don't ever spill out.

khtml/rendering/render_button.h: Added paintChildren method.

khtml/rendering/render_style.h: (khtml::BorderData::hasBorder): Fixed a regression in hasBorder. The border-image logic was inverted, resulting in hasBorder being true for every element!

khtml/rendering/render_theme.cpp: (khtml::RenderTheme::paint): Patched to return a boolean indicating whether or not the border/background should be painted.

khtml/rendering/render_theme.h:
khtml/rendering/render_theme_mac.h:
khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustRepaintRect): Forgot to include radio and button in this method so that repaint rects would be correct.

(khtml::RenderThemeMac::paintCheckbox):
(khtml::RenderThemeMac::paintRadio):
Adjusted to return the boolean to indicate that painting of
border/background should not occur.

(khtml::RenderThemeMac::adjustButtonStyle):
Added support for border/background/colors. Also locked
white-space to nowrap for Aqua buttons to avoid line wrapping.

(khtml::RenderThemeMac::setButtonCellState):
(khtml::RenderThemeMac::paintButton):
More support for custom border/background/color.

Oct 21, 2005:

9:38 PM Changeset in webkit [10908] by hyatt

1 edit in trunk/WebCore/khtml/khtml_part.cpp

Put back in the hasRef() check for jumping to anchors to fix the regression (bug 5457)

8:07 PM Changeset in webkit [10907]

210 copies
15 deletes in tags/WebCore-416~13

This commit was manufactured by cvs2svn to create tag
'WebCore-416~13'.

8:07 PM Changeset in webkit [10906] by thatcher

2 edits in branches/Safari-Den-branch/WebCore

Versioning just in case to WebCore-416.13

8:06 PM Changeset in webkit [10905] by thatcher

2 edits in branches/Safari-Den-branch/WebCore

Reviewed by Justin Garcia.

If node is an ancestor of refNode, use the highest non-common ancestor instead
(otherwise we would be trying to append refNode's ancestor after refNode)

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode):

6:42 PM Changeset in webkit [10904] by ggaren

2 edits in trunk/WebKit

Reviewed by darin.

WebKit side of the fix for <rdar://problem/4184719> window.print() followed by
window.close() causes world leak

No test case added because I have another reviewed patch that will include a test
for this bug as well as many others.

Under some conditions, [WebDataSource stopLoading] did not set [WebDataSource isLoading]
to false, so the didFInishLoad delegates never fired.

The reason isLoading didn't become false was that the tokenizer was still running.
The fix here is to move the call to [WebCoreBridge stopLoading] above the early return
inside [WebDataSource stopLoading] -- since the tokenizer may still be running even if the
loader is finished loading -- and then to call [WebFrame _checkLoadComplete] to
give the frame a chance to fire its delegates.

WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]):

6:41 PM Changeset in webkit [10903] by ggaren

7 edits in trunk/WebCore

Reviewed by darin.

WebCore side of fix for <rdar://problem/4184719> window.print() followed by window.close()
causes world leak

No test case added because I have another reviewed patch that will include a test
for this bug as well as many others.

Under some conditions, [WebDataSource stopLoading] did not set [WebDataSource isLoading]
to false, so the didFInishLoad delegates never fired.

The reason isLoading didn't become false was that the tokenizer was still running.
The fix here is to add a call to Tokenizer::stopParsing inside HTMLPart::stopLoading.

Since the WebKit side of the fix eliminates an early return that used to protect
HTMLPart::stopLoading from multiple calls, I added an early return inside
HTMLPart::stopLoading.

I also merged stopped and stopLoading, and merged the way XMLTokenizer and HTMLTokenizer
track whether they're in a stopped state, because anything less would be uncivilized.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::stopParsing): (khtml::HTMLTokenizer::processToken):
khtml/html/htmltokenizer.h:
khtml/khtml_part.cpp: (KHTMLPart::stopLoading): (KHTMLPart::endIfNotLoading): (KHTMLPart::stop):
khtml/xml/xml_tokenizer.cpp: (khtml::Tokenizer::Tokenizer): (khtml::Tokenizer::finishedParsing): (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::endElementNs): (khtml::XMLTokenizer::characters): (khtml::XMLTokenizer::error): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::cdataBlock): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::stopParsing):
khtml/xml/xml_tokenizer.h: (khtml::Tokenizer::stopParsing):
kwq/KWQSignalStubs.mm: (Loader::requestStarted):

6:10 PM Changeset in webkit [10902] by bdakin

3 edits
4 adds in trunk

* empty log message *

5:11 PM Changeset in webkit [10901] by bdakin

2 edits
4 adds in trunk

* empty log message *

5:06 PM Changeset in webkit [10900] by mjs

3 edits in trunk/LayoutTests

Reviewed by Eric, landed by Maciej.

fixed xmlhttprequest test to not depend on property enumeration order

fast/js/xmlhttprequest-get-expected.txt:
fast/js/xmlhttprequest-get.xhtml:

4:35 PM Changeset in webkit [10899] by mjs

8 edits
2 deletes in trunk/LayoutTests

temporarily reverted test changes corresponding to reverted changes

dom/xhtml/level3/core/nodeissamenode01-expected.txt:
dom/xhtml/level3/core/nodeissamenode02-expected.txt:
dom/xhtml/level3/core/nodeissamenode03-expected.txt:
dom/xhtml/level3/core/nodeissamenode04-expected.txt:
dom/xhtml/level3/core/nodeissamenode05-expected.txt:
dom/xhtml/level3/core/nodeissamenode06-expected.txt:
dom/xhtml/level3/core/nodeissamenode10-expected.txt:
fast/js/for-in-expected.txt: Removed.
fast/js/for-in.html: Removed.

4:13 PM Changeset in webkit [10898] by vicki

1 add in trunk/WebCore/manual-tests/linkjump-1.html

forgot to add this file in my previous commit

4:11 PM Changeset in webkit [10897] by vicki

2 edits in trunk/WebCore

Reviewed by John.

fixed <rdar://problem/4304213> sometimes have to click twice to jump to top, on href=""

manual-tests/linkjump-1.html: Added.
khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): remove check for m_url.hasRef() - encodedHtmlRef and gotoAnchor handle empty strings for scrolling to the top of the document

3:55 PM Changeset in webkit [10896] by bdakin

1 edit
4 adds in trunk/LayoutTests

Bug #:
Submitted by:
Reviewed by:

3:49 PM Changeset in webkit [10895] by bdakin

2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

3:45 PM Changeset in webkit [10894] by sullivan

2 edits in trunk/WebCore

No test cases added.

khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setButtonPaddingFromControlSize): fix deployment build by adding default: statement to button-size switch statement

3:17 PM Changeset in webkit [10893]

52 copies
22 deletes in tags/WebKit-417~3

This commit was manufactured by cvs2svn to create tag 'WebKit-417~3'.

3:17 PM Changeset in webkit [10892] by thatcher

2 edits in branches/Safari-2-0-branch/WebKit

Versioning WebKit to 417.3

3:04 PM Changeset in webkit [10891] by bdakin

2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

2:43 PM Changeset in webkit [10890] by hyatt

2 adds in trunk/LayoutTests/fast/forms

add new test of html4 button font sizes.

2:41 PM Changeset in webkit [10889] by hyatt

8 edits in trunk/LayoutTests/fast

Update the fast layout tests to have the new buttons.

2:27 PM Changeset in webkit [10888] by hyatt

19 edits
2 adds
5 deletes in trunk/WebCore

Land the new "NSView-less" buttons. With this landing both
<input type=button> and <button> will now look like OS X-style
widgets. Customization of background and border is not yet
enabled, but this is still a big improvement over the old
AppKit widgets.

Reviewed by mjs

ForwardingHeaders/qpushbutton.h: Removed.
WebCore.xcodeproj/project.pbxproj:
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::adjustRenderStyle):
khtml/css/cssstyleselector.h: (khtml::CSSStyleSelector::paintMetrics):
khtml/css/cssvalues.in:
khtml/css/html4.css:
khtml/html/html_formimpl.cpp: (DOM::HTMLButtonElementImpl::createRenderer): (DOM::HTMLInputElementImpl::click): (DOM::HTMLInputElementImpl::createRenderer):
khtml/html/html_formimpl.h: (DOM::HTMLInputElementImpl::isTextButton):
khtml/rendering/render_button.cpp: Added. (khtml::m_inner): (khtml::RenderButton::~RenderButton): (khtml::RenderButton::addChild): (khtml::RenderButton::removeChild): (khtml::RenderButton::setStyle): (khtml::RenderButton::updateFromElement):
khtml/rendering/render_button.h: Added. (khtml::RenderButton::removeLeftoverAnonymousBoxes): (khtml::RenderButton::renderName):
khtml/rendering/render_form.cpp:
khtml/rendering/render_form.h: (khtml::RenderFileButton::calcReplacedHeight): (khtml::RenderFileButton::isEditable):
khtml/rendering/render_style.h: (khtml::):
khtml/rendering/render_theme.cpp: (khtml::RenderTheme::adjustStyle): (khtml::RenderTheme::paint): (khtml::RenderTheme::adjustCheckboxStyle): (khtml::RenderTheme::adjustRadioStyle): (khtml::RenderTheme::adjustButtonStyle):
khtml/rendering/render_theme.h: (khtml::RenderTheme::setButtonSize):
khtml/rendering/render_theme_mac.h:
khtml/rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setSizeFromFont): (khtml::RenderThemeMac::setFontFromControlSize): (khtml::RenderThemeMac::addIntrinsicMargins): (khtml::RenderThemeMac::setButtonPaddingFromControlSize): (khtml::RenderThemeMac::adjustButtonStyle): (khtml::RenderThemeMac::buttonSizes): (khtml::RenderThemeMac::buttonMargins): (khtml::RenderThemeMac::setButtonSize): (khtml::RenderThemeMac::setButtonCellState): (khtml::RenderThemeMac::paintButton):
kwq/KWQAccObject.mm: (-[KWQAccObject actionElement]): (-[KWQAccObject role]): (-[KWQAccObject title]):
kwq/KWQButton.h: Removed.
kwq/KWQButton.mm: Removed.
kwq/KWQComboBox.mm:
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm:
kwq/KWQPushButton.h: Removed.
kwq/KWQPushButton.mm: Removed.

2:20 PM Changeset in webkit [10887]

203 copies
15 deletes in tags/WebCore-417~4

This commit was manufactured by cvs2svn to create tag
'WebCore-417~4'.

2:20 PM Changeset in webkit [10886]

69 copies
5 deletes in tags/JavaScriptCore-417~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~3'.

2:20 PM Changeset in webkit [10885] by thatcher

4 edits in branches/Safari-2-0-branch

Versioning WebCore and JavaScriptCore-417.3

2:04 PM Changeset in webkit [10884] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/khtml/ecma/kjs_binding.cpp

Rolling out some local test changes that CVS wasn't suppose to commit.

1:58 PM Changeset in webkit [10883] by thatcher

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-10-19 Adele Peterson <adele@apple.com>

Reviewed by Hyatt.

Fixed <rdar://problem/4243807> Denver Regression: DOM returns lower case strings for tags in empty document

khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::HTMLDocumentImpl): initialize hMode to Html4.

11:43 AM Changeset in webkit [10882] by ggaren

2 edits in trunk/WebKit

Patch by TimO, Reviewed by hyatt, tested and landed by me.

Found what appears to be a misguided optimization that actually causes a measurable performance problem.
A fixed-size buffer was allocated on the stack to pass into CFURLGetBytes(), presumably to avoid malloc()
for URLs less than 2048 bytes. There was also a fallback which malloc()'ed a buffer in case the fixed-size
buffer was too small to hold the URL's bytes. This malloc()'ed buffer was then wrapped in an NSData using
+dataWithBytesNoCopy:length:, avoiding a memory copy (yay!)

The problem with this approach is two-fold:

Regardless of how the buffer was allocated and filled, it is immediately wrapped in an NSData using +dataWithBytes:length:, which copies the input bytes. This is pretty much unavoidable; we need to get the data into a malloc()'ed buffer to return it to the caller, unless the caller provides its own storage (which would be super inconvenient).

The size of the fixed buffer was large enough that it fit most (if not all) URLs involved in our Page Load Test. This means the unintentionally-inefficient case was by far the most *common* case!

My fix is to malloc() the buffer from the start, and then use +[NSData dataWithBytes:length:freeWhenDone:]
to wrap the buffer in an NSData. This avoids a memory copy for the normal case where a URL is less than
2048 bytes, and keeps the efficient behavior for the uncommon long URL case.

Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_originalData]):

9:35 AM Changeset in webkit [10881] by darin

2 edits in trunk/WebKit

Reviewed and landed by Darin.

fixed a couple regressions caused by my last check-in http://bugzilla.opendarwin.org/show_bug.cgi?id=5437 http://bugzilla.opendarwin.org/show_bug.cgi?id=5443

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer CG_drawHighlightForRun:style:geometry:]): Compute background width correctly, by subtracting position after run from position before run. (addDirectionalOverride): Make the range include only the characters between the directional override characters, not the directional override characters themselves. (initializeWidthIterator): Correctly compute "widthToStart" based on the offset to the beginning of the run, not to the end of the run!

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed