Context Navigation

got ready to make m_parent private by removing references to it also removed tabs (and used spaces instead) to files I touched
fixed code that initialized m_parent twice

khtml/css/css_base.cpp: (StyleBaseImpl::checkLoaded): Use parent(). (StyleBaseImpl::stylesheet): Ditto.
khtml/css/css_base.h: (DOM::StyleBaseImpl::StyleBaseImpl): Initialize base TreeShared with the appropriate parent instead of first setting m_parent to 0 and then to the correct value. Also removed setParent, since the base class setParent works fine.
khtml/css/css_ruleimpl.cpp: (DOM::CSSRuleImpl::parentStyleSheet): Use parent(). (DOM::CSSRuleImpl::parentRule): Ditto.
khtml/css/css_stylesheetimpl.cpp: (StyleSheetImpl::parentStyleSheet): Ditto. (MediaListImpl::parentStyleSheet): Ditto. (MediaListImpl::parentRule): Ditto.
khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::parentRule): Ditto.
khtml/rendering/render_replaced.cpp: Reformatting only, and removed some APPLE_CHANGES-only instead.
khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isContentEditable): Use parent().
khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::parentNode): Ditto.
khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLImportRuleImpl::parentStyleSheet): Ditto.

4:46 PM Changeset in webkit [10944] by darin

5 edits in trunk/LayoutTests

changed a test to use a GIF instead of a PNG to avoid issues with color correction also, it was using an image that's part of OS X, and it's nicer to have a standalone test

fast/dynamic/genContentDestroyChildren-expected.checksum:
fast/dynamic/genContentDestroyChildren-expected.png:
fast/dynamic/genContentDestroyChildren-expected.txt:
fast/dynamic/genContentDestroyChildren.html:

4:38 PM Changeset in webkit [10943] by darin

3 edits in trunk/WebKit

Reviewed by Geoff.

change internal methods in WebTextRenderer to be functions in case this has any effect on speed (also makes things a bit clearer, in my opinion)

WebCoreSupport.subproj/WebTextRenderer.h: Made all fields public, which is OK since this is really a private class. Made setAlwaysUseATSU: class method public too for the same reason.

WebCoreSupport.subproj/WebTextRenderer.m: Change all methods to functions. (destroy): Function name for method free. (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): Removed code to first subtract lineSpacing - descent, then later add it back. (getSmallCapsRenderer): Function name for method smallCapsRenderer. (findSubstituteFont): Function name for method substituteFontForString:families:. (findSubstituteRenderer): Function name for method substituteRendererForCharacters:length:families:. (updateGlyphMapEntry): Function name for method updateGlyphEntryForCharacter:glyphID:substituteRenderer:. (extendGlyphMap): Function name for method extendCharacterToGlyphMapToInclude:. (extendWidthMap): Function name for method extendGlyphToWidthMapToInclude:. (getTextBounds): Function name for method trapezoidForRun:style:atPoint:.

4:23 PM Changeset in webkit [10942] by darin

4 edits in trunk/LayoutTests

fixed results for http://bugzilla.opendarwin.org/show_bug.cgi?id=5415

Mitz's patch removed some strange code about 1-character runs and rounding.
It affected the results of this one test. Here are new results.

fast/text/international/bidi-explicit-embedding-expected.checksum:
fast/text/international/bidi-explicit-embedding-expected.png:
fast/text/international/bidi-explicit-embedding-expected.txt:

3:59 PM Changeset in webkit [10941] by hyatt

2 edits
2 adds in trunk

Fix for 5485, make sure generated content's "rightmost selector"
check does not apply once you move to another selector in the
compound selector chain.

Reviewed by mjs

khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector):

3:51 PM Changeset in webkit [10940] by bdakin

4 edits
4 adds in trunk

* empty log message *

3:43 PM Changeset in webkit [10939] by hyatt

2 edits
2 adds in trunk

Make sure the button's generated text using the value with
the default label so that Submit/Reset buttons aren't blank.

Reviewed by mjs

Added fast/forms/blankbuttons.html

khtml/rendering/render_button.cpp: (khtml::RenderButton::updateFromElement):

3:33 PM Changeset in webkit [10938] by mjs

11 edits in trunk

LayoutTests:

Re-landing Dave Hyatt's changes from when the tree was closed.

fast/clip/008-expected.txt:
fast/css/acid2-expected.txt:
fast/css/acid2-pixel-expected.txt:
fast/table/overflowHidden-expected.txt:

WebCore:

Re-landing Dave Hyatt's changes from when the tree was closed.

khtml/rendering/render_container.cpp: (RenderContainer::destroy): (RenderContainer::destroyLeftoverAnonymousChildren):
khtml/rendering/render_container.h:
khtml/rendering/render_flow.cpp: (RenderFlow::destroy):
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent): (khtml::RenderLayer::paintLayer): (khtml::isOverflowOnly): (khtml::compare): (khtml::sortByZOrder):
khtml/rendering/render_layer.h:

2:52 PM Changeset in webkit [10937] by thatcher

2 edits in trunk/WebCore

Reviewed by Darin Adler.
Commited by Tim Hatcher.

fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=5484 REGRESSION: reproducible crash in CachedCSSStyleSheet::setCharset

khtml/misc/loader.cpp: (CachedCSSStyleSheet::setCharset): (CachedScript::setCharset):

2:42 PM Changeset in webkit [10936] by harrison

1 edit
2 adds in trunk/LayoutTests

Reviewed by Darin. Committed by David Harrison.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5449
"OBJECT should be accessible by id/name as document property only if its only children are PARAMs"

fast/js/object-by-name-or-id-expected.txt: Added.
fast/js/object-by-name-or-id.html: Added.

2:42 PM Changeset in webkit [10935] by harrison

4 edits in trunk/WebCore

Reviewed by Darin. Committed by David Harrison.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5449
"OBJECT should be accessible by id/name as document property only if its only children are PARAMs"

Test added:

fast/js/object-by-name-or-id-expected.txt: Added.
fast/js/object-by-name-or-id.html: Added.

Files changed:

khtml/html/html_miscimpl.cpp: (DOM::HTMLNameCollectionImpl::traverseNextItem):
khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::HTMLObjectElementImpl): (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLObjectElementImpl::insertedIntoDocument): (DOM::HTMLObjectElementImpl::removedFromDocument): (DOM::HTMLObjectElementImpl::childrenChanged): (DOM::HTMLObjectElementImpl::updateDocNamedItem):
khtml/html/html_objectimpl.h: (DOM::HTMLObjectElementImpl::isDocNamedItem):
manual-tests/drag_select_highlighting.html: Added.

2:34 PM Changeset in webkit [10934] by harrison

1 edit
1 add in trunk/WebCore

Reviewed by Darin. Committed by David Harrison.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5415
"Left border of selection highlight leaves behind a trail"

(Code changes are in WebKit)

manual-tests/drag_select_highlighting.html: Added.

2:22 PM Changeset in webkit [10933] by sullivan

3 edits in trunk/JavaScriptCore

Reviewed by Darin Adler. Code changes by Alexey Proskuryakov.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4931 Unicode format characters (Cf) should be removed from JavaScript source

kjs/lexer.cpp: include <unicode/uchar.h> (Lexer::Lexer): use KJS::UChar instead of UChar to avoid ambiguity caused by new include (Lexer::setCode): ditto; also, use shift(4) to skip first 4 chars to take advantage of new logic there. (Lexer::shift): skip chars of type U_FORMAT_CHAR (Lexer::convertUnicode): use KJS::UChar instead of UChar to avoid ambiguity caused by new include (Lexer::record16): ditto (Lexer::makeIdentifier): ditto (Lexer::makeUString): ditto

tests/mozilla/ecma/Array/15.4.5.1-1.js: updated to skip soft hyphens

1:45 PM Changeset in webkit [10932] by sullivan

2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler. Code changes by George Staikos/Geoff Garen.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4142 Date object does not always adjust daylight savings correctly

kjs/date_object.cpp: (KJS::makeTime): Fix the case where a time change crosses the daylight savings start/end dates.

12:40 PM Changeset in webkit [10931] by harrison

2 edits in trunk/WebKit

Reviewed by Darin. Committed by David Harrison.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5415
"Left border of selection highlight leaves behind a trail"

manual-tests/drag_select_highlighting.html: Added. (this test case was added to WebCore)

WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): (-[WebTextRenderer CG_drawHighlightForRun:style:geometry:]): (-[WebTextRenderer ATSU_drawHighlightForRun:style:geometry:]): (advanceWidthIterator):

12:36 PM Changeset in webkit [10930] by vicki

2 edits in trunk/WebCore

Changes by Mitz Pettel, reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5306 (KHTMLPart::requestObject doesn't destroy old plugin content)

khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::recalcStyle):

11:58 AM Changeset in webkit [10929] by vicki

3 edits in trunk/WebCore

Changes by Alexey Proskuryakov, reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5140 (CachedObject loading ignores charset from HTTP headers)

khtml/misc/loader.cpp: (CachedCSSStyleSheet::setCharset): (CachedScript::setCharset): (CachedXSLStyleSheet::setCharset): (CachedXSLStyleSheet::data): (CachedXBLDocument::CachedXBLDocument): (CachedXBLDocument::setCharset): (CachedXBLDocument::data): (Loader::slotReceivedResponse):
khtml/misc/loader.h:

10:47 AM Changeset in webkit [10928] by bdakin

3 edits
4 adds in trunk

* empty log message *

12:25 AM Changeset in webkit [10927] by eseidel

7 edits in trunk/LayoutTests

Bug #: 5317
Submitted by: darin
Reviewed by: hyatt

Updated tests after fixing QName validation.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5317

dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement-expected.txt:
dom/xhtml/level1/core/hc_documentinvalidcharacterexceptioncreateelement1-expected.txt:
dom/xhtml/level3/core/canonicalform06-expected.txt:
dom/xhtml/level3/core/infoset06-expected.txt:
dom/xhtml/level3/core/wellformed01-expected.txt:
dom/xhtml/level3/core/wellformed02-expected.txt:

12:24 AM Changeset in webkit [10926] by eseidel

4 edits in trunk/WebCore

Bug #: 5317
Submitted by: darin
Reviewed by: hyatt

Fix Qualified Name parsing to match spec.
xhtml dom tests cover these cases.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5317

khtml/xml/dom_docimpl.cpp: (isValidNameStart): (isValidNamePart): (qualifiedNameIsMalformed): (DOMImplementationImpl::createDocumentType): (DOMImplementationImpl::createDocument): (DocumentImpl::createElementNS): (DocumentImpl::isValidName): (DocumentImpl::parseQualifiedName):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttributeNS):

Oct 23, 2005:

11:55 PM Changeset in webkit [10925] by eseidel

8 edits in trunk

Bug #: 5361
Submitted by: Julien Palmas <julien.palmas@gmail.com>
Reviewed by: eseidel

Finally fix pattern "userspaceonuse" support.
Several test cases already cover this.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5361

kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::draw):
svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.checksum:
svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:

11:31 PM Changeset in webkit [10924] by eseidel

115 edits
1 add in trunk

Bug #: 5391
Submitted by: Julien Palmas <julien.palmas@gmail.com>
Reviewed by: eseidel

Merged over Shared -> Shared<T> change from kdom.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5391

WebCore.xcodeproj/project.pbxproj:
kdom/Shared.h: (KDOM::Shared::Shared): (KDOM::Shared::~Shared): (KDOM::Shared::refCount): (KDOM::Shared::ref): (KDOM::Shared::deref):
kdom/SharedPtr.h: Added. (KDOM::SharedPtr::SharedPtr): (KDOM::SharedPtr::~SharedPtr): (KDOM::SharedPtr::isNull): (KDOM::SharedPtr::notNull): (KDOM::SharedPtr::reset): (KDOM::SharedPtr::get): (KDOM::SharedPtr::operator!): (KDOM::SharedPtr::operator bool): (KDOM::SharedPtr::operator==): (KDOM::::operator):
kdom/TreeShared.h: (KDOM::TreeShared::TreeShared): (KDOM::TreeShared::~TreeShared): (KDOM::TreeShared::refCount): (KDOM::TreeShared::ref): (KDOM::TreeShared::deref): (KDOM::TreeShared::parent): (KDOM::TreeShared::setParent):
kdom/core/DOMConfigurationImpl.cpp: (DOMConfigurationImpl::DOMConfigurationImpl):
kdom/core/DOMConfigurationImpl.h:
kdom/core/DOMErrorHandlerImpl.cpp: (DOMErrorHandlerImpl::DOMErrorHandlerImpl):
kdom/core/DOMErrorHandlerImpl.h:
kdom/core/DOMErrorImpl.cpp: (DOMErrorImpl::DOMErrorImpl):
kdom/core/DOMErrorImpl.h: (KDOM::):
kdom/core/DOMExceptionImpl.cpp: (DOMExceptionImpl::DOMExceptionImpl):
kdom/core/DOMExceptionImpl.h:
kdom/core/DOMList.h: (KDOM::DOMList::DOMList): (KDOM::DOMList::~DOMList):
kdom/core/DOMLocatorImpl.cpp: (DOMLocatorImpl::DOMLocatorImpl):
kdom/core/DOMLocatorImpl.h:
kdom/core/DOMObjectImpl.cpp: (DOMObjectImpl::DOMObjectImpl):
kdom/core/DOMObjectImpl.h:
kdom/core/DOMStringImpl.cpp: (DOMStringImpl::DOMStringImpl):
kdom/core/DOMStringImpl.h:
kdom/core/DOMUserDataImpl.cpp: (DOMUserDataImpl::DOMUserDataImpl):
kdom/core/DOMUserDataImpl.h:
kdom/core/NamedNodeMapImpl.cpp: (NamedNodeMapImpl::NamedNodeMapImpl):
kdom/core/NamedNodeMapImpl.h:
kdom/core/NodeImpl.h:
kdom/core/NodeListImpl.cpp: (NodeListImpl::NodeListImpl):
kdom/core/NodeListImpl.h:
kdom/core/TypeInfoImpl.cpp: (TypeInfoImpl::TypeInfoImpl):
kdom/core/TypeInfoImpl.h:
kdom/css/CSSRuleListImpl.cpp: (CSSRuleListImpl::CSSRuleListImpl):
kdom/css/CSSRuleListImpl.h:
kdom/css/CounterImpl.cpp: (CounterImpl::CounterImpl):
kdom/css/CounterImpl.h:
kdom/css/RGBColorImpl.cpp: (RGBColorImpl::RGBColorImpl):
kdom/css/RGBColorImpl.h:
kdom/css/RectImpl.cpp: (RectImpl::RectImpl):
kdom/css/RectImpl.h:
kdom/css/RenderStyle.cpp: (RenderStyle::RenderStyle):
kdom/css/RenderStyle.h: (KDOM::RenderStyle::RenderStyle):
kdom/css/RenderStyleDefs.cpp: (StyleSurroundData::StyleSurroundData): (StyleBoxData::StyleBoxData): (StyleVisualData::StyleVisualData): (StyleBackgroundData::StyleBackgroundData): (StyleMarqueeData::StyleMarqueeData): (StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (StyleCSS3InheritedData::StyleCSS3InheritedData): (StyleInheritedData::StyleInheritedData):
kdom/css/RenderStyleDefs.h: (KDOM::BorderData::BorderData):
kdom/css/StyleSheetListImpl.cpp: (StyleSheetListImpl::StyleSheetListImpl):
kdom/css/StyleSheetListImpl.h:
kdom/events/EventExceptionImpl.cpp: (EventExceptionImpl::EventExceptionImpl):
kdom/events/EventExceptionImpl.h:
kdom/events/EventImpl.cpp: (EventImpl::EventImpl):
kdom/events/EventImpl.h:
kdom/events/EventListenerImpl.cpp: (EventListenerImpl::EventListenerImpl):
kdom/events/EventListenerImpl.h:
kdom/ls/LSExceptionImpl.cpp: (LSExceptionImpl::LSExceptionImpl):
kdom/ls/LSExceptionImpl.h:
kdom/ls/LSInputImpl.cpp: (LSInputImpl::LSInputImpl):
kdom/ls/LSInputImpl.h:
kdom/ls/LSOutputImpl.cpp: (LSOutputImpl::LSOutputImpl):
kdom/ls/LSOutputImpl.h:
kdom/ls/LSParserFilterImpl.cpp: (LSParserFilterImpl::LSParserFilterImpl):
kdom/ls/LSParserFilterImpl.h:
kdom/ls/LSResourceResolverImpl.cpp: (LSResourceResolverImpl::LSResourceResolverImpl):
kdom/ls/LSResourceResolverImpl.h:
kdom/ls/LSSerializerImpl.cpp: (LSSerializerImpl::LSSerializerImpl):
kdom/ls/LSSerializerImpl.h:
kdom/range/RangeExceptionImpl.cpp: (RangeExceptionImpl::RangeExceptionImpl):
kdom/range/RangeExceptionImpl.h:
kdom/range/RangeImpl.cpp: (RangeImpl::RangeImpl):
kdom/range/RangeImpl.h:
kdom/traversal/NodeFilterImpl.cpp: (NodeFilterImpl::NodeFilterImpl):
kdom/traversal/NodeFilterImpl.h: (KDOM::NodeFilterCondition::NodeFilterCondition): (KDOM::NodeFilterCondition::~NodeFilterCondition): (KDOM::NodeFilterCondition::acceptNode):
kdom/traversal/TraversalImpl.cpp: (TraversalImpl::TraversalImpl):
kdom/traversal/TraversalImpl.h:
kdom/views/AbstractViewImpl.cpp: (AbstractViewImpl::AbstractViewImpl):
kdom/views/AbstractViewImpl.h:
kdom/xpath/XPathExceptionImpl.h:
kdom/xpath/XPathExpressionImpl.h:
kdom/xpath/XPathNSResolverImpl.h:
kdom/xpath/XPathResultImpl.h:
kdom/xpointer/NBCImpl.cpp: (NBCImpl::NBCImpl):
kdom/xpointer/NBCImpl.h:
kdom/xpointer/PointerPartImpl.cpp: (PointerPartImpl::PointerPartImpl):
kdom/xpointer/PointerPartImpl.h:
kdom/xpointer/XPointerExceptionImpl.cpp: (XPointerExceptionImpl::XPointerExceptionImpl):
kdom/xpointer/XPointerExceptionImpl.h:
kdom/xpointer/XPointerExpressionImpl.cpp: (XPointerExpressionImpl::XPointerExpressionImpl):
kdom/xpointer/XPointerExpressionImpl.h:
kdom/xpointer/XPointerResultImpl.cpp: (XPointerResultImpl::XPointerResultImpl):
kdom/xpointer/XPointerResultImpl.h:
ksvg2/css/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleClipData::StyleClipData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
ksvg2/css/SVGRenderStyleDefs.h:
ksvg2/svg/SVGAngleImpl.cpp: (SVGAngleImpl::SVGAngleImpl):
ksvg2/svg/SVGAngleImpl.h:
ksvg2/svg/SVGAnimatedBooleanImpl.cpp: (SVGAnimatedBooleanImpl::SVGAnimatedBooleanImpl):
ksvg2/svg/SVGAnimatedBooleanImpl.h:
ksvg2/svg/SVGAnimatedEnumerationImpl.cpp: (SVGAnimatedEnumerationImpl::SVGAnimatedEnumerationImpl):
ksvg2/svg/SVGAnimatedEnumerationImpl.h:
ksvg2/svg/SVGAnimatedIntegerImpl.cpp: (SVGAnimatedIntegerImpl::SVGAnimatedIntegerImpl):
ksvg2/svg/SVGAnimatedIntegerImpl.h:
ksvg2/svg/SVGAnimatedNumberImpl.cpp: (SVGAnimatedNumberImpl::SVGAnimatedNumberImpl):
ksvg2/svg/SVGAnimatedNumberImpl.h:
ksvg2/svg/SVGAnimatedTemplate.h: (KSVG::SVGAnimatedTemplate::SVGAnimatedTemplate):
ksvg2/svg/SVGExceptionImpl.cpp: (SVGExceptionImpl::SVGExceptionImpl):
ksvg2/svg/SVGExceptionImpl.h:
ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::SVGLengthImpl):
ksvg2/svg/SVGLengthImpl.h:
ksvg2/svg/SVGMatrixImpl.cpp: (SVGMatrixImpl::SVGMatrixImpl):
ksvg2/svg/SVGMatrixImpl.h:
ksvg2/svg/SVGNumberImpl.cpp: (SVGNumberImpl::SVGNumberImpl):
ksvg2/svg/SVGNumberImpl.h:
ksvg2/svg/SVGPathSegImpl.cpp: (SVGPathSegImpl::SVGPathSegImpl):
ksvg2/svg/SVGPathSegImpl.h:
ksvg2/svg/SVGPointImpl.cpp: (SVGPointImpl::SVGPointImpl):
ksvg2/svg/SVGPointImpl.h:
ksvg2/svg/SVGPreserveAspectRatioImpl.cpp: (SVGPreserveAspectRatioImpl::SVGPreserveAspectRatioImpl):
ksvg2/svg/SVGPreserveAspectRatioImpl.h:
ksvg2/svg/SVGRectImpl.cpp: (SVGRectImpl::SVGRectImpl):
ksvg2/svg/SVGRectImpl.h:
ksvg2/svg/SVGTransformImpl.cpp: (SVGTransformImpl::SVGTransformImpl):
ksvg2/svg/SVGTransformImpl.h:

11:14 PM Changeset in webkit [10923] by eseidel

2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: No review, build fix only.

WebCore.xcodeproj/project.pbxproj: added RenderButton.cpp

7:13 PM Changeset in webkit [10922] by tomernic

4 edits in trunk/WebKit

Bug #: <http://bugzilla.opendarwin.org/show_bug.cgi?id=5365>
Submitted by: mitzpettel
Reviewed by: Dave Hyatt

Send -webPlugInStop (or -pluginStop) and -webPluginDestroy (or -pluginDestroy)
to complying plugins right when they're removed from the WebHTMLView, and also
release them from the plugin controller's arrays.

I think this patch makes WebKit behave more like plugins expect it to, which is
the way it already behaves with Netscape plugins.

I expect complying plugins to stop making noise when receiving the stop
message, but QuickTime doesn't. If it's lucky, then it will be deallocated
because of the release and will stop then. However, JS, for one, can retain the
plugin (e.g. if you execute <javascript:document.getElementById('obj').width;>
before clicking Remove OBJECT), in which case it will just keep playing.

6:43 PM Changeset in webkit [10921] by ggaren

2 edits in trunk/WebKit

Reviewed by Maciej.

For better abstraction, made the tokenizer -- instead of the
data source -- responsible for calling [WebFrame _checkLoadComplete]
when the tokenizer stops.

WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoadingInternal]):

6:39 PM Changeset in webkit [10920] by ggaren

3 edits in trunk/WebCore

Reviewed by Maciej.

Removed early return from stopLoading because it prevented
onunload events from firing.

Also, for better abstraction, made the tokenizer -- instead of the
data source -- responsible for calling [WebFrame _checkLoadComplete]
when the tokenizer stops.

khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::stopParsing):
khtml/khtml_part.cpp: (KHTMLPart::stopLoading):

11:00 AM Changeset in webkit [10919] by eseidel

2 edits in trunk/WebCore

Bug #: 5462
Submitted by: Julien Palmas <julien.palmas@gmail.com>
Reviewed by: mjs

WebCore+SVG/xml_kdomtokenizer.cpp: (KDOMTokenizer::KDOMTokenizer): build fix. http://bugzilla.opendarwin.org/show_bug.cgi?id=5462

8:24 AM Changeset in webkit [10918] by thatcher

1 edit
4 adds in trunk/LayoutTests

Layout test to go with fix for bugzilla bug 3442
Adds support for :first-of-type CSS3 pseudo-selectors

fast/selectors/034-expected.checksum: Added.
fast/selectors/034-expected.png: Added.
fast/selectors/034-expected.txt: Added.
fast/selectors/034.html: Added.

8:12 AM Changeset in webkit [10917] by thatcher

4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3442
Adds support for :first-of-type CSS3 pseudo-selectors
And builds foundations for :last-of-type and :only-of-type

khtml/css/css_base.cpp: (CSSSelector::extractPseudoType):
khtml/css/css_base.h: (DOM::CSSSelector::CSSSelector): (DOM::CSSSelector::~CSSSelector): (DOM::CSSSelector::): (DOM::CSSSelector::pseudoType): (DOM::StyleBaseImpl::StyleBaseImpl): (DOM::StyleBaseImpl::~StyleBaseImpl): (DOM::StyleBaseImpl::isStyleSheet): (DOM::StyleBaseImpl::isCSSStyleSheet): (DOM::StyleBaseImpl::isStyleSheetList): (DOM::StyleBaseImpl::isMediaList): (DOM::StyleBaseImpl::isRuleList): (DOM::StyleBaseImpl::isRule): (DOM::StyleBaseImpl::isStyleRule): (DOM::StyleBaseImpl::isCharetRule): (DOM::StyleBaseImpl::isImportRule): (DOM::StyleBaseImpl::isMediaRule): (DOM::StyleBaseImpl::isFontFaceRule): (DOM::StyleBaseImpl::isPageRule): (DOM::StyleBaseImpl::isUnknownRule): (DOM::StyleBaseImpl::isStyleDeclaration): (DOM::StyleBaseImpl::isValue): (DOM::StyleBaseImpl::isPrimitiveValue): (DOM::StyleBaseImpl::isValueList): (DOM::StyleBaseImpl::isValueCustom): (DOM::StyleBaseImpl::setParent): (DOM::StyleBaseImpl::parseString): (DOM::StyleBaseImpl::setStrictParsing): (DOM::StyleBaseImpl::useStrictParsing): (DOM::StyleListImpl::StyleListImpl): (DOM::StyleListImpl::length): (DOM::StyleListImpl::item): (DOM::StyleListImpl::append):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed