⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 5, 2005:

10:22 PM Changeset in webkit [11081] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5357
REGRESSION: Scriptable plugin hides properties of OBJECT element

  • fast/dom/object-plugin-hides-properties.html: Added.
  • fast/js/object-plugin-hides-properties-expected.txt: Added.
10:20 PM Changeset in webkit [11080] by ggaren
  • 2 edits in trunk/JavaScriptCore

Patch by Mitz Pettel, reviewed by Maciej.

  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::fallbackObject):
9:58 PM Changeset in webkit [11079] by ggaren
  • 1 edit in trunk/LayoutTests/ChangeLog

changelog fixup

9:52 PM Changeset in webkit [11078] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5409
slice() testcase doesn't pass

  • fast/js/string-slice-abnormal-values.html: Added.
  • fast/js/string-slice-abnormal-values-expected.txt: Added.
9:48 PM Changeset in webkit [11077] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

Modified String.slice to deal with funky values.
Updated test results. We now pass <js1_2/String/slice.js>.

  • kjs/string_object.cpp: (StringProtoFuncImp::callAsFunction):
  • tests/mozilla/expected.html:
9:07 PM Changeset in webkit [11076] by ggaren
  • 2 edits in branches/Ti-2005-009-branch/JavaScriptCore
  • Rolled out the pcre changes in my previous checkin because I applied them to the wrong branch.

Reviewed by TimH.

  • pcre/pcre.c: (compile_branch):
8:09 PM Changeset in webkit [11075] by ggaren
  • 1 edit in branches/Ti-2005-009-branch/JavaScriptCore/ChangeLog

changelog fixup

8:05 PM Changeset in webkit [11074] by ggaren
  • 3 edits in branches/Ti-2005-009-branch/JavaScriptCore

Reviewed by NOBODY (OOPS!).

  • Fixed <rdar://problem/4323773> REGRESSION (412.2-416.12): xxx appears on page due to JS regexp with char > 255 (5597) (tiddlywiki.com)

Previously, we fixed a buffer overflow by returning an error when
compiling character classes with characters > 255. But that broke
the internet.

Plan B here is to work around such classes, skipping single characters

255, skipping character ranges beginning > 255, and truncating

character ranges at 255.

I removed the early returns we added and the early returns in the
original library. Now, funky expressions compile normally, tweaked
by our special rules.

I also merged the UTF8 and UTF16 checks for out of range characters.
I remember we kept them separate before because we were purist about
marking off our code changes inside UTF16 #ifdefs. Since this patch
applies equally to UTF8 and UTF16, we've already lost that innocence,
so why not have a little fun?

  • ChangeLog:
  • pcre/pcre.c: (compile_branch):
  • tests/mozilla/jsDriver.pl: Oh, by the way, I modified this to look inside of $SYMROOTS/Development. Not perfect, but certainly better than $SYMROOTS/, which is always wrong with XCode 2.1.

Nov 4, 2005:

10:49 PM Changeset in webkit [11073] by darin
  • 1 edit
    32 adds in trunk/LayoutTests
  • added pixel results for a bunch of tests that didn't have them
  • fast/block/basic/021-expected.checksum: Added.
  • fast/block/basic/021-expected.png: Added.
  • fast/block/positioning/062-expected.checksum: Added.
  • fast/block/positioning/062-expected.png: Added.
  • fast/box-sizing/box-sizing-expected.checksum: Added.
  • fast/box-sizing/box-sizing-expected.png: Added.
  • fast/box-sizing/panels-one-expected.checksum: Added.
  • fast/box-sizing/panels-one-expected.png: Added.
  • fast/box-sizing/panels-two-expected.checksum: Added.
  • fast/box-sizing/panels-two-expected.png: Added.
  • fast/box-sizing/percentage-height-expected.checksum: Added.
  • fast/box-sizing/percentage-height-expected.png: Added.
  • fast/css-generated-content/014-expected.checksum: Added.
  • fast/css-generated-content/014-expected.png: Added.
  • fast/events/event-targets-expected.checksum: Added.
  • fast/events/event-targets-expected.png: Added.
  • fast/forms/blankbuttons-expected.checksum: Added.
  • fast/forms/blankbuttons-expected.png: Added.
  • fast/forms/button-positioned-expected.checksum: Added.
  • fast/forms/button-positioned-expected.png: Added.
  • fast/forms/indeterminate-expected.checksum: Added.
  • fast/forms/indeterminate-expected.png: Added.
  • fast/frames/calculate-fixed-expected.checksum: Added.
  • fast/frames/calculate-fixed-expected.png: Added.
  • fast/frames/calculate-order-expected.checksum: Added.
  • fast/frames/calculate-order-expected.png: Added.
  • fast/frames/calculate-percentage-expected.checksum: Added.
  • fast/frames/calculate-percentage-expected.png: Added.
  • fast/frames/calculate-relative-expected.checksum: Added.
  • fast/frames/calculate-relative-expected.png: Added.
  • fast/frames/calculate-round-expected.checksum: Added.
  • fast/frames/calculate-round-expected.png: Added.
4:20 PM Changeset in webkit [11072] by hyatt
  • 1 edit in trunk/WebCore/khtml/rendering/render_block.cpp

Fix build bustage.

4:13 PM Changeset in webkit [11071]
  • 82 copies
    5 deletes in tags/JavaScriptCore-416~14

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-416~14'.

4:13 PM Changeset in webkit [11070] by thatcher
  • 2 edits in branches/Ti-2005-009-branch/JavaScriptCore

Versioning to JavaScriptCore-416.14

4:05 PM Changeset in webkit [11069]
  • 8 copies
    3 deletes in tags/JavaScriptCore-312~1~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~1~1'.

4:05 PM Changeset in webkit [11068] by thatcher
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Versioning JavaScriptCore-312.1.1

4:02 PM Changeset in webkit [11067] by thatcher
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Merging fix from Ti-2005-009-branch to Safari-1-3-branch

2005-11-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by darin.

  • Fixed <rdar://problem/4317701> *SecUpd: Tiger* PCRE heap overflow in Safari JavaScriptCore
  • pcre/pcre.c: (read_repeat_counts): We now return an error for negative repeat counts in regular expressions. This matches Firefox exactly, and Win IE by effect (Win IE doesn't return an error, but it does refuse to match anything).
3:26 PM Changeset in webkit [11066] by ggaren
  • 2 edits in branches/Ti-2005-009-branch/JavaScriptCore

Reviewed by darin.

  • Fixed <rdar://problem/4317701> *SecUpd: Tiger* PCRE heap overflow in Safari JavaScriptCore
  • pcre/pcre.c: (read_repeat_counts): We now return an error for negative repeat counts in regular expressions. This matches Firefox exactly, and Win IE by effect (Win IE doesn't return an error, but it does refuse to match anything).
1:13 PM Changeset in webkit [11065] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 5626, ghosted float steals mouse events. Make sure
that the floatRect() method deals with overflow.

Reviewed by john

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paint): (khtml::RenderBlock::floatRect): (khtml::RenderBlock::nodeAtPoint):
1:02 PM Changeset in webkit [11064] by harrison
  • 2 edits
    1 add in trunk/WebCore

Reviewed by John Sullivan.

Test case added:

  • manual-tests/whitespace-pre-affinity.html

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3739

This patch addresses the root cause of the problem by making
RenderText::inlineBox() cope with the fact that in white-space:pre text the
newline characters are not part of any InlineTextBox... they lie "between"
them. Now DOWNSTREAM affinity selects the next text box only if the offset
that is past the current box is actually _in_ the next box.

  • khtml/rendering/render_text.cpp: (RenderText::inlineBox):
12:40 PM Changeset in webkit [11063] by darin
  • 1 edit
    7 deletes in trunk/WebCore
  • removed unused duplicate copy of hash table code
  • khtml/misc/hashfunctions.h: Removed.
  • khtml/misc/hashmap.h: Removed.
  • khtml/misc/hashset.h: Removed.
  • khtml/misc/hashtable.cpp: Removed.
  • khtml/misc/hashtable.h: Removed.
  • khtml/misc/hashtraits.h: Removed.
  • khtml/misc/pointerhash.h: Removed.
12:12 PM Changeset in webkit [11062]
  • 22 copies
    3 deletes in tags/WebKit-312~5~2

This commit was manufactured by cvs2svn to create tag
'WebKit-312~5~2'.

12:12 PM Changeset in webkit [11061]
  • 70 copies
    3 deletes in tags/WebCore-315~10~1

This commit was manufactured by cvs2svn to create tag
'WebCore-315~10~1'.

12:12 PM Changeset in webkit [11060] by thatcher
  • 4 edits in branches/Safari-1-3-branch

Versioning to WebKit-312.5.2 and WebCore-315.10.1

12:04 PM Changeset in webkit [11059]
  • 53 copies
    22 deletes in tags/WebKit-416~12

This commit was manufactured by cvs2svn to create tag
'WebKit-416~12'.

12:04 PM Changeset in webkit [11058]
  • 210 copies
    15 deletes in tags/WebCore-416~14

This commit was manufactured by cvs2svn to create tag
'WebCore-416~14'.

12:04 PM Changeset in webkit [11057] by thatcher
  • 4 edits in branches/Ti-2005-009-branch

Versioning to WebCore-416.14 and WebKit-416.12

9:45 AM Changeset in webkit [11056]
  • 10 copies
    7 deletes in tags/Safari-521

This commit was manufactured by cvs2svn to create tag 'Safari-521'.

9:45 AM Changeset in webkit [11055] by thatcher
  • 1 edit in branches/Safari-Leo-branch/JavaScriptCore/Info.plist

Versioning to 521.1

9:30 AM Changeset in webkit [11054] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Tim Hatcher.

  • kxmlcore/HashSet.h: Fixed case of "hashfunctions.h" -- needs to be "HashFunctions.h".
9:02 AM Changeset in webkit [12211] by thatcher
  • 2 edits in trunk/JavaScriptGlue

Reviewed by Darin.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Fixed the FRAMEWORK_SEARCH_PATHS to look in the WebKit Frameworks for the Default config.
12:07 AM Changeset in webkit [11053] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-10-07 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick.

WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

  • WebView.subproj/WebUIDelegatePrivate.h: New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was running in. Eventually we'll deprecate the old three methods in favor of these in the public API.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Call version of the delegate method that has the frame parameter if the delegate supports it. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): ditto (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): ditto
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. Doesn't actually use the frame parameter here yet though.
Note: See TracTimeline for information about the timeline view.