⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 13, 2005:

11:43 PM Changeset in webkit [11181] by mjs
  • 2 edits in trunk/WebCore
  • fix Deployment build
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
10:46 PM Changeset in webkit [11180] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4341389> crash in elementAtPoint code quitting Safari, and make this code slightly more readable
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): add a nil check
7:49 PM Changeset in webkit [11179] by vicki
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text
3:56 PM Changeset in webkit [11178] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Add test to make sure that importNode preserves element prefixes.

  • fast/dom/importNode-prefix-expected.txt: Added.
  • fast/dom/importNode-prefix.html: Added.
3:52 PM Changeset in webkit [11177] by andersca
  • 2 edits in trunk/WebCore

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Use tagName() instead of localName() so the prefix will be preserved.
12:42 PM Changeset in webkit [11176] by bdakin
  • 1 edit
    1 add in trunk/LayoutTests

Bug #:
Submitted by:
Reviewed by:

11:45 AM Changeset in webkit [11175] by andersca
  • 12 edits
    2 adds in trunk/LayoutTests

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Update tests for change to createDocument which now creates a document element.

  • dom/xhtml/level3/core/documentadoptnode14-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode26-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode27-expected.txt:
  • dom/xhtml/level3/core/infoset07-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace05-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri05-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix05-expected.txt:
  • dom/xhtml/level3/core/wellformed03-expected.txt:
  • dom/xhtml/level3/core/wellformed04-expected.txt: These tests still fail, but elsewhere now.
  • dom/xhtml/level3/core/nodereplacechild14-expected.txt:
  • dom/xhtml/level3/core/nodesettextcontent02-expected.txt: These tests now succeed.
  • fast/dom/createDocument.html: Added.
  • fast/dom/createDocument-expected.txt: Added.
11:44 AM Changeset in webkit [11174] by andersca
  • 2 edits in trunk/WebCore

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::createDocument): Make sure to create a document element.
11:26 AM Changeset in webkit [11173] by andersca
  • 1 add in trunk/LayoutTests/fast/dom/setAttributeNS-expected.txt

Forgot this.

10:53 AM Changeset in webkit [11172] by andersca
  • 1 edit
    1 add in trunk/LayoutTests

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Add test for setAttributeNS with null namespaceURI.

  • fast/dom/setAttributeNS.html: Added.
10:52 AM Changeset in webkit [11171] by andersca
  • 6 edits in trunk/WebCore

2005-11-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/kjs_binding.cpp: (KJS::valueToStringWithNullCheck):
  • khtml/ecma/kjs_binding.h: Add function which converts a JavaScript value to a DOMString, converting the null value to a null DOMString.
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::putValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): Use valueToStringWithNullCheck in setAttributeNS and the textContent setter.
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::insertedIntoDocument): Don't try to evaluate scripts for viewless documents.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isEqualNode): Get the attribute map from the correct element.

Nov 12, 2005:

7:22 PM Changeset in webkit [11170] by thatcher
  • 6 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from Ti-2005-009-branch to Safari-2-0-branch

2005-10-06 Beth Dakin <Beth Dakin>

Reviewed by Vicki.

Fix for <rdar://problem/4145535> Crash in khtml::RenderBlock::addOverhangingFloats
with simple HTML test file.

  • khtml/rendering/render_block.cpp: Added nil check (khtml::RenderBlock::addOverhangingFloats):

WebKit:

Merged fix from Ti-2005-009-branch to Safari-2-0-branch

2005-10-07 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick.

WebKit support for allowing clients to know which frame originated a particular JavaScript alert/dialog.

  • WebView.subproj/WebUIDelegatePrivate.h: New optional delegate methods for the three JavaScript alert/dialogs. These are just like the existing ones in WebUIDelegate.h except that each adds a parameter specifying the frame that the JavaScript was running in. Eventually we'll deprecate the old three methods in favor of these in the public API.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge runJavaScriptAlertPanelWithMessage:]): Call version of the delegate method that has the frame parameter if the delegate supports it. (-[WebBridge runJavaScriptConfirmPanelWithMessage:]): ditto (-[WebBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): ditto
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. (Still doesn't do anything though.) (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]): Now implements the new version of the delegate method that includes the frame parameter. Doesn't actually use the frame parameter here yet though.
5:17 PM Changeset in webkit [11169] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-09-16 John Sullivan <​sullivan@apple.com>

Reviewed by Tim Omernick

  • fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at com.apple.AppKit: -[NSPasteboard setData:forType:] + 188
  • WebView.subproj/WebImageView.m: (-[WebImageView copy:]): declare types to pasteboard before starting to set their data (-[WebImageView writeSelectionToPasteboard:types:]): ditto
5:10 PM Changeset in webkit [11168] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-29 Geoffrey Garen <​ggaren@apple.com>

Fixed:
<rdar://problem/3461547> can't use document.writeln() on windows opened via window.open("about:blank") in same function
<rdar://problem/3725977> A_WINDOW.document.write() content overwritten when first parameter to window.open is provided
<rdar://problem/4101498> SAP: window.write in same call chain as window.open fails to write if URL parameter is provided
<rdar://problem/4179028> document.write in same function as window.open fails to write new content (4056)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4056 document.write in same function as window.open fails to write new content

Reviewed by darin.

Test cases added:

  • manual-tests/resources/write-after-open-popup.html: Added.
  • khtml/khtml_part.cpp: (KHTMLPart::didExplicitOpen): now cancels any pending redirection
5:03 PM Changeset in webkit [11167] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch
Vicki thinks this fixes <rdar://problem/3562729> location.replace with dynamically written frameset doesn't change view (3621)

2005-08-01 Geoffrey Garen <​ggaren@apple.com>

Fixed <rdar://problem/3572585> window.open fails if name param = the name of a window just closed in same function

Reviewed by darin.

Test cases added:

  • manual-tests/open-after-close.html: Added.
  • manual-tests/resources/open-after-close-popup.html: Added.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): We now remove a WebView from WebViewSets when the WebView is *scheduled* to close.
4:20 PM Changeset in webkit [11166] by thatcher
  • 9 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-09-19 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Test cases added: fast/table/overflowHidden.html

Fixed <rdar://problem/3885711> (4047) CSS: Content displays incorrectly in tables with TD style set overflow:hidden
Table cells render correctly with overflow:hidden, :auto, and :scroll specified. Cells now have a layer when overflow is specified.

  • khtml/css/cssstyleselector.cpp: Make sure table cells do not honor position:relative (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/rendering/render_block.cpp: Add borderTopExtra() and borderBottomExtra() to various calculations of table cell height so that scroll bars render properly. (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
  • khtml/rendering/render_box.cpp: Allow table cells to have overflow, and add borderTopExtra() and borderBottomExtra() to calculation of the clip rect. (RenderBox::setStyle): (RenderBox::getOverflowClipRect):
  • khtml/rendering/render_box.h: Removed definitions of borderTopExtra() and borderBottomExtra() so that they occur at the RenderObject level now.
  • khtml/rendering/render_layer.cpp: Layers must also take borderTopExtra() and borderBottomExtra() into account. (khtml::RenderLayer::updateLayerPosition): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTestLayer):
  • khtml/rendering/render_object.cpp: Use m_overflowClip instead of hasOverflowClip() for consistency. (RenderObject::requiresLayer):
  • khtml/rendering/render_object.h: Add definitions of borderTopExtra() and borderBottomExtra() to RenderObject level. (khtml::RenderObject::borderTopExtra): (khtml::RenderObject::borderBottomExtra):
  • khtml/rendering/render_table.cpp: Allow table cells to have a layer if overflow is specified. (RenderTableSection::paint): (RenderTableCell::requiresLayer): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations):
  • layout-tests/fast/table/029-expected.txt: This layout test now paints a layer because it specifies overflow:hidden
  • layout-tests/fast/table/overflowHidden-expected.txt: Added.
  • layout-tests/fast/table/overflowHidden.html: Added.
4:18 PM Changeset in webkit [11165] by thatcher
  • 9 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-09-19 Beth Dakin <Beth Dakin>

Reviewed by Hyatt

Test cases added: fast/table/overflowHidden.html

Fixed <rdar://problem/3885711> (4047) CSS: Content displays incorrectly in tables with TD style set overflow:hidden
Table cells render correctly with overflow:hidden, :auto, and :scroll specified. Cells now have a layer when overflow is specified.

  • khtml/css/cssstyleselector.cpp: Make sure table cells do not honor position:relative (khtml::CSSStyleSelector::adjustRenderStyle):
  • khtml/rendering/render_block.cpp: Add borderTopExtra() and borderBottomExtra() to various calculations of table cell height so that scroll bars render properly. (khtml::RenderBlock::isPointInScrollbar): (khtml::RenderBlock::nodeAtPoint):
  • khtml/rendering/render_box.cpp: Allow table cells to have overflow, and add borderTopExtra() and borderBottomExtra() to calculation of the clip rect. (RenderBox::setStyle): (RenderBox::getOverflowClipRect):
  • khtml/rendering/render_box.h: Removed definitions of borderTopExtra() and borderBottomExtra() so that they occur at the RenderObject level now.
  • khtml/rendering/render_layer.cpp: Layers must also take borderTopExtra() and borderBottomExtra() into account. (khtml::RenderLayer::updateLayerPosition): (khtml::RenderLayer::paintLayer): (khtml::RenderLayer::hitTestLayer):
  • khtml/rendering/render_object.cpp: Use m_overflowClip instead of hasOverflowClip() for consistency. (RenderObject::requiresLayer):
  • khtml/rendering/render_object.h: Add definitions of borderTopExtra() and borderBottomExtra() to RenderObject level. (khtml::RenderObject::borderTopExtra): (khtml::RenderObject::borderBottomExtra):
  • khtml/rendering/render_table.cpp: Allow table cells to have a layer if overflow is specified. (RenderTableSection::paint): (RenderTableCell::requiresLayer): (RenderTableCell::paint): (RenderTableCell::paintBoxDecorations):
  • layout-tests/fast/table/029-expected.txt: This layout test now paints a layer because it specifies overflow:hidden
  • layout-tests/fast/table/overflowHidden-expected.txt: Added.
  • layout-tests/fast/table/overflowHidden.html: Added.
3:37 PM Changeset in webkit [11164] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-11 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Unfortunately both the Render and DOM trees will actually preform
the load on <embed> <object> and <iframe> tags depending on the
circumstances. The <iframe> code path was missing a recursion
check in the render tree. I fixed that. And improved the
recursion checking for all tags.
<rdar://problem/4187169> High CPU usage/hang occurs with Safari after loading cbsnews.com (also at cbs.com)

  • khtml/rendering/render_frames.cpp: (isURLAllowed): added, to prevent recursive loops (mapClassIdToServiceType): added, to simplify code (RenderPartObject::updateWidget): updated, to use above functions.
3:36 PM Changeset in webkit [11163] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-11 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Unfortunately both the Render and DOM trees will actually preform
the load on <embed> <object> and <iframe> tags depending on the
circumstances. The <iframe> code path was missing a recursion
check in the render tree. I fixed that. And improved the
recursion checking for all tags.
<rdar://problem/4187169> High CPU usage/hang occurs with Safari after loading cbsnews.com (also at cbs.com)

  • khtml/rendering/render_frames.cpp: (isURLAllowed): added, to prevent recursive loops (mapClassIdToServiceType): added, to simplify code (RenderPartObject::updateWidget): updated, to use above functions.
Note: See TracTimeline for information about the timeline view.