Context Navigation

← Previous Period
Next Period →

Timeline

Nov 15, 2005:

6:15 PM Changeset in webkit [11215]

2 copies
6 deletes in tags/JavaScriptCore-521~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-521~2'.

6:15 PM Changeset in webkit [11214] by thatcher

1 edit in branches/Safari-Leo-branch/JavaScriptCore/Info.plist

Versioning

5:45 PM Changeset in webkit [12214] by ggaren

2 edits in trunk/JavaScriptGlue

Reviewed by mjs.

Part of the fix for <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

Added locking in JSRunCreate, since JSRun::JSRun constructs an object.

JavaScriptGlue.cpp: (JSRunCreate):

5:45 PM Changeset in webkit [11213] by ggaren

6 edits in trunk/JavaScriptCore

Reviewed by mjs.

Fixed <rdar://problem/4342216> Installer crash in KJS::ValueImp::marked() when garbage collector runs inside call to ConstantValues::init()

I took responsibility for initializing and marking ConstantValues away
from InterpreterImp, since it's possible to reference such a value
before any interpreter has been created and after the last interpreter
has been destroyed.

InterpreterImp::lock now initializes ConstantValues. It's a good
place for the initialization because you have to call it before
creating any objects. Since ::lock can be called more than once,
I added a check in ConstantValues::init to ensure that it executes
only once.

Collector:collect is now responsible for marking ConstantValues.

We no longer clear the ConstantValues since we can't guarantee that no
one has a reference to them.

FIXME: This is hackery. The long-term plan is to make ConstantValues
use immediate values that require no initialization.

ChangeLog:
kjs/collector.cpp: (KJS::Collector::collect):
kjs/internal.cpp: (KJS::InterpreterImp::InterpreterImp): (KJS::InterpreterImp::lock): (KJS::InterpreterImp::clear): (KJS::InterpreterImp::mark):
kjs/internal.h:
kjs/value.cpp: (KJS::ConstantValues::initIfNeeded):
kjs/value.h:

5:39 PM Changeset in webkit [11212] by thatcher

2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-15 Vicki Murley <vicki@apple.com>

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

5:36 PM Changeset in webkit [11211] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-15 Vicki Murley <vicki@apple.com>

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

5:23 PM Changeset in webkit [11210] by thatcher

1 edit in branches/Safari-1-3-branch/WebCore/kwq/DOM.mm

Rolled out the rest of the ObjC DOM changes from Adele's patch.

5:20 PM Changeset in webkit [11209] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/kwq/DOM.mm

Rolled out the rest of the ObjC DOM changes from Adele's patch.

4:24 PM Changeset in webkit [11208] by thatcher

3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-13 Vicki Murley <vicki@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text

4:23 PM Changeset in webkit [11207] by thatcher

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-13 Vicki Murley <vicki@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when mousing over links in a frame (5509)

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): add a case to handle NSMouseMoved, to fix the problem with the hand cursor (KWQKHTMLPart::mouseMoved): return if we're already sending an event to the subview
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): if we're over a frame, return the element within the frame, to fix the problem with status bar text

4:12 PM Changeset in webkit [11206] by thatcher

1 edit in branches/Safari-2-0-branch/WebCore/kwq/DOMExtensions.h

Rolling out the header change from Adele's patch. We can't add to the public API in Glendale.

4:11 PM Changeset in webkit [11205] by thatcher

9 edits in branches/Safari-1-3-branch/WebCore

Applied fix for the Safari-1-3-branch

2005-11-14 Adele Peterson <adele@apple.com>

Reviewed by Maciej and Darin.

fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

fast/dom/focus-contenteditable.html
fast/dom/blur-contenteditable.html

khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
khtml/xml/dom_elementimpl.h: Added focus and blur functions
khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

2:53 PM Changeset in webkit [11204] by vicki

2 edits in trunk/WebCore

Reviewed by Tim O.

Improve this loop. We'd get an infinite loop in the old code if we came across a part with no renderer, such as a frame whose src is an image.

kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):

12:02 PM Changeset in webkit [11203] by adele

3 edits in trunk/WebCore

Reviewed by Darin.

fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present

kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.

12:00 PM Changeset in webkit [11202] by harrison

7 edits in trunk/LayoutTests

<rdar://problem/4337532> Paragraph concatenation fails

Fix these tests to check for same behavior as in TextEdit.
(updated png and checksums)

editing/deleting/delete-block-merge-contents-019-expected.checksum:
editing/deleting/delete-block-merge-contents-019-expected.png:
editing/deleting/delete-line-011-expected.checksum:
editing/deleting/delete-line-011-expected.png:
editing/deleting/delete-line-012-expected.checksum:
editing/deleting/delete-line-012-expected.png:

11:15 AM Changeset in webkit [11201] by justing

2 edits in trunk/WebCore

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5717>
REGRESSION: [WebCoreBridge _visiblePositionForPoint:(0,x)] crashes

Reviewed by justin

kwq/WebCoreBridge.mm: (-[WebCoreBridge _visiblePositionForPoint:]): Early return if node found by hitTest is null.

Nov 14, 2005:

11:31 PM Changeset in webkit [11200] by adele

10 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-14 Adele Peterson <adele@apple.com>

Reviewed by Maciej and Darin.

fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

fast/dom/focus-contenteditable.html
fast/dom/blur-contenteditable.html

khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
khtml/xml/dom_elementimpl.h: Added focus and blur functions
khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

9:09 PM Changeset in webkit [11199]

71 copies
5 deletes in tags/JavaScriptCore-417~6

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~6'.

9:09 PM Changeset in webkit [11198] by thatcher

3 edits in branches/Safari-2-0-branch/JavaScriptCore

JavaScriptCore.exp: removed type info sysmbols that we no longer export according to B&I.

7:26 PM Changeset in webkit [11197]

55 copies
22 deletes in tags/WebKit-417~4

This commit was manufactured by cvs2svn to create tag 'WebKit-417~4'.

7:26 PM Changeset in webkit [11196]

210 copies
17 deletes in tags/WebCore-417~5

This commit was manufactured by cvs2svn to create tag
'WebCore-417~5'.

7:26 PM Changeset in webkit [11195]

71 copies
5 deletes in tags/JavaScriptCore-417~5

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~5'.

7:26 PM Changeset in webkit [11194] by thatcher

6 edits in branches/Safari-2-0-branch

Versioning.

6:05 PM Changeset in webkit [11193] by adele

11 edits
8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Added layout tests for:
<rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
<rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

fast/dom/blur-contenteditable-expected.checksum: Added.
fast/dom/blur-contenteditable-expected.png: Added.
fast/dom/blur-contenteditable-expected.txt: Added.
fast/dom/blur-contenteditable.html: Added.
fast/dom/focus-contenteditable-expected.checksum: Added.
fast/dom/focus-contenteditable-expected.png: Added.
fast/dom/focus-contenteditable-expected.txt: Added.
fast/dom/focus-contenteditable.html: Added.

WebCore:

Reviewed by Maciej and Darin.

fix for <rdar://problem/4233938> calling focus on contentEditable block elements should scroll them into view
fix for <rdar://problem/3624946> No 'blur' method defined on editable non-form DOM objects

Added

fast/dom/focus-contenteditable.html
fast/dom/blur-contenteditable.html

khtml/ecma/kjs_dom.cpp: Added ElementFocus and ElementBlur to DOMElementProtoTable (KJS::DOMElementProtoFunc::callAsFunction): Added cases for ElementFocus and ElementBlur
khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Added ElementFocus and ElementBlur to enum
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Added case for onblur.
khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): If the element isFocusable, calls setFocusNode to give element focus. (ElementImpl::blur): If the element is focused, calls setFocusNode to take away focus.
khtml/xml/dom_elementimpl.h: Added focus and blur functions
khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): If we're trying to take focus away from a node, then we should clear the selection before we fire events. If we don't, then efforts to focus the cursor during the event can reset focus on the old node. (DocumentImpl::clearSelectionIfNeeded): Added function since we need to clear the selection at multiple points.
khtml/xml/dom_docimpl.h: Added clearSelectionIfNeeded.
kwq/DOMExtensions.h: Added Obj-C bindings for focus and blur.
kwq/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]):

5:12 PM Changeset in webkit [11192] by hyatt

1 edit in trunk/WebCore/khtml/rendering/render_box.cpp

Add copyright for box-sizing render code from Allan Jensen at KDE

3:04 PM Changeset in webkit [11191] by thatcher

4 edits in branches/Safari-1-3-branch/WebCore

Applied fix for the Safari-1-3-branch

2005-11-10 Adele Peterson <adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

fast/forms/radio_checked.html

khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup

3:03 PM Changeset in webkit [11190] by thatcher

4 edits in branches/Safari-2-0-branch/WebCore

Applied fix for the Safari-2-0-branch

2005-11-10 Adele Peterson <adele@apple.com>

Reviewed by Maciej.

Fixed <rdar://problem/4228997> selecting a new radio button does not automatically clear the previous selected (outside <form> element)

Moved the radio button checking code to the document, since we shouldn't need a form to keep track of grouped radio buttons.

Added

fast/forms/radio_checked.html

khtml/xml/dom_docimpl.h: Added m_selectedRadioButtons (now a two level hash table to account for forms and group names), radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup
khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): initialize m_selectedRadioButtons (DocumentImpl::~DocumentImpl): delete m_selectedRadioButtons, and any of the inner hashtables if necessary (DocumentImpl::radioButtonChecked): moved from HTMLFormElementImpl. (DocumentImpl::checkedRadioButtonForGroup): ditto. (DocumentImpl::removeRadioButtonGroup): ditto.
khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::HTMLFormElementImpl): removed initialization of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::~HTMLFormElementImpl): removed deletion of m_selectedRadioButtons. (DOM::HTMLFormElementImpl::removeFormElement): now calls document's radio button functions (DOM::HTMLInputElementImpl::isKeyboardFocusable): ditto. (DOM::HTMLInputElementImpl::setInputType): ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): ditto. (DOM::HTMLInputElementImpl::setChecked): ditto. (DOM::HTMLInputElementImpl::preDispatchEventHandler): ditto.
khtml/html/html_formimpl.h: removed m_selectedRadioButtons, radioButtonChecked, checkedRadioButtonForGroup, and removeRadioButtonGroup

2:09 PM Changeset in webkit [11189] by justing

31 edits
4 adds in trunk/LayoutTests

Reviewed by harrison

<rdar://problem/4180820> Erroneous spacing between lines introduced on paste

Added/update layout test results:

editing/pasteboard/block-wrappers-necessary-expected.checksum: Added.
editing/pasteboard/block-wrappers-necessary-expected.png: Added.
editing/pasteboard/block-wrappers-necessary-expected.txt: Added.
editing/pasteboard/block-wrappers-necessary.html: Added.
editing/style/create-block-for-style-001-expected.checksum:
editing/style/create-block-for-style-001-expected.png:
editing/style/create-block-for-style-001-expected.txt:
editing/style/create-block-for-style-002-expected.checksum:
editing/style/create-block-for-style-002-expected.png:
editing/style/create-block-for-style-002-expected.txt:
editing/style/create-block-for-style-003-expected.checksum:
editing/style/create-block-for-style-003-expected.png:
editing/style/create-block-for-style-003-expected.txt:
editing/style/create-block-for-style-004-expected.checksum:
editing/style/create-block-for-style-004-expected.png:
editing/style/create-block-for-style-004-expected.txt:
editing/style/create-block-for-style-007-expected.checksum:
editing/style/create-block-for-style-007-expected.png:
editing/style/create-block-for-style-007-expected.txt:
editing/style/create-block-for-style-009-expected.checksum:
editing/style/create-block-for-style-009-expected.png:
editing/style/create-block-for-style-009-expected.txt:
editing/style/create-block-for-style-010-expected.checksum:
editing/style/create-block-for-style-010-expected.png:
editing/style/create-block-for-style-010-expected.txt:
editing/style/create-block-for-style-011-expected.checksum:
editing/style/create-block-for-style-011-expected.png:
editing/style/create-block-for-style-011-expected.txt:
editing/style/create-block-for-style-012-expected.checksum:
editing/style/create-block-for-style-012-expected.png:
editing/style/create-block-for-style-012-expected.txt:
editing/style/create-block-for-style-013-expected.checksum:
editing/style/create-block-for-style-013-expected.png:
editing/style/create-block-for-style-013-expected.txt:

2:09 PM Changeset in webkit [11188] by justing

3 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4180820> Erroneous spacing between lines introduced on paste

Updated layout test results in editing/style
Added layout test in editing/pasteboard

khtml/css/css_valueimpl.cpp: Fixed a comment.
khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Don't use clones of paragraphs already in the document to hold paragraph contents, since they are likely to introduce unwanted styles, just use a generic paragraph element. It's less likely, but still possible that a generic paragraph element will have unwanted style, so we may want to eventually use class=Apple-style-block.

11:53 AM Changeset in webkit [11187] by harrison

5 edits in trunk/LayoutTests

<rdar://problem/4337532> Paragraph concatenation fails

Fix these tests to check for same behavior as in TextEdit.

editing/deleting/delete-block-merge-contents-019-expected.txt:
editing/deleting/delete-block-merge-contents-019.html:
editing/deleting/delete-line-011-expected.txt:
editing/deleting/delete-line-012-expected.txt:

11:53 AM Changeset in webkit [11186] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4337532> Paragraph concatenation fails

Updated editing/deleting tests to correctly check this behavior.

khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Remove erroneous check for isStartOfParagraph(visibleEnd) when deciding whether to clear m_mergeBlocksAfterDelete.

11:32 AM Changeset in webkit [11185] by thatcher