⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 17, 2005:

4:57 PM Changeset in webkit [11244]
  • 24 copies
    3 deletes in tags/WebKit-312~6

This commit was manufactured by cvs2svn to create tag 'WebKit-312~6'.

4:57 PM Changeset in webkit [11243]
  • 105 copies
    5 deletes in tags/WebCore-315~11

This commit was manufactured by cvs2svn to create tag
'WebCore-315~11'.

4:57 PM Changeset in webkit [11242]
  • 9 copies
    3 deletes in tags/JavaScriptCore-312~2

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~2'.

4:57 PM Changeset in webkit [11241] by thatcher
  • 3 edits in branches/Safari-1-3-branch

Versioning

4:49 PM Changeset in webkit [11240] by thatcher
  • 3 edits in branches/Safari-1-3-branch

Versioning

3:40 PM Changeset in webkit [11239] by bdakin
  • 3 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

3:17 PM Changeset in webkit [11238] by adele
  • 2 edits in trunk/WebCore

Reviewed by Beth.

  • fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.
2:44 PM Changeset in webkit [11237] by adele
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Fix by Darin, reviewed by me.

fix for <rdar://problem/3885811> Some values used with setAttribute() cause the attribute to be removed (null strings vs. empty strings) (4059)

Changed the constructors to return the emtpy string if the string is null.

  • kjs/value.cpp: (Value::Value): (String::String):
2:36 PM Changeset in webkit [11236] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-17 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/3871165> text box in nested table
disappears when you click on it (3452) (Safari PSOFT: US
EDU PS8: Lead List searches)

Table cells that are in an overlap of a rowspan and a colspan
were not always being repainted correctly. This is because our
previous implementation had no way for a cell to keep track of
both its rowspan and its colspan. This patch maintains the old
way of dealing with rowspan and introduces CellStruct for dealing
with colspan. CellStruct is a structure that contains a
RenderTableCell and a boolean value that is true if the cell is in
a colspan.

  • khtml/rendering/render_table.cpp: (RenderTable::splitColumn): The section grid now returns a CellStruct. (RenderTable::appendColumn): Same as above, and cellAt() also returns

a CellStruct and needs to be set appropriately.

(RenderTable::cellAbove): cellAt() now returns a CellStruct.
(RenderTable::cellBelow): Same.
(RenderTable::cellLeft): Same.
(RenderTable::cellRight): Same.
(RenderTableSection::ensureRows): Create empty CellStruct to fill the

grid.

(RenderTableSection::addCell): cellAt() now returns a CellStruct. This

is also where the change in behavior is to fix
the bug.

(RenderTableSection::setCellWidths): cellAt() now returns a CellStruct.
(RenderTableSection::calcRowHeight): Same.
(RenderTableSection::layoutRows): Same.
(RenderTableSection::paint): Same.
(RenderTableSection::dump): Same.

  • khtml/rendering/render_table.h: (khtml::RenderTableSection::cellAt): Same.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn): Same. (AutoTableLayout::calcEffectiveWidth): Removed reference to

(RenderTableCell *)-1 because that is now
removed, and a cell will never be in a colspan
in this function anyway.

(AutoTableLayout::insertSpanCell): Same.

2:29 PM Changeset in webkit [11235] by hyatt
  • 4 edits in trunk/WebCore

Add support for getting a style property off of a DOMAttr. This is an API that allows
access to the style declaration for HTML presentational attributes like width and height. This API exists only
in Objective-C, since JS would have to make the declaration readonly before it could be safely
returned.

Reviewed by darin

  • khtml/xml/dom_elementimpl.h: (DOM::AttributeImpl::style): (DOM::AttrImpl::style): (DOM::MappedAttributeImpl::style):
  • kwq/DOM.mm: (-[DOMAttr style]):
  • kwq/DOMPrivate.h:
2:24 PM Changeset in webkit [11234] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-17 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/3871165> text box in nested table
disappears when you click on it (3452) (Safari PSOFT: US
EDU PS8: Lead List searches)

Table cells that are in an overlap of a rowspan and a colspan
were not always being repainted correctly. This is because our
previous implementation had no way for a cell to keep track of
both its rowspan and its colspan. This patch maintains the old
way of dealing with rowspan and introduces CellStruct for dealing
with colspan. CellStruct is a structure that contains a
RenderTableCell and a boolean value that is true if the cell is in
a colspan.

  • khtml/rendering/render_table.cpp: (RenderTable::splitColumn): The section grid now returns a CellStruct. (RenderTable::appendColumn): Same as above, and cellAt() also returns

a CellStruct and needs to be set appropriately.

(RenderTable::cellAbove): cellAt() now returns a CellStruct.
(RenderTable::cellBelow): Same.
(RenderTable::cellLeft): Same.
(RenderTable::cellRight): Same.
(RenderTableSection::ensureRows): Create empty CellStruct to fill the

grid.

(RenderTableSection::addCell): cellAt() now returns a CellStruct. This

is also where the change in behavior is to fix
the bug.

(RenderTableSection::setCellWidths): cellAt() now returns a CellStruct.
(RenderTableSection::calcRowHeight): Same.
(RenderTableSection::layoutRows): Same.
(RenderTableSection::paint): Same.
(RenderTableSection::dump): Same.

  • khtml/rendering/render_table.h: (khtml::RenderTableSection::cellAt): Same.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::recalcColumn): Same. (AutoTableLayout::calcEffectiveWidth): Removed reference to

(RenderTableCell *)-1 because that is now
removed, and a cell will never be in a colspan
in this function anyway.

(AutoTableLayout::insertSpanCell): Same.

1:28 PM Changeset in webkit [11233] by hyatt
  • 11 edits in trunk/WebCore

Add support for getMatchedCSSRules, an API that can be used to
inspect the set of rules that match on an element. From Obj-C
you see all rules (user agent, author, user). From JS you just
see author rules.

Reviewed by darin

  • khtml/css/cssparser.cpp:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleRulesForElement): (khtml::CSSStyleSelector::pseudoStyleRulesForElement):
  • khtml/css/cssstyleselector.h:
  • khtml/css/parser.y:
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::):
  • khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle): (DOM::AbstractViewImpl::getMatchedCSSRules):
  • khtml/xml/dom2_viewsimpl.h:
  • kwq/DOM-CSS.mm: (-[DOMDocument getMatchedCSSRules::]):
  • kwq/DOMCSS.h:
10:45 AM Changeset in webkit [11232] by bdakin
  • 5 edits
    4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

10:32 AM Changeset in webkit [11231] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-15 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

  • fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
  • kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.
10:29 AM Changeset in webkit [11230] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-15 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

  • fix for <rdar://problem/4341948> REGRESSION(TOT/GLENDALE): Safari won't tab between input/textarea elements if a select element is present
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton canBecomeKeyView]): removed check for tabsToAllControls() since we now always allow tabbing to select elements
  • kwq/KWQListBox.mm: (-[KWQTableView canBecomeKeyView]): ditto.

Nov 16, 2005:

7:37 PM Changeset in webkit [11229] by justing
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Fixed the line endings in my previous ChangeLog entry.

6:10 PM Changeset in webkit [11228]
  • 212 copies
    17 deletes in tags/WebCore-417~6

This commit was manufactured by cvs2svn to create tag
'WebCore-417~6'.

6:10 PM Changeset in webkit [11227] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/Info.plist

Version to WebCore-417.6

6:01 PM Changeset in webkit [11226] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

More workarounds for <rdar://problem/4213314> WebCore build fails with gcc-5216 or later

5:17 PM Changeset in webkit [11225] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-16 Adele Peterson <​adele@apple.com>

Reviewed by Dave Harrson.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.
5:05 PM Changeset in webkit [11224] by justing
  • 293 edits in trunk/LayoutTests

Reviewed by harrison

Updated editing tests to reflect changes for:

<rdar://problem/4108909> Editing delegate gets extra webViewDidChangeSelection: notifications

5:04 PM Changeset in webkit [11223] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin


<rdar://problem/4108909> Editing delegate gets extra webViewDidChangeSelection: notifications


Editing operations used to set an empty selection on the part before
doing work. Doing this 1) isn't necessary* 2) creates an extra didChangeSelection
notification (4108909) 3) produces a strange shouldChangeSelection call after the
editing operation is complete, i.e. "shouldChangeSelection from null to ...?"


There are still strange shouldChangeSelection calls after this change. For example,
after a delete, the selection before the delete no longer exists, so it probably
doesn't make sense to ask the delegate if WebKit shouldChangeSelection. This is filed
as 4343068.


  • This was added on 2004-09-28 in order to mark misspellings in the selection to be operated on (marking misspellings is a side effect of setting a selection). Misspellings in the old selection are still marked, but not until after the operation is complete. Since some editing operations remove the selection from the document (i.e. delete or undo-typing), respondToChangedSelection no longer assumes that the old selection is in the document.


Updated layout tests to reflect this change.


  • khtml/editing/edit_command.cpp: (khtml::EditCommand::EditCommand): Don't set the part's selection to empty before editing. (khtml::EditCommand::apply): Ditto. (khtml::EditCommand::unapply): Ditto. (khtml::EditCommand::reapply): Ditto.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::respondToChangedSelection): Don't assume that the old selection is still in the document.
4:39 PM Changeset in webkit [11222] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/khtml/xsl/xslt_processorimpl.cpp

Merge fix, was missing one line.

4:32 PM Changeset in webkit [11221] by adele
  • 3 edits in trunk/WebCore

Reviewed by Dave Harrson.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.
4:30 PM Changeset in webkit [11220]
  • 72 copies
    5 deletes in tags/JavaScriptCore-417~7

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~7'.

4:30 PM Changeset in webkit [11219] by thatcher
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Versioning to JavaScriptCore-417.7

2:07 PM Changeset in webkit [11218] by thatcher
  • 3 edits
    1 add in branches/Safari-2-0-branch/JavaScriptCore

Fixes build failures on Glendale and Chardonnay.
We now use an export file for whatever compiler is selected (since the exported symbols differ.)

  • JavaScriptCore.xcodeproj: use GCC_VERSION_IDENTIFIER to pick the proper export file
  • JavaScriptCore.exp: added the 4 type infos that GCC 4 adds.
  • JavaScriptCore-3.3.exp: the GCC 3.3 export file that excluded GCC 4 symbols
1:45 AM Changeset in webkit [11217] by andersca
  • 45 edits in trunk/LayoutTests

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Updated tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5737>
Implement DOM3 namespace functions.

  • dom/xhtml/level3/core/nodeisdefaultnamespace01-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace02-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace03-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace05-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace06-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace07-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace08-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace09-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace10-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace11-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace13-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace14-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace15-expected.txt:
  • dom/xhtml/level3/core/nodeisdefaultnamespace16-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri02-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri03-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri05-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri06-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri07-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri08-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri09-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri10-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri11-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri13-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri14-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri15-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri16-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri18-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri19-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix01-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix02-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix03-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix05-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix06-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix07-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix08-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix09-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix10-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix11-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix13-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix14-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix15-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix16-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix18-expected.txt: These tests pass now.
1:43 AM Changeset in webkit [11216] by andersca
  • 6 edits in trunk/WebCore

2005-11-14 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::): Add JavaScript wrappers for new Node namespace functions.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::isDefaultNamespace): (DOM::NodeImpl::lookupPrefix): (DOM::NodeImpl::lookupNamespaceURI): (DOM::NodeImpl::lookupNamespacePrefix): (DOM::NodeImpl::getAncestorElement): Implement Node namespace functions.
  • khtml/xml/dom_nodeimpl.h: Add definitions for Node namespace functions.
  • kwq/DOM.mm: (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): Add objective C wrappers for new Node namespace functions.
Note: See TracTimeline for information about the timeline view.