⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 18, 2005:

7:51 PM Changeset in webkit [11269]
  • 55 copies
    22 deletes in tags/WebKit-417~5

This commit was manufactured by cvs2svn to create tag 'WebKit-417~5'.

7:51 PM Changeset in webkit [11268]
  • 210 copies
    17 deletes in tags/WebCore-417~7

This commit was manufactured by cvs2svn to create tag
'WebCore-417~7'.

7:51 PM Changeset in webkit [11267]
  • 72 copies
    5 deletes in tags/JavaScriptCore-417~8

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-417~8'.

7:51 PM Changeset in webkit [11266] by thatcher
  • 6 edits in branches/Safari-2-0-branch

Versioning

6:47 PM Changeset in webkit [11265] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-18 David Harrison <​harrison@apple.com>

Reviewed by Tim Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

Tests added: None, becaause it keeps some existing ones from crashing.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.
6:46 PM Changeset in webkit [11264] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 David Harrison <​harrison@apple.com>

Reviewed by Tim Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

Tests added: None, becaause it keeps some existing ones from crashing.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.
6:36 PM Changeset in webkit [11263] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

Tests added: None, becaause it keeps some existing ones from crashing.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): Call enableEventDispatch() sooner, when basic dom mods are done.
6:36 PM Changeset in webkit [11262] by thatcher
  • 19 edits in branches/Safari-2-0-branch

WebCore:

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Vicki Murley <​vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

  • fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute):
  • khtml/html/htmlnames.h:
  • khtml/xml/EventNames.h:
  • khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::storesResultAsString): (DOM::EventImpl::storeResult): (DOM::BeforeUnloadEventImpl::BeforeUnloadEventImpl): (DOM::BeforeUnloadEventImpl::storesResultAsString): (DOM::BeforeUnloadEventImpl::storeResult):
  • khtml/xml/dom2_eventsimpl.h: (DOM::BeforeUnloadEventImpl::result):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge shouldClose]):

WebKit:

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Vicki Murley <​vicki@apple.com>

Changes by Darin, reviewed by Beth and Vicki.

  • fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canRunBeforeUnloadConfirmPanel]): (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
  • WebView.subproj/WebUIDelegatePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView shouldClose]):
  • WebView.subproj/WebViewPrivate.h:
6:08 PM Changeset in webkit [11261] by vicki
  • 2 edits in trunk/WebKit

Changes by Tim H, reviewed by Vicki.

  • call shouldClose on the bridge for the main frame
  • WebView.subproj/WebView.m: (-[WebView shouldClose]):
5:27 PM Changeset in webkit [11260] by vicki
  • 6 edits in trunk/WebKit

Changes by Darin, reviewed by Beth and Vicki.

  • fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canRunBeforeUnloadConfirmPanel]): (-[WebBridge runBeforeUnloadConfirmPanelWithMessage:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
  • WebView.subproj/WebUIDelegatePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView shouldClose]):
  • WebView.subproj/WebViewPrivate.h:
5:26 PM Changeset in webkit [11259] by vicki
  • 13 edits in trunk/WebCore

Changes by Darin, reviewed by Beth and Vicki.

  • fix <rdar://problem/3939265> support "before unload" event and onbeforeunload handler (supported by both IE and Mozilla)
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put):
  • khtml/ecma/kjs_window.h: (KJS::Window::):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): (HTMLFrameElementImpl::parseMappedAttribute): (HTMLFrameSetElementImpl::parseMappedAttribute):
  • khtml/html/htmlnames.h:
  • khtml/xml/EventNames.h:
  • khtml/xml/dom2_eventsimpl.cpp: (DOM::EventImpl::storesResultAsString): (DOM::EventImpl::storeResult): (DOM::BeforeUnloadEventImpl::BeforeUnloadEventImpl): (DOM::BeforeUnloadEventImpl::storesResultAsString): (DOM::BeforeUnloadEventImpl::storeResult):
  • khtml/xml/dom2_eventsimpl.h: (DOM::BeforeUnloadEventImpl::result):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge shouldClose]):
4:19 PM Changeset in webkit [11258] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-16 Adele Peterson <​adele@apple.com>

Reviewed by Dave Harrson.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::getRectToExpose): If the rect is larger than the visible rect, and we're trying to align to the closest edge, align to the left edge.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect): If width or height is negative, we were setting both to zero. Now we only set the negative value to zero without affecting the other value.
4:12 PM Changeset in webkit [11257] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-18 Beth Dakin <Beth Dakin>

Reviewed by Darin.

This is an additional fix for <rdar://problem/3871165> text box
in nested table disappears when you click on it (3452) (Safari
PSOFT: US EDU PS8: Lead List searches). The test case I used
previously did not cover the case where one cell has both a
rowspan and a colspan and other cells later have rowspan and
colspan from two different cells overlapping.

One manual test case added.

  • khtml/rendering/render_table.cpp: Remove check for inColSpan (RenderTableSection::addCell):
4:11 PM Changeset in webkit [11256] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 Beth Dakin <Beth Dakin>

Reviewed by Darin.

This is an additional fix for <rdar://problem/3871165> text box
in nested table disappears when you click on it (3452) (Safari
PSOFT: US EDU PS8: Lead List searches). The test case I used
previously did not cover the case where one cell has both a
rowspan and a colspan and other cells later have rowspan and
colspan from two different cells overlapping.

One manual test case added.

  • khtml/rendering/render_table.cpp: Remove check for inColSpan (RenderTableSection::addCell):
3:42 PM Changeset in webkit [11255] by bdakin
  • 2 edits
    1 add in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

3:39 PM Changeset in webkit [11254] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-18 David Harrison <​harrison@apple.com>

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):
3:38 PM Changeset in webkit [11253] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-18 David Harrison <​harrison@apple.com>

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):
2:46 PM Changeset in webkit [11252] by thatcher
  • 17 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-29 David Hyatt <​hyatt@apple.com>

(1) Fixes khtml-user-select: none to have the following additional behavior (that matches Firefox's implementation of the property as well)
(a) If you mouse down (or click, double click, triple click) inside a "none" region, the selection should not be cleared or changed
(b) If you drag from within a "none" region out to a selectable region, so what, no selection should be changed or started.

(2) Adds a new value to khtml-user-select called "element" that is used for any object that should have the behavior of (a) and (b) above (but that is selectable aside from that). This includes images, links, buttons, and so on. html4.css is patched to add support for these objects.

This feature fixes the big contenteditable issue and selection is no longer cleared now when you click on these controls (or on links). This behavior matches other browsers.

(3) :active and :hover have been substantially reworked.

(a) If you mouse down on a selectable region, then the behavior is unchanged. :hover/:active is completely frozen, and they aren't updated at all.
(b) If you mouse down on a non-selectable region and start moving, then the behavior has changed. Instead of not updating at all, we mark the chain at the time the mouse goes down, and we restrict :hover/:active updates to only apply to elements that are in that chain. This yields perfect hover/active control behavior, even when :active has been applied hierarchically.
(c) :hover has moved onto the node and is no longer on the renderobject (allowing them to be consistent).

Reviewed by john

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/html4.css:
  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
  • khtml/khtml_part.h: (KHTMLPart::mouseDownMayStartSelect):
  • khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):
  • khtml/rendering/render_layer.cpp: (RenderLayer::hitTest): (RenderLayer::updateHoverActiveState):
  • khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isRunIn): (khtml::RenderObject::setInline): (khtml::RenderObject::NodeInfo::NodeInfo): (khtml::RenderObject::NodeInfo::mouseMove):
  • khtml/rendering/render_style.h: (khtml::):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setActiveNode):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::activeNode):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::setHovered):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inActiveChain): (DOM::NodeImpl::hovered): (DOM::NodeImpl::setInActiveChain): (DOM::NodeImpl::setHovered):
  • kwq/KWQKHTMLPart.h: (KWQKHTMLPart::mouseDownMayStartSelect):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canMouseDownStartSelect): (KWQKHTMLPart::khtmlMousePressEvent):
2:41 PM Changeset in webkit [11251] by thatcher
  • 17 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-29 David Hyatt <​hyatt@apple.com>

(1) Fixes khtml-user-select: none to have the following additional behavior (that matches Firefox's implementation of the property as well)
(a) If you mouse down (or click, double click, triple click) inside a "none" region, the selection should not be cleared or changed
(b) If you drag from within a "none" region out to a selectable region, so what, no selection should be changed or started.

(2) Adds a new value to khtml-user-select called "element" that is used for any object that should have the behavior of (a) and (b) above (but that is selectable aside from that). This includes images, links, buttons, and so on. html4.css is patched to add support for these objects.

This feature fixes the big contenteditable issue and selection is no longer cleared now when you click on these controls (or on links). This behavior matches other browsers.

(3) :active and :hover have been substantially reworked.

(a) If you mouse down on a selectable region, then the behavior is unchanged. :hover/:active is completely frozen, and they aren't updated at all.
(b) If you mouse down on a non-selectable region and start moving, then the behavior has changed. Instead of not updating at all, we mark the chain at the time the mouse goes down, and we restrict :hover/:active updates to only apply to elements that are in that chain. This yields perfect hover/active control behavior, even when :active has been applied hierarchically.
(c) :hover has moved onto the node and is no longer on the renderobject (allowing them to be consistent).

Reviewed by john

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::canShareStyleWithElement): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/html4.css:
  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
  • khtml/khtml_part.h: (KHTMLPart::mouseDownMayStartSelect):
  • khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent):
  • khtml/rendering/render_layer.cpp: (RenderLayer::hitTest): (RenderLayer::updateHoverActiveState):
  • khtml/rendering/render_object.cpp: (RenderObject::RenderObject): (RenderObject::information):
  • khtml/rendering/render_object.h: (khtml::RenderObject::isRunIn): (khtml::RenderObject::setInline): (khtml::RenderObject::NodeInfo::NodeInfo): (khtml::RenderObject::NodeInfo::mouseMove):
  • khtml/rendering/render_style.h: (khtml::):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::prepareMouseEvent): (DocumentImpl::setActiveNode):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::activeNode):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::setHovered):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::inActiveChain): (DOM::NodeImpl::hovered): (DOM::NodeImpl::setInActiveChain): (DOM::NodeImpl::setHovered):
  • kwq/KWQKHTMLPart.h: (KWQKHTMLPart::mouseDownMayStartSelect):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canMouseDownStartSelect): (KWQKHTMLPart::khtmlMousePressEvent):
1:35 PM Changeset in webkit [11250] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

Layout tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>

  • editing/deleting/move-nodes-001-expected.checksum: Added.
  • editing/deleting/move-nodes-001-expected.png: Added.
  • editing/deleting/move-nodes-001-expected.txt: Added.
  • editing/deleting/move-nodes-001.html: Added.
1:34 PM Changeset in webkit [11249] by harrison
  • 4 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5629>
REGRESSION: appendChild() does not remove nodes from source nodelist when inserting into destination

Enable event dispatch when calling removeChild() in loops. That it was
disabled previously was wrong because the DOM is not fragile at that point.
Makes the event dispatch forbiddance a debug-only check

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent): (DOM::NodeImpl::dispatchGenericEvent): (DOM::NodeImpl::dispatchHTMLEvent): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::dispatchSimulatedMouseEvent): (DOM::NodeImpl::dispatchUIEvent): (DOM::NodeImpl::dispatchSubtreeModifiedEvent): (DOM::NodeImpl::dispatchKeyEvent): (DOM::NodeImpl::dispatchWheelEvent): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::removeChild): (DOM::ContainerNodeImpl::removeChildren): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild): (DOM::ContainerNodeImpl::dispatchChildInsertedEvents):
10:27 AM Changeset in webkit [11248] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Reviewed by Dave Harrson.
Commited by Tim Hatcher.

  • khtml/rendering/render_layer.cpp: (khtml::ContainerNodeImpl::appendChild): Dispatch old parent's subtree modified event from appendChild()
10:26 AM Changeset in webkit [11247] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Dave Harrson.
Commited by Tim Hatcher.

  • khtml/rendering/render_layer.cpp: (khtml::ContainerNodeImpl::appendChild): Dispatch old parent's subtree modified event from appendChild()
10:02 AM Changeset in webkit [11246] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-17 Adele Peterson <​adele@apple.com>

Reviewed by Beth.

  • fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.
10:01 AM Changeset in webkit [11245] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-17 Adele Peterson <​adele@apple.com>

Reviewed by Beth.

  • fix for <rdar://problem/4347856> Safari crash after browsing Fandango.

When removeFormElement is getting called in a destructor, there may not be a document.
So we don't need to worry about cleaning up the radio buttons in this case, not only to
avoid the crash, but also because the document's destructor will clean that up.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::removeFormElement): Added nil check for document.
Note: See TracTimeline for information about the timeline view.