⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 23, 2005:

7:14 AM Changeset in webkit [11287] by eseidel
  • 30 edits in trunk/WebCore

Bug #: 4780
Submitted by: eseidel
Reviewed by: mjs

No additional test cases needed, this fixes 15+ existing tests.

This latest set of changes fixes <image> loading (mostly)
(There still seems to be an image loading race condition.)
This also fixes viewBox support (for many tests)
Fixes a Safari crasher when using patterns
Fixes bbox() handling throughout code (for spec conformance)

  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::Private::Private): renamed drawContents (KCanvasContainer::drawsContents): renamed drawContents (KCanvasContainer::setDrawsContents): renamed drawContents (KCanvasContainer::relativeBBox): renamed bbox(), fixed
  • kcanvas/KCanvasContainer.h:
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasItem.cpp: (RenderPath::relativeBBox): renamed bbox()
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasPath.cpp: (operator<<): removed deprecated "viewportClip" support
  • kcanvas/KCanvasPath.h: (KCClipDataList::addPath): removed "viewportClip" support
  • kcanvas/KCanvasResources.cpp: (KCanvasClipper::KCanvasClipper): removed "viewportClip" support (KCanvasClipper::addClipData): removed "viewportClip" support (KCanvasClipper::externalRepresentation): removed "viewportClip"
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<): removed "viewportClip" support
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::prepareFilter): combined, simplified (KCanvasFilterQuartz::applyFilter): combined, simplified (KCanvasFilterQuartz::filterBBoxForItemBBox): simplified
  • kcanvas/device/quartz/KCanvasItemQuartz.h: (KCanvasItemQuartz::getAbsoluteRepaintRect): added
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): updated for bbox() changes (getSharedContext): simplified (KCanvasItemQuartz::bboxForPath): name change (KCanvasItemQuartz::hitsPath): fixed for absoluteTransform()
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasContainerQuartz::getAbsoluteRepaintRect): added
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::layout): call RenderContainer::layout() (KCanvasContainerQuartz::paint): drawsContents() && viewbox() (KCanvasContainerQuartz::absoluteTransform): added (KCanvasClipperQuartz::applyClip): simplified
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerImageQuartz::draw): added stretch/scale
  • khtml/rendering/render_object.cpp: added absoluteTransform() (RenderObject::absoluteTransform):
  • khtml/rendering/render_object.h: added absoluteTransform() (khtml::RenderObject::relativeBBox): rename (khtml::RenderObject::localTransform): better default behavior
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): simpler code
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::viewportElement): use isElementNode()
  • ksvg2/svg/SVGImageElementImpl.cpp: removed finalizeStyle() (SVGImageElementImpl::attach): (SVGImageElementImpl::notifyFinished):
  • ksvg2/svg/SVGImageElementImpl.h:
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value): bbox() rename
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getBBox): fixed bbox() behavior
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::createRenderer): drawsContents rename
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): fixed crash (SVGPatternElementImpl::createRenderer): drawsContents rename
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::x): simplified code (SVGSVGElementImpl::y): simplified code (SVGSVGElementImpl::width): simplified code (SVGSVGElementImpl::height): simplified code (SVGSVGElementImpl::parseMappedAttribute): add width/height to DOM
  • kwq/KWQWMatrix.mm: (QWMatrix::mapRect): simplified code
1:48 AM Changeset in webkit [11286] by andersca
  • 33 edits
    1 add
    1 delete in trunk/LayoutTests

2005-11-23 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Update tests for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5805>
Implement adoptNode.

  • dom/xhtml/level3/core/documentadoptnode01-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode02-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode03-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode04-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode05-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode06-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode07-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode08-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode09-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode10-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode11-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode12-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode13-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode14-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode15-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode16-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode21-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode23-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode24-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode25-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode26-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode27-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode28-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode30-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode31-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode32-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode33-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode34-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode35-expected.txt:
  • dom/xhtml/level3/core/documentadoptnode36-expected.txt: These tests pass now.
  • dom/xhtml/level3/core/documentadoptnode22.xhtml: Removed.
  • dom/xhtml/level3/core/documentadoptnode22.xhtml-disabled: Added. Disable this test for now. It removes the entire document tree which makes it hard to show the test result.
  • dom/xhtml/level3/core/documentrenamenode09-expected.txt: This now fails because renameNode is undefined.
  • dom/xhtml/level3/core/nodeisequalnode18-expected.txt: This now passes.
1:46 AM Changeset in webkit [11285] by andersca
  • 7 edits in trunk/WebCore

2005-11-23 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5805>
Implement adoptNode.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocumentProtoFunc::callAsFunction):
  • khtml/ecma/kjs_dom.h: (KJS::DOMDocument::): Add JS wrapper for adoptNode.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::adoptNode):
  • khtml/xml/dom_docimpl.h: Implement adoptNode.
  • kwq/DOM.mm: (-[DOMDocument adoptNode:]):
  • kwq/DOMPrivate.h: Add Objective C wrapper for adoptNode.

Nov 22, 2005:

9:41 PM Changeset in webkit [11284] by mjs
  • 15 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

<rdar://problem/4139620> Seed: WebKit: hang when sending XMLHttpRequest if automatic proxy config is used

Also factored locking code completely into a separate class, and
added a convenient packaged way to temporarily drop locks.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSLock.cpp: Added. (KJS::initializeInterpreterLock): (KJS::InterpreterLock::lock): (KJS::InterpreterLock::unlock): (KJS::InterpreterLock::lockCount): (KJS::InterpreterLock::DropAllLocks::DropAllLocks): (KJS::InterpreterLock::DropAllLocks::~DropAllLocks):
  • kjs/JSLock.h: Added. (KJS::InterpreterLock::InterpreterLock): (KJS::InterpreterLock::~InterpreterLock):
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/interpreter.cpp:
  • kjs/interpreter.h:
  • kjs/protect.h:
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction):

WebCore:

Reviewed by Geoff.

<rdar://problem/4139620> Seed: WebKit: hang when sending XMLHttpRequest if automatic proxy config is used

  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send):
  • kwq/WebCoreJavaScript.mm:
9:40 PM Changeset in webkit [12215] by mjs
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Geoff.

Updated to use new API to drop all locks.

  • JavaScriptGlue.cpp: (JSLockInterpreter): (JSUnlockInterpreter):
  • UserObjectImp.cpp: (UserObjectImp::callAsFunction):
3:04 PM Changeset in webkit [11283] by eseidel
  • 35 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: No review required, svg target only.

No additional test cases needed, this fixes 10+ existing tests.

Fixed filters by fixing how KCanvasDeviceContexts are pushed/poped
They now properly update the NSGrapicsContext currentContext, when
being pushed/poped which allows for QPainter to notice the change.
I also fixed <feImage> while there and updated all of the
subclassed filterEffect() methods to return to proper subclass.

  • kcanvas/KCanvasFilters.h:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::KCanvasFilterQuartz): (KCanvasFilterQuartz::~KCanvasFilterQuartz): (KCanvasFilterQuartz::prepareFilter): fixed to push context (KCanvasFilterQuartz::applyFilter): fixed to pop context (KCanvasFEImageQuartz::getCIFilter): fixed :)
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): fixed to push/pop context
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): fixed to push/pop context
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h: (KRenderingDeviceContextQuartz::cgContext):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz): (KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz): (KRenderingDeviceContextQuartz::nsGraphicsContext): added (KRenderingDeviceQuartz::currentCGContext): (KRenderingDeviceQuartz::pushContext): now updates NSGraphicsContext (KRenderingDeviceQuartz::popContext): now updates NSGraphicsContext (KRenderingDeviceQuartz::contextForImage): fixed spacing (KRenderingDeviceQuartz::createPaintServer): removed comment
  • ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFEBlendElementImpl.h:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFEColorMatrixElementImpl.h:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::filterEffect): returns sublcass
  • ksvg2/svg/SVGFEComponentTransferElementImpl.h:
  • ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFECompositeElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFEFloodElementImpl.h:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::notifyFinished): updates filterEffect on load (SVGFEImageElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFEImageElementImpl.h:
  • ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFEMergeElementImpl.h:
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFEOffsetElementImpl.h:
  • ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFETileElementImpl.h:
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::filterEffect): now returns subclass
  • ksvg2/svg/SVGFETurbulenceElementImpl.h:
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::attach): simplified
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainterPrivate::QPainterPrivate): removed cached quartz context (QPainterPrivate::~QPainterPrivate): removed cached quartz context (QPainter::createRenderingDeviceContext): changed method name
7:27 AM Changeset in webkit [11282] by darin
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebView.h: Fixed incorrect comment in public header.
4:25 AM Changeset in webkit [11281] by eseidel
  • 3 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

No additional tests needed, this fixes bbox printing for all tests.

  • kcanvas/device/quartz/KCanvasFilterQuartz.h: removed space
  • khtml/rendering/render_object.h: (khtml::RenderObject::bbox): added const (unbreaking bbox() calls)
4:03 AM Changeset in webkit [11280] by eseidel
  • 34 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

No additional test cases needed, this fixes 10+ existing tests.

Moved filter code off of createRenderer format, fixing filters.
Hacked in support for <image> and <feImage> (Pixmap only)
Simplified FEComponentTransfer function construction.

  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasFilters.h: (KCanvasFEImage::KCanvasFEImage): (KCanvasFEImage::~KCanvasFEImage): (KCanvasFEImage::pixmap): added (KCanvasFEImage::setPixmap): added
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter): added
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerImageQuartz::draw): added
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp: (SVGComponentTransferFunctionElementImpl::transferFunction):
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::filterEffect):
  • ksvg2/svg/SVGFEBlendElementImpl.h:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElementImpl.h:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElementImpl.h:
  • ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::filterEffect):
  • ksvg2/svg/SVGFECompositeElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
  • ksvg2/svg/SVGFEFloodElementImpl.h:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::filterEffect):
  • ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEMergeElementImpl.h:
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::filterEffect):
  • ksvg2/svg/SVGFEOffsetElementImpl.h:
  • ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::filterEffect):
  • ksvg2/svg/SVGFETileElementImpl.h:
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElementImpl.h:
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::x): (SVGFilterElementImpl::y): (SVGFilterElementImpl::width): (SVGFilterElementImpl::height): (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp: (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::notifyFinished): (SVGImageElementImpl::finalizeStyle):
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.cpp: (SVGURIReferenceImpl::parseMappedAttribute):
2:03 AM Changeset in webkit [11279] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: SVG build fix only, no review.

I used debug-only method DOMString::ascii(), broke Deployment.

  • kcanvas/KCanvasResources.cpp: (getResourceById):
Note: See TracTimeline for information about the timeline view.