⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 1, 2005:

7:48 PM Changeset in webkit [11392] by mjs
  • 29 edits
    1 delete in trunk

JavaScriptCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • kxmlcore/RefPtr.h:

WebCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • replaced use of KWQRefPtr with RefPtr
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toBoolean): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValueProperty): (KJS::XMLHttpRequest::mark): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open):
  • khtml/editing/edit_command.cpp:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell):
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleScript): (KHTMLPart::executeScheduledScript): (KHTMLPart::clear): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::MouseEvent::MouseEvent):
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::KWQArrayPrivate::KWQArrayPrivate): (KWQArrayImpl::duplicate): (KWQArrayImpl::detach):
  • kwq/KWQClipboard.mm: (KWQClipboard::setDragImage): (KWQClipboard::dragNSImage):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetrics::setFont): (QFontMetrics::ascent): (QFontMetrics::descent): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::checkSelectionPoint):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceMovedTo): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::snapshotDragImage): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::setMarkedTextRange):
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm: (KWQMapImpl::KWQMapPrivate::KWQMapPrivate): (KWQMapImpl::copyOnWrite): (KWQMapImpl::swap):
  • kwq/KWQRefPtr.h: Removed.
  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): (QRegExp::operator=):
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::operator=): (KWQValueListImpl::copyOnWrite):
  • kwq/KWQVariant.h:
  • kwq/KWQVariant.mm: (QVariant::QVariantPrivate::): (QVariant::QVariantPrivate::QVariantPrivate):
4:41 PM Changeset in webkit [11391] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:38 PM Changeset in webkit [11390] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:04 PM Changeset in webkit [11389] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
More fixes NULL checks for button and slider that were not on TOT.

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:57 PM Changeset in webkit [11388] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
3:55 PM Changeset in webkit [11387] by thatcher
  • 8 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added nil check. (-[KWQPopUpButton resignFirstResponder]): Added nil check.
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): Added nil check. (-[KWQTableView resignFirstResponder]): Added nil check.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added nil check. (-[KWQTextAreaTextView resignFirstResponder]): Added nil check.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added nil check.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): Added nil check.
3:50 PM Changeset in webkit [11386] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Another fix for 4098083 to apply to sliders.

<rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:45 PM Changeset in webkit [11385] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Added test for <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

  • editing/selection/focus_editable_html-expected.checksum: Added.
  • editing/selection/focus_editable_html-expected.png: Added.
  • editing/selection/focus_editable_html-expected.txt: Added.
  • editing/selection/focus_editable_html.html: Added.

WebCore:

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
3:25 PM Changeset in webkit [11384] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
3:16 PM Changeset in webkit [11383] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
3:15 PM Changeset in webkit [11382] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
1:59 PM Changeset in webkit [11381] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
12:10 PM Changeset in webkit [11380] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
10:34 AM Changeset in webkit [11379] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
10:26 AM Changeset in webkit [11378] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
9:59 AM Changeset in webkit [11377] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Patch by Mark Rowe.

  • kjs/nodes2string.cpp: (ForInNode::streamTo): Add lexpr if there's no varDecl.
9:58 AM Changeset in webkit [11376] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

  • fast/js/for-in-to-text-expected.txt: Added.
  • fast/js/for-in-to-text.html: Added.
2:32 AM Changeset in webkit [11375] by mjs
  • 76 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/internal.cpp: (KJS::Parser::parse): (KJS::InterpreterImp::checkSyntax): (KJS::InterpreterImp::evaluate):
  • kjs/internal.h:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp: (KJS::SourceStream::operator<<):
  • kjs/protect.h:
  • kxmlcore/RefPtr.h: Added. (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::~RefPtr): (KXMLCore::RefPtr::isNull): (KXMLCore::RefPtr::notNull): (KXMLCore::RefPtr::reset): (KXMLCore::RefPtr::get): (KXMLCore::RefPtr::operator*): (KXMLCore::RefPtr::operator->): (KXMLCore::RefPtr::operator!): (KXMLCore::RefPtr::operator UnspecifiedBoolType): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):
  • kxmlcore/SharedPtr.h: Removed.

WebCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • ForwardingHeaders/kxmlcore/RefPtr.h: Added.
  • ForwardingHeaders/kxmlcore/SharedPtr.h: Removed.
  • khtml/css/css_computedstyle.h:
  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/XSLTProcessor.h:
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::OptionConstructorImp::construct):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/SelectionController.h:
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): (khtml::StyleChange::currentlyHasStyle): (khtml::ApplyStyleCommand::doApply): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::hasTextDecorationProperty): (khtml::ApplyStyleCommand::extractTextDecorationStyle): (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): (khtml::ApplyStyleCommand::computedFontSize):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/edit_command.cpp: (khtml::EditCommandPtr::EditCommandPtr): (khtml::EditCommandPtr::operator=):
  • khtml/editing/edit_command.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_range.h:
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::range): (khtml::TextIterator::rangeFromLocationAndLength): (khtml::findPlainText):
  • khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::children):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::elements): (DOM::HTMLSelectElementImpl::add): (DOM::HTMLSelectElementImpl::optionsHTMLCollection):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLMapElementImpl::areas):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::namedItems):
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::rows): (DOM::HTMLTableElementImpl::tBodies): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableSectionElementImpl::rows): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell): (DOM::HTMLTableRowElementImpl::cells):
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): (HTMLParser::insertNode):
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle): (KHTMLPart::selectionComputedStyle): (KHTMLPart::applyEditingStyleToBodyElement): (KHTMLPart::removeEditingStyleFromBodyElement):
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::dispatchMouseEvent):
  • khtml/misc/shared.h:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::rangeOfContents):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::adoptNode): (DocumentImpl::setFocusNode): (DocumentImpl::addMarker): (DocumentImpl::removeMarkers): (DocumentImpl::applyXSLTransform): (DocumentImpl::images): (DocumentImpl::applets): (DocumentImpl::embeds): (DocumentImpl::objects): (DocumentImpl::links): (DocumentImpl::forms): (DocumentImpl::anchors): (DocumentImpl::all): (DocumentImpl::windowNamedItems): (DocumentImpl::documentNamedItems): (DocumentImpl::getElementsByName):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::transformSourceDocument):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttributeNode): (ElementImpl::removeAttributeNode): (NamedAttrMapImpl::removeNamedItemNS): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::setAttributeNodeNS):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::childNodes): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::getElementsByTagNameNS): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::getElementsByTagName): (DOM::NamedNodeMapImpl::removeNamedItem): (DOM::NamedNodeMapImpl::setNamedItemNS):
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): (DOM::createFragmentFromSource): (DOM::xsltStylesheetPointer): (DOM::xmlDocPtrFromNode): (DOM::XSLTProcessorImpl::transformToString): (DOM::XSLTProcessorImpl::transformToDocument): (DOM::XSLTProcessorImpl::transformToFragment): (DOM::XSLTProcessorImpl::getParameter):
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQClipboard.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::fontForSelection): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]):
12:38 AM Changeset in webkit [11374] by mjs
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • kjs/protect.h: (KJS::ProtectedPtr::operator UnspecifiedBoolType):
  • kxmlcore/SharedPtr.h: (KXMLCore::SharedPtr::operator UnspecifiedBoolType):

WebCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • khtml/xml/DocPtr.h: (DOM::DocPtr::operator UnspecifiedBoolType):

Nov 30, 2005:

3:04 PM Changeset in webkit [11373] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5890
Submitted by: eseidel
Reviewed by: darin

No additional tests needed, acid2 covers this case.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): call down into NodeImpl if needed.
2:46 PM Changeset in webkit [11372] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
2:44 PM Changeset in webkit [11371] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
2:40 PM Changeset in webkit [11370] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-28 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
2:39 PM Changeset in webkit [11369] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-28 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
2:25 PM Changeset in webkit [11368] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
2:24 PM Changeset in webkit [11367] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Beth Dakin <Beth Dakin>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
2:15 PM Changeset in webkit [11366] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Vicki Murley <​vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
2:14 PM Changeset in webkit [11365] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Vicki Murley <​vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
1:53 PM Changeset in webkit [11364] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Added layout test for <rdar://problem/4344760> REGRESSION
(Safari 416.12-417.2) gmail 'reply' does not fill in to: field or
quoted message (3751)

  • fast/forms/textarea-setvalue-without-renderer-expected.txt: Added.
  • fast/forms/textarea-setvalue-without-renderer.html: Added.
3:49 AM Changeset in webkit [11363] by eseidel
  • 9 edits
    2 adds in trunk/WebCore

Bug #: 5887
Submitted by: eseidel
Reviewed by: mjs

No functionality change, no tests needed.

Make make_names.pl namespace agnostic and add XLinkNames.* for SVG

  • WebCore+SVG/XLinkNamesWrapper.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: added files, build rule.
  • khtml/khtml_part.cpp: (KHTMLPart::init): init XLinkNames
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): remove foreignObjectTag (temp.)
  • ksvg2/misc/xlinkattrs.in: Added.
  • ksvg2/scripts/make_names.pl: make namespace agnostic
  • ksvg2/svg/SVGLocatableImpl.cpp: remove foreignObjectTag (temp.) (SVGLocatableImpl::nearestViewportElement): (SVGLocatableImpl::farthestViewportElement):
  • ksvg2/svg/SVGURIReferenceImpl.cpp: use XLinkNames (SVGURIReferenceImpl::parseMappedAttribute):
  • ksvg2/svg/svgattrs.in: remove href
  • ksvg2/svg/svgtags.in: comment out unused tags
3:07 AM Changeset in webkit [11362] by eseidel
  • 1 edit
    117 deletes in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none neede, removing unused test results only.

Removing erroneously committed results content.

  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt: Removed.
1:21 AM Changeset in webkit [11361] by eseidel
  • 18 edits in trunk

Bug #: 5881
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fixes 5 test cases:

  • paths-data-02-t.svg (most noticeable)
  • fonts-elem-01-t.svg
  • fonts-elem-02-t.svg
  • fonts-elem-03-t.svg
  • fonts-elem-04-t.svg

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5881
Quadratic bezier path render error

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):
Note: See TracTimeline for information about the timeline view.