⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 2, 2005:

6:33 PM Changeset in webkit [11421] by bdakin
  • 4 edits
    4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

5:44 PM Changeset in webkit [11420] by eseidel
  • 9 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: tim h

Added ending newlines to files missing them.

  • ForwardingHeaders/kjs/property_map.h:
  • khtml/rendering/break_lines.cpp:
  • khtml/xbl/xbl_binding.h:
  • khtml/xbl/xbl_protobinding.h:
  • khtml/xbl/xbl_protohandler.h:
  • kwq/DOM-compat.h:
  • kwq/KWQTextUtilities.h:
  • kwq/WebCoreKeyboardAccess.h:
5:32 PM Changeset in webkit [11419] by eseidel
  • 54 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed, svg build fix only.

SVG Build fix after SharedPtr -> RefPtr changes.

  • ksvg2/events/SVGZoomEventImpl.h:
  • ksvg2/svg/SVGAElementImpl.h:
  • ksvg2/svg/SVGAnimateColorElementImpl.h:
  • ksvg2/svg/SVGAnimateTransformElementImpl.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElementImpl.h:
  • ksvg2/svg/SVGCircleElementImpl.h:
  • ksvg2/svg/SVGClipPathElementImpl.h:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
  • ksvg2/svg/SVGCursorElementImpl.h:
  • ksvg2/svg/SVGEllipseElementImpl.h:
  • ksvg2/svg/SVGExternalResourcesRequiredImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.h:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.h:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.h:
  • ksvg2/svg/SVGFECompositeElementImpl.h:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.h:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
  • ksvg2/svg/SVGFEImageElementImpl.h:
  • ksvg2/svg/SVGFELightElementImpl.h:
  • ksvg2/svg/SVGFEMergeNodeElementImpl.h:
  • ksvg2/svg/SVGFEOffsetElementImpl.h:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h:
  • ksvg2/svg/SVGFETileElementImpl.h:
  • ksvg2/svg/SVGFETurbulenceElementImpl.h:
  • ksvg2/svg/SVGFilterElementImpl.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h:
  • ksvg2/svg/SVGFitToViewBoxImpl.h:
  • ksvg2/svg/SVGGradientElementImpl.h:
  • ksvg2/svg/SVGHelper.h: (KSVG::lazy_create):
  • ksvg2/svg/SVGImageElementImpl.h:
  • ksvg2/svg/SVGLineElementImpl.h:
  • ksvg2/svg/SVGLinearGradientElementImpl.h:
  • ksvg2/svg/SVGMarkerElementImpl.h:
  • ksvg2/svg/SVGPathElementImpl.h:
  • ksvg2/svg/SVGPatternElementImpl.h:
  • ksvg2/svg/SVGPolyElementImpl.h:
  • ksvg2/svg/SVGRadialGradientElementImpl.h:
  • ksvg2/svg/SVGRectElementImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGStopElementImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.h:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGStyledTransformableElementImpl.h:
  • ksvg2/svg/SVGTestsImpl.h:
  • ksvg2/svg/SVGTextContentElementImpl.h:
  • ksvg2/svg/SVGTextPositioningElementImpl.h:
  • ksvg2/svg/SVGTransformImpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/SVGUseElementImpl.h:
  • ksvg2/svg/SVGViewElementImpl.h:
5:30 PM Changeset in webkit [11418] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed.

No review needed.

  • ksvg2/scripts/make_names.pl: Add standard license header.
5:18 PM Changeset in webkit [11417]
  • 55 copies
    22 deletes in tags/WebKit-417~6

This commit was manufactured by cvs2svn to create tag 'WebKit-417~6'.

5:18 PM Changeset in webkit [11416] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning to WebKit-417.6

5:17 PM Changeset in webkit [11415]
  • 210 copies
    17 deletes in tags/WebCore-417~8

This commit was manufactured by cvs2svn to create tag
'WebCore-417~8'.

5:17 PM Changeset in webkit [11414] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.8

5:06 PM Changeset in webkit [11413] by adele
  • 8 edits in trunk

LayoutTests:

Updating test for latest changes in:
<rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • fast/replaced/width100percent.html:

WebCore:

Reviewed by Hyatt.

  • fix for <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

We're backing out the fix for <rdar://problem/3952698>.
With the new button implementation, the buttons will
not overlap for the telia webmail case. We may need to address
the minWidth behavior for other elements at a later time.

  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
5:06 PM Changeset in webkit [11412] by adele
  • 4 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
4:54 PM Changeset in webkit [11411] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

4:00 PM Changeset in webkit [11410] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
3:58 PM Changeset in webkit [11409] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
3:19 PM Changeset in webkit [11408] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
2:53 PM Changeset in webkit [11407] by justing
  • 3 edits in trunk/WebKit

<rdar://problem/4345030>
Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

Before checking the navigation policy for a request, the request is compared
against the last checked request. If the two are the same, no check is done.
In the bug, the two requests are identical except for the boolean on
NSURLRequests that tells Foundation to support multipart loads for that request.
One request was the one that was used to start servicing "Back" operation, and
the second was being used to start loading the page (it needed to be reloaded
because it was the result of a form submission). Set the boolean on all
NSURLRequests, not just one's that are about to be used to start a load.

Reviewed by harrison

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
2:44 PM Changeset in webkit [11406] by mjs
  • 12 edits in trunk/WebCore

SVG build fix, not reviewed.

  • land the ksvg2 part of my SharedPtr --> RefPtr change, which I forgot about before.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent): (SVGAnimateTransformElementImpl::parseTransformValue): (SVGAnimateTransformElementImpl::initialMatrix):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::~SVGDocumentImpl): (SVGDocumentImpl::dispatchZoomEvent): (SVGDocumentImpl::dispatchScrollEvent): (SVGDocumentImpl::dispatchKeyEvent): (SVGDocumentImpl::executeScripts): (SVGDocumentImpl::dispatchUIEvent): (SVGDocumentImpl::dispatchMouseEvent):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getCTM): (SVGLocatableImpl::getScreenCTM):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::canvasResource):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): (SVGPatternElementImpl::getCTM):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::viewport): (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::getCTM): (SVGSVGElementImpl::getScreenCTM):
  • ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::executeScript):
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::updateLocalTransform):
1:26 PM Changeset in webkit [11405] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:17 PM Changeset in webkit [11404] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:16 PM Changeset in webkit [11403] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 David Hyatt <​hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
1:13 PM Changeset in webkit [11402] by vicki
  • 2 edits
    3 adds in trunk/WebCore

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:13 PM Changeset in webkit [11401] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 David Hyatt <​hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
12:58 PM Changeset in webkit [11400] by aboule
  • 2 edits in trunk/WebCore

Reviewed by rjw.

Added #else for XSLT ifdef to make sure switch case
doesn't fall through when feature turned off.

  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
12:32 PM Changeset in webkit [11399] by hyatt
  • 2 adds in trunk/LayoutTests/fast/clip

Add layout test for new clipping behavior.

12:23 PM Changeset in webkit [11398] by hyatt
  • 2 edits in trunk/WebCore

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

fast/clip/018.html

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
1:19 AM Changeset in webkit [11397] by andersca
  • 3 edits in trunk/WebCore

2005-12-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy.

  • WebCore.xcodeproj/project.pbxproj: Remove KWQRefPtr.h
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Remove a call to notNull here.
1:13 AM Changeset in webkit [11396] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Cache the lastItem and lastItemOffset for fast retrieval of the
same index or indeicies greater than lastItemOffset. Also cache
the length. Like other node lists these cached values rest when the
subtree under the root node changes.

  • khtml/xml/dom_nodeimpl.cpp: (ChildNodeListImpl::length): Use cachedLength when possible. (ChildNodeListImpl::item): Use lastItemOffset and lastItem if we can.
1:00 AM Changeset in webkit [11395] by justing
  • 2 edits
    4 adds in trunk/LayoutTests

Reviewed by justin

Updated/added tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

  • editing/deleting/delete-3775172-fix-expected.txt: Fixed.
  • editing/inserting/editing-empty-divs-expected.checksum: Added.
  • editing/inserting/editing-empty-divs-expected.png: Added.
  • editing/inserting/editing-empty-divs-expected.txt: Added.
  • editing/inserting/editing-empty-divs.html: Added.
1:00 AM Changeset in webkit [11394] by justing
  • 2 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

Reviewed/tweaked/landed by justin

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): A position at the original block shouldn't be considered 'outside' the original block. (khtml::hasRenderedChildrenWithHeight): Added. (khtml::VisiblePosition::isCandidate): A block flow element with rendered children may be considered a candidate for a visible position, as long as its children do not have a positive height.
12:33 AM Changeset in webkit [11393] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Remove duplicate entry

Dec 1, 2005:

7:48 PM Changeset in webkit [11392] by mjs
  • 29 edits
    1 delete in trunk

JavaScriptCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • kxmlcore/RefPtr.h:

WebCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • replaced use of KWQRefPtr with RefPtr
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toBoolean): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValueProperty): (KJS::XMLHttpRequest::mark): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open):
  • khtml/editing/edit_command.cpp:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell):
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleScript): (KHTMLPart::executeScheduledScript): (KHTMLPart::clear): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::MouseEvent::MouseEvent):
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::KWQArrayPrivate::KWQArrayPrivate): (KWQArrayImpl::duplicate): (KWQArrayImpl::detach):
  • kwq/KWQClipboard.mm: (KWQClipboard::setDragImage): (KWQClipboard::dragNSImage):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetrics::setFont): (QFontMetrics::ascent): (QFontMetrics::descent): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::checkSelectionPoint):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceMovedTo): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::snapshotDragImage): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::setMarkedTextRange):
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm: (KWQMapImpl::KWQMapPrivate::KWQMapPrivate): (KWQMapImpl::copyOnWrite): (KWQMapImpl::swap):
  • kwq/KWQRefPtr.h: Removed.
  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): (QRegExp::operator=):
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::operator=): (KWQValueListImpl::copyOnWrite):
  • kwq/KWQVariant.h:
  • kwq/KWQVariant.mm: (QVariant::QVariantPrivate::): (QVariant::QVariantPrivate::QVariantPrivate):
4:41 PM Changeset in webkit [11391] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:38 PM Changeset in webkit [11390] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
4:04 PM Changeset in webkit [11389] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
More fixes NULL checks for button and slider that were not on TOT.

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:57 PM Changeset in webkit [11388] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
3:55 PM Changeset in webkit [11387] by thatcher
  • 8 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-10-28 Beth Dakin <Beth Dakin>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added nil check. (-[KWQPopUpButton resignFirstResponder]): Added nil check.
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): Added nil check. (-[KWQTableView resignFirstResponder]): Added nil check.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added nil check. (-[KWQTextAreaTextView resignFirstResponder]): Added nil check.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added nil check.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): Added nil check.
3:50 PM Changeset in webkit [11386] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Another fix for 4098083 to apply to sliders.

<rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
3:45 PM Changeset in webkit [11385] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Added test for <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

  • editing/selection/focus_editable_html-expected.checksum: Added.
  • editing/selection/focus_editable_html-expected.png: Added.
  • editing/selection/focus_editable_html-expected.txt: Added.
  • editing/selection/focus_editable_html.html: Added.

WebCore:

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
3:25 PM Changeset in webkit [11384] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Darin Adler <Darin Adler>

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
3:16 PM Changeset in webkit [11383] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
3:15 PM Changeset in webkit [11382] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-07-30 Darin Adler <Darin Adler>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
1:59 PM Changeset in webkit [11381] by vicki
  • 2 edits in trunk/WebKit

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
12:10 PM Changeset in webkit [11380] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
10:34 AM Changeset in webkit [11379] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
10:26 AM Changeset in webkit [11378] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
9:59 AM Changeset in webkit [11377] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Patch by Mark Rowe.

  • kjs/nodes2string.cpp: (ForInNode::streamTo): Add lexpr if there's no varDecl.
9:58 AM Changeset in webkit [11376] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

  • fast/js/for-in-to-text-expected.txt: Added.
  • fast/js/for-in-to-text.html: Added.
2:32 AM Changeset in webkit [11375] by mjs
  • 76 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/internal.cpp: (KJS::Parser::parse): (KJS::InterpreterImp::checkSyntax): (KJS::InterpreterImp::evaluate):
  • kjs/internal.h:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp: (KJS::SourceStream::operator<<):
  • kjs/protect.h:
  • kxmlcore/RefPtr.h: Added. (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::~RefPtr): (KXMLCore::RefPtr::isNull): (KXMLCore::RefPtr::notNull): (KXMLCore::RefPtr::reset): (KXMLCore::RefPtr::get): (KXMLCore::RefPtr::operator*): (KXMLCore::RefPtr::operator->): (KXMLCore::RefPtr::operator!): (KXMLCore::RefPtr::operator UnspecifiedBoolType): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):
  • kxmlcore/SharedPtr.h: Removed.

WebCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • ForwardingHeaders/kxmlcore/RefPtr.h: Added.
  • ForwardingHeaders/kxmlcore/SharedPtr.h: Removed.
  • khtml/css/css_computedstyle.h:
  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/XSLTProcessor.h:
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::OptionConstructorImp::construct):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/SelectionController.h:
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): (khtml::StyleChange::currentlyHasStyle): (khtml::ApplyStyleCommand::doApply): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::hasTextDecorationProperty): (khtml::ApplyStyleCommand::extractTextDecorationStyle): (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): (khtml::ApplyStyleCommand::computedFontSize):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/edit_command.cpp: (khtml::EditCommandPtr::EditCommandPtr): (khtml::EditCommandPtr::operator=):
  • khtml/editing/edit_command.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_range.h:
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::range): (khtml::TextIterator::rangeFromLocationAndLength): (khtml::findPlainText):
  • khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::children):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::elements): (DOM::HTMLSelectElementImpl::add): (DOM::HTMLSelectElementImpl::optionsHTMLCollection):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLMapElementImpl::areas):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::namedItems):
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::rows): (DOM::HTMLTableElementImpl::tBodies): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableSectionElementImpl::rows): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell): (DOM::HTMLTableRowElementImpl::cells):
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): (HTMLParser::insertNode):
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle): (KHTMLPart::selectionComputedStyle): (KHTMLPart::applyEditingStyleToBodyElement): (KHTMLPart::removeEditingStyleFromBodyElement):
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::dispatchMouseEvent):
  • khtml/misc/shared.h:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::rangeOfContents):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::adoptNode): (DocumentImpl::setFocusNode): (DocumentImpl::addMarker): (DocumentImpl::removeMarkers): (DocumentImpl::applyXSLTransform): (DocumentImpl::images): (DocumentImpl::applets): (DocumentImpl::embeds): (DocumentImpl::objects): (DocumentImpl::links): (DocumentImpl::forms): (DocumentImpl::anchors): (DocumentImpl::all): (DocumentImpl::windowNamedItems): (DocumentImpl::documentNamedItems): (DocumentImpl::getElementsByName):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::transformSourceDocument):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttributeNode): (ElementImpl::removeAttributeNode): (NamedAttrMapImpl::removeNamedItemNS): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::setAttributeNodeNS):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::childNodes): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::getElementsByTagNameNS): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::getElementsByTagName): (DOM::NamedNodeMapImpl::removeNamedItem): (DOM::NamedNodeMapImpl::setNamedItemNS):
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): (DOM::createFragmentFromSource): (DOM::xsltStylesheetPointer): (DOM::xmlDocPtrFromNode): (DOM::XSLTProcessorImpl::transformToString): (DOM::XSLTProcessorImpl::transformToDocument): (DOM::XSLTProcessorImpl::transformToFragment): (DOM::XSLTProcessorImpl::getParameter):
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQClipboard.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::fontForSelection): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]):
12:38 AM Changeset in webkit [11374] by mjs
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • kjs/protect.h: (KJS::ProtectedPtr::operator UnspecifiedBoolType):
  • kxmlcore/SharedPtr.h: (KXMLCore::SharedPtr::operator UnspecifiedBoolType):

WebCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • khtml/xml/DocPtr.h: (DOM::DocPtr::operator UnspecifiedBoolType):
Note: See TracTimeline for information about the timeline view.