⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 3, 2005:

5:22 PM Changeset in webkit [11429] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/4364302> leftmargin and topmargin
should match marginwidth and marginheight respectively

  • fast/block/positioning/leftmargin-topmargin-expected.txt: Added.
  • fast/block/positioning/leftmargin-topmargin.html: Added.
5:21 PM Changeset in webkit [11428] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4364302> leftmargin and topmargin should match
marginwidth and marginheight respectively

Layout test added:
positioning/leftmargin-topmargin-expected.txt
positioning/leftmargin-topmargin.html

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Merged leftmargin/marginwidth, topmargin/marginheight
4:53 PM Changeset in webkit [11427] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

Reviewed by darin

  • editing/selection/expanding-selections-expected.checksum: Added.
  • editing/selection/expanding-selections-expected.png: Added.
  • editing/selection/expanding-selections-expected.txt: Added.
  • editing/selection/expanding-selections.html: Added.
  • editing/selection/expanding-selections2-expected.checksum: Added.
  • editing/selection/expanding-selections2-expected.png: Added.
  • editing/selection/expanding-selections2-expected.txt: Added.
  • editing/selection/expanding-selections2.html: Added.
4:48 PM Changeset in webkit [11426] by justing
  • 3 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

validate() used to do expansion of the selection. The expansion
itself wasn't validated, so it could create a selection
that extended outside an editable area. Also m_base and
m_extent weren't updated with the results of the expansion.

Reviewed by darin

Layout tests added:

  • editing/selection/expanding-selections
  • editing/selection/expanding-selections2
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::expandUsingGranularity): Does the expansion. (khtml::SelectionController::validate): Removed the granularity parameter.
  • khtml/editing/SelectionController.h:
4:32 PM Changeset in webkit [11425] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
show up wrong size (with scroll bars)

We had the wrong default features for new windows. The IE rule is:
all features except for channelmode and fullscreen default to YES, but
if the user specifies a feature string, all features default to NO.
(There is no public standard that applies to this method.)

<​http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>

No test case because testing requires a call to window.open, which
DumpRenderTree can't simulate.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs):
12:26 PM Changeset in webkit [11424] by andersca
  • 5 edits in trunk/WebCore/khtml

Didn't mean to commit this.

12:16 PM Changeset in webkit [11423] by andersca
  • 11 edits
    1 add in trunk/WebCore

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Update calls to append functions to set the enabled state of items.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): (QComboBox::appendGroupLabel): (QComboBox::appendSeparator): Add enabled parameter to append functions.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Don't autoenable menu items on the popup button since that's handled manually now.

(QComboBox::setTitle):
Set enabled state on menu items.

(QComboBox::appendItem):
Add enabled parameter.

  • kwq/KWQListBox.h: (KWQListBoxItem::KWQListBoxItem): Add enabled variable to item struct.

(QListBox::appendItem):
(QListBox::appendGroupLabel):
Add enabled parameter to append functions.

  • kwq/KWQListBox.mm: (QListBox::appendItem): Add enabled parameter.

(-[KWQTableView tableView:shouldSelectRow:]):
Only select the row if the item is enabled.

(-[KWQTableView drawRow:clipRect:]):
Draw using the disabled color if the row is disabled.

  • manual-tests/disabled-option-elements.html: Added.
8:56 AM Changeset in webkit [11422] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Improved ChangeLog comment.

Dec 2, 2005:

6:33 PM Changeset in webkit [11421] by bdakin
  • 4 edits
    4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

5:44 PM Changeset in webkit [11420] by eseidel
  • 9 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: tim h

Added ending newlines to files missing them.

  • ForwardingHeaders/kjs/property_map.h:
  • khtml/rendering/break_lines.cpp:
  • khtml/xbl/xbl_binding.h:
  • khtml/xbl/xbl_protobinding.h:
  • khtml/xbl/xbl_protohandler.h:
  • kwq/DOM-compat.h:
  • kwq/KWQTextUtilities.h:
  • kwq/WebCoreKeyboardAccess.h:
5:32 PM Changeset in webkit [11419] by eseidel
  • 54 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed, svg build fix only.

SVG Build fix after SharedPtr -> RefPtr changes.

  • ksvg2/events/SVGZoomEventImpl.h:
  • ksvg2/svg/SVGAElementImpl.h:
  • ksvg2/svg/SVGAnimateColorElementImpl.h:
  • ksvg2/svg/SVGAnimateTransformElementImpl.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElementImpl.h:
  • ksvg2/svg/SVGCircleElementImpl.h:
  • ksvg2/svg/SVGClipPathElementImpl.h:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
  • ksvg2/svg/SVGCursorElementImpl.h:
  • ksvg2/svg/SVGEllipseElementImpl.h:
  • ksvg2/svg/SVGExternalResourcesRequiredImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.h:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.h:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.h:
  • ksvg2/svg/SVGFECompositeElementImpl.h:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.h:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
  • ksvg2/svg/SVGFEImageElementImpl.h:
  • ksvg2/svg/SVGFELightElementImpl.h:
  • ksvg2/svg/SVGFEMergeNodeElementImpl.h:
  • ksvg2/svg/SVGFEOffsetElementImpl.h:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h:
  • ksvg2/svg/SVGFETileElementImpl.h:
  • ksvg2/svg/SVGFETurbulenceElementImpl.h:
  • ksvg2/svg/SVGFilterElementImpl.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h:
  • ksvg2/svg/SVGFitToViewBoxImpl.h:
  • ksvg2/svg/SVGGradientElementImpl.h:
  • ksvg2/svg/SVGHelper.h: (KSVG::lazy_create):
  • ksvg2/svg/SVGImageElementImpl.h:
  • ksvg2/svg/SVGLineElementImpl.h:
  • ksvg2/svg/SVGLinearGradientElementImpl.h:
  • ksvg2/svg/SVGMarkerElementImpl.h:
  • ksvg2/svg/SVGPathElementImpl.h:
  • ksvg2/svg/SVGPatternElementImpl.h:
  • ksvg2/svg/SVGPolyElementImpl.h:
  • ksvg2/svg/SVGRadialGradientElementImpl.h:
  • ksvg2/svg/SVGRectElementImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGStopElementImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.h:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGStyledTransformableElementImpl.h:
  • ksvg2/svg/SVGTestsImpl.h:
  • ksvg2/svg/SVGTextContentElementImpl.h:
  • ksvg2/svg/SVGTextPositioningElementImpl.h:
  • ksvg2/svg/SVGTransformImpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/SVGUseElementImpl.h:
  • ksvg2/svg/SVGViewElementImpl.h:
5:30 PM Changeset in webkit [11418] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none needed.

No review needed.

  • ksvg2/scripts/make_names.pl: Add standard license header.
5:18 PM Changeset in webkit [11417]
  • 55 copies
    22 deletes in tags/WebKit-417~6

This commit was manufactured by cvs2svn to create tag 'WebKit-417~6'.

5:18 PM Changeset in webkit [11416] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning to WebKit-417.6

5:17 PM Changeset in webkit [11415]
  • 210 copies
    17 deletes in tags/WebCore-417~8

This commit was manufactured by cvs2svn to create tag
'WebCore-417~8'.

5:17 PM Changeset in webkit [11414] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.8

5:06 PM Changeset in webkit [11413] by adele
  • 8 edits in trunk

LayoutTests:

Updating test for latest changes in:
<rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • fast/replaced/width100percent.html:

WebCore:

Reviewed by Hyatt.

  • fix for <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

We're backing out the fix for <rdar://problem/3952698>.
With the new button implementation, the buttons will
not overlap for the telia webmail case. We may need to address
the minWidth behavior for other elements at a later time.

  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
5:06 PM Changeset in webkit [11412] by adele
  • 4 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
4:54 PM Changeset in webkit [11411] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

4:00 PM Changeset in webkit [11410] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
3:58 PM Changeset in webkit [11409] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
3:19 PM Changeset in webkit [11408] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
2:53 PM Changeset in webkit [11407] by justing
  • 3 edits in trunk/WebKit

<rdar://problem/4345030>
Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

Before checking the navigation policy for a request, the request is compared
against the last checked request. If the two are the same, no check is done.
In the bug, the two requests are identical except for the boolean on
NSURLRequests that tells Foundation to support multipart loads for that request.
One request was the one that was used to start servicing "Back" operation, and
the second was being used to start loading the page (it needed to be reloaded
because it was the result of a form submission). Set the boolean on all
NSURLRequests, not just one's that are about to be used to start a load.

Reviewed by harrison

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
2:44 PM Changeset in webkit [11406] by mjs
  • 12 edits in trunk/WebCore

SVG build fix, not reviewed.

  • land the ksvg2 part of my SharedPtr --> RefPtr change, which I forgot about before.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent): (SVGAnimateTransformElementImpl::parseTransformValue): (SVGAnimateTransformElementImpl::initialMatrix):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::~SVGDocumentImpl): (SVGDocumentImpl::dispatchZoomEvent): (SVGDocumentImpl::dispatchScrollEvent): (SVGDocumentImpl::dispatchKeyEvent): (SVGDocumentImpl::executeScripts): (SVGDocumentImpl::dispatchUIEvent): (SVGDocumentImpl::dispatchMouseEvent):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getCTM): (SVGLocatableImpl::getScreenCTM):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::canvasResource):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): (SVGPatternElementImpl::getCTM):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::viewport): (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::getCTM): (SVGSVGElementImpl::getScreenCTM):
  • ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::executeScript):
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::updateLocalTransform):
1:26 PM Changeset in webkit [11405] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:17 PM Changeset in webkit [11404] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:16 PM Changeset in webkit [11403] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 David Hyatt <​hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
1:13 PM Changeset in webkit [11402] by vicki
  • 2 edits
    3 adds in trunk/WebCore

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
1:13 PM Changeset in webkit [11401] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 David Hyatt <​hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
12:58 PM Changeset in webkit [11400] by aboule
  • 2 edits in trunk/WebCore

Reviewed by rjw.

Added #else for XSLT ifdef to make sure switch case
doesn't fall through when feature turned off.

  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
12:32 PM Changeset in webkit [11399] by hyatt
  • 2 adds in trunk/LayoutTests/fast/clip

Add layout test for new clipping behavior.

12:23 PM Changeset in webkit [11398] by hyatt
  • 2 edits in trunk/WebCore

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

fast/clip/018.html

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
1:19 AM Changeset in webkit [11397] by andersca
  • 3 edits in trunk/WebCore

2005-12-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy.

  • WebCore.xcodeproj/project.pbxproj: Remove KWQRefPtr.h
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Remove a call to notNull here.
1:13 AM Changeset in webkit [11396] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Cache the lastItem and lastItemOffset for fast retrieval of the
same index or indeicies greater than lastItemOffset. Also cache
the length. Like other node lists these cached values rest when the
subtree under the root node changes.

  • khtml/xml/dom_nodeimpl.cpp: (ChildNodeListImpl::length): Use cachedLength when possible. (ChildNodeListImpl::item): Use lastItemOffset and lastItem if we can.
1:00 AM Changeset in webkit [11395] by justing
  • 2 edits
    4 adds in trunk/LayoutTests

Reviewed by justin

Updated/added tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

  • editing/deleting/delete-3775172-fix-expected.txt: Fixed.
  • editing/inserting/editing-empty-divs-expected.checksum: Added.
  • editing/inserting/editing-empty-divs-expected.png: Added.
  • editing/inserting/editing-empty-divs-expected.txt: Added.
  • editing/inserting/editing-empty-divs.html: Added.
1:00 AM Changeset in webkit [11394] by justing
  • 2 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

Reviewed/tweaked/landed by justin

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): A position at the original block shouldn't be considered 'outside' the original block. (khtml::hasRenderedChildrenWithHeight): Added. (khtml::VisiblePosition::isCandidate): A block flow element with rendered children may be considered a candidate for a visible position, as long as its children do not have a positive height.
12:33 AM Changeset in webkit [11393] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Remove duplicate entry

Note: See TracTimeline for information about the timeline view.