⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 4, 2005:

3:45 PM Changeset in webkit [11449] by ggaren
  • 2 edits in trunk/JavaScriptCore

Update test results to match Anders's last checkin.

  • tests/mozilla/expected.html:
3:30 PM Changeset in webkit [11448] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

Add new tests for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3999>

  • fast/js/test-propertyIsEnumerable-expected.txt: Added.
  • fast/js/test-propertyIsEnumerable.html: Added.
3:28 PM Changeset in webkit [11447] by andersca
  • 5 edits in trunk/JavaScriptCore

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

  • kjs/object.cpp: (KJS::ObjectImp::canPut): Refactor to use getPropertyAttributes.

(KJS::ObjectImp::propertyIsEnumerable):
New function which checks if a property is enumerable.

(KJS::ObjectImp::getPropertyAttributes):

  • kjs/object.h: Add getPropertyAttributes and propertyIsEnumerable.
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::callAsFunction):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::): Add propertyIsEnumerable to the Object prototype.
3:14 PM Changeset in webkit [11446] by eseidel
  • 11 edits
    60 deletes in trunk/WebCore

Bug #: 5930
Submitted by: eseidel
Reviewed by: ggaren

No additional test cases needed (or possible).

Further dom/* cleanup, also removing extra forwarding headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5930

  • ForwardingHeaders/dom/dom2_views.h: Removed.
  • ForwardingHeaders/dom/dom_core.h: Removed.
  • ForwardingHeaders/dom/dom_doc.h: Removed.
  • ForwardingHeaders/dom/dom_element.h: Removed.
  • ForwardingHeaders/dom/dom_misc.h: Removed.
  • ForwardingHeaders/dom/dom_text.h: Removed.
  • ForwardingHeaders/dom/dom_xml.h: Removed.
  • ForwardingHeaders/dom/html_base.h: Removed.
  • ForwardingHeaders/dom/html_block.h: Removed.
  • ForwardingHeaders/dom/html_document.h: Removed.
  • ForwardingHeaders/dom/html_element.h: Removed.
  • ForwardingHeaders/dom/html_form.h: Removed.
  • ForwardingHeaders/dom/html_head.h: Removed.
  • ForwardingHeaders/dom/html_image.h: Removed.
  • ForwardingHeaders/dom/html_inline.h: Removed.
  • ForwardingHeaders/dom/html_list.h: Removed.
  • ForwardingHeaders/dom/html_misc.h: Removed.
  • ForwardingHeaders/dom/html_object.h: Removed.
  • ForwardingHeaders/dom/html_table.h: Removed.
  • ForwardingHeaders/ecma/kjs_css.h: Removed.
  • ForwardingHeaders/ecma/kjs_html.h: Removed.
  • ForwardingHeaders/ecma/kjs_html.lut.h: Removed.
  • ForwardingHeaders/ecma/kjs_views.h: Removed.
  • ForwardingHeaders/ecma/kjs_views.lut.h: Removed.
  • ForwardingHeaders/ecma/kjs_window.h: Removed.
  • ForwardingHeaders/html/dtd.h: Removed.
  • ForwardingHeaders/kdom/KDOMPart.h: Removed.
  • ForwardingHeaders/kdom/KDOMView.h: Removed.
  • ForwardingHeaders/kdom/core/NodeListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSMediaRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSRuleListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/cssproperties.h: Removed.
  • ForwardingHeaders/kdom/css/cssvalues.h: Removed.
  • ForwardingHeaders/kdom/events/DocumentEventImpl.h: Removed.
  • ForwardingHeaders/kdom/parser/KDOMDocumentBuilder.h: Removed.
  • ForwardingHeaders/kdomcssproperties.h: Removed.
  • ForwardingHeaders/kdomcssvalues.h: Removed.
  • ForwardingHeaders/kinstance.h: Removed.
  • ForwardingHeaders/kjs/identifier.h: Removed.
  • ForwardingHeaders/kjs/property_map.h: Removed.
  • ForwardingHeaders/kjs/protected_object.h: Removed.
  • ForwardingHeaders/kjs/scope_chain.h: Removed.
  • ForwardingHeaders/kjs/ustring.h: Removed.
  • ForwardingHeaders/kjs/value.h: Removed.
  • ForwardingHeaders/ksvg2/svg/svgtags.h: Removed.
  • ForwardingHeaders/q3intdict.h: Removed.
  • ForwardingHeaders/q3memarray.h: Removed.
  • ForwardingHeaders/q3ptrcollection.h: Removed.
  • ForwardingHeaders/q3ptrdict.h: Removed.
  • ForwardingHeaders/qcstring.h: Removed.
  • ForwardingHeaders/qcursor.h: Removed.
  • ForwardingHeaders/qintdict.h: Removed.
  • ForwardingHeaders/qpair.h: Removed.
  • ForwardingHeaders/qprinter.h: Removed.
  • ForwardingHeaders/qptrcollection.h: Removed.
  • ForwardingHeaders/qsize.h: Removed.
  • ForwardingHeaders/qsortedlist.h: Removed.
  • ForwardingHeaders/qvaluevector.h: Removed.
  • ForwardingHeaders/xml/dom_positioniterator.h: Removed.
  • khtml/css/css_ruleimpl.cpp:
  • khtml/dom/css_value.h:
  • khtml/dom/dom2_events.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_range.h:
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_node.h:
  • khtml/dom/dom_string.cpp:
  • khtml/ecma/kjs_traversal.cpp:
3:07 PM Changeset in webkit [11445]
  • 210 copies
    17 deletes in tags/WebCore-417~9

This commit was manufactured by cvs2svn to create tag
'WebCore-417~9'.

3:07 PM Changeset in webkit [11444] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.9

2:01 PM Changeset in webkit [11443]
  • 26 copies
    3 deletes in tags/WebKit-312~7

This commit was manufactured by cvs2svn to create tag 'WebKit-312~7'.

2:01 PM Changeset in webkit [11442] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning to WebKit-312.7

1:59 PM Changeset in webkit [11441]
  • 118 copies
    5 deletes in tags/WebCore-315~12

This commit was manufactured by cvs2svn to create tag
'WebCore-315~12'.

1:59 PM Changeset in webkit [11440] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.12

1:58 PM Changeset in webkit [11439] by thatcher
  • 1 edit in branches/Safari-1-3-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

1:56 PM Changeset in webkit [11438]
  • 10 copies
    3 deletes in tags/JavaScriptCore-312~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~3'.

1:56 PM Changeset in webkit [11437] by thatcher
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Versioning to JavaScriptCore-312.3

1:12 PM Changeset in webkit [11436] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2005-12-02 Adele Peterson <​adele@apple.com>

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
1:02 PM Changeset in webkit [11435] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Darin Adler <Darin Adler>

Reviewed by Beth

Fix for <rdar://problem/4358898> TOT/GLENDALE REGRESSION: Table
layout issue occurs at ​http://www.pixar.com/shorts/index.html and
​http://www.mitzpettel.com.

This fix rolls a line from the fix for <rdar://problem/3871165>
text box in nested table disappears when you click on it (3452)
(Safari PSOFT: US EDU PS8: Lead List searches). This line causes
the above regressions. To fix the original problem, we realized
that TableLayout::calcEffectiveWidth() essentially ignored setting
the minimum and maximum widths of cells of width 0 (thereby ignoring
cells in colspans).

  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): Roll out from the original fix.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Set effMinWidth and effMaxWidth of a cell even when maxw or maxWidth is 0.
1:01 PM Changeset in webkit [11434] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Darin Adler <Darin Adler>

Reviewed by Beth

Fix for <rdar://problem/4358898> TOT/GLENDALE REGRESSION: Table
layout issue occurs at ​http://www.pixar.com/shorts/index.html and
​http://www.mitzpettel.com.

This fix rolls a line from the fix for <rdar://problem/3871165>
text box in nested table disappears when you click on it (3452)
(Safari PSOFT: US EDU PS8: Lead List searches). This line causes
the above regressions. To fix the original problem, we realized
that TableLayout::calcEffectiveWidth() essentially ignored setting
the minimum and maximum widths of cells of width 0 (thereby ignoring
cells in colspans).

  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): Roll out from the original fix.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Set effMinWidth and effMaxWidth of a cell even when maxw or maxWidth is 0.
12:55 PM Changeset in webkit [11433] by andersca
  • 4 edits
    1 add in trunk/WebCore

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin and Geoffrey.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Don't send onblur to a node if m_inDetach is true.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::detach): Set m_inDetach to true while calling RenderObject::destroy.
  • khtml/xml/dom_nodeimpl.h:

Add m_inDetach flag.

  • manual-tests/onblur-remove.html: Added.
5:08 AM Changeset in webkit [11432] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5929
Submitted by: eseidel
Reviewed by: No review needed, WebCore+SVG build fix only.

I broke the WebCore+SVG build when removing dom_misc.h, fixing.

  • WebCore+SVG/KDOMHeaders.h: remove reference to dom_misc.h
4:43 AM Changeset in webkit [11431] by eseidel
  • 10 edits
    2 deletes in trunk/WebCore

Bug #: 5929
Submitted by: eseidel
Reviewed by: darin

No functionality changes, no test cases possible or necessary.

Removed dom_misc.* and changed to use Shared instead of DOMShared.
Also removed FilterNode typedef, now using NodeImpl* directly.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5929

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_base.h:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.cpp: (DOM::NodeFilterCondition::acceptNode):
  • khtml/dom/dom2_traversal.h:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_misc.cpp: Removed.
  • khtml/dom/dom_misc.h: Removed.
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_traversal.h:
  • kwq/DOM.mm: (ObjCNodeFilterCondition::acceptNode):
3:35 AM Changeset in webkit [11430] by eseidel
  • 21 edits in trunk/WebCore

Bug #: 5877
Submitted by: eseidel
Reviewed by: mjs

No test cases needed/possible, only removing dead code.

Remove rotten #ifdef'd code from the source:
APPLE_CHANGES & KHTML_NO_CPLUSPLUS_DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5877

  • khtml/dom/css_rule.h: (DOM::CSSRule::):
  • khtml/dom/css_stylesheet.h:
  • khtml/dom/css_value.h: (DOM::CSSValue::): (DOM::CSSPrimitiveValue::):
  • khtml/dom/dom2_events.cpp: (DOM::EventListener::handleEventImpl):
  • khtml/dom/dom2_events.h: (DOM::Event::): (DOM::EventException::): (DOM::MutationEvent::):
  • khtml/dom/dom2_range.h: (DOM::RangeException::): (DOM::Range::):
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom2_traversal.h: (DOM::NodeFilter::):
  • khtml/dom/dom_exception.h: (DOM::DOMException::):
  • khtml/dom/dom_misc.cpp: (DOM::DomShared::~DomShared):
  • khtml/dom/dom_misc.h: (DOM::DomShared::deleteMe):
  • khtml/dom/dom_node.h: (DOM::Node::):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading):
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::focusNextPrevNode):
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKHTMLPageCache.h:
  • kwq/KWQPointArray.h:

Dec 3, 2005:

5:22 PM Changeset in webkit [11429] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/4364302> leftmargin and topmargin
should match marginwidth and marginheight respectively

  • fast/block/positioning/leftmargin-topmargin-expected.txt: Added.
  • fast/block/positioning/leftmargin-topmargin.html: Added.
5:21 PM Changeset in webkit [11428] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4364302> leftmargin and topmargin should match
marginwidth and marginheight respectively

Layout test added:
positioning/leftmargin-topmargin-expected.txt
positioning/leftmargin-topmargin.html

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Merged leftmargin/marginwidth, topmargin/marginheight
4:53 PM Changeset in webkit [11427] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

Reviewed by darin

  • editing/selection/expanding-selections-expected.checksum: Added.
  • editing/selection/expanding-selections-expected.png: Added.
  • editing/selection/expanding-selections-expected.txt: Added.
  • editing/selection/expanding-selections.html: Added.
  • editing/selection/expanding-selections2-expected.checksum: Added.
  • editing/selection/expanding-selections2-expected.png: Added.
  • editing/selection/expanding-selections2-expected.txt: Added.
  • editing/selection/expanding-selections2.html: Added.
4:48 PM Changeset in webkit [11426] by justing
  • 3 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

validate() used to do expansion of the selection. The expansion
itself wasn't validated, so it could create a selection
that extended outside an editable area. Also m_base and
m_extent weren't updated with the results of the expansion.

Reviewed by darin

Layout tests added:

  • editing/selection/expanding-selections
  • editing/selection/expanding-selections2
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::expandUsingGranularity): Does the expansion. (khtml::SelectionController::validate): Removed the granularity parameter.
  • khtml/editing/SelectionController.h:
4:32 PM Changeset in webkit [11425] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
show up wrong size (with scroll bars)

We had the wrong default features for new windows. The IE rule is:
all features except for channelmode and fullscreen default to YES, but
if the user specifies a feature string, all features default to NO.
(There is no public standard that applies to this method.)

<​http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>

No test case because testing requires a call to window.open, which
DumpRenderTree can't simulate.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs):
12:26 PM Changeset in webkit [11424] by andersca
  • 5 edits in trunk/WebCore/khtml

Didn't mean to commit this.

12:16 PM Changeset in webkit [11423] by andersca
  • 11 edits
    1 add in trunk/WebCore

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Update calls to append functions to set the enabled state of items.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): (QComboBox::appendGroupLabel): (QComboBox::appendSeparator): Add enabled parameter to append functions.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Don't autoenable menu items on the popup button since that's handled manually now.

(QComboBox::setTitle):
Set enabled state on menu items.

(QComboBox::appendItem):
Add enabled parameter.

  • kwq/KWQListBox.h: (KWQListBoxItem::KWQListBoxItem): Add enabled variable to item struct.

(QListBox::appendItem):
(QListBox::appendGroupLabel):
Add enabled parameter to append functions.

  • kwq/KWQListBox.mm: (QListBox::appendItem): Add enabled parameter.

(-[KWQTableView tableView:shouldSelectRow:]):
Only select the row if the item is enabled.

(-[KWQTableView drawRow:clipRect:]):
Draw using the disabled color if the row is disabled.

  • manual-tests/disabled-option-elements.html: Added.
8:56 AM Changeset in webkit [11422] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Improved ChangeLog comment.

Note: See TracTimeline for information about the timeline view.