⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 8, 2005:

8:10 PM Changeset in webkit [11506] by adele
  • 6 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

  • fixed <rdar://problem/4363794> 10.4.4 REGRESSION: Page scroll position jumps when clicking on word in editable div (5911) setFocusNode was trying to scroll to reveal elements unnecessarily. Now the callers have to decide whether or not to scroll.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): No longer calls scrolling code.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now calls scrolling code after setting the focus node.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Moved functionality from Element::focus. Now these functions also call scrolling code. (ElementImpl::blur): ditto.
  • khtml/xml/dom_elementimpl.h: Added focus and blur.
  • khtml/dom/dom_element.cpp: (Element::focus): Now calls ElementImpl::focus (Element::blur): ditto.
6:12 PM Changeset in webkit [11505] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Some cleanup of how selection rects are associated with NSViews.

  • WebView.subproj/WebDocumentPrivate.h: Added a -selectionView method to <WebDocumentSelection>, and clarified that the selectionRect is in the coordinate system of this view.
  • Misc.subproj/WebSearchableTextView.m: (-[WebSearchableTextView selectionView]): new method, returns self
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView selectionView]): new method, returns self
  • WebView.subproj/WebPDFView.m: (-[WebPDFView selectionRect]): translate result into coordinate system of [PDFSubview documentView] (-[WebPDFView selectionView]): new method, returns [PDFSubview documentView]
6:10 PM Changeset in webkit [11504] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4311703> Crash in NPN_Invoke receiving contents of ​http://www.woodieschilidogs.com/ in Mail.app

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptNPObject): The window script object can be 0 if JavaScript is disabled. However, callers (like plugins) expect us to always return a window script object here. By substituting a plain ObjectImp for the window's ObjectImp, we can satisfy callers' assumptions and let them try to manipulate the dummy object when JavaScript is disabled.
4:06 PM Changeset in webkit [11503] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick and Dave Hyatt.

  • fixed these semi-legendary bugs: <rdar://problem/4032405> Inline PDF doesn't get keyboard focus like web pages do, so can't scroll with keys without clicking <rdar://problem/4265684> PDFs use secondary selection when displaying found text (4748)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView becomeFirstResponder]): Discovered that there is indeed PDFKit API for accessing the view that becomes focused; now passes the focus down to that view.
3:13 PM Changeset in webkit [11502] by tomernic
  • 5 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

Reviewed and landed by Maciej.

  • some simple changes that amount to a < 1% speedup.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):
  • kwq/KWQKURL.mm: (hasSlashDotOrDotDot):
  • kwq/KWQString.mm: (QString::~QString):
3:05 PM Changeset in webkit [11501] by tomernic
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch.

Bug #: none
Submitted by: timo
Reviewed by: eseidel & darin

Changed some of the run measurement methods to C functions
to avoid overhead associated with objc_msgSend().

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForRun:style:widths:]): Updated to call new run measurement functions instead of calling ObjC methods. (-[WebTextRenderer CG_drawRun:style:geometry:]): ditto (floatWidthForRun): ditto (CG_floatWidthForRun): ditto (ATSU_floatWidthForRun): ditto (widthForNextCharacter): ditto
2:22 PM Changeset in webkit [11500] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)"
crashed when going from the "Open a template" menu to "Select recent
Document" in the "Welcome to Corel XI!" window.

These are the parts of that bug fix that were not already fixed in TOT.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...]
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::sendFakeEventsAfterWidgetTracking): Allow for the event not being leftmousedown or keydown
1:44 PM Changeset in webkit [11499] by harrison
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)" crashed
when going from the "Open a template" menu to "Select recent Document" in the
"Welcome to Corel XI!" window.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...].
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): Check isWidget() rather than using a dynamic_cast to RenderPart*.

(KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown.

11:44 AM Changeset in webkit [11498] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

  • Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy, in order to start addressing keyboard focus and selection highlight issues. Unfortunately this doesn't actually have any user effect yet due to problems that must be fixed in PDFKit.
  • WebView.subproj/WebPDFView.m: (-[WebPDFView acceptsFirstResponder]): Overridden to returns YES. Needed so NSClipView knows it's OK to pass focus down to this level. (-[WebPDFView becomeFirstResponder]): With setNextKeyView:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView setNextKeyView:]): With becomeFirstResponder:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView resignFirstResponder]): Removed this method because the WebPDFView itself is never first responder except transiently.
10:33 AM Changeset in webkit [11497] by mjs
  • 7 edits in trunk/WebKit

Reviewed by John.

  • some small changes towards frame tree refactoring

Renamed WebViewSets to WebFrameNamespaces, and put the method for
performing a selector on all extant WebViews to WebView itself,
with a separate set tracking live WebViews. This should allow
moving the storage of this info down to WebCore more easily.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge closeWindowSoon]): (-[WebBridge runModal]):
  • WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory refreshPlugins:]):
  • WebView.subproj/WebControllerSets.h:
  • WebView.subproj/WebControllerSets.m: (+[WebFrameNamespaces addWebView:toFrameNamespace:]): (webView::if): (+[WebFrameNamespaces webViewsInFrameNamespace:]):
  • WebView.subproj/WebView.m: (+[WebView _makeAllWebViewsPerformSelector:]): (-[WebView _removeFromAllWebViewsSet]): (-[WebView _addToAllWebViewsSet]): (-[WebView _close]): (-[WebView _findFrameNamed:sourceFrame:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setGroupName:]):
  • WebView.subproj/WebViewInternal.h:
10:19 AM Changeset in webkit [11496] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by John.

  • fix major memory leak and resultant slowdown on JavaScript iBench from my PassRefPtr changes
  • kjs/ustring.cpp: (KJS::UString::Rep::create): I forgot to change one of the two overloads to create with a refcount of 0 instead of 1 (the smart pointer then bumps it. But instead of changing it, I changed both to start with a refcounter of 1 and use PassRefPtr::adopt to adopt the initial refcount, this may be a hair more efficient.
  • made the assignment operators for smart pointers inline because Shark said so
  • kxmlcore/PassRefPtr.h: (KXMLCore::::operator=):
  • kxmlcore/RefPtr.h: (KXMLCore::::operator=):
2:20 AM Changeset in webkit [11495] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5997
Submitted by: mitz
Reviewed by: eseidel

No test possible since this fixes random behavior.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5997
REGRESSION: Focus rings around links are not erased when focus is lost

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_inDetach to false.
1:30 AM Changeset in webkit [11494] by eseidel
  • 17 edits in trunk/LayoutTests

Bug #: 5987
Submitted by: eseidel
Reviewed by: darin

Fixes <applet> in xhtml, as well as <use> in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
1:17 AM Changeset in webkit [11493] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5987
Submitted by: eseidel
Reviewed by: darin

No applet test (mjs says DRT has kittens in that case)
SVG is covered by <use> test cases (5 tests).

Fixes <applet> in xhtml, as well as <use> in SVG.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5987

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::endElementNs): call closeRenderer()
12:54 AM Changeset in webkit [11492] by darin
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/misc/shared.h: Rewrote both Shared and TreeShared to be functionally the same, but used signed reference counts and remove the extra check inside deref that handles the case of extra derefs (a programming mistake in any case). This elimnates a branch from a hot code path. Also added license header. New versions have private data members, unlike the old ones that used protected.
  • khtml/rendering/render_replaced.h: Removed private inheritance from Shared, and instead just declared a variable that holds a reference count, because that's the only thing that was being used from Shared.
  • khtml/rendering/render_replaced.cpp: (RenderWidget::RenderWidget): Initialized m_refCount. (RenderWidget::~RenderWidget): Use m_refCount. (RenderWidget::eventFilter): Ditto. (RenderWidget::deref): Use m_refCount and the new faster idiom (although here it's not important becaue the function isn't even inlined).
12:44 AM Changeset in webkit [11491] by eseidel
  • 5 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none, svg build fix only.

  • ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue): parseShorthand rename
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: missing header
  • ksvg2/svg/SVGFELightElementImpl.cpp: missing header
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: missing header
12:40 AM Changeset in webkit [11490] by darin
  • 20 edits in trunk

WebCore:

Reviewed by Eric.

  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added code to the CSS_PROP_CURSOR case to handle cursor images.
  • khtml/css/cssparser.cpp: (CSSParser::parseValue): Allow and parse a URL for the cursor for the image case.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Do the appropriate inherit and initial for CSS_PROP_CURSOR, and allow either an identifier or a URL for the value.
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::defaultEventHandler): Removed inappropriate call to resetCursor. We don't change the cursor shape just because we're following a link.
  • khtml/khtmlview.cpp: (selectCursor): Added. New function that chooses the appropriate cursor. Includes new logic to handle image cursors. (KHTMLView::viewportMouseMoveEvent): Refactored to use selectCursor to choose the appropriate cursor.
  • kwq/KWQClipboard.mm: (KWQClipboard::dragNSImage): Call the function to get an image renderer by its new name, imageRenderer().
  • kwq/KWQCursor.mm: (createCustomCursor): Added. (QCursor::QCursor): Changed constructor that takes a QPixmap to call createCustomCursor.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): Replaced a call to resetCursor with a call to setCursor(QCursor()). (KWQKHTMLPart::fileWrapperForElement): Fixed code that assumed the render object is always a RenderImage. Call TIFFRepresentation on the image renderer instead of incorrectly assuming it's always an NSImage.
  • kwq/KWQPainter.mm: (QPainter::drawFloatPixmap): Call imageRenderer function instead of getting right at the data member. (QPainter::drawTiledPixmap): Ditto. (QPainter::drawScaledAndTiledPixmap): Ditto.
  • kwq/KWQPixmap.h: Removed convertToImage(), renamed image() to imageRenderer().
  • kwq/KWQPixmap.mm: Similar name changes.
  • kwq/KWQWidget.mm: (QWidget::setCursor): To workaround extra work done by AppKit when you set the cursor to the same one, check if the cursor is already set before calling setDocumentCursor.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Call the image method on the image renderer instead of incorrectly assuming the renderer itself is an image.
  • kwq/WebCoreImageRenderer.h: Added a TIFFRepresentation method to this protocol.

WebKit:

Reviewed by Eric.

  • WebCoreSupport.subproj/WebImageRenderer.h: Remove declaration of TIFFRepresentation and image methods since both are required by the WebCoreImageRenderer protocol now and we don't have to re-declare them.
  • Misc.subproj/WebNSPasteboardExtras.m: Add an import of the WebCoreImageRenderer.h file since we need to use methods inherited from that protocol.
  • Misc.subproj/WebNSViewExtras.m: Ditto.
  • WebCoreSupport.subproj/WebImageRenderer.m: Ditto. (Use and implement.)

Dec 7, 2005:

11:42 PM Changeset in webkit [11489] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Landed by Darin.

  • fast/text/atsui-pointtooffset-calls-cg-expected.checksum: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.png: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • fast/text/atsui-pointtooffset-calls-cg.html: Added.
11:41 PM Changeset in webkit [11488] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): Added the missing "return".
4:19 PM Changeset in webkit [11487] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView] @ home.netscape.com
  • WebView.subproj/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assert that I added a while back. In this case at least, the assertion is overzealous, and I can't recreate the tortured chain of logic that led me to adding this assertion in the first place.
3:19 PM Changeset in webkit [11486] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Add Radar bug # to an old commit.

2:48 PM Changeset in webkit [11485] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar bug #4333923, typing tab character into empty
document in Mail doesn't work. This was just a silly regression
from my pre-wrap/pre-line implementation. I accidentally changed
code to examine the wrong style().

Reviewed by harrison

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
1:24 PM Changeset in webkit [11484] by hyatt
  • 2 edits in trunk/WebCore

Fix the DHTML menus on monster.com. offsetParent should only return RenderObjects that
have corresponding DOM elements.

Reviewed by Eric Seidel

  • khtml/rendering/render_object.cpp: (RenderObject::offsetParent):
2:31 AM Changeset in webkit [11483] by eseidel
  • 1 edit
    2 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed.

Removing unused files.

  • kcanvas/KCanvasRegistry.cpp: Removed.
  • kcanvas/KCanvasRegistry.h: Removed.
Note: See TracTimeline for information about the timeline view.