⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 11, 2005:

8:23 PM Changeset in webkit [11534] by eseidel
  • 1 edit
    6 adds in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: none

Adding pixel results omitted from previous commits.

  • fast/block/positioning/leftmargin-topmargin-expected.checksum: Added.
  • fast/block/positioning/leftmargin-topmargin-expected.png: Added.
  • fast/clip/017-expected.checksum: Added.
  • fast/clip/017-expected.png: Added.
  • fast/inspector/style-expected.checksum: Added.
  • fast/inspector/style-expected.png: Added.
8:15 PM Changeset in webkit [11533] by eseidel
  • 1 edit
    3 adds in trunk/LayoutTests

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Adding resources overlooked in previous commit.

  • fast/xsl/resources/xslt-extra-content-at-end.xsl: Added.
  • fast/xsl/resources/xslt-mismatched-tags-in-xslt.xsl: Added.
  • fast/xsl/resources/xslt-missing-namespace-in-xslt.xsl: Added.
3:47 AM Changeset in webkit [11532] by eseidel
  • 1 edit
    28 adds in trunk/LayoutTests

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Fixes SVG to load external scripts and report parse errors.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5875

Added 7 layout tests to exercise parse error code.

  • fast/invalid/junk-data-expected.checksum: Added.
  • fast/invalid/junk-data-expected.png: Added.
  • fast/invalid/junk-data-expected.txt: Added.
  • fast/invalid/junk-data.xml: Added.
  • fast/invalid/missing-end-tag-expected.checksum: Added.
  • fast/invalid/missing-end-tag-expected.png: Added.
  • fast/invalid/missing-end-tag-expected.txt: Added.
  • fast/invalid/missing-end-tag.xhtml: Added.
  • fast/xsl/xslt-extra-content-at-end-expected.checksum: Added.
  • fast/xsl/xslt-extra-content-at-end-expected.png: Added.
  • fast/xsl/xslt-extra-content-at-end-expected.txt: Added.
  • fast/xsl/xslt-extra-content-at-end.xml: Added.
  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.checksum: Added.
  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Added.
  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Added.
  • fast/xsl/xslt-mismatched-tags-in-xslt.xml: Added.
  • fast/xsl/xslt-missing-namespace-in-xslt-expected.checksum: Added.
  • fast/xsl/xslt-missing-namespace-in-xslt-expected.png: Added.
  • fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Added.
  • fast/xsl/xslt-missing-namespace-in-xslt.xml: Added.
  • svg/custom/junk-data-expected.checksum: Added.
  • svg/custom/junk-data-expected.png: Added.
  • svg/custom/junk-data-expected.txt: Added.
  • svg/custom/junk-data.svg: Added.
  • svg/custom/missing-xlink-expected.checksum: Added.
  • svg/custom/missing-xlink-expected.png: Added.
  • svg/custom/missing-xlink-expected.txt: Added.
  • svg/custom/missing-xlink.svg: Added.
3:42 AM Changeset in webkit [11531] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs

Fixes SVG to load external scripts and report parse errors.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5875

Added 7 layout tests to exercise parse error code.

  • khtml/xml/xml_tokenizer.cpp: (khtml::createXHTMLParserErrorHeader): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts):
  • ksvg2/svg/SVGStyledElementImpl.h: removed broken code
  • ksvg2/svg/SVGStyledElementImpl.cpp: removed broken attach()
1:28 AM Changeset in webkit [11530] by eseidel
  • 2 edits
    4 adds in trunk/LayoutTests

Bug #: 5999
Submitted by: eseidel
Reviewed by: hyatt

Small fixes made during SVG code review.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5999

  • svg/custom/conditional-processing-outside-switch-expected.checksum: Added.
  • svg/custom/conditional-processing-outside-switch-expected.png: Added.
  • svg/custom/conditional-processing-outside-switch-expected.txt: Added.
  • svg/custom/conditional-processing-outside-switch.svg: Added.
  • svg/custom/simpleCDF-expected.txt:
1:26 AM Changeset in webkit [11529] by eseidel
  • 24 edits in trunk/WebCore

Bug #: 5999
Submitted by: eseidel
Reviewed by: hyatt

Small fixes made during SVG code review.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5999

One test case added for conditional processing directives
used outside of switch statements.

  • WebCore+SVG/DrawDocument.mm: (-[DrawView description]):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEGaussianBlurQuartz::getCIFilter):
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::loadDefaultStyle): (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::retrieveWindow): (KJS::Window::retrieveActive):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
  • khtml/khtml_part.h:
  • khtml/rendering/DataRef.h: (khtml::DataRef::operator == ): (khtml::DataRef::operator != ):
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_object.h: (khtml::RenderObject::localTransform):
  • khtml/rendering/render_style.cpp: (RenderStyle::diff):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): (DocumentImpl::createEvent):
  • khtml/xml/dom_elementimpl.cpp:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
  • ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue):
  • ksvg2/css/svg.css:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::childShouldCreateRenderer):
  • ksvg2/svg/SVGElementImpl.h: (KSVG::SVGElementImpl::isValid):

Dec 10, 2005:

11:28 PM Changeset in webkit [11528] by mjs
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • fix SVG build for recent QTimer changes.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::SVGTimer):
6:06 PM Changeset in webkit [11527] by darin
  • 134 edits in trunk

JavaScriptCore:

Rubber stamped by Maciej.

  • did long-promised KJS renaming:

ValueImp -> JSValue
ObjectImp -> JSObject
AllocatedValueImp -> JSCell

A renaming to get a class out of the way

KJS::Bindings::JSObject -> JavaJSObject

and some other "imp-reduction" renaming

*InstanceImp -> *Instance
*ProtoFuncImp -> *ProtoFunc
*PrototypeImp -> *Prototype
ArgumentsImp -> Arguments
RuntimeArrayImp -> RuntimeArray
RuntimeMethodImp -> RuntimeMethod

  • most files and functions

WebCore:

Rubber stamped by Maciej.

  • updated for KJS class renaming
  • many files and functions
6:03 PM Changeset in webkit [12219] by darin
  • 10 edits in trunk/JavaScriptGlue

Rubber stamped by Maciej.

  • updated for KJS class renaming
  • many files and functions
5:44 PM Changeset in webkit [11526] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin and Eric.

  • Makefile.am: Support --enable-svg
4:38 PM Changeset in webkit [11525] by darin
  • 53 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • bindings/NP_jsobject.cpp: (_NPN_Evaluate):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • bindings/c/c_runtime.cpp: (CField::valueFromInstance):
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JavaInstance::invokeDefaultMethod):
  • bindings/jni/jni_jsobject.cpp: (JSObject::eval): (JSObject::convertJObjectToValue):
  • bindings/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaArray::valueAt):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject webScriptValueAtIndex:]):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcFallbackObjectImp::callAsFunction):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertNSStringToString): (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.h: (KJS::Bindings::Class::fallbackObject): (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::valueOf):
  • bindings/runtime_array.cpp: (RuntimeArrayImp::lengthGetter):
  • bindings/runtime_method.cpp: (RuntimeMethodImp::lengthGetter): (RuntimeMethodImp::callAsFunction): (RuntimeMethodImp::execute):
  • kjs/array_object.cpp: (ArrayInstanceImp::lengthGetter): (CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments): (ArrayPrototypeImp::ArrayPrototypeImp): (ArrayProtoFuncImp::ArrayProtoFuncImp): (ArrayProtoFuncImp::callAsFunction): (ArrayObjectImp::ArrayObjectImp):
  • kjs/bool_object.cpp: (BooleanPrototypeImp::BooleanPrototypeImp): (BooleanProtoFuncImp::callAsFunction): (BooleanObjectImp::BooleanObjectImp): (BooleanObjectImp::callAsFunction):
  • kjs/error_object.cpp: (ErrorPrototypeImp::ErrorPrototypeImp): (ErrorProtoFuncImp::ErrorProtoFuncImp): (ErrorProtoFuncImp::callAsFunction): (ErrorObjectImp::ErrorObjectImp): (NativeErrorImp::NativeErrorImp):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::DeclaredFunctionImp::execute): (KJS::encode): (KJS::decode): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionPrototypeImp::FunctionPrototypeImp): (FunctionPrototypeImp::callAsFunction): (FunctionProtoFuncImp::callAsFunction): (FunctionObjectImp::FunctionObjectImp):
  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject):
  • kjs/interpreter.h:
  • kjs/lookup.h:
  • kjs/math_object.cpp: (MathObjectImp::getValueProperty): (MathFuncImp::callAsFunction):
  • kjs/nodes.cpp: (Node::setExceptionDetailsIfNeeded): (NullNode::evaluate): (PropertyNode::evaluate): (FunctionCallBracketNode::evaluate): (FunctionCallDotNode::evaluate): (PostfixBracketNode::evaluate): (PostfixDotNode::evaluate): (VoidNode::evaluate): (PrefixBracketNode::evaluate): (PrefixDotNode::evaluate): (ShiftNode::evaluate): (valueForReadModifyAssignment): (AssignDotNode::evaluate): (AssignBracketNode::evaluate): (VarDeclNode::evaluate): (VarDeclNode::processVarDecls): (VarDeclListNode::evaluate): (ReturnNode::execute): (CaseClauseNode::evalStatements): (ParameterNode::evaluate): (FuncDeclNode::processFuncDecl):
  • kjs/nodes.h: (KJS::StatementNode::evaluate):
  • kjs/number_object.cpp: (NumberPrototypeImp::NumberPrototypeImp): (NumberProtoFuncImp::callAsFunction): (NumberObjectImp::NumberObjectImp): (NumberObjectImp::getValueProperty): (NumberObjectImp::callAsFunction):
  • kjs/object.cpp: (KJS::ObjectImp::get): (KJS::Error::create):
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::callAsFunction): (ObjectObjectImp::ObjectObjectImp):
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter):
  • kjs/regexp_object.cpp: (RegExpPrototypeImp::RegExpPrototypeImp): (RegExpProtoFuncImp::callAsFunction): (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::arrayOfMatches): (RegExpObjectImp::getBackref): (RegExpObjectImp::getLastMatch): (RegExpObjectImp::getLastParen): (RegExpObjectImp::getLeftContext): (RegExpObjectImp::getRightContext): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::construct):
  • kjs/string_object.cpp: (StringInstanceImp::StringInstanceImp): (StringPrototypeImp::StringPrototypeImp): (replace): (StringProtoFuncImp::callAsFunction): (StringObjectImp::StringObjectImp): (StringObjectImp::callAsFunction): (StringObjectFuncImp::StringObjectFuncImp): (StringObjectFuncImp::callAsFunction):
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): (VersionFunctionImp::callAsFunction):
  • kjs/value.h:

WebCore:

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
  • khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrNull): (KJS::setDOMException):
  • khtml/ecma/kjs_binding.h: (KJS::DOMFunction::toPrimitive):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMCSSStyleDeclaration::getValueProperty): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::DOMStyleSheet::getValueProperty): (KJS::getDOMStyleSheet): (KJS::DOMStyleSheetList::getValueProperty): (KJS::getDOMStyleSheetList): (KJS::DOMStyleSheetListFunc::callAsFunction): (KJS::DOMMediaList::getValueProperty): (KJS::DOMMediaList::indexGetter): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): (KJS::DOMCSSStyleSheet::getValueProperty): (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction): (KJS::DOMCSSRuleList::getValueProperty): (KJS::DOMCSSRuleListFunc::callAsFunction): (KJS::DOMCSSRule::getValueProperty): (KJS::DOMCSSRuleFunc::callAsFunction): (KJS::CSSRuleConstructor::getValueProperty): (KJS::DOMCSSValue::getValueProperty): (KJS::getDOMCSSValue): (KJS::CSSValueConstructor::getValueProperty): (KJS::DOMCSSPrimitiveValue::getValueProperty): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction): (KJS::CSSPrimitiveValueConstructor::getValueProperty): (KJS::DOMCSSValueList::getValueProperty): (KJS::DOMCSSValueListFunc::callAsFunction): (KJS::DOMCounter::getValueProperty):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::getListener): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::toPrimitive): (KJS::DOMNodeList::getValueProperty): (KJS::DOMNodeList::callAsFunction): (KJS::DOMAttr::getValueProperty): (KJS::DOMDocument::getValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::getValueProperty): (KJS::DOMElement::attributeGetter): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::DOMDOMImplementationProtoFunc::callAsFunction): (KJS::DOMDocumentType::getValueProperty): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::DOMProcessingInstruction::getValueProperty): (KJS::DOMNotation::getValueProperty): (KJS::DOMEntity::getValueProperty): (KJS::getDOMNode): (KJS::NodeConstructor::getValueProperty): (KJS::DOMExceptionConstructor::getValueProperty): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMCharacterData::getValueProperty): (KJS::DOMCharacterDataProtoFunc::callAsFunction): (KJS::DOMTextProtoFunc::callAsFunction):
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode): (KJS::EventConstructor::getValueProperty): (KJS::DOMEvent::getValueProperty): (KJS::DOMEventProtoFunc::callAsFunction): (KJS::getDOMEvent): (KJS::EventExceptionConstructor::getValueProperty): (KJS::DOMUIEvent::getValueProperty): (KJS::DOMUIEventProtoFunc::callAsFunction): (KJS::DOMMouseEvent::getValueProperty): (KJS::DOMMouseEventProtoFunc::callAsFunction): (KJS::DOMKeyboardEvent::getValueProperty): (KJS::DOMKeyboardEventProtoFunc::callAsFunction): (KJS::MutationEventConstructor::getValueProperty): (KJS::DOMMutationEvent::getValueProperty): (KJS::DOMMutationEventProtoFunc::callAsFunction): (KJS::DOMWheelEvent::getValueProperty): (KJS::DOMWheelEventProtoFunc::callAsFunction): (KJS::stringOrUndefined): (KJS::Clipboard::getValueProperty): (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::callAsFunction): (KJS::HTMLDocument::getValueProperty): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::KJS::HTMLElement::callAsFunction): (KJS::HTMLElement::htmlGetter): (KJS::HTMLElement::headGetter): (KJS::HTMLElement::linkGetter): (KJS::HTMLElement::titleGetter): (KJS::HTMLElement::metaGetter): (KJS::HTMLElement::baseGetter): (KJS::HTMLElement::isIndexGetter): (KJS::HTMLElement::styleGetter): (KJS::HTMLElement::bodyGetter): (KJS::HTMLElement::formGetter): (KJS::HTMLElement::selectGetter): (KJS::HTMLElement::optGroupGetter): (KJS::HTMLElement::optionGetter): (KJS::getInputSelectionStart): (KJS::getInputSelectionEnd): (KJS::HTMLElement::inputGetter): (KJS::HTMLElement::textAreaGetter): (KJS::HTMLElement::buttonGetter): (KJS::HTMLElement::labelGetter): (KJS::HTMLElement::fieldSetGetter): (KJS::HTMLElement::legendGetter): (KJS::HTMLElement::uListGetter): (KJS::HTMLElement::oListGetter): (KJS::HTMLElement::dListGetter): (KJS::HTMLElement::dirGetter): (KJS::HTMLElement::menuGetter): (KJS::HTMLElement::liGetter): (KJS::HTMLElement::divGetter): (KJS::HTMLElement::paragraphGetter): (KJS::HTMLElement::headingGetter): (KJS::HTMLElement::blockQuoteGetter): (KJS::HTMLElement::quoteGetter): (KJS::HTMLElement::preGetter): (KJS::HTMLElement::brGetter): (KJS::HTMLElement::baseFontGetter): (KJS::HTMLElement::fontGetter): (KJS::HTMLElement::hrGetter): (KJS::HTMLElement::modGetter): (KJS::HTMLElement::anchorGetter): (KJS::HTMLElement::imageGetter): (KJS::HTMLElement::objectGetter): (KJS::HTMLElement::paramGetter): (KJS::HTMLElement::appletGetter): (KJS::HTMLElement::mapGetter): (KJS::HTMLElement::areaGetter): (KJS::HTMLElement::scriptGetter): (KJS::HTMLElement::tableGetter): (KJS::HTMLElement::tableCaptionGetter): (KJS::HTMLElement::tableColGetter): (KJS::HTMLElement::tableSectionGetter): (KJS::HTMLElement::tableRowGetter): (KJS::HTMLElement::tableCellGetter): (KJS::HTMLElement::frameSetGetter): (KJS::HTMLElement::frameGetter): (KJS::HTMLElement::iFrameGetter): (KJS::HTMLElement::marqueeGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElementFunction::HTMLElementFunction): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::HTMLCollection::lengthGetter): (KJS::KJS::HTMLCollection::callAsFunction): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::HTMLSelectCollection::selectedIndexGetter): (KJS::HTMLSelectCollection::getOwnPropertySlot): (KJS::OptionConstructorImp::OptionConstructorImp): (KJS::Image::getValueProperty): (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::getValueProperty): (KJS::Context2D::Context2D): (KJS::GradientFunction::callAsFunction): (KJS::Gradient::getValueProperty): (KJS::ImagePattern::getValueProperty): (KJS::getSelectHTMLCollection):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::Plugins::getValueProperty): (KJS::Plugins::nameGetter): (KJS::MimeTypes::getValueProperty): (KJS::MimeTypes::nameGetter): (KJS::Plugin::getValueProperty): (KJS::Plugin::nameGetter): (KJS::MimeType::getValueProperty): (KJS::PluginsFunc::callAsFunction): (KJS::NavigatorFunc::callAsFunction):
  • khtml/ecma/kjs_proxy.cpp: (TestFunctionImp::callAsFunction):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction): (KJS::RangeConstructor::getValueProperty):
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::getValueProperty): (KJS::DOMNodeIteratorProtoFunc::callAsFunction): (KJS::NodeFilterConstructor::getValueProperty): (KJS::DOMNodeFilterProtoFunc::callAsFunction): (KJS::DOMTreeWalker::getValueProperty): (KJS::DOMTreeWalkerProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::Window::retrieve): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::Location::getValueProperty): (KJS::Location::toPrimitive): (KJS::LocationFunc::callAsFunction): (KJS::Selection::getValueProperty): (KJS::Selection::toPrimitive): (KJS::SelectionFunc::callAsFunction): (KJS::BarInfo::getValueProperty): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::getAllResponseHeaders): (KJS::XMLHttpRequest::getResponseHeader): (KJS::XMLHttpRequest::getStatus): (KJS::XMLHttpRequest::getStatusText): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
  • ksvg2/ecma/Ecma.cpp: (KSVG::getSVGPathSeg):
  • ksvg2/ecma/GlobalObject.cpp: (GlobalObject::get):
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
4:35 PM Changeset in webkit [12218] by darin
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

  • eliminated the old Undefined(), Null(), Boolean(), Number(), and String()

Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().

  • JSUtils.cpp: (JSObjectKJSValue):
  • UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::toPrimitive):
4:07 PM Changeset in webkit [11524] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin and Tim Hatcher.

  • fix WebCore SVG build for gcc 3.3 (don't know why it has these complaints)
  • kcanvas/KCanvasFilters.h: (QPointF::QPointF): Add a default constructor (KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix): ditto
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEBlendQuartz::getCIFilter): Move a variable declaration instead exception blocking (KCanvasFECompositeQuartz::getCIFilter): ditto (KCanvasFEMergeQuartz::getCIFilter): ditto
12:40 PM Changeset in webkit [11523] by darin
  • 7 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • WebCore.exp: Export the new WebCoreElementImageRendererKey and remove the old WebCoreElementImageKey.
  • kwq/WebCoreBridge.h: Add WebCoreElementImageRendererKey, remove WebCoreElementImageKey.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Pass the image renderer in the dictionary, but not the NSImage.

WebKit:

Reviewed by John Sullivan.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Pass the image renderer, not the NSImage. (-[WebHTMLView elementAtPoint:]): Add an NSImage to the dictionary, which now comes from WebCore with only an image renderer.
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]): Pass the image renderer, not the NSImage.
12:34 PM Changeset in webkit [11522] by darin
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6029
plainText() returns a partial result when the node contains RTL text

  • fast/dom/inner-text-rtl-expected.txt: Added.
  • fast/dom/inner-text-rtl.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/dom/inner-text-rtl.html

  • khtml/editing/visible_text.cpp: (khtml::TextIterator::handleTextBox): Avoid advancing m_sortedTextBoxes if textBoxEnd wasn't reached.
  • kwq/KWQListImpl.h:
  • kwq/KWQListImpl.mm: (KWQListImpl::getNext): Added. (KWQListImpl::getPrev): Added.
  • kwq/KWQPtrList.h: (QPtrList::getNext): Added. (QPtrList::getPrev): Added.
12:21 PM Changeset in webkit [11521] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5826

  • fast/overflow/overflow-rtl-expected.checksum: Added.
  • fast/overflow/overflow-rtl-expected.png: Added.
  • fast/overflow/overflow-rtl-expected.txt: Added.
  • fast/overflow/overflow-rtl.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::leftmostPosition):
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::RenderLayer): Initialize (khtml::RenderLayer::scrollOffset): (khtml::RenderLayer::subtractScrollOffset): (khtml::RenderLayer::scrollToOffset): (khtml::RenderLayer::scrollRectToVisible): (khtml::RenderLayer::updateScrollPositionFromScrollbars): (khtml::RenderLayer::computeScrollDimensions): (khtml::RenderLayer::updateScrollInfoAfterLayout):
  • khtml/rendering/render_layer.h: (khtml::RenderLayer::scrollXOffset): (khtml::RenderLayer::scrollToYOffset):
11:56 AM Changeset in webkit [11520] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3983

  • fast/css/outline-auto-location-expected.checksum: Added.
  • fast/css/outline-auto-location-expected.png: Added.
  • fast/css/outline-auto-location-expected.txt: Added.
  • fast/css/outline-auto-location.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): Only add the rect if this is a RenderBlock.
11:05 AM Changeset in webkit [11519] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej, landed by Darin.

  • kjs/array_object.cpp: (ArrayProtoFuncImp::callAsFunction): Added set of visited objects -- don't recurse if item is already in the set.

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3539

  • fast/js/cyclic-ref-toString-expected.txt: Added.
  • fast/js/cyclic-ref-toString.html: Added.
10:56 AM Changeset in webkit [11518] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

New layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5784

  • fast/parser/duplicate-html-body-element-IDs-expected.txt: Added.
  • fast/parser/duplicate-html-body-element-IDs.html: Added.

WebCore:

Reviewed and landed by Darin.

Added a new layout test that checks for at least one symptom of the bug.

  • khtml/html/htmlparser.cpp: (HTMLParser::handleError): Use setAttribute here instead of using insertAttribute and calling recalcStyle explicitly. That's because setAttribute does other things that are needed to change an attribute in an attribute map that's already connected to an element, including updating the ID map if the attribute is the ID attribute.
  • khtml/xml/dom_elementimpl.h: (DOM::NamedAttrMapImpl::insertAttribute): Assert that this parser-only function is only used on attribute maps that aren't yet attached to elements.
9:14 AM Changeset in webkit [11517] by darin
  • 12 edits in trunk/WebCore

Reviewed by Eric and Tim Omernick.

  • kwq/KWQObject.h: Removed pauseTimer, resumeTimers, and _addTimer, added timerIntervals and restartTimer. Made KWQObjectSenderScope functions be inline.
  • kwq/KWQObject.mm: (timerFired): Added. Function called when the CFRunLoopTimerRef fires. Puts the timer into the deferred timer array if timers are deferred, otherwise makes a QTimerEvent and calls timerEvent on the target. (QObject::startTimer): Moved most of the code inside restartTimer. This now just picks a new timer ID and calls restartTimer. (QObject::restartTimer): Added. Creates a KWQObjectTimer and puts it in a timers dictionary. That includes creating a CFRunLoopTimer and scheduling it on the current run loop. (QObject::timerIntervals): Added. Looks up a timer and returns the intervals for next time to fire and the "fire again" interval. (deleteTimer): Added. Invalidates and then removes a timer. (QObject::killTimer): Changed to use deleteTimer to do most of its work. (deleteOneTimer): Added. Calls deleteTimer. (QObject::killTimers): Changed to use deleteOneTimer to do most of its work. (sendDeferredTimerEvent): Added. Creates a QTimerEvent and calls timerEvent on the target. (sendDeferredTimerEvents): Added. Calls sendDeferredTimerEvent in a loop on all the deferred timers. (QObject::setDefersTimers): Updated to call sendDeferredTimerEvents as needed.
  • kwq/KWQTimer.h: (QTimer::QTimer): Made constructor inline and removed the optional parameter. (QTimer::isActive): Made inline. (QTimer::fireDate): Added. Inline function. Got rid of the NSTimer and added a CFRunLoopTimer.
  • kwq/KWQTimer.mm: (timerFired): Added. Calls fire on the QTimer object. (QTimer::start): Changed to create a CFRunLoopTimer. (QTimer::stop): Changed to use CFRunLoopTimer functions. (QTimer::fire): Ditto.
  • khtml/ecma/kjs_window.h: Added PausedTimeouts class. Moved WindowQObject class up in the file so it can be used inline in the implementation of the Window class, and changed to use the PausedTimeouts class intead of a QMap to store the paused timeouts.
  • khtml/ecma/kjs_window.cpp: (KJS::ScheduledAction::execute): Put a check for nil part at the start; this replaces a check in the caller and a check partway down this function (after the part was already dereferenced). Fixed message handling so the message is not converted to ascii and back. Added an isObject() check so we won't crash if the passed function is a value that's not an object. Changed check for function vs. script to check for a function of nil instead of using a separate boolean. (KJS::WindowQObject::pauseTimeouts): Updated to create the new PausedTimeouts object, using the new QObject::timerIntervals function rather than the old QObject::pauseTimer function. This means that the paused timers are entirely stored in the PausedTimeouts object instead of being half in a QMap and the other half inside the QObject itself. (KJS::WindowQObject::resumeTimeouts): Ditto, using the new QObject::restartTimer function. (KJS::PausedTimeouts::~PausedTimeouts): Added. Deletes the stored timeouts, including the scheduled actions, unless the timeouts have already been resumed (in which case the m_array field will be 0).
  • kwq/KWQKHTMLPart.h: Renamed pause/resumeActions to pause/resumeTimeouts and made them use the PausedTimeouts class and no longer take a key parameter.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::redirectionTimerStartedOrStopped): Use the new fireDate() function rathe than the old getNSTimer() function to get the fire date. (KWQKHTMLPart::pauseTimeouts): Remove the call to hasTimeouts and the key parameter. (KWQKHTMLPart::resumeTimeouts): Remove the key parameter. (KWQKHTMLPart::openURLFromPageCache): Change the timeout handling to use PausedTimeouts instead of a QMap for the paused timeouts.
  • kwq/KWQPageState.h: Changed to use PausedTimeouts instead of a QMap for timeouts. Added a pausedTimeouts parameter to the initializer and removed the setPausedActions: method.
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:pausedTimeouts:]): Added code where it sets the pausedTimouts. (-[KWQPageState pausedTimeouts]): Added. (-[KWQPageState clear]): Added code to delete the pausedTimeouts and to deref mousePressNode. (-[KWQPageState invalidate]): Fixed bug where document would not be deref'd if the view was 0. (-[KWQPageState dealloc]): Removed code to deref mousePressNode since that's now handled in the clear method. (-[KWQPageState finalize]): Set document to 0 after deref for consistency.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge saveDocumentToPageCache]): Changed to pass in the paused timeouts using the new pauseTimeouts function.
7:27 AM Changeset in webkit [11516] by darin
  • 2 edits in trunk/WebKit

Was getting build failures related to "count" methods.
Made Tim's build fix Leopard-only.

  • WebView.subproj/WebPreferencesPrivate.h: Go back to <PDFKit/PDFKit.h> on Tiger.
Note: See TracTimeline for information about the timeline view.