Timeline
Dec 12, 2005:
- 8:39 PM Changeset in webkit [11560] by
-
- 3 edits in trunk/WebKit
Revised fix.
Reviewed by nobody, simple build fix.
Fixes a couple ambiguous selector build errors when building with GCC 3.3.
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]):
- WebView.subproj/WebHTMLView.m: (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSArray elementAtPoint:]):
- 6:01 PM Changeset in webkit [11559] by
-
- 4 edits in trunk/WebKit
Reviewed by nobody, simple build fix.
Fixes a couple ambiguous selector build errors when building with 3.3.
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]):
- WebCoreSupport.subproj/WebImageRenderer.h: Added missing methods for image and imageRef.
- WebView.subproj/WebHTMLView.m: (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSArray elementAtPoint:]):
- 5:50 PM Changeset in webkit [11558] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by harrison
- editing/selection/previous-line-position-expected.checksum: Added.
- editing/selection/previous-line-position-expected.png: Added.
- editing/selection/previous-line-position-expected.txt: Added.
- editing/selection/previous-line-position.html: Added.
- 5:50 PM Changeset in webkit [11557] by
-
- 2 edits in trunk/WebCore
Reviewed by harrison
<rdar://problem/4040763> VisiblePosition constructor can return a result outside of the original
This bug was filed as a reminder to remove the workaround for
<rdar://problem/4033202>. We fixed the problems with
VisiblePosition causing 4033202, so I removed the workaround
and added a layout test.
- khtml/editing/visible_units.cpp: (khtml::previousLinePosition):
- 5:36 PM Changeset in webkit [11556] by
-
- 2 edits8 adds in trunk/LayoutTests
<rdar://problem/4026906> Paste of HTML table content can break table structure
<rdar://problem/4027704> Paste of HTML list content can break list structure by dropping empty list items
- editing/pasteboard/block-wrappers-necessary.html:
Removed empty p tag.
- editing/pasteboard/paste-list-001-expected.checksum: Added.
- editing/pasteboard/paste-list-001-expected.png: Added.
- editing/pasteboard/paste-list-001-expected.txt: Added.
- editing/pasteboard/paste-list-001.html: Added.
- editing/pasteboard/paste-table-001-expected.checksum: Added.
- editing/pasteboard/paste-table-001-expected.png: Added.
- editing/pasteboard/paste-table-001-expected.txt: Added.
- editing/pasteboard/paste-table-001.html: Added.
- 5:28 PM Changeset in webkit [11555] by
-
- 3 edits in trunk/WebCore
Reviewed by Justin.
<rdar://problem/4027704> Paste of HTML list content can break list structure by dropping empty list items
Fixed by having ReplaceSelectionCommand remove empty nodes just
from the ancestors of the node(s) moved by mergeStart, rather
than scanning the whole fragment.
Layout tests added:
editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-list-001.html
- khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::isProbablyTableStructureNode): (khtml::ReplaceSelectionCommand::pruneEmptyNodes): Removed no longer needed functions.
(khtml::ReplaceSelectionCommand::doApply):
Remove ancestor nodes emptied by mergeStart.
Do that instead of calling pruneEmptyNodes().
- khtml/editing/replace_selection_command.h: (khtml::ReplacementFragment::desiredStyles): Removed pruneEmptyNodes().
- 4:35 PM Changeset in webkit [11554] by
-
- 2 edits in branches/Safari-1-3-branch/WebKit
Merged fix from TOT to Safari-1-3-branch
2005-12-06 David Harrison <harrison@apple.com>
Reviewed by Darin.
- fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields
Add use of NSAccessibilityHitTest to the list of exceptions.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
- 4:21 PM Changeset in webkit [11553] by
-
- 6 edits in branches/Safari-1-3-branch/WebCore
Merged fix from TOT to Safari-1-3-branch
2005-12-08 Adele Peterson <adele@apple.com>
Reviewed by Tim Hatcher.
- fixed <rdar://problem/4363794> 10.4.4 REGRESSION: Page scroll position jumps when clicking on word in editable div (5911) setFocusNode was trying to scroll to reveal elements unnecessarily. Now the callers have to decide whether or not to scroll.
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): No longer calls scrolling code.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now calls scrolling code after setting the focus node.
- khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Moved functionality from Element::focus. Now these functions also call scrolling code. (ElementImpl::blur): ditto.
- khtml/xml/dom_elementimpl.h: Added focus and blur.
- khtml/dom/dom_element.cpp: (Element::focus): Now calls ElementImpl::focus (Element::blur): ditto.
- 4:12 PM Changeset in webkit [11552] by
-
- 3 edits in branches/Safari-1-3-branch/WebCore
Merged fix from TOT to Safari-1-3-branch
2005-12-08 David Harrison <harrison@apple.com>
Reviewed by Geoff.
<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)" crashed
when going from the "Open a template" menu to "Select recent Document" in the
"Welcome to Corel XI!" window.
- kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...].
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): Check isWidget() rather than using a dynamic_cast to RenderPart*.
(KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown.
- 4:05 PM Changeset in webkit [11551] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Merged fix from TOT to Safari-1-3-branch
2005-12-12 Adele Peterson <adele@apple.com>
Reviewed by Dave Harrison.
- fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present
When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.
- khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
- 3:54 PM Changeset in webkit [11550] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Merged fix from TOT to Safari-1-3-branch
2005-12-09 Tim Omernick <timo@apple.com>
Reviewed by Darin.
<rdar://problem/4371187> Regression: Anchor tags for navigation
within messages in HTML mail no longer working
A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().
- kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
- 3:53 PM Changeset in webkit [11549] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Merged fix from TOT to Safari-2-0-branch
2005-12-09 Tim Omernick <timo@apple.com>
Reviewed by Darin.
<rdar://problem/4371187> Regression: Anchor tags for navigation
within messages in HTML mail no longer working
A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().
- kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
- 3:49 PM Changeset in webkit [11548] by
-
- 2 edits in branches/Safari-1-3-branch/WebCore
Merged fix from TOT to Safari-1-3-branch
2005-12-12 Eric Seidel <eseidel@apple.com>
Reviewed by ggaren.
Test: fast/forms/textarea-setinnerhtml.html
Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>
- khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
- 3:48 PM Changeset in webkit [11547] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Merged fix from TOT to Safari-2-0-branch
2005-12-12 Eric Seidel <eseidel@apple.com>
Reviewed by ggaren.
Test: fast/forms/textarea-setinnerhtml.html
Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>
- khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
- 3:22 PM Changeset in webkit [11546] by
-
- 2 edits in branches/Safari-2-0-branch/WebKit
Merged fix from TOT to Safari-2-0-branch
2005-12-09 Tim Omernick <timo@apple.com>
Reviewed by John Sullivan.
Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures.
-performSelector:withObject:'s return value should only be checked if the method returns an object.
- Carbon.subproj/HIWebView.m: (UpdateCommandStatus):
- 2:22 PM Changeset in webkit [11545] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Test case for our CSS seletorText serialization.
- fast/dom/css-selectorText-expected.checksum: Added.
- fast/dom/css-selectorText-expected.png: Added.
- fast/dom/css-selectorText-expected.txt: Added.
- fast/dom/css-selectorText.html: Added.
WebCore:
Reviewed by Dave Hyatt.
Test: fast/dom/css-selectorText.html
Fixes selecotrText serialization to only print "*"
when it is stand alone. Fixes the attribute set selector,
along with general cleanup. Also print chained selectors.
- khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
- khtml/css/css_ruleimpl.cpp: (DOM::CSSStyleRuleImpl::selectorText):
- 1:01 PM Changeset in webkit [11544] by
-
- 2 edits in trunk/WebKit
Reviewed and checked in by John Sullivan.
Fix for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6053
WebIconDatabase returns the Accessibility Verifier app icon instead of
a generic document icon
- Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): use file type iconForFileType:NSFileTypeForHFSTypeCode(kGenericDocumentIcon) instead of '????' to get the generic document icon.
- 11:42 AM Changeset in webkit [11543] by
-
- 7 edits in trunk/WebKit
Reviewed by Tim Omernick.
- Made protocol <WebDocumentSelection> include protocol <WebDocumentText>, for clarity. This required moving some methods from WebTextView, which conformed to <WebDocumentText>, up into superclass WebSearchableTextView, which conformed to <WebDocumentSelection>.
- Misc.subproj/WebSearchableTextView.m: (-[NSString supportsTextEncoding]): moved this method (unchanged) from subclass WebTextView (-[NSString string]): ditto (-[NSString attributedString]): ditto (-[NSString selectedString]): ditto (-[NSString selectedAttributedString]): ditto (-[NSString selectAll]): ditto (-[NSString deselectAll]): ditto
- WebView.subproj/WebDocumentPrivate.h: made <WebDocumentSelection> incorporate <WebDocumentText> rather than just <NSObject>
- WebView.subproj/WebHTMLView.h: removed <WebDocumentText> from protocol list since it's covered by <WebDocumentSelection>
- WebView.subproj/WebPDFView.h: ditto
- WebView.subproj/WebTextView.h: ditto
- WebView.subproj/WebTextView.m: removed the methods that were moved into WebSearchableTextView.m
- 11:22 AM Changeset in webkit [11542] by
-
- 2 edits in trunk/WebCore
Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren
Test: fast/forms/textarea-setinnerhtml.html
Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>
- khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
- 11:20 AM Changeset in webkit [11541] by
-
- 1 edit4 adds in trunk/LayoutTests
Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren
- 11:07 AM Changeset in webkit [11540] by
-
- 2 edits in branches/Safari-2-0-branch/WebCore
Reviewed by Dave Harrison.
- fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present
When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.
- khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
- 11:04 AM Changeset in webkit [11539] by
-
- 2 edits in trunk/WebCore
Reviewed by Dave Harrison.
- fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present
When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.
- khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
- 9:40 AM Changeset in webkit [11538] by
-
- 1 edit4 adds in trunk/LayoutTests
Bug #: 6042
Submitted by: rob buis
Reviewed by: eseidel
"S" and "T" path types handle control points incorrectly
http://bugzilla.opendarwin.org/show_bug.cgi?id=6042
- svg/custom/control-points-for-S-and-T-expected.checksum: Added.
- svg/custom/control-points-for-S-and-T-expected.png: Added.
- svg/custom/control-points-for-S-and-T-expected.txt: Added.
- svg/custom/control-points-for-S-and-T.svg: Added.
- 9:37 AM Changeset in webkit [11537] by
-
- 2 edits in trunk/WebCore
Bug #: 6042
Submitted by: rob buis
Reviewed by: eseidel
Test: svg/custom/control-points-for-S-and-T.svg
"S" and "T" path types handle control points incorrectly
http://bugzilla.opendarwin.org/show_bug.cgi?id=6042
- ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):
- 9:25 AM Changeset in webkit [11536] by
-
- 4 edits in trunk/WebCore
Bug #: 6039
Submitted by: eseidel
Reviewed by: darin
No test cases needed, no functionality change.
Corrected spacing, and conformance with style guidelines.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6039
- kcanvas/KCanvasFilters.cpp:
- kcanvas/KCanvasFilters.h: (KCanvasFEComponentTransfer::setRedFunction): (KCanvasFEComponentTransfer::setGreenFunction): (KCanvasFEComponentTransfer::setBlueFunction): (KCanvasFEComponentTransfer::setAlphaFunction):
- kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciVector): (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter): (KCanvasFilterQuartz::filterBBoxForItemBBox): (KCanvasFilterQuartz::getCIFilterStack): (KCanvasFilterQuartz::imageForName): (KCanvasFilterQuartz::setImageForName): (KCanvasFilterQuartz::setOutputImage): (alphaImageForImage): (KCanvasFilterQuartz::inputImage): (KCanvasFEBlendQuartz::getCIFilter): (KCanvasFEColorMatrixQuartz::getCIFilter): (KCanvasFECompositeQuartz::getCIFilter): (getPointLightVectors): (getLightVectors): (getNormalMap): (KCanvasFEDiffuseLightingQuartz::getCIFilter): (KCanvasFEFloodQuartz::getCIFilter): (KCanvasFEGaussianBlurQuartz::getCIFilter): (KCanvasFEMergeQuartz::getCIFilter): (KCanvasFEOffsetQuartz::getCIFilter): (KCanvasFESpecularLightingQuartz::getCIFilter): (KCanvasFETileQuartz::getCIFilter):
- 9:01 AM Changeset in webkit [11535] by
-
- 3 edits5 adds in trunk
LayoutTests:
Reviewed by Eric.
Test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=5538
- fast/xsl/resources/xslt-entity.xsl: Added.
- fast/xsl/xslt-entity-expected.checksum: Added.
- fast/xsl/xslt-entity-expected.png: Added.
- fast/xsl/xslt-entity-expected.txt: Added.
- fast/xsl/xslt-entity.xml: Added.
WebCore:
Reviewed by Eric.
- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5538 XSLT crashes with multi-word internal entity declarations
Added the crashing specimen as a layout test.
- khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::loadChildSheets): Check that the node is an element node before calling IS_XSLT_ELEM.
Dec 11, 2005:
- 8:23 PM Changeset in webkit [11534] by
-
- 1 edit6 adds in trunk/LayoutTests
Bug #: none
Submitted by: eseidel
Reviewed by: none
Adding pixel results omitted from previous commits.
- fast/block/positioning/leftmargin-topmargin-expected.checksum: Added.
- fast/block/positioning/leftmargin-topmargin-expected.png: Added.
- fast/clip/017-expected.checksum: Added.
- fast/clip/017-expected.png: Added.
- fast/inspector/style-expected.checksum: Added.
- fast/inspector/style-expected.png: Added.
- 8:15 PM Changeset in webkit [11533] by
-
- 1 edit3 adds in trunk/LayoutTests
Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs
Adding resources overlooked in previous commit.
- fast/xsl/resources/xslt-extra-content-at-end.xsl: Added.
- fast/xsl/resources/xslt-mismatched-tags-in-xslt.xsl: Added.
- fast/xsl/resources/xslt-missing-namespace-in-xslt.xsl: Added.
- 3:47 AM Changeset in webkit [11532] by
-
- 1 edit28 adds in trunk/LayoutTests
Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs
Fixes SVG to load external scripts and report parse errors.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5875
Added 7 layout tests to exercise parse error code.
- fast/invalid/junk-data-expected.checksum: Added.
- fast/invalid/junk-data-expected.png: Added.
- fast/invalid/junk-data-expected.txt: Added.
- fast/invalid/junk-data.xml: Added.
- fast/invalid/missing-end-tag-expected.checksum: Added.
- fast/invalid/missing-end-tag-expected.png: Added.
- fast/invalid/missing-end-tag-expected.txt: Added.
- fast/invalid/missing-end-tag.xhtml: Added.
- fast/xsl/xslt-extra-content-at-end-expected.checksum: Added.
- fast/xsl/xslt-extra-content-at-end-expected.png: Added.
- fast/xsl/xslt-extra-content-at-end-expected.txt: Added.
- fast/xsl/xslt-extra-content-at-end.xml: Added.
- fast/xsl/xslt-mismatched-tags-in-xslt-expected.checksum: Added.
- fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Added.
- fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Added.
- fast/xsl/xslt-mismatched-tags-in-xslt.xml: Added.
- fast/xsl/xslt-missing-namespace-in-xslt-expected.checksum: Added.
- fast/xsl/xslt-missing-namespace-in-xslt-expected.png: Added.
- fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Added.
- fast/xsl/xslt-missing-namespace-in-xslt.xml: Added.
- svg/custom/junk-data-expected.checksum: Added.
- svg/custom/junk-data-expected.png: Added.
- svg/custom/junk-data-expected.txt: Added.
- svg/custom/junk-data.svg: Added.
- svg/custom/missing-xlink-expected.checksum: Added.
- svg/custom/missing-xlink-expected.png: Added.
- svg/custom/missing-xlink-expected.txt: Added.
- svg/custom/missing-xlink.svg: Added.
- 3:42 AM Changeset in webkit [11531] by
-
- 4 edits in trunk/WebCore
Bug #: 5875
Submitted by: eseidel
Reviewed by: darin & mjs
Fixes SVG to load external scripts and report parse errors.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5875
Added 7 layout tests to exercise parse error code.
- khtml/xml/xml_tokenizer.cpp: (khtml::createXHTMLParserErrorHeader): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts):
- ksvg2/svg/SVGStyledElementImpl.h: removed broken code
- ksvg2/svg/SVGStyledElementImpl.cpp: removed broken attach()
- 1:28 AM Changeset in webkit [11530] by
-
- 2 edits4 adds in trunk/LayoutTests
Bug #: 5999
Submitted by: eseidel
Reviewed by: hyatt
Small fixes made during SVG code review.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5999
- svg/custom/conditional-processing-outside-switch-expected.checksum: Added.
- svg/custom/conditional-processing-outside-switch-expected.png: Added.
- svg/custom/conditional-processing-outside-switch-expected.txt: Added.
- svg/custom/conditional-processing-outside-switch.svg: Added.
- svg/custom/simpleCDF-expected.txt:
- 1:26 AM Changeset in webkit [11529] by
-
- 24 edits in trunk/WebCore
Bug #: 5999
Submitted by: eseidel
Reviewed by: hyatt
Small fixes made during SVG code review.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5999
One test case added for conditional processing directives
used outside of switch statements.
- WebCore+SVG/DrawDocument.mm: (-[DrawView description]):
- kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEGaussianBlurQuartz::getCIFilter):
- khtml/css/cssparser.cpp: (CSSParser::parseValue):
- khtml/css/cssparser.h:
- khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::loadDefaultStyle): (khtml::CSSStyleSelector::applyProperty):
- khtml/css/cssstyleselector.h:
- khtml/ecma/kjs_window.cpp: (KJS::Window::retrieveWindow): (KJS::Window::retrieveActive):
- khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::isImageType):
- khtml/khtml_part.h:
- khtml/rendering/DataRef.h: (khtml::DataRef::operator == ): (khtml::DataRef::operator != ):
- khtml/rendering/render_canvas.cpp:
- khtml/rendering/render_object.h: (khtml::RenderObject::localTransform):
- khtml/rendering/render_style.cpp: (RenderStyle::diff):
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::createElementNS): (DocumentImpl::createEvent):
- khtml/xml/dom_elementimpl.cpp:
- khtml/xml/dom_elementimpl.h:
- khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):
- ksvg2/css/KSVGCSSParser.cpp: (DOM::CSSParser::parseSVGValue):
- ksvg2/css/svg.css:
- ksvg2/svg/SVGDocumentImpl.cpp:
- ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::childShouldCreateRenderer):
- ksvg2/svg/SVGElementImpl.h: (KSVG::SVGElementImpl::isValid):