⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 13, 2005:

11:48 PM Changeset in webkit [11581] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

  • fast/forms/checkbox-radio-onchange-expected.checksum: Added.
  • fast/forms/checkbox-radio-onchange-expected.png: Added.
  • fast/forms/checkbox-radio-onchange-expected.txt: Added.
  • fast/forms/checkbox-radio-onchange.html: Added.

WebCore:

Reviewed by Maciej.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

Test: fast/forms/checkbox-radio-onchange.html

  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::setChecked): call onChange after setting the checked state. This will match our old behavior, and Firefox behavior. This will also fire onChange for radio buttons which matches Firefox behavior.
10:16 PM Changeset in webkit [11580] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
6:22 PM Changeset in webkit [11579] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

5:14 PM Changeset in webkit [11578]
  • 5 copies in tags/Safari-521~5

This commit was manufactured by cvs2svn to create tag 'Safari-521~5'.

5:14 PM Changeset in webkit [11577] by thatcher
  • 3 edits in trunk

Adding release markers.

5:12 PM Changeset in webkit [12222] by thatcher
  • 1 edit in trunk/JavaScriptGlue/ChangeLog

Adding release markers.

5:00 PM Changeset in webkit [12221] by ggaren
  • 3 edits in trunk/JavaScriptGlue

Reviewed by darin.

  • UserObjectImp.cpp: (UserObjectImp::userObjectGetter): Updated to reflect new argument that getters take (unused here).
  • UserObjectImp.h:
4:40 PM Changeset in webkit [11576] by thatcher
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test case for our CSS shorthand serialization.

  • fast/dom/css-shortHands-expected.checksum: Added.
  • fast/dom/css-shortHands-expected.png: Added.
  • fast/dom/css-shortHands-expected.txt: Added.
  • fast/dom/css-shortHands.html: Added.

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dom/css-shortHands.html

First cut at leaving off implicit values in shorthand properties.
Need to account for multipl backgrounds and "border" later.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::get4Values): (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue):
3:29 PM Changeset in webkit [11575] by thatcher
  • 3 edits in branches/Safari-Leo-branch

Versioning

2:05 PM Changeset in webkit [11574] by ggaren
  • 2 edits in trunk/JavaScriptCore

Updated test results to match Anders's last fix.

  • tests/mozilla/expected.html:
1:42 PM Changeset in webkit [11573] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-13 Anders Carlsson <​andersca@mac.com>

  • ChangeLog: Add titles to the recent bugzilla bugs.
1:38 PM Changeset in webkit [11572] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Correct a date.

1:37 PM Changeset in webkit [11571] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2005-12-13 Anders Carlsson <​andersca@mac.com>

  • ChangeLog: Add titles for my bugzilla bugs.
1:37 PM Changeset in webkit [11570] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/js/property-getters-and-setters-expected.txt: Added.
  • fast/js/property-getters-and-setters.html: Added.
  • ChangeLog: Add titles for the bugzilla urls.
1:29 PM Changeset in webkit [11569] by andersca
  • 10 edits in trunk/WebCore

2005-12-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMStyleSheetList::indexGetter): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMMediaList::indexGetter): (KJS::DOMCSSRuleList::indexGetter): (KJS::DOMCSSValueList::indexGetter):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMElement::attributeGetter): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::indexGetter):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLElement::formIndexGetter): (KJS::HTMLElement::formNameGetter): (KJS::HTMLElement::selectIndexGetter): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::HTMLCollection::lengthGetter): (KJS::HTMLCollection::indexGetter): (KJS::HTMLCollection::nameGetter): (KJS::HTMLSelectCollection::selectedIndexGetter):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::indexGetter): (KJS::Plugins::nameGetter): (KJS::MimeTypes::indexGetter): (KJS::MimeTypes::nameGetter): (KJS::Plugin::indexGetter): (KJS::Plugin::nameGetter):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
  • khtml/ecma/kjs_window.h: Update for changes to PropertySlot::GetValueFunc.
1:26 PM Changeset in webkit [11568] by eseidel
  • 1 edit
    12 adds in trunk/LayoutTests

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

3 tests checking expected behavior for bad transform.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

  • svg/custom/transform-ignore-after-invalid-expected.checksum: Added.
  • svg/custom/transform-ignore-after-invalid-expected.png: Added.
  • svg/custom/transform-ignore-after-invalid-expected.txt: Added.
  • svg/custom/transform-ignore-after-invalid.svg: Added.
  • svg/custom/transform-invalid-expected.checksum: Added.
  • svg/custom/transform-invalid-expected.png: Added.
  • svg/custom/transform-invalid-expected.txt: Added.
  • svg/custom/transform-invalid.svg: Added.
  • svg/custom/transform-with-ending-space-expected.checksum: Added.
  • svg/custom/transform-with-ending-space-expected.png: Added.
  • svg/custom/transform-with-ending-space-expected.txt: Added.
  • svg/custom/transform-with-ending-space.svg: Added.
1:25 PM Changeset in webkit [11567] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

Fix crash on malformed transform attributes and transforms with
trailing spaces:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
1:24 PM Changeset in webkit [11566] by andersca
  • 27 edits in trunk/JavaScriptCore

2005-12-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter):
  • bindings/runtime_array.h:
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::lengthGetter): (getProperty): Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.
  • kjs/collector.cpp: (KJS::className): Handle GetterSetterType.
  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter):
  • kjs/function.h: Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.
  • kjs/grammar.y: Rework grammar parts for get set declarations directly in the object literal.
  • kjs/internal.cpp: (KJS::GetterSetterImp::mark): (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean): (KJS::GetterSetterImp::toNumber): (KJS::GetterSetterImp::toString): (KJS::GetterSetterImp::toObject): Add type conversion functions. These aren't meant to be called.

(KJS::printInfo):
Handle GetterSetterType.

  • kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter): Update for changes to PropertySlot::GetValueFunc.
  • kjs/nodes.cpp: Refactor they way properties nodes are implemented. We now have a PropertyListNode which is a list of PropertyNodes. Each PropertyNode has a name (which is a PropertyNameNode) and an associated value node. PropertyNodes can be of different types. The Constant type is the old constant declaration and the Getter and Setter types are for property getters and setters. (ResolveNode::evaluate): Update for changes to PropertySlot::getValue.

(PropertyListNode::evaluate):
Go through all property nodes and set them on the newly created object. If the
property nodes are of type Getter or Setter, define getters and setters. Otherwise,
just add the properties like before.

(PropertyNode::evaluate):
This should never be called directly.

(PropertyNameNode::evaluate):
Rename from PropertyNode::evaluate.

(FunctionCallResolveNode::evaluate):
(FunctionCallBracketNode::evaluate):
(FunctionCallDotNode::evaluate):
(PostfixResolveNode::evaluate):
(PostfixBracketNode::evaluate):
(PostfixDotNode::evaluate):
(TypeOfResolveNode::evaluate):
(PrefixResolveNode::evaluate):
(PrefixBracketNode::evaluate):
(PrefixDotNode::evaluate):
(AssignResolveNode::evaluate):
(AssignDotNode::evaluate):
(AssignBracketNode::evaluate):
Update for changes to PropertySlot::getValue.

  • kjs/nodes.h: (KJS::PropertyNameNode::PropertyNameNode): Rename from PropertyNode.

(KJS::PropertyNode::):
(KJS::PropertyNode::PropertyNode):
New class, representing a single property.

(KJS::PropertyListNode::PropertyListNode):
Rename from PropertyValueNode.

(KJS::FuncExprNode::FuncExprNode):
Put ParameterNode parameter last, and make it optional.

(KJS::ObjectLiteralNode::ObjectLiteralNode):
Use a PropertyListNode here now.

  • kjs/nodes2string.cpp: (PropertyListNode::streamTo): Iterate through all property nodes.

(PropertyNode::streamTo):
Print out the name and value. Doesn't handle getters and setters currently.

(PropertyNameNode::streamTo):
Rename from PropertyNode::streamTo.

  • kjs/object.cpp: (KJS::JSObject::get): Update for changes to PropertySlot::getValue.

(KJS::JSObject::put):
If the property already exists and has a Setter, invoke
the setter function instead of setting the property directly.

(KJS::JSObject::defineGetter):
(KJS::JSObject::defineSetter):
New functions for defining property getters and setters on the object.

  • kjs/object.h: (KJS::GetterSetterImp::type): (KJS::GetterSetterImp::GetterSetterImp): (KJS::GetterSetterImp::getGetter): (KJS::GetterSetterImp::setGetter): (KJS::GetterSetterImp::getSetter): (KJS::GetterSetterImp::setSetter): New class for properties which have getters and setters defined. This class is only used internally and should never be seen from the outside.

(KJS::JSObject::getOwnPropertySlot):

If the property is a getter, call setGetterSlot on the property slot.

  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add defineGetter, defineSetter, lookupGetter, lookupSetter to prototype.

(ObjectProtoFunc::callAsFunction):
Implement handlers for new functions.

  • kjs/object_object.h: (KJS::ObjectProtoFunc::): Add ids for new functions.
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): Update for changes to PropertySlot::GetValueFunc.

(KJS::PropertySlot::functionGetter):
Call the function getter object and return its value.

  • kjs/property_slot.h: (KJS::PropertySlot::getValue): Add a new argument which is the original object that getPropertySlot was called on.

(KJS::PropertySlot::setGetterSlot):
(KJS::PropertySlot::):
New function which sets a getter slot. When getValue is called on a
getter slot, the getter function object is invoked.

  • kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter):
  • kjs/string_object.h: Update for changes to PropertySlot::GetValueFunc.
  • kjs/value.h: (KJS::): Add GetterSetterType and make GetterSetterImp a friend class of JSCell.
1:12 PM Changeset in webkit [11565]
  • 56 copies
    22 deletes in tags/WebKit-417~9

This commit was manufactured by cvs2svn to create tag 'WebKit-417~9'.

1:12 PM Changeset in webkit [11564]
  • 211 copies
    17 deletes in tags/WebCore-417~12

This commit was manufactured by cvs2svn to create tag
'WebCore-417~12'.

1:12 PM Changeset in webkit [11563] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning:
WebCore-417.12
WebKit-417.9

3:46 AM Changeset in webkit [11562] by mjs
  • 2 edits in trunk/WebCore
  • build fix for last-minute part of previous change
  • khtml/ecma/kjs_binding.cpp:
3:06 AM Changeset in webkit [11561] by mjs
  • 11 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

  • added a new HashCountedSet class for the common pattern of mapping items to counts that can change
  • kxmlcore/HashCountedSet.h: Added. (KXMLCore::HashCountedSet::*): Implemented, on top of HashMap.
  • kxmlcore/HashMap.h: (KXMLCore::HashMap::add): New method - does not replace existing value if key already present but otherwise like set(). (KXMLCore::HashMap::set): Improved comments.
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::HashMap::add): Added to specializations too.
  • JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
  • kxmlcore/HashFunctions.h: Added include of stdint.h
  • replaced the custom hashtable for values protected from GC with HashCountedSet
  • kjs/collector.cpp: (KJS::Collector::protect): Moved code here from ProtectedValues::increaseProtectCount since the code is so simple now. (KJS::Collector::unprotect): Ditto for ProtectedValues::decreaseProtectCount. (KJS::Collector::markProtectedObjects): Updated for new way of doing things, now simpler and safer. (KJS::Collector::numReferencedObjects): ditto (KJS::Collector::rootObjectClasses): ditto
  • kjs/collector.h: Added protect and unprotect static methods
  • kjs/protect.h: (KJS::gcProtect): Updated for removal of ProtectedValues class (KJS::gcUnprotect): likewise
  • kjs/protected_values.cpp: Removed.
  • kjs/protected_values.h: Removed.

WebCore:

Reviewed by Eric.

  • updated for new HashCountedSet class
  • ForwardingHeaders/kxmlcore/HashCountedSet.h: Added forwarding header.
  • khtml/ecma/kjs_binding.cpp: Moved #define to disable pointer specialization higher in the file.
3:04 AM Changeset in webkit [12220] by mjs
  • 1 edit
    1 add in trunk/JavaScriptGlue

Reviewed by Eric.

  • added forwarding header for HashCountedSet
  • kxmlcore/HashCountedSet.h: Added.

Dec 12, 2005:

8:39 PM Changeset in webkit [11560] by thatcher
  • 3 edits in trunk/WebKit

Revised fix.

Reviewed by nobody, simple build fix.

Fixes a couple ambiguous selector build errors when building with GCC 3.3.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]):
  • WebView.subproj/WebHTMLView.m: (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSArray elementAtPoint:]):
6:01 PM Changeset in webkit [11559] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by nobody, simple build fix.

Fixes a couple ambiguous selector build errors when building with 3.3.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForURL:]):
  • WebCoreSupport.subproj/WebImageRenderer.h: Added missing methods for image and imageRef.
  • WebView.subproj/WebHTMLView.m: (-[NSView _web_layoutIfNeededRecursive:testDirtyRect:]): (-[NSArray elementAtPoint:]):
5:50 PM Changeset in webkit [11558] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by harrison

  • editing/selection/previous-line-position-expected.checksum: Added.
  • editing/selection/previous-line-position-expected.png: Added.
  • editing/selection/previous-line-position-expected.txt: Added.
  • editing/selection/previous-line-position.html: Added.
5:50 PM Changeset in webkit [11557] by justing
  • 2 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4040763> VisiblePosition constructor can return a result outside of the original

This bug was filed as a reminder to remove the workaround for
<rdar://problem/4033202>. We fixed the problems with
VisiblePosition causing 4033202, so I removed the workaround
and added a layout test.

  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition):
5:36 PM Changeset in webkit [11556] by harrison
  • 2 edits
    8 adds in trunk/LayoutTests

<rdar://problem/4026906> Paste of HTML table content can break table structure
<rdar://problem/4027704> Paste of HTML list content can break list structure by dropping empty list items

  • editing/pasteboard/block-wrappers-necessary.html:

Removed empty p tag.

  • editing/pasteboard/paste-list-001-expected.checksum: Added.
  • editing/pasteboard/paste-list-001-expected.png: Added.
  • editing/pasteboard/paste-list-001-expected.txt: Added.
  • editing/pasteboard/paste-list-001.html: Added.
  • editing/pasteboard/paste-table-001-expected.checksum: Added.
  • editing/pasteboard/paste-table-001-expected.png: Added.
  • editing/pasteboard/paste-table-001-expected.txt: Added.
  • editing/pasteboard/paste-table-001.html: Added.
5:28 PM Changeset in webkit [11555] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4027704> Paste of HTML list content can break list structure by dropping empty list items

Fixed by having ReplaceSelectionCommand remove empty nodes just
from the ancestors of the node(s) moved by mergeStart, rather
than scanning the whole fragment.

Layout tests added:

editing/pasteboard/paste-table-001.html
editing/pasteboard/paste-list-001.html

  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::isProbablyTableStructureNode): (khtml::ReplaceSelectionCommand::pruneEmptyNodes): Removed no longer needed functions.

(khtml::ReplaceSelectionCommand::doApply):
Remove ancestor nodes emptied by mergeStart.
Do that instead of calling pruneEmptyNodes().

  • khtml/editing/replace_selection_command.h: (khtml::ReplacementFragment::desiredStyles): Removed pruneEmptyNodes().
4:35 PM Changeset in webkit [11554] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Merged fix from TOT to Safari-1-3-branch

2005-12-06 David Harrison <​harrison@apple.com>

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
4:21 PM Changeset in webkit [11553] by thatcher
  • 6 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-08 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

  • fixed <rdar://problem/4363794> 10.4.4 REGRESSION: Page scroll position jumps when clicking on word in editable div (5911) setFocusNode was trying to scroll to reveal elements unnecessarily. Now the callers have to decide whether or not to scroll.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): No longer calls scrolling code.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Now calls scrolling code after setting the focus node.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Moved functionality from Element::focus. Now these functions also call scrolling code. (ElementImpl::blur): ditto.
  • khtml/xml/dom_elementimpl.h: Added focus and blur.
  • khtml/dom/dom_element.cpp: (Element::focus): Now calls ElementImpl::focus (Element::blur): ditto.
4:12 PM Changeset in webkit [11552] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-08 David Harrison <​harrison@apple.com>

Reviewed by Geoff.

<rdar://problem/4366496> 10.4.4 Regression: "Corel Painter IX (v9.1)" crashed
when going from the "Open a template" menu to "Select recent Document" in the
"Welcome to Corel XI!" window.

  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): Retain the event because it is the [NSApp currentEvent], which can change and therefore be released during [super trackMouse:...].
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): Check isWidget() rather than using a dynamic_cast to RenderPart*.

(KWQKHTMLPart::sendFakeEventsAfterWidgetTracking):
Allow for the event not being leftmousedown or keydown.

4:05 PM Changeset in webkit [11551] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-12 Adele Peterson <​adele@apple.com>

Reviewed by Dave Harrison.

  • fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
3:54 PM Changeset in webkit [11550] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-09 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<rdar://problem/4371187> Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
3:53 PM Changeset in webkit [11549] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-09 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<rdar://problem/4371187> Regression: Anchor tags for navigation
within messages in HTML mail no longer working

A kwq category on NSView used to ensure scrolling the super NSClipViews, but that is gone now.
Implemented equivalent functionality by walking up the view hierarchy in QScrollView::setContentsPos().

  • kwq/KWQScrollView.mm: (QScrollView::setContentsPos):
3:49 PM Changeset in webkit [11548] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-12 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
3:48 PM Changeset in webkit [11547] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-12 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
3:22 PM Changeset in webkit [11546] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-09 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

Don't call -performSelector:withObject: on a method that returns a BOOL; this is not guaranteed to work on all architectures.
-performSelector:withObject:'s return value should only be checked if the method returns an object.

  • Carbon.subproj/HIWebView.m: (UpdateCommandStatus):
2:22 PM Changeset in webkit [11545] by thatcher
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test case for our CSS seletorText serialization.

  • fast/dom/css-selectorText-expected.checksum: Added.
  • fast/dom/css-selectorText-expected.png: Added.
  • fast/dom/css-selectorText-expected.txt: Added.
  • fast/dom/css-selectorText.html: Added.

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dom/css-selectorText.html

Fixes selecotrText serialization to only print "*"
when it is stand alone. Fixes the attribute set selector,
along with general cleanup. Also print chained selectors.

  • khtml/css/css_base.cpp: (CSSSelector::extractPseudoType): (CSSSelector::selectorText):
  • khtml/css/css_ruleimpl.cpp: (DOM::CSSStyleRuleImpl::selectorText):
1:01 PM Changeset in webkit [11544] by sullivan
  • 2 edits in trunk/WebKit

Reviewed and checked in by John Sullivan.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6053
WebIconDatabase returns the Accessibility Verifier app icon instead of
a generic document icon

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): use file type iconForFileType:NSFileTypeForHFSTypeCode(kGenericDocumentIcon) instead of '????' to get the generic document icon.
11:42 AM Changeset in webkit [11543] by sullivan
  • 7 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • Made protocol <WebDocumentSelection> include protocol <WebDocumentText>, for clarity. This required moving some methods from WebTextView, which conformed to <WebDocumentText>, up into superclass WebSearchableTextView, which conformed to <WebDocumentSelection>.
  • Misc.subproj/WebSearchableTextView.m: (-[NSString supportsTextEncoding]): moved this method (unchanged) from subclass WebTextView (-[NSString string]): ditto (-[NSString attributedString]): ditto (-[NSString selectedString]): ditto (-[NSString selectedAttributedString]): ditto (-[NSString selectAll]): ditto (-[NSString deselectAll]): ditto
  • WebView.subproj/WebDocumentPrivate.h: made <WebDocumentSelection> incorporate <WebDocumentText> rather than just <NSObject>
  • WebView.subproj/WebHTMLView.h: removed <WebDocumentText> from protocol list since it's covered by <WebDocumentSelection>
  • WebView.subproj/WebPDFView.h: ditto
  • WebView.subproj/WebTextView.h: ditto
  • WebView.subproj/WebTextView.m: removed the methods that were moved into WebSearchableTextView.m
11:22 AM Changeset in webkit [11542] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren

Test: fast/forms/textarea-setinnerhtml.html

Fixes setInnerHTML for <textarea>
<rdar://problem/4372143>

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
11:20 AM Changeset in webkit [11541] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 4372143
Submitted by: eseidel
Reviewed by: ggaren

11:07 AM Changeset in webkit [11540] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Dave Harrison.

  • fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
11:04 AM Changeset in webkit [11539] by adele
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • fixed <rdar://problem/4374673> Regression: Safari fails to scroll to top of page if (name="top") attribute is not present

When there's no node corresponding to the anchor (the name is empty or "top"), we still want to scroll to the top of the document. This got left out in the conversion to the new scrolling code.

  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor):
9:40 AM Changeset in webkit [11538] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

Bug #: 6042
Submitted by: rob buis
Reviewed by: eseidel

"S" and "T" path types handle control points incorrectly
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6042

  • svg/custom/control-points-for-S-and-T-expected.checksum: Added.
  • svg/custom/control-points-for-S-and-T-expected.png: Added.
  • svg/custom/control-points-for-S-and-T-expected.txt: Added.
  • svg/custom/control-points-for-S-and-T.svg: Added.
9:37 AM Changeset in webkit [11537] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6042
Submitted by: rob buis
Reviewed by: eseidel

Test: svg/custom/control-points-for-S-and-T.svg

"S" and "T" path types handle control points incorrectly
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6042

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):
9:25 AM Changeset in webkit [11536] by eseidel
  • 4 edits in trunk/WebCore

Bug #: 6039
Submitted by: eseidel
Reviewed by: darin

No test cases needed, no functionality change.
Corrected spacing, and conformance with style guidelines.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6039

  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasFilters.h: (KCanvasFEComponentTransfer::setRedFunction): (KCanvasFEComponentTransfer::setGreenFunction): (KCanvasFEComponentTransfer::setBlueFunction): (KCanvasFEComponentTransfer::setAlphaFunction):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciVector): (KCanvasFilterQuartz::prepareFilter): (KCanvasFilterQuartz::applyFilter): (KCanvasFilterQuartz::filterBBoxForItemBBox): (KCanvasFilterQuartz::getCIFilterStack): (KCanvasFilterQuartz::imageForName): (KCanvasFilterQuartz::setImageForName): (KCanvasFilterQuartz::setOutputImage): (alphaImageForImage): (KCanvasFilterQuartz::inputImage): (KCanvasFEBlendQuartz::getCIFilter): (KCanvasFEColorMatrixQuartz::getCIFilter): (KCanvasFECompositeQuartz::getCIFilter): (getPointLightVectors): (getLightVectors): (getNormalMap): (KCanvasFEDiffuseLightingQuartz::getCIFilter): (KCanvasFEFloodQuartz::getCIFilter): (KCanvasFEGaussianBlurQuartz::getCIFilter): (KCanvasFEMergeQuartz::getCIFilter): (KCanvasFEOffsetQuartz::getCIFilter): (KCanvasFESpecularLightingQuartz::getCIFilter): (KCanvasFETileQuartz::getCIFilter):
9:01 AM Changeset in webkit [11535] by darin
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Eric.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5538

  • fast/xsl/resources/xslt-entity.xsl: Added.
  • fast/xsl/xslt-entity-expected.checksum: Added.
  • fast/xsl/xslt-entity-expected.png: Added.
  • fast/xsl/xslt-entity-expected.txt: Added.
  • fast/xsl/xslt-entity.xml: Added.

WebCore:

Reviewed by Eric.

Added the crashing specimen as a layout test.

  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::loadChildSheets): Check that the node is an element node before calling IS_XSLT_ELEM.
Note: See TracTimeline for information about the timeline view.