⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 14, 2005:

8:51 PM Changeset in webkit [11590] by adele
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Adele Peterson <​adele@apple.com>

Reviewed by Darin and Tim Hatcher.

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
8:29 PM Changeset in webkit [11589] by adele
  • 4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
3:32 PM Changeset in webkit [11588] by eseidel
  • 46 edits
    4 deletes in trunk/WebCore

Bug #: 6078
Submitted by: eseidel
Reviewed by: darin

SVG test cases changed (now the svg.css is loaded properly).
No other functionality changes, just code removal.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6078

  • ForwardingHeaders/klibloader.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/csshelper.cpp:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::parseUASheet): (khtml::CSSStyleSelector::loadDefaultStyle):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::eventParameterName): (KJS::JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::implementsCall):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::PluginBase::PluginBase):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_proxy.h: (KJSProxyImpl::setEventHandlerLineno):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::interpreter): (KJS::Window::retrieve): (KJS::Window::clear): (KJS::ScheduledAction::execute):
  • khtml/ecma/kjs_window.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData):
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::evaluateScript):
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::processToken):
  • khtml/khtml_part.cpp: (KHTMLPart::KHTMLPart): (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::restoreURL): (KHTMLPart::didOpenURL): (KHTMLPart::jScript): (KHTMLPart::executeScript): (KHTMLPart::write): (KHTMLPart::reparseConfiguration): (KHTMLPart::createHTMLEventListener):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/misc/decoder.cpp:
  • khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): (CachedScript::CachedScript):
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_inline.cpp:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/table_layout.cpp:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitOpen): (DocumentImpl::write):
  • khtml/xml/dom_nodeimpl.cpp:
  • ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::isValid):
  • kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • kwq/KWQKGlobal.h:
  • kwq/KWQKHTMLFactory.h: (KHTMLFactory::vLinks):
  • kwq/KWQKHTMLFactory.mm:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::userGestureHint): (KWQKHTMLPart::bindingRootObject):
  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::fantasyFontName): (KHTMLSettings::isJavaScriptEnabled):
  • kwq/KWQKInstance.h: Removed.
  • kwq/KWQKLibrary.h: Removed.
  • kwq/KWQKPartsFactory.h: Removed.
  • kwq/KWQKPartsPart.h: (KParts::ReadOnlyPart::name):
  • kwq/KWQKStandardDirs.h:
  • kwq/KWQKStandardDirs.mm: (locate):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge executionContextForView:]):
2:49 PM Changeset in webkit [11587] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.
2:45 PM Changeset in webkit [11586] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.
2:39 PM Changeset in webkit [11585] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

2:21 PM Changeset in webkit [11584] by bdakin
  • 3 edits
    4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

10:46 AM Changeset in webkit [11583] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Layout test for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

  • fast/overflow/overflow-text-hit-testing-expected.checksum: Added.
  • fast/overflow/overflow-text-hit-testing-expected.png: Added.
  • fast/overflow/overflow-text-hit-testing-expected.txt: Added.
  • fast/overflow/overflow-text-hit-testing.html: Added.

WebCore:

Reviewed by Darin & Geoff, committed by Adele.

Test: fast/overflow/overflow-text-hit-testing.html

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

  • khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Adjust for containing block scroll
10:19 AM Changeset in webkit [11582] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4362
Add mac-cyrillic to the list of encodings

  • kwq/mac-encodings.txt: Added maccyrillic

Dec 13, 2005:

11:48 PM Changeset in webkit [11581] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

  • fast/forms/checkbox-radio-onchange-expected.checksum: Added.
  • fast/forms/checkbox-radio-onchange-expected.png: Added.
  • fast/forms/checkbox-radio-onchange-expected.txt: Added.
  • fast/forms/checkbox-radio-onchange.html: Added.

WebCore:

Reviewed by Maciej.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5465
REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla)

Test: fast/forms/checkbox-radio-onchange.html

  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::setChecked): call onChange after setting the checked state. This will match our old behavior, and Firefox behavior. This will also fire onChange for radio buttons which matches Firefox behavior.
10:16 PM Changeset in webkit [11580] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
6:22 PM Changeset in webkit [11579] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

5:14 PM Changeset in webkit [11578]
  • 5 copies in tags/Safari-521~5

This commit was manufactured by cvs2svn to create tag 'Safari-521~5'.

5:14 PM Changeset in webkit [11577] by thatcher
  • 3 edits in trunk

Adding release markers.

5:12 PM Changeset in webkit [12222] by thatcher
  • 1 edit in trunk/JavaScriptGlue/ChangeLog

Adding release markers.

5:00 PM Changeset in webkit [12221] by ggaren
  • 3 edits in trunk/JavaScriptGlue

Reviewed by darin.

  • UserObjectImp.cpp: (UserObjectImp::userObjectGetter): Updated to reflect new argument that getters take (unused here).
  • UserObjectImp.h:
4:40 PM Changeset in webkit [11576] by thatcher
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test case for our CSS shorthand serialization.

  • fast/dom/css-shortHands-expected.checksum: Added.
  • fast/dom/css-shortHands-expected.png: Added.
  • fast/dom/css-shortHands-expected.txt: Added.
  • fast/dom/css-shortHands.html: Added.

WebCore:

Reviewed by Dave Hyatt.

Test: fast/dom/css-shortHands.html

First cut at leaving off implicit values in shorthand properties.
Need to account for multipl backgrounds and "border" later.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::get4Values): (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue):
3:29 PM Changeset in webkit [11575] by thatcher
  • 3 edits in branches/Safari-Leo-branch

Versioning

2:05 PM Changeset in webkit [11574] by ggaren
  • 2 edits in trunk/JavaScriptCore

Updated test results to match Anders's last fix.

  • tests/mozilla/expected.html:
1:42 PM Changeset in webkit [11573] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-13 Anders Carlsson <​andersca@mac.com>

  • ChangeLog: Add titles to the recent bugzilla bugs.
1:38 PM Changeset in webkit [11572] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Correct a date.

1:37 PM Changeset in webkit [11571] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2005-12-13 Anders Carlsson <​andersca@mac.com>

  • ChangeLog: Add titles for my bugzilla bugs.
1:37 PM Changeset in webkit [11570] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/js/property-getters-and-setters-expected.txt: Added.
  • fast/js/property-getters-and-setters.html: Added.
  • ChangeLog: Add titles for the bugzilla urls.
1:29 PM Changeset in webkit [11569] by andersca
  • 10 edits in trunk/WebCore

2005-12-13 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::indexGetter): (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): (KJS::DOMStyleSheetList::indexGetter): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMMediaList::indexGetter): (KJS::DOMCSSRuleList::indexGetter): (KJS::DOMCSSValueList::indexGetter):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMElement::attributeGetter): (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::indexGetter):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLElement::formIndexGetter): (KJS::HTMLElement::formNameGetter): (KJS::HTMLElement::selectIndexGetter): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::runtimeObjectGetter): (KJS::HTMLElement::runtimeObjectPropertyGetter): (KJS::HTMLCollection::lengthGetter): (KJS::HTMLCollection::indexGetter): (KJS::HTMLCollection::nameGetter): (KJS::HTMLSelectCollection::selectedIndexGetter):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::indexGetter): (KJS::Plugins::nameGetter): (KJS::MimeTypes::indexGetter): (KJS::MimeTypes::nameGetter): (KJS::Plugin::indexGetter): (KJS::Plugin::nameGetter):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
  • khtml/ecma/kjs_window.h: Update for changes to PropertySlot::GetValueFunc.
1:26 PM Changeset in webkit [11568] by eseidel
  • 1 edit
    12 adds in trunk/LayoutTests

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

3 tests checking expected behavior for bad transform.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

  • svg/custom/transform-ignore-after-invalid-expected.checksum: Added.
  • svg/custom/transform-ignore-after-invalid-expected.png: Added.
  • svg/custom/transform-ignore-after-invalid-expected.txt: Added.
  • svg/custom/transform-ignore-after-invalid.svg: Added.
  • svg/custom/transform-invalid-expected.checksum: Added.
  • svg/custom/transform-invalid-expected.png: Added.
  • svg/custom/transform-invalid-expected.txt: Added.
  • svg/custom/transform-invalid.svg: Added.
  • svg/custom/transform-with-ending-space-expected.checksum: Added.
  • svg/custom/transform-with-ending-space-expected.png: Added.
  • svg/custom/transform-with-ending-space-expected.txt: Added.
  • svg/custom/transform-with-ending-space.svg: Added.
1:25 PM Changeset in webkit [11567] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6061
Submitted by: eseidel
Reviewed by: darin

Fix crash on malformed transform attributes and transforms with
trailing spaces:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6061

  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
1:24 PM Changeset in webkit [11566] by andersca
  • 27 edits in trunk/JavaScriptCore

2005-12-12 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter):
  • bindings/runtime_array.h:
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter):
  • bindings/runtime_object.h:
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::lengthGetter): (getProperty): Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.
  • kjs/collector.cpp: (KJS::className): Handle GetterSetterType.
  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter):
  • kjs/function.h: Update for changes to PropertySlot::getValue and PropertySlot::GetValueFunc.
  • kjs/grammar.y: Rework grammar parts for get set declarations directly in the object literal.
  • kjs/internal.cpp: (KJS::GetterSetterImp::mark): (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean): (KJS::GetterSetterImp::toNumber): (KJS::GetterSetterImp::toString): (KJS::GetterSetterImp::toObject): Add type conversion functions. These aren't meant to be called.

(KJS::printInfo):
Handle GetterSetterType.

  • kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter): Update for changes to PropertySlot::GetValueFunc.
  • kjs/nodes.cpp: Refactor they way properties nodes are implemented. We now have a PropertyListNode which is a list of PropertyNodes. Each PropertyNode has a name (which is a PropertyNameNode) and an associated value node. PropertyNodes can be of different types. The Constant type is the old constant declaration and the Getter and Setter types are for property getters and setters. (ResolveNode::evaluate): Update for changes to PropertySlot::getValue.

(PropertyListNode::evaluate):
Go through all property nodes and set them on the newly created object. If the
property nodes are of type Getter or Setter, define getters and setters. Otherwise,
just add the properties like before.

(PropertyNode::evaluate):
This should never be called directly.

(PropertyNameNode::evaluate):
Rename from PropertyNode::evaluate.

(FunctionCallResolveNode::evaluate):
(FunctionCallBracketNode::evaluate):
(FunctionCallDotNode::evaluate):
(PostfixResolveNode::evaluate):
(PostfixBracketNode::evaluate):
(PostfixDotNode::evaluate):
(TypeOfResolveNode::evaluate):
(PrefixResolveNode::evaluate):
(PrefixBracketNode::evaluate):
(PrefixDotNode::evaluate):
(AssignResolveNode::evaluate):
(AssignDotNode::evaluate):
(AssignBracketNode::evaluate):
Update for changes to PropertySlot::getValue.

  • kjs/nodes.h: (KJS::PropertyNameNode::PropertyNameNode): Rename from PropertyNode.

(KJS::PropertyNode::):
(KJS::PropertyNode::PropertyNode):
New class, representing a single property.

(KJS::PropertyListNode::PropertyListNode):
Rename from PropertyValueNode.

(KJS::FuncExprNode::FuncExprNode):
Put ParameterNode parameter last, and make it optional.

(KJS::ObjectLiteralNode::ObjectLiteralNode):
Use a PropertyListNode here now.

  • kjs/nodes2string.cpp: (PropertyListNode::streamTo): Iterate through all property nodes.

(PropertyNode::streamTo):
Print out the name and value. Doesn't handle getters and setters currently.

(PropertyNameNode::streamTo):
Rename from PropertyNode::streamTo.

  • kjs/object.cpp: (KJS::JSObject::get): Update for changes to PropertySlot::getValue.

(KJS::JSObject::put):
If the property already exists and has a Setter, invoke
the setter function instead of setting the property directly.

(KJS::JSObject::defineGetter):
(KJS::JSObject::defineSetter):
New functions for defining property getters and setters on the object.

  • kjs/object.h: (KJS::GetterSetterImp::type): (KJS::GetterSetterImp::GetterSetterImp): (KJS::GetterSetterImp::getGetter): (KJS::GetterSetterImp::setGetter): (KJS::GetterSetterImp::getSetter): (KJS::GetterSetterImp::setSetter): New class for properties which have getters and setters defined. This class is only used internally and should never be seen from the outside.

(KJS::JSObject::getOwnPropertySlot):

If the property is a getter, call setGetterSlot on the property slot.

  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add defineGetter, defineSetter, lookupGetter, lookupSetter to prototype.

(ObjectProtoFunc::callAsFunction):
Implement handlers for new functions.

  • kjs/object_object.h: (KJS::ObjectProtoFunc::): Add ids for new functions.
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): Update for changes to PropertySlot::GetValueFunc.

(KJS::PropertySlot::functionGetter):
Call the function getter object and return its value.

  • kjs/property_slot.h: (KJS::PropertySlot::getValue): Add a new argument which is the original object that getPropertySlot was called on.

(KJS::PropertySlot::setGetterSlot):
(KJS::PropertySlot::):
New function which sets a getter slot. When getValue is called on a
getter slot, the getter function object is invoked.

  • kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter):
  • kjs/string_object.h: Update for changes to PropertySlot::GetValueFunc.
  • kjs/value.h: (KJS::): Add GetterSetterType and make GetterSetterImp a friend class of JSCell.
1:12 PM Changeset in webkit [11565]
  • 56 copies
    22 deletes in tags/WebKit-417~9

This commit was manufactured by cvs2svn to create tag 'WebKit-417~9'.

1:12 PM Changeset in webkit [11564]
  • 211 copies
    17 deletes in tags/WebCore-417~12

This commit was manufactured by cvs2svn to create tag
'WebCore-417~12'.

1:12 PM Changeset in webkit [11563] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning:
WebCore-417.12
WebKit-417.9

3:46 AM Changeset in webkit [11562] by mjs
  • 2 edits in trunk/WebCore
  • build fix for last-minute part of previous change
  • khtml/ecma/kjs_binding.cpp:
3:06 AM Changeset in webkit [11561] by mjs
  • 11 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

Reviewed by Eric.

  • added a new HashCountedSet class for the common pattern of mapping items to counts that can change
  • kxmlcore/HashCountedSet.h: Added. (KXMLCore::HashCountedSet::*): Implemented, on top of HashMap.
  • kxmlcore/HashMap.h: (KXMLCore::HashMap::add): New method - does not replace existing value if key already present but otherwise like set(). (KXMLCore::HashMap::set): Improved comments.
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::HashMap::add): Added to specializations too.
  • JavaScriptCore.xcodeproj/project.pbxproj: Add new file.
  • kxmlcore/HashFunctions.h: Added include of stdint.h
  • replaced the custom hashtable for values protected from GC with HashCountedSet
  • kjs/collector.cpp: (KJS::Collector::protect): Moved code here from ProtectedValues::increaseProtectCount since the code is so simple now. (KJS::Collector::unprotect): Ditto for ProtectedValues::decreaseProtectCount. (KJS::Collector::markProtectedObjects): Updated for new way of doing things, now simpler and safer. (KJS::Collector::numReferencedObjects): ditto (KJS::Collector::rootObjectClasses): ditto
  • kjs/collector.h: Added protect and unprotect static methods
  • kjs/protect.h: (KJS::gcProtect): Updated for removal of ProtectedValues class (KJS::gcUnprotect): likewise
  • kjs/protected_values.cpp: Removed.
  • kjs/protected_values.h: Removed.

WebCore:

Reviewed by Eric.

  • updated for new HashCountedSet class
  • ForwardingHeaders/kxmlcore/HashCountedSet.h: Added forwarding header.
  • khtml/ecma/kjs_binding.cpp: Moved #define to disable pointer specialization higher in the file.
3:04 AM Changeset in webkit [12220] by mjs
  • 1 edit
    1 add in trunk/JavaScriptGlue

Reviewed by Eric.

  • added forwarding header for HashCountedSet
  • kxmlcore/HashCountedSet.h: Added.
Note: See TracTimeline for information about the timeline view.