⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 15, 2005:

11:51 PM Changeset in webkit [11613] by darin
  • 2 edits in trunk/WebCore
  • fix crash caused by my last check-in
  • khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction): Use RefPtr to ref/deref the tokenizer.
11:28 PM Changeset in webkit [11612] by darin
  • 2 edits in trunk/WebCore
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::exitText): Add missing null check.
10:39 PM Changeset in webkit [11611] by ggaren
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/4381444> Remove GMail-specific work-around
previously added.

Reviewed by Darin.

No test case because this patch just turns on already-tested behavior
for GMail.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Removed code that hid the selectionEnd property from sites on the GMail domain.
10:33 PM Changeset in webkit [11610] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::XMLTokenizer): Initialize the new m_currentNodeIsReferenced field to false for the document case, and true for the non-0 fragment case. Also don't reference the document in the document tokenizer case to avoid a circular reference -- HTML parser already does both of these things. (khtml::XMLTokenizer::~XMLTokenizer): Call setCurrentNode(0) to release the current node in case the tokenizer is being destroyed without finishing parsing. Only call deref on the document inthe fragment-parsing case. (khtml::XMLTokenizer::setCurrentNode): Added. Reference the current node only if it's not the document. Just as with the HTML parser, use a boolean to track whether the current node needs a deref or not. (khtml::XMLTokenizer::startElementNs): Use a RefPtr to keep the newly created element alive at least until setCurrentNode is called. Remove the bogus explicit delete of of the node after calling addChild, since reference counting takes care of it. Stop parsing if we fail to create an element. (khtml::XMLTokenizer::endElementNs): Use setCurrentNode and use a local variable to avoid reference count thrash. (khtml::XMLTokenizer::characters): Changed to only support text nodes. CDATA no longer calls this function. (khtml::XMLTokenizer::enterText): Use setCurrentNode, and remove bogus delete call. (khtml::XMLTokenizer::exitText): Add checks for stopped parser and for whether the current node is a text node so this can be called unconditionally. (khtml::XMLTokenizer::cdataBlock): Use setCurrentNode and move the call before the call to attach to make sure the node is already ref'd when attach is called. (khtml::XMLTokenizer::finish): Call setCurrentNode(0) to release the nodes we've been parsing. (khtml::XMLTokenizer::executeScripts): Fixed incorrect cast to TextImpl to cast to the base class CharacterDataImpl instead.
6:30 PM Changeset in webkit [11609] by eseidel
  • 9 edits
    1 delete in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: tim hatcher

Made SVG on by default!
Also removed last two KHTML_NO_CPLUSPLUS_DOM #ifs and turned off.
Removed APPLE_COMPILE_HACK, fixing or replacing with #if 0 for now.

  • WebCore.xcodeproj/project.pbxproj: Made SVG default!
  • ksvg2/KSVGSettings.cpp: Removed.
  • ksvg2/css/SVGCSSStyleSelector.cpp: fixed copyright.
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::notifyFinished): fixed
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): removed dead code.
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::createRenderer): #if 0 (SVGImageElementImpl::notifyFinished): #if 0
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::pixelUnitToMillimeterX): #if 0 (SVGSVGElementImpl::pixelUnitToMillimeterY): #if 0
  • kwq/DOM.mm: removed KHTML_NO_CPLUSPLUS_DOM (ObjCNodeFilterCondition::acceptNode):
  • kwq/KWQKHTMLPart.mm: removed KHTML_NO_CPLUSPLUS_DOM
6:21 PM Changeset in webkit [11608] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: tim h

  • Scripts/build-webkit: --svg is now default!
6:16 PM Changeset in webkit [11607] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Don't run svg test automatically if +SVG is built (yet).

  • Scripts/run-webkit-tests:
4:17 PM Changeset in webkit [11606]
  • 211 copies
    17 deletes in tags/WebCore-417~14

This commit was manufactured by cvs2svn to create tag
'WebCore-417~14'.

4:17 PM Changeset in webkit [11605] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

4:08 PM Changeset in webkit [11604] by eseidel
  • 5 edits in trunk/WebCore

Bug #:
Submitted by: eseidel
Reviewed by: none

Fix build break. (Files missed in previous commit.)

  • khtml/css/csshelper.cpp:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/rendering/render_canvasimage.cpp:
  • khtml/rendering/render_image.cpp:
3:40 PM Changeset in webkit [11603] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Test for <rdar://problem/4258232> Crash in HTMLOptionElementImpl::index when option element has no corresponding select - http://www.mattkruse.com/javascript/datadumper/

  • fast/forms/option-index-expected.checksum: Added.
  • fast/forms/option-index-expected.png: Added.
  • fast/forms/option-index-expected.txt: Added.
  • fast/forms/option-index.html: Added.

WebCore:

Reviewed by John.

Test: fast/forms/option-index.html

  • khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::index): nil check for select element.
2:31 PM Changeset in webkit [11602] by eseidel
  • 36 edits
    60 deletes in trunk/WebCore

Bug #: 6091
Submitted by: eseidel
Reviewed by: darin

Remove more legacy code from khtml/kwq
http://bugzilla.opendarwin.org/show_bug.cgi?id=6091

No tests needed, no functionality changes.

  • ForwardingHeaders/kapplication.h: Removed.
  • ForwardingHeaders/kcompletionbox.h: Removed.
  • ForwardingHeaders/kdatastream.h: Removed.
  • ForwardingHeaders/kfiledialog.h: Removed.
  • ForwardingHeaders/kfileitem.h: Removed.
  • ForwardingHeaders/khtml_iface.h: Removed.
  • ForwardingHeaders/khtml_pagecache.h: Removed.
  • ForwardingHeaders/khtml_printsettings.h: Removed.
  • ForwardingHeaders/khtml_run.h: Removed.
  • ForwardingHeaders/kiconloader.h: Removed.
  • ForwardingHeaders/kio/kprotocolmanager.h: Removed.
  • ForwardingHeaders/kio/netaccess.h: Removed.
  • ForwardingHeaders/kmessagebox.h: Removed.
  • ForwardingHeaders/kmimetype.h: Removed.
  • ForwardingHeaders/kmultipledrag.h: Removed.
  • ForwardingHeaders/kparts/partmanager.h: Removed.
  • ForwardingHeaders/kprinter.h: Removed.
  • ForwardingHeaders/kprotocolmanager.h: Removed.
  • ForwardingHeaders/ksimpleconfig.h: Removed.
  • ForwardingHeaders/ksslcertchain.h: Removed.
  • ForwardingHeaders/ksslinfodlg.h: Removed.
  • ForwardingHeaders/kstdaction.h: Removed.
  • ForwardingHeaders/ktempfile.h: Removed.
  • ForwardingHeaders/ktrader.h: Removed.
  • ForwardingHeaders/kurldrag.h: Removed.
  • ForwardingHeaders/kxmlguifactory.h: Removed.
  • ForwardingHeaders/netaccess.h: Removed.
  • ForwardingHeaders/private/qucomextra_p.h: Removed.
  • ForwardingHeaders/qasyncimageio.h: Removed.
  • ForwardingHeaders/qbitmap.h: Removed.
  • ForwardingHeaders/qclipboard.h: Removed.
  • ForwardingHeaders/qdir.h: Removed.
  • ForwardingHeaders/qdrawutil.h: Removed.
  • ForwardingHeaders/qfontdatabase.h: Removed.
  • ForwardingHeaders/qfontinfo.h: Removed.
  • ForwardingHeaders/qglobal.h: Removed.
  • ForwardingHeaders/qhbox.h: Removed.
  • ForwardingHeaders/qinputdialog.h: Removed.
  • ForwardingHeaders/qintcache.h: Removed.
  • ForwardingHeaders/qmetaobject.h: Removed.
  • ForwardingHeaders/qmovie.h: Removed.
  • ForwardingHeaders/qobjectlist.h: Removed.
  • ForwardingHeaders/qtooltip.h: Removed.
  • ForwardingHeaders/scheduler.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/cssstyleselector.cpp:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/kjs_window.moc: Removed.
  • khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::HTMLDocumentImpl):
  • khtml/html/html_documentimpl.moc: Removed.
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_formimpl.h:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/html/htmltokenizer.moc: Removed.
  • khtml/khtml_part.cpp: (KHTMLPart::didOpenURL): (KHTMLPart::stopLoading): (KHTMLPart::createJavaContext): (KHTMLPart::begin): (KHTMLPart::slotRedirection): (KHTMLPart::setSelection): (KHTMLPart::handleFallbackContent):
  • khtml/khtml_part.h:
  • khtml/khtml_part.moc: Removed.
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLView::KHTMLView): (KHTMLView::init): (KHTMLView::resizeEvent): (KHTMLView::layout): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::scrollTo): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent):
  • khtml/khtmlview.h:
  • khtml/khtmlview.moc: Removed.
  • khtml/misc/loader.cpp: (CachedImage::CachedImage): (CachedImage::ref): (CachedImage::deref): (CachedImage::pixmap_size): (CachedImage::valid_rect): (CachedImage::clear): (CachedXSLStyleSheet::CachedXSLStyleSheet): (Cache::clear): (Cache::flush): (Cache::getStatistics): (Cache::setCacheDisabled):
  • khtml/misc/loader.h:
  • khtml/misc/loader.moc: Removed.
  • khtml/rendering/render_form.cpp: (ComboBoxWidget::ComboBoxWidget): (RenderSelect::createListBox): (RenderSlider::slotClicked):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_form.moc: Removed.
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderPart::updateWidgetPosition):
  • khtml/rendering/render_frames.moc: Removed.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::isTransparent):
  • khtml/rendering/render_replaced.cpp: (RenderWidget::destroy): (RenderWidget::setSelectionState):
  • khtml/rendering/render_replaced.moc: Removed.
  • khtml/xml/dom_docimpl.cpp: (DocumentTypeImpl::cloneNode):
  • khtml/xml/dom_docimpl.moc: Removed.
  • khtml/xml/xml_tokenizer.cpp:
  • khtml/xml/xml_tokenizer.moc: Removed.
  • ksvg2/svg/SVGImageElementImpl.cpp:
  • kwq/KWQApplication.h: (QApplication::sendEvent):
  • kwq/KWQComboBox.h:
  • kwq/KWQKApplication.h: Removed.
  • kwq/KWQKHTMLPageCache.h: Removed.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):
  • kwq/KWQKHTMLPartBrowserExtension.h:
  • kwq/KWQKHistoryProvider.mm:
  • kwq/KWQKJavaAppletContext.h: (KJavaAppletContext::KJavaAppletContext):
  • kwq/KWQKPartsHistoryProvider.h:
  • kwq/KWQKPartsPartManager.h: Removed.
  • kwq/KWQMovie.h: Removed.
  • kwq/KWQMovie.mm: Removed.
  • kwq/KWQObject.h:
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm:
  • kwq/KWQWidget.h:
2:17 PM Changeset in webkit [11601] by mjs
  • 7 edits in trunk/WebKit

Reviewed by Darin.

  • remove _frameForView: method from WebView and replace with a direct pointer on the WebFrameView in the WebFrame
  • Misc.subproj/WebNSViewExtras.m:
  • WebView.subproj/WebFrame.m: (-[WebFrame _detachFromParent]): (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame initWithName:webFrameView:webView:]):
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _setWebFrame:]): (-[WebFrameView webFrame]):
  • WebView.subproj/WebFrameViewInternal.h:
  • WebView.subproj/WebView.m:
  • WebView.subproj/WebViewPrivate.h:
1:39 PM Changeset in webkit [11600] by eseidel
  • 10 edits in trunk/WebCore

Bug #: 6094
Submitted by: eseidel
Reviewed by: darin

khtml/css should use RefPtr instead of manual ref() deref()
http://bugzilla.opendarwin.org/show_bug.cgi?id=6094

No functionality changes, thus no tests.

  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyValue):
  • khtml/css/css_ruleimpl.cpp: (DOM::CSSFontFaceRuleImpl::CSSFontFaceRuleImpl): (DOM::CSSFontFaceRuleImpl::~CSSFontFaceRuleImpl): (DOM::CSSImportRuleImpl::CSSImportRuleImpl): (DOM::CSSImportRuleImpl::~CSSImportRuleImpl): (DOM::CSSImportRuleImpl::setStyleSheet): (DOM::CSSMediaRuleImpl::CSSMediaRuleImpl): (DOM::CSSMediaRuleImpl::~CSSMediaRuleImpl): (DOM::CSSPageRuleImpl::CSSPageRuleImpl): (DOM::CSSPageRuleImpl::~CSSPageRuleImpl): (DOM::CSSStyleRuleImpl::CSSStyleRuleImpl): (DOM::CSSStyleRuleImpl::~CSSStyleRuleImpl): (DOM::CSSStyleRuleImpl::setDeclaration):
  • khtml/css/css_ruleimpl.h: (DOM::CSSFontFaceRuleImpl::style): (DOM::CSSImportRuleImpl::media): (DOM::CSSImportRuleImpl::styleSheet): (DOM::CSSMediaRuleImpl::cssRules): (DOM::CSSPageRuleImpl::style): (DOM::CSSStyleRuleImpl::style): (DOM::CSSStyleRuleImpl::declaration):
  • khtml/css/css_stylesheetimpl.cpp: (StyleSheetImpl::StyleSheetImpl): (StyleSheetImpl::~StyleSheetImpl): (StyleSheetImpl::setMedia):
  • khtml/css/css_stylesheetimpl.h: (DOM::StyleSheetImpl::media):
  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::get4Values): (DOM::CSSMutableStyleDeclarationImpl::getShortHandValue): (DOM::CSSMutableStyleDeclarationImpl::merge): (DOM::CSSStyleDeclarationImpl::diff): (DOM::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (DOM::CSSPrimitiveValueImpl::cleanup): (DOM::CSSPrimitiveValueImpl::cssText): (DOM::RectImpl::RectImpl): (DOM::RectImpl::~RectImpl): (DOM::RectImpl::setTop): (DOM::RectImpl::setRight): (DOM::RectImpl::setBottom): (DOM::RectImpl::setLeft): (DOM::PairImpl::PairImpl): (DOM::PairImpl::~PairImpl): (DOM::PairImpl::setFirst): (DOM::PairImpl::setSecond): (DOM::CSSBorderImageValueImpl::CSSBorderImageValueImpl): (DOM::CSSBorderImageValueImpl::~CSSBorderImageValueImpl):
  • khtml/css/css_valueimpl.h: (DOM::RectImpl::top): (DOM::RectImpl::right): (DOM::RectImpl::bottom): (DOM::RectImpl::left): (DOM::PairImpl::first): (DOM::PairImpl::second): (DOM::DashboardRegionImpl::setNext): (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::operator=): (DOM::CSSProperty::~CSSProperty): (DOM::CSSProperty::setValue): (DOM::CSSProperty::value):
  • khtml/css/cssparser.cpp: (CSSParser::parseColor):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::transformToString):
1:37 PM Changeset in webkit [11599] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

<rdar://problem/4381444> Remove GMail-specific work-around previously added

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Remove GMail workaround.
1:36 PM Changeset in webkit [11598] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

<rdar://problem/4381444> Remove GMail-specific work-around previously added

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter): Remove GMail workaround.
1:06 PM Changeset in webkit [11597] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Test for <rdar://problem/4381360>, http://bugzilla.opendarwin.org/show_bug.cgi?id=6100
REGRESSION: Focus ring on contenteditable div outlines text in overflow area instead of div (6100)

  • fast/overflow/overflow-focus-ring-expected.checksum: Added.
  • fast/overflow/overflow-focus-ring-expected.png: Added.
  • fast/overflow/overflow-focus-ring-expected.txt: Added.
  • fast/overflow/overflow-focus-ring.html: Added.

WebCore:

Reviewed by Darin and Hyatt.

Fixed <rdar://problem/4381360> REGRESSION: Focus ring on contenteditable div outlines text in overflow area instead of div (6100)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6100

Test: fast/overflow/overflow-focus-ring.html

  • khtml/rendering/render_flow.cpp: (RenderFlow::addFocusRingRects): For overflow, we don't need to compute the rects for the children.
12:20 PM Changeset in webkit [11596] by darin
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • removed unnecessary conversion between AtomicString and QString
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): Remove extra conversions. (HTMLScriptElementImpl::insertedIntoDocument): Ditto.
12:10 PM Changeset in webkit [12223] by darin
  • 2 edits in trunk/JavaScriptGlue

Reviewed by Tim Hatcher.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Removed some redundant build settings, turned off prebinding explicitly for our Development and Deployment builds, remove .exp file from sources. All "clean-up".
11:37 AM Changeset in webkit [11595] by hyatt
  • 1 edit in trunk/WebCore/ksvg2/css/svg.css

Bug #:
Submitted by:
Reviewed by:

11:07 AM Changeset in webkit [11594]
  • 211 copies
    17 deletes in tags/WebCore-417~13

This commit was manufactured by cvs2svn to create tag
'WebCore-417~13'.

11:07 AM Changeset in webkit [11593] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

9:42 AM Changeset in webkit [11592] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Don't run tests in directories named "svg" if SVG support is not compiled in. Report the 10 slowest tests if "--slowest" is passed on the command line.
9:14 AM Changeset in webkit [11591] by darin
  • 2 edits in trunk/LayoutTests
  • updated test result -- this test now succeeds due to some recent change
  • dom/xhtml/level2/html/HTMLTextAreaElement12-expected.txt: Regenerated.

Dec 14, 2005:

8:51 PM Changeset in webkit [11590] by adele
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Adele Peterson <adele@apple.com>

Reviewed by Darin and Tim Hatcher.

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
8:29 PM Changeset in webkit [11589] by adele
  • 4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
3:32 PM Changeset in webkit [11588] by eseidel
  • 46 edits
    4 deletes in trunk/WebCore

Bug #: 6078
Submitted by: eseidel
Reviewed by: darin

SVG test cases changed (now the svg.css is loaded properly).
No other functionality changes, just code removal.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6078

  • ForwardingHeaders/klibloader.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/csshelper.cpp:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::parseUASheet): (khtml::CSSStyleSelector::loadDefaultStyle):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::eventParameterName): (KJS::JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::implementsCall):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): (KJS::PluginBase::PluginBase):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_proxy.h: (KJSProxyImpl::setEventHandlerLineno):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::interpreter): (KJS::Window::retrieve): (KJS::Window::clear): (KJS::ScheduledAction::execute):
  • khtml/ecma/kjs_window.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData):
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::evaluateScript):
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::processToken):
  • khtml/khtml_part.cpp: (KHTMLPart::KHTMLPart): (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::restoreURL): (KHTMLPart::didOpenURL): (KHTMLPart::jScript): (KHTMLPart::executeScript): (KHTMLPart::write): (KHTMLPart::reparseConfiguration): (KHTMLPart::createHTMLEventListener):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/misc/decoder.cpp:
  • khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): (CachedScript::CachedScript):
  • khtml/rendering/render_flow.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_inline.cpp:
  • khtml/rendering/render_line.cpp:
  • khtml/rendering/render_table.cpp:
  • khtml/rendering/table_layout.cpp:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::implicitOpen): (DocumentImpl::write):
  • khtml/xml/dom_nodeimpl.cpp:
  • ksvg2/svg/SVGTestsImpl.cpp: (SVGTestsImpl::isValid):
  • kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • kwq/KWQKGlobal.h:
  • kwq/KWQKHTMLFactory.h: (KHTMLFactory::vLinks):
  • kwq/KWQKHTMLFactory.mm:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): (KWQKHTMLPart::userGestureHint): (KWQKHTMLPart::bindingRootObject):
  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::fantasyFontName): (KHTMLSettings::isJavaScriptEnabled):
  • kwq/KWQKInstance.h: Removed.
  • kwq/KWQKLibrary.h: Removed.
  • kwq/KWQKPartsFactory.h: Removed.
  • kwq/KWQKPartsPart.h: (KParts::ReadOnlyPart::name):
  • kwq/KWQKStandardDirs.h:
  • kwq/KWQKStandardDirs.mm: (locate):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge executionContextForView:]):
2:49 PM Changeset in webkit [11587] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.
2:45 PM Changeset in webkit [11586] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Beth Dakin <Beth Dakin>

Reviewed by Eric.

Fix for <rdar://problem/4374783> 10.4.4 REGRESSION: caret
disappears when typing at the bottom of a scrollable textarea.

This regression occurred because we were calculating the font
height incorrectly. Made changes that Doug suggested in the bug.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView setFont:]): Send the font itself to _KWQ_updateTypingAttributes (-[KWQTextAreaTextView setLineHeight:]): Same. (-[NSTextView _KWQ_updateTypingAttributes:forLineHeight:font:]): Calculate the font height using defaultLineHeightForFont.
2:39 PM Changeset in webkit [11585] by bdakin
  • 2 edits in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

2:21 PM Changeset in webkit [11584] by bdakin
  • 3 edits
    4 adds in trunk

Bug #:
Submitted by:
Reviewed by:

10:46 AM Changeset in webkit [11583] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Layout test for <http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

  • fast/overflow/overflow-text-hit-testing-expected.checksum: Added.
  • fast/overflow/overflow-text-hit-testing-expected.png: Added.
  • fast/overflow/overflow-text-hit-testing-expected.txt: Added.
  • fast/overflow/overflow-text-hit-testing.html: Added.

WebCore:

Reviewed by Darin & Geoff, committed by Adele.

Test: fast/overflow/overflow-text-hit-testing.html

Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=5921>
Hit-testing text in overflows does not take scrolling into account.

  • khtml/rendering/render_text.cpp: (RenderText::positionForCoordinates): Adjust for containing block scroll
10:19 AM Changeset in webkit [11582] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4362
Add mac-cyrillic to the list of encodings

  • kwq/mac-encodings.txt: Added maccyrillic
Note: See TracTimeline for information about the timeline view.